Files
multica/server/internal/handler/comment.go
Bohan Jiang 69744241e8 fix(comment): restore autopilot @mention delegation authority (MUL-4857) (#5512)
* fix(comment): restore autopilot @mention delegation authority (MUL-4857)

A schedule/webhook autopilot run is unattributed by design (no top-of-chain
human originator, MUL-4302). Since MUL-3963 the A2A invoke gate (canInvokeAgent)
keys on that originator, so a mid-run @agent/@squad delegation on an
autopilot-created issue fails closed for the DEFAULT private agent (and
member-scoped public_to agents): the mention renders but no run is enqueued.
The SAME autopilot's first dispatch is admitted via the autopilot creator
(autopilotAdmitInvoke -> canCreatorInvokeAgent), so first-dispatch and mid-run
delegation disagreed.

Align them: when an unattributed agent/system-authored comment on an
autopilot-origin issue reaches computeCommentAgentTriggers with no originator,
fall back to the autopilot creator as the effective invoking user for the gate.
The gate still runs (no unrestricted agent-to-agent bypass); it is authorization
only -- the enqueued task's originator/attribution stays unattributed. Scoped to
autopilot-origin issues so other unattributed chains stay fail-closed.

Adds a DB-backed regression test covering: creator-owns-target admits, a
non-autopilot unattributed run stays denied, and a creator without invoke rights
stays denied.

Co-authored-by: multica-agent <github@multica.ai>

* fix(comment): bind autopilot @mention authority to verified task lineage (MUL-4857)

Address the review's confused-deputy finding on the P0 fix. The first cut keyed
the invoke-gate fallback on issue provenance + an empty originator alone
(invokeAuthorityForAutopilotIssue took only the issue), so any unattributed run
could borrow a stranger autopilot creator's rights merely by commenting on that
autopilot's issue — and the fallback also leaked past explicit @mention into the
plain-comment squad-leader path and system actors.

Rework it so the autopilot-creator authority is granted ONLY when the SPEAKING
task's lineage is verified against this issue:

  - resolve the authority separately (new AutopilotDelegationAuthorityUserID on
    commentTriggerComputeOptions), never by overwriting OriginatorUserID; the
    gate reads it through opts.effectiveInvoker() only when no human originator
    resolved, so attribution stays untouched;
  - resolve from a server-trusted speaking task — X-Task-ID on create/preview,
    comment.source_task_id on edit/reconcile — via autopilotDelegationAuthority,
    which admits only when author == task agent AND task.issue_id == this issue
    AND the issue is autopilot-origin, then keys on the member autopilot creator;
  - do NOT key on autopilot_run_id: in create_issue mode (the reported case) the
    leader task is enqueued through the ordinary issue-assignment path and has no
    autopilot_run_id — the task.issue_id == issue binding is what proves the run
    is part of this autopilot's work while rejecting foreign-issue runs.

Tests: replace the provenance-only regression with lineage-bound coverage —
verified-lineage-admits, creator-without-rights-denied, non-autopilot-denied,
missing-source-task-denied, cross-issue-source-task-denied, author!=task-agent-
denied — plus an end-to-end CreateComment path asserting the private worker is
enqueued and the delegated run stays unattributed. Verified the fallback is
load-bearing (positive + e2e fail with it disabled) and the full internal/handler
package passes. Skill docs (multica-mentioning) updated to the lineage-bound
contract and new helper names.

Co-authored-by: multica-agent <github@multica.ai>

* fix(comment): make autopilot @mention authority consistent across defer/edit (MUL-4857)

Second review round (Elon) surfaced two must-fixes on top of the lineage binding.

1. Busy-target completion reconcile lost the authority. A delegation to a target
   that is already running is deferred to that target's completion reconcile
   (reconcileCommentsOnCompletion). That path recomputed triggers with only the
   (empty) originator, so an unattributed autopilot delegation's follow-up was
   gate-denied again and silently dropped. It now restores the delegation
   authority from comment.source_task_id, so the follow-up fires once the target
   frees up — still unattributed.

2. Edit could borrow the old authoring run's authority, and preview != save. The
   edit preview keyed authority on the current request task while save keyed it on
   the comment's original source_task_id, so an agent editing its old autopilot
   comment from a task on an UNRELATED issue would fail-closed in preview but reuse
   the old autopilot creator's authority on save (cross-issue confused-deputy, and
   a preview/side-effect divergence). Fix: treat source_task_id as the persisted
   per-action authority lineage and re-stamp it on edit to the CURRENT editing
   task, issue-scoped exactly like CreateComment. A cross-issue edit re-stamps it
   to NULL, so preview, save, AND the deferred reconcile all fail closed
   identically. UpdateComment query gains a source_task_id param (sqlc regen).

Also locks the review-accepted behavior that effectiveInvoker() carries the
autopilot-creator authority into the plain assigned-squad-leader wake (a worker's
result comment on the autopilot issue can still wake the private leader).

Tests: reconcile-restores-authority (owns -> one unattributed follow-up; no rights
-> none); edit re-stamp (same-issue keeps authority and triggers; cross-issue
clears source_task_id and fails closed); worker-result wakes private squad leader.
Verified both fixes are load-bearing (each negative control reproduces the exact
regression Elon described), full internal/handler + internal/service packages pass,
gofmt/vet clean. Skill docs (multica-mentioning) updated.

Co-authored-by: multica-agent <github@multica.ai>

* fix(comment): clear stale task lineage on non-author comment edits (MUL-4857)

An admin editing an autopilot Agent's comment previously preserved the
comment's original source_task_id. The immediate save is judged on the
admin's member identity and correctly fails closed, but the deferred
completion-reconcile routes the comment under its original agent author
and resolved the delegation authority from the stale source_task_id,
resurrecting the autopilot creator's invoke authority once the busy
target freed up — an admin (manage rights) could thereby trigger another
owner's private agent (invoke rights).

Now a content edit re-derives lineage from the edit action: only the
agent author editing its own comment re-stamps source_task_id to the
current editing task; every other editor (member/admin, or any
non-author) clears it, so preview, save, and reconcile all fail closed.

Adds a regression covering the admin-edit + busy-target path and syncs
the multica-mentioning skill docs.

Co-authored-by: multica-agent <github@multica.ai>

---------

Co-authored-by: Bohan-J <bohan@devv.ai>
Co-authored-by: multica-agent <github@multica.ai>
2026-07-16 15:23:56 +08:00

2890 lines
118 KiB
Go

package handler
import (
"context"
"encoding/json"
"errors"
"log/slog"
"net/http"
"sort"
"strconv"
"strings"
"time"
"unicode"
"github.com/go-chi/chi/v5"
"github.com/jackc/pgx/v5/pgtype"
"github.com/multica-ai/multica/server/internal/logger"
"github.com/multica-ai/multica/server/internal/service"
"github.com/multica-ai/multica/server/internal/util"
db "github.com/multica-ai/multica/server/pkg/db/generated"
"github.com/multica-ai/multica/server/pkg/protocol"
)
type CommentResponse struct {
ID string `json:"id"`
IssueID string `json:"issue_id"`
AuthorType string `json:"author_type"`
AuthorID string `json:"author_id"`
Content string `json:"content"`
Type string `json:"type"`
ParentID *string `json:"parent_id"`
CreatedAt string `json:"created_at"`
UpdatedAt string `json:"updated_at"`
ResolvedAt *string `json:"resolved_at"`
ResolvedByType *string `json:"resolved_by_type"`
ResolvedByID *string `json:"resolved_by_id"`
SourceTaskID *string `json:"source_task_id,omitempty"`
Reactions []ReactionResponse `json:"reactions"`
Attachments []AttachmentResponse `json:"attachments"`
// Orientation stats — populated only on the roots_only path and omitted in
// every other mode, so the default response shape stays byte-identical for
// existing callers. ReplyCount is the number of descendants in the thread;
// LastActivityAt is the MAX(created_at) across the whole subtree. Together
// they let an agent triage which thread to drill into without fetching any
// replies.
ReplyCount *int `json:"reply_count,omitempty"`
LastActivityAt *string `json:"last_activity_at,omitempty"`
// ContentTruncated is set only under summary=true: true when Content was
// clipped to the summary budget, false when it fit. nil (omitted) means the
// caller did not request a summary projection, so Content is verbatim.
ContentTruncated *bool `json:"content_truncated,omitempty"`
// Fold projection fields — populated only under fold=true, and only on the
// thread ROOT of a resolved thread (mirrors the human timeline fold; see
// foldResolvedThreads). Both are nil/omitted everywhere else: every comment
// under an unresolved thread, and every non-root comment. ThreadResolved
// marks a thread whose discussion was collapsed to its conclusion;
// FoldedCount is how many comments in that thread were dropped from the
// response (0 when the thread was already at root + conclusion). The reader
// pulls the folded comments back with `comment list --full`.
ThreadResolved *bool `json:"thread_resolved,omitempty"`
FoldedCount *int `json:"folded_count,omitempty"`
// TriggerOutcomes is the per-target result of every EXPLICIT @agent / @squad
// mention in this comment (MUL-4525 §2). It is additive and populated only on
// create/edit responses: old clients ignore it. A saved comment whose mention
// was blocked (no invoke permission, target unavailable, runtime offline) now
// reports that here instead of silently dropping the trigger, so the client
// can show "comment posted, but N targets were not triggered".
TriggerOutcomes []CommentTriggerOutcome `json:"trigger_outcomes,omitempty"`
}
// CommentTriggerOutcome is the per-target result of an explicit @agent / @squad
// mention (MUL-4525 §2). target_id is the id the user mentioned — the agent id,
// or the SQUAD id for a squad mention — so the client correlates it back to the
// mention it rendered without the server echoing a private target's name/owner.
// reason_code is the stable, enumeration-safe admission reason.
type CommentTriggerOutcome struct {
TargetType string `json:"target_type"` // "agent" | "squad"
TargetID string `json:"target_id"`
Status DispatchStatus `json:"status"` // queued | coalesced | deferred | blocked
ReasonCode DispatchReasonCode `json:"reason_code"`
}
func commentToResponse(c db.Comment, reactions []ReactionResponse, attachments []AttachmentResponse) CommentResponse {
if reactions == nil {
reactions = []ReactionResponse{}
}
if attachments == nil {
attachments = []AttachmentResponse{}
}
return CommentResponse{
ID: uuidToString(c.ID),
IssueID: uuidToString(c.IssueID),
AuthorType: c.AuthorType,
AuthorID: uuidToString(c.AuthorID),
Content: c.Content,
Type: c.Type,
ParentID: uuidToPtr(c.ParentID),
CreatedAt: timestampToString(c.CreatedAt),
UpdatedAt: timestampToString(c.UpdatedAt),
ResolvedAt: timestampToPtr(c.ResolvedAt),
ResolvedByType: textToPtr(c.ResolvedByType),
ResolvedByID: uuidToPtr(c.ResolvedByID),
SourceTaskID: uuidToPtr(c.SourceTaskID),
Reactions: reactions,
Attachments: attachments,
}
}
// summaryContentRunes bounds comment content under summary=true. 200 runes is
// enough to tell what a comment is about (its opening) while cutting the bulk
// of a long body out of an agent's context budget. Counted in runes, not bytes,
// so multi-byte (e.g. CJK) content is clipped on a character boundary.
const summaryContentRunes = 200
// summarizeContent clips content to summaryContentRunes for the summary
// projection. Returns the (possibly clipped) content and whether it was
// truncated. An ellipsis marks a clip so the reader knows more text exists.
//
// It scans by rune and stops at the (budget+1)th rune rather than allocating a
// full []rune for the whole body — so a pathologically long comment costs only
// the budget, not its full length, under summary mode.
func summarizeContent(content string) (string, bool) {
count := 0
for byteOffset := range content { // range over a string yields rune start offsets
if count == summaryContentRunes {
return content[:byteOffset] + "…", true
}
count++
}
return content, false
}
// foldStat is the per-thread fold annotation attached to a resolved thread's
// root under fold=true. FoldedCount is how many comments in the thread were
// dropped from the response. See CommentResponse.ThreadResolved / FoldedCount.
type foldStat struct {
FoldedCount int
}
// foldResolvedThreads collapses every resolved thread in a COMPLETE-thread
// comment set down to the comments a reader actually needs, mirroring the human
// timeline fold (deriveThreadResolution in
// packages/views/issues/components/thread-utils.ts) so agents see what humans
// see:
//
// - unresolved thread → every comment kept, unchanged, no annotation.
// - reply-resolved thread → keep the thread root + the resolution reply (the
// conclusion), drop every other reply. Root + conclusion, never conclusion
// alone: a conclusion is often referential ("go with what we said above")
// and unreadable without the root question.
// - root-resolved thread → keep only the root, drop every reply (the whole
// discussion was a settled dead-end; the root states the topic).
//
// The thread root of each resolved thread is annotated (foldStat keyed by the
// root's id string) so the response can mark it thread_resolved and report how
// many comments were folded; a reader that needs the dropped discussion pulls
// it back with `comment list --full`.
//
// Resolution is derived exactly as the UI does: the root wins if resolved;
// otherwise the reply with the latest resolved_at is THE resolution. The single
// resolved-per-thread invariant (ClearOtherThreadResolutions) normally makes
// this unambiguous; the latest-wins tiebreak keeps the projection total if an
// older/concurrent write ever left two.
//
// Callers MUST invoke this only on a set containing COMPLETE threads (the
// default list, --recent, and untailed --thread reads). Partial-thread reads
// (--since, --tail) are rejected upstream because a fold computed over a partial
// thread could drop a resolution that was never fetched. As defense in depth,
// any comment whose thread root is absent from the set is treated as its own
// root and kept verbatim, so a partial thread degrades to "unchanged" rather
// than to silent data loss.
func foldResolvedThreads(comments []db.Comment) ([]db.Comment, map[string]foldStat) {
if len(comments) == 0 {
return comments, nil
}
byID := make(map[string]db.Comment, len(comments))
for _, c := range comments {
byID[uuidToString(c.ID)] = c
}
// rootOf walks parent_id up to the thread root within this set. It stops at
// the first comment whose parent is absent (in a complete-thread set that is
// the real root; in a partial set it is the highest ancestor we hold). The
// loop is bounded by len(comments) so an unexpected cycle cannot hang it —
// the PK forbids real cycles, but never trust a graph walk over stored data.
rootOf := func(c db.Comment) db.Comment {
cur := c
for i := 0; i < len(comments); i++ {
if !cur.ParentID.Valid {
return cur
}
parent, ok := byID[uuidToString(cur.ParentID)]
if !ok {
return cur
}
cur = parent
}
return cur
}
type thread struct {
root db.Comment
replies []db.Comment // non-root, in input (chronological) order
}
threads := map[string]*thread{}
for _, c := range comments {
root := rootOf(c)
rid := uuidToString(root.ID)
th := threads[rid]
if th == nil {
th = &thread{root: root}
threads[rid] = th
}
if uuidToString(c.ID) != rid {
th.replies = append(th.replies, c)
}
}
keep := make(map[string]bool, len(comments))
stats := map[string]foldStat{}
for rid, th := range threads {
// Root-resolved: keep only the root.
if th.root.ResolvedAt.Valid {
keep[rid] = true
stats[rid] = foldStat{FoldedCount: len(th.replies)}
continue
}
// Reply-resolved: the latest-resolved reply is the conclusion.
var resolution *db.Comment
for i := range th.replies {
r := &th.replies[i]
if !r.ResolvedAt.Valid {
continue
}
if resolution == nil || r.ResolvedAt.Time.After(resolution.ResolvedAt.Time) {
resolution = r
}
}
if resolution == nil {
// Unresolved thread: keep everything, no annotation.
keep[rid] = true
for _, r := range th.replies {
keep[uuidToString(r.ID)] = true
}
continue
}
keep[rid] = true
keep[uuidToString(resolution.ID)] = true
// Every reply except the conclusion is folded away.
stats[rid] = foldStat{FoldedCount: len(th.replies) - 1}
}
out := make([]db.Comment, 0, len(comments))
for _, c := range comments {
if keep[uuidToString(c.ID)] {
out = append(out, c)
}
}
return out, stats
}
// commentHardCap bounds the comments returned per issue. Sized as a defensive
// safety net rather than a UX paging window: prod p99 is ~30 comments and
// the all-time max observed is ~1.1k, so 2000 leaves ~2x headroom while still
// preventing a runaway response if some user manages to accumulate a wild
// number of rows on a single issue.
const commentHardCap = 2000
// ListComments returns comments for an issue. The default behaviour is
// unchanged — full chronological dump capped at commentHardCap — so existing
// callers and the desktop UI keep working as-is. Optional query params give
// agent-style readers bounded views that scale to long issues without dragging
// every prior reply into context:
//
// - roots_only=true — return only top-level comments (parent_id IS NULL),
// each annotated with reply_count + last_activity_at so the caller can
// triage which thread to drill into. May combine with since for incremental
// polling of newly created roots, but is exclusive with thread/recent/tail/
// cursor modes because those have their own grouping or pagination semantics.
//
// - summary=true — orthogonal content projection. Clips each returned
// comment's content to a fixed budget and sets content_truncated, so an
// agent can scan a list cheaply before pulling a full body. Composes with
// every mode (default, since, thread, recent, roots_only).
//
// - fold=true — resolve-aware thread projection. Collapses each resolved
// thread to root + conclusion (reply-resolved) or root only (root-resolved),
// reusing the human timeline fold so an agent does not pay tokens for
// settled discussion. The resolved thread's root carries thread_resolved +
// folded_count; `--full` (no fold param) brings the dropped comments back.
// Needs whole threads to compute a resolution, so it is rejected with since,
// tail, and roots_only (partial-thread / reply-less reads) and composes with
// the default list, recent, untailed thread, and summary.
//
// - thread=<comment-uuid> — return the root of the thread containing this
// comment plus every descendant. The anchor may be a root or any reply;
// the server walks up to the root via a recursive CTE, so callers do not
// need to know whether the id they have is a root.
//
// - tail=<N> — only valid with thread. Cap the reply count at the N most
// recent replies (per (created_at, id)). The thread root is always
// returned, even when N=0, so the reader keeps the "what is this thread
// about" context. Without tail, thread returns the entire thread (the
// pre-MUL-2421 behavior).
//
// - recent=<N> — return the N most recently active threads (root + every
// descendant per thread). A thread's recency is MAX(created_at) across
// the whole subtree, so a stale-but-recently-replied thread ranks ahead
// of an active-but-quiet one. Row-based "newest N comments" is
// deliberately NOT exposed — it surfaces unrelated thread tails and
// hides relevant history (#2340).
//
// - before=<RFC3339> + before-id=<uuid> — cursor. The pair's meaning is
// context-dependent so the flag surface stays small:
//
// - with recent: a *thread* cursor — (last_activity_at, root_id) — and
// the next page returns threads strictly less recent.
//
// - with thread + tail: a *reply* cursor — (created_at, id) — and the
// next page returns replies in the same thread strictly older than
// that reply.
//
// Both values must be set together so the cursor can tie-break entries
// landing in the same microsecond. The cursor for the next page is
// emitted via the X-Multica-Next-Before / X-Multica-Next-Before-Id
// response headers.
//
// Combination rules (kept narrow on purpose — Elon flagged the matrix risk):
//
// - roots_only is exclusive with thread, recent, tail, and before/before-id.
// It may combine with since. This keeps "list issue roots" separate from
// "read a specific thread" and "read recently active threads".
// - thread is exclusive with recent. Asking for "the most recent N within
// thread X" mixes two different navigation models and is rejected.
// - thread + before/before-id requires tail. Without tail, thread returns
// the entire thread and a cursor would be ignored — reject loudly so
// the documented "cursor scrolls within a tailed window" rule holds.
// - tail requires thread (it is a thread-scoped limit; outside of thread
// it has no defined behavior).
// - thread may combine with since (incremental polling of one thread),
// and the since filter is applied after the tail/cursor cut so the
// thread root is still emitted but stale rows drop out.
// - recent may combine with before/before-id (scroll older threads) and
// with since (recent activity in a window).
//
// The response body is always chronological (oldest → newest); under recent
// that means threads are listed oldest-active first and the freshest thread
// sits at the tail, closest to "now" in an agent prompt.
func (h *Handler) ListComments(w http.ResponseWriter, r *http.Request) {
issueID := chi.URLParam(r, "id")
issue, ok := h.loadIssueForUser(w, r, issueID)
if !ok {
return
}
q := r.URL.Query()
var sinceTime pgtype.Timestamptz
if v := q.Get("since"); v != "" {
t, err := time.Parse(time.RFC3339Nano, v)
if err != nil {
// Fall back to RFC3339 for backwards-compat with the original CLI.
t, err = time.Parse(time.RFC3339, v)
if err != nil {
writeError(w, http.StatusBadRequest, "invalid since parameter; expected RFC3339 format")
return
}
}
sinceTime = pgtype.Timestamptz{Time: t, Valid: true}
}
threadStr := q.Get("thread")
recentStr := q.Get("recent")
tailStr := q.Get("tail")
beforeTimeStr := q.Get("before")
beforeIDStr := q.Get("before_id")
if beforeIDStr == "" {
// Accept hyphenated alias to match CLI flag convention.
beforeIDStr = q.Get("before-id")
}
rootsOnlyStr := q.Get("roots_only")
if rootsOnlyStr == "" {
// Accept hyphenated alias to match CLI flag convention.
rootsOnlyStr = q.Get("roots-only")
}
rootsOnly := false
if rootsOnlyStr != "" {
switch rootsOnlyStr {
case "true":
rootsOnly = true
case "false":
default:
writeError(w, http.StatusBadRequest, "invalid roots_only parameter; expected boolean")
return
}
}
// summary=true is an orthogonal content projection: it clips each comment's
// content to a fixed budget so an agent can scan a list without pulling full
// bodies into context. It is intentionally NOT mutually exclusive with any
// mode — it composes with the default list, since, thread, recent, and
// roots_only alike.
summary := false
if summaryStr := q.Get("summary"); summaryStr != "" {
switch summaryStr {
case "true":
summary = true
case "false":
default:
writeError(w, http.StatusBadRequest, "invalid summary parameter; expected boolean")
return
}
}
// fold=true is a thread-level projection: it collapses every resolved thread
// in the result to root + conclusion (reply-resolved) or root only
// (root-resolved), reusing the human timeline's fold semantics so an agent
// reading a long issue doesn't pay tokens for settled discussion. Unlike
// summary (a per-comment content clip that composes with everything), fold
// needs WHOLE threads to compute a resolution, so it is rejected on the
// partial-thread reads (since / tail) and on roots_only (which carries no
// replies to fold). It composes with summary, the default list, recent, and
// untailed thread reads.
fold := false
if foldStr := q.Get("fold"); foldStr != "" {
switch foldStr {
case "true":
fold = true
case "false":
default:
writeError(w, http.StatusBadRequest, "invalid fold parameter; expected boolean")
return
}
}
// --- combination validation ----------------------------------------
if fold && sinceTime.Valid {
writeError(w, http.StatusBadRequest, "fold and since are mutually exclusive: since returns a partial thread, and a fold over a partial thread could hide a resolution that was not fetched")
return
}
if fold && tailStr != "" {
writeError(w, http.StatusBadRequest, "fold and tail are mutually exclusive: tail returns a partial thread, which cannot be folded safely")
return
}
if fold && rootsOnly {
writeError(w, http.StatusBadRequest, "fold and roots_only are mutually exclusive: roots_only returns no replies to fold")
return
}
if rootsOnly && threadStr != "" {
writeError(w, http.StatusBadRequest, "roots_only and thread are mutually exclusive")
return
}
if rootsOnly && recentStr != "" {
writeError(w, http.StatusBadRequest, "roots_only and recent are mutually exclusive")
return
}
if rootsOnly && tailStr != "" {
writeError(w, http.StatusBadRequest, "roots_only and tail are mutually exclusive")
return
}
if rootsOnly && (beforeTimeStr != "" || beforeIDStr != "") {
writeError(w, http.StatusBadRequest, "roots_only does not support before / before_id")
return
}
if threadStr != "" && recentStr != "" {
writeError(w, http.StatusBadRequest, "thread and recent are mutually exclusive")
return
}
if tailStr != "" && threadStr == "" {
writeError(w, http.StatusBadRequest, "tail requires thread (it is a thread-scoped limit)")
return
}
if (beforeTimeStr == "") != (beforeIDStr == "") {
writeError(w, http.StatusBadRequest, "before and before_id must be set together (composite cursor)")
return
}
// Cursor needs either a recent window (thread cursor) or a tailed thread
// (reply cursor). A bare cursor would otherwise fall through to the
// default / since path — returning a full timeline that the caller did
// not ask for. Reject loudly so the API surface matches the documented
// semantics.
if beforeTimeStr != "" && recentStr == "" && (threadStr == "" || tailStr == "") {
writeError(w, http.StatusBadRequest, "before / before_id require recent (thread cursor) or thread + tail (reply cursor)")
return
}
// --- parse cursor / recent ----------------------------------------
var beforeCursor pgtype.Timestamptz
var beforeUUID pgtype.UUID
hasCursor := false
if beforeTimeStr != "" {
t, err := time.Parse(time.RFC3339Nano, beforeTimeStr)
if err != nil {
t, err = time.Parse(time.RFC3339, beforeTimeStr)
if err != nil {
writeError(w, http.StatusBadRequest, "invalid before parameter; expected RFC3339 format")
return
}
}
beforeCursor = pgtype.Timestamptz{Time: t, Valid: true}
uuid, perr := util.ParseUUID(beforeIDStr)
if perr != nil {
writeError(w, http.StatusBadRequest, "invalid before_id parameter; expected UUID")
return
}
beforeUUID = uuid
hasCursor = true
}
recentN := 0
if recentStr != "" {
n, err := strconv.Atoi(recentStr)
if err != nil || n <= 0 {
writeError(w, http.StatusBadRequest, "invalid recent parameter; expected positive integer")
return
}
if n > commentHardCap {
n = commentHardCap
}
recentN = n
}
// tail=0 is allowed (returns root only — useful for "what is this thread
// about" lookups without dragging any replies into context). Negative
// values are rejected because they'd round-trip to LIMIT -N which
// PostgreSQL flags as a syntax error.
threadTail := -1
threadTailSet := false
if tailStr != "" {
n, err := strconv.Atoi(tailStr)
if err != nil || n < 0 {
writeError(w, http.StatusBadRequest, "invalid tail parameter; expected non-negative integer")
return
}
if n > commentHardCap {
n = commentHardCap
}
threadTail = n
threadTailSet = true
}
result, err := h.fetchCommentsForList(r.Context(), fetchCommentsArgs{
Issue: issue,
Since: sinceTime,
ThreadAnchor: threadStr,
ThreadTail: threadTail,
ThreadTailSet: threadTailSet,
RecentN: recentN,
HasCursor: hasCursor,
BeforeAt: beforeCursor,
BeforeID: beforeUUID,
RootsOnly: rootsOnly,
})
if err != nil {
switch err {
case errCommentThreadNotFound:
writeError(w, http.StatusNotFound, "thread anchor not found in this issue")
return
case errCommentThreadBadID:
writeError(w, http.StatusBadRequest, "invalid thread parameter; expected UUID")
return
default:
writeError(w, http.StatusInternalServerError, "failed to list comments")
return
}
}
// Apply the resolve-aware fold before anything keys off the comment set
// (reaction/attachment grouping, the response array): folding drops comments,
// and the dropped ones should not pay a reactions/attachments round-trip or
// appear in the response. fetchCommentsForList only ever returns complete
// threads on the modes fold is allowed with (default, recent, untailed
// thread), which is the precondition foldResolvedThreads documents.
var foldInfo map[string]foldStat
if fold {
result.Comments, foldInfo = foldResolvedThreads(result.Comments)
}
commentIDs := make([]pgtype.UUID, len(result.Comments))
for i, c := range result.Comments {
commentIDs[i] = c.ID
}
grouped := h.groupReactions(r, commentIDs)
groupedAtt := h.groupAttachments(r, commentIDs)
resp := make([]CommentResponse, len(result.Comments))
for i, c := range result.Comments {
cid := uuidToString(c.ID)
resp[i] = commentToResponse(c, grouped[cid], groupedAtt[cid])
// Attach roots_only orientation stats when present (nil map elsewhere).
if st, ok := result.RootStats[cid]; ok {
rc := st.ReplyCount
resp[i].ReplyCount = &rc
if st.LastActivityAt.Valid {
la := timestampToString(st.LastActivityAt)
resp[i].LastActivityAt = &la
}
}
// Attach fold annotations on a resolved thread's root (nil map elsewhere;
// keyed by root id, so only root comments match).
if st, ok := foldInfo[cid]; ok {
resolved := true
resp[i].ThreadResolved = &resolved
fc := st.FoldedCount
resp[i].FoldedCount = &fc
}
// Apply the summary projection last so it clips whatever content the
// chosen read mode produced, uniformly across every mode.
if summary {
clipped, truncated := summarizeContent(resp[i].Content)
resp[i].Content = clipped
resp[i].ContentTruncated = &truncated
}
}
// Emit the next cursor as response headers when the page is likely not
// the last one. The cursor's meaning is context-dependent: under recent
// it points at the oldest thread in the page (next page = older threads);
// under thread + tail it points at the oldest reply in the page (next
// page = older replies in the same thread). Headers stay out of the JSON
// body so the default flat-array response shape — which the desktop UI
// and existing callers depend on — is unchanged.
if result.NextBefore != "" && result.NextBeforeID != "" {
w.Header().Set("X-Multica-Next-Before", result.NextBefore)
w.Header().Set("X-Multica-Next-Before-Id", result.NextBeforeID)
}
writeJSON(w, http.StatusOK, resp)
}
// fetchCommentsArgs bundles the parsed query params so fetchCommentsForList
// stays readable. Sentinel errors below let the caller turn DB-layer outcomes
// into the right HTTP status without leaking SQL details.
//
// ThreadTail is split into a value + a "set" flag because tail=0 is a
// meaningful caller intent (return just the root). A bare int would collapse
// "user did not pass --tail" and "user passed --tail 0" into the same state,
// which would silently downgrade the latter to the full-thread path.
type fetchCommentsArgs struct {
Issue db.Issue
Since pgtype.Timestamptz
RootsOnly bool
ThreadAnchor string
ThreadTail int
ThreadTailSet bool
RecentN int
HasCursor bool
BeforeAt pgtype.Timestamptz
BeforeID pgtype.UUID
}
// fetchCommentsResult carries both the materialised comments and (for the
// recent/thread-grouped path) the cursor to use for the next page. Cursor
// fields are empty strings when there is no next page or the path does not
// support cursors.
type fetchCommentsResult struct {
Comments []db.Comment
NextBefore string
NextBeforeID string
// RootStats carries per-root orientation stats keyed by comment id string.
// Populated only on the roots_only path; nil for every other mode.
RootStats map[string]rootStat
}
// rootStat is the per-thread orientation metadata attached to each root comment
// on the roots_only path. See CommentResponse.ReplyCount / LastActivityAt.
type rootStat struct {
ReplyCount int
LastActivityAt pgtype.Timestamptz
}
var (
errCommentThreadNotFound = &commentFetchError{"thread anchor not found"}
errCommentThreadBadID = &commentFetchError{"invalid thread anchor id"}
)
type commentFetchError struct{ msg string }
func (e *commentFetchError) Error() string { return e.msg }
func (h *Handler) fetchCommentsForList(ctx context.Context, args fetchCommentsArgs) (fetchCommentsResult, error) {
issue := args.Issue
// Thread-scoped read. Server resolves the anchor → root via recursive
// CTE, so we don't have to assume two-layer flat threads here.
if args.ThreadAnchor != "" {
anchor, err := util.ParseUUID(args.ThreadAnchor)
if err != nil {
return fetchCommentsResult{}, errCommentThreadBadID
}
// Tailed path: paged query that returns root + the @reply_limit
// most recent replies (per (created_at, id)). The thread root is
// always returned, so a reader can land on a long thread without
// dragging hundreds of replies into context. The reply-internal
// cursor (--before / --before-id under --thread + --tail) scrolls
// to older replies inside the same thread.
if args.ThreadTailSet {
// Probe for has-more by asking the SQL for one extra reply
// beyond what the caller wants. If we get back >tail replies
// there is at least one older reply still on disk; if we get
// back ≤tail the page is the tail of the thread and there is
// nothing older to scroll to (so we must NOT emit a cursor —
// otherwise the next page is wasted round-trip that returns
// just the root). This is the exact-boundary fix called out
// in the MUL-2421 review.
rows, err := h.Queries.ListThreadCommentsForIssuePaged(ctx, db.ListThreadCommentsForIssuePagedParams{
AnchorID: anchor,
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
HasCursor: args.HasCursor,
BeforeAt: args.BeforeAt,
BeforeID: args.BeforeID,
ReplyLimit: int32(args.ThreadTail) + 1,
})
if err != nil {
return fetchCommentsResult{}, err
}
if len(rows) == 0 {
return fetchCommentsResult{}, errCommentThreadNotFound
}
// Split the result into root + replies (ASC order preserved).
// Root is identified by parent_id IS NULL and is always
// present in the SQL output; we keep it out of the cursor /
// tail-trim logic so the user always sees thread context.
var rootComment *db.Comment
replies := make([]db.Comment, 0, len(rows))
for _, r := range rows {
c := db.Comment{
ID: r.ID,
IssueID: r.IssueID,
AuthorType: r.AuthorType,
AuthorID: r.AuthorID,
Content: r.Content,
Type: r.Type,
CreatedAt: r.CreatedAt,
UpdatedAt: r.UpdatedAt,
ParentID: r.ParentID,
WorkspaceID: r.WorkspaceID,
ResolvedAt: r.ResolvedAt,
ResolvedByType: r.ResolvedByType,
ResolvedByID: r.ResolvedByID,
}
if !r.ParentID.Valid {
root := c
rootComment = &root
continue
}
replies = append(replies, c)
}
// Trim the probe overflow back to the caller's tail. The SQL
// emits ASC, so the extra row is the oldest reply — dropping
// it from the head is what aligns "newest N" with the user's
// request.
hasMore := len(replies) > args.ThreadTail
if hasMore {
replies = replies[1:]
}
out := make([]db.Comment, 0, len(replies)+1)
if rootComment != nil {
out = append(out, *rootComment)
}
for _, r := range replies {
// since drops stale rows AFTER the tail / cursor cut.
// The root is exempt (already appended above): a reader
// who set --since to skip already-seen replies still
// needs the root context if the page only contained
// the root.
if args.Since.Valid && !r.CreatedAt.Time.After(args.Since.Time) {
continue
}
out = append(out, r)
}
// Emit a reply cursor only when we proved an older reply
// exists (hasMore). On an exact-boundary page (replyCount
// == tail with no overflow) hasMore is false and the cursor
// stays empty.
//
// Additionally suppress the cursor when `since` is set and
// the oldest retained reply on this page is already <= since.
// The next page walks replies strictly older than that one,
// so every older reply has created_at strictly less — if the
// cursor target itself can't satisfy `> since`, no older
// reply can either, and continuing to paginate would only
// return root-only pages until the agent walks the entire
// pre-`since` history. This mirrors the head-thread guard on
// the recent + since path. Flagged by Elon's second review on
// MUL-2421.
res := fetchCommentsResult{Comments: out}
emitCursor := hasMore && len(replies) > 0
if emitCursor && args.Since.Valid && !replies[0].CreatedAt.Time.After(args.Since.Time) {
emitCursor = false
}
if emitCursor {
oldest := replies[0]
res.NextBefore = oldest.CreatedAt.Time.UTC().Format(time.RFC3339Nano)
res.NextBeforeID = uuidToString(oldest.ID)
}
return res, nil
}
rows, err := h.Queries.ListThreadCommentsForIssue(ctx, db.ListThreadCommentsForIssueParams{
AnchorID: anchor,
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
RowLimit: commentHardCap,
})
if err != nil {
return fetchCommentsResult{}, err
}
if len(rows) == 0 {
return fetchCommentsResult{}, errCommentThreadNotFound
}
out := make([]db.Comment, 0, len(rows))
for _, r := range rows {
if args.Since.Valid && !r.CreatedAt.Time.After(args.Since.Time) {
continue
}
out = append(out, db.Comment{
ID: r.ID,
IssueID: r.IssueID,
AuthorType: r.AuthorType,
AuthorID: r.AuthorID,
Content: r.Content,
Type: r.Type,
CreatedAt: r.CreatedAt,
UpdatedAt: r.UpdatedAt,
ParentID: r.ParentID,
WorkspaceID: r.WorkspaceID,
ResolvedAt: r.ResolvedAt,
ResolvedByType: r.ResolvedByType,
ResolvedByID: r.ResolvedByID,
})
}
return fetchCommentsResult{Comments: out}, nil
}
// Thread-grouped recent read: N most recently active threads.
if args.RecentN > 0 {
rows, err := h.Queries.ListRecentThreadCommentsForIssue(ctx, db.ListRecentThreadCommentsForIssueParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
HasCursor: args.HasCursor,
BeforeAt: args.BeforeAt,
BeforeID: args.BeforeID,
ThreadLimit: int32(args.RecentN),
})
if err != nil {
return fetchCommentsResult{}, err
}
// The SQL already orders rows by (last_activity_at ASC, root_id ASC,
// created_at ASC, id ASC), so the OLDEST-active thread sits at the
// head and the FRESHEST thread at the tail. Walk the rows once to:
// 1. Strip the thread-metadata columns down to db.Comment for the
// caller (uniform shape across paths).
// 2. Count distinct threads in the page so we know whether a "next
// older page" is likely to exist.
// 3. Capture the head thread's (last_activity_at, root_id) — that
// is the cursor for the next page (next page = threads strictly
// less recent than this one).
comments := make([]db.Comment, 0, len(rows))
var headRoot pgtype.UUID
var headLast pgtype.Timestamptz
seenRoot := map[string]struct{}{}
for _, r := range rows {
if !headRoot.Valid {
headRoot = r.ThreadRootID
headLast = r.ThreadLastActivityAt
}
seenRoot[uuidToString(r.ThreadRootID)] = struct{}{}
// Since filter on the recent path: drop comments older than
// `since`. Done in-memory so we keep the thread-grouped
// semantics from the query (don't pre-filter rows before the
// MAX(created_at) ranking — that would silently downgrade a
// thread whose most recent activity falls inside the window).
if args.Since.Valid && !r.CreatedAt.Time.After(args.Since.Time) {
continue
}
comments = append(comments, db.Comment{
ID: r.ID,
IssueID: r.IssueID,
AuthorType: r.AuthorType,
AuthorID: r.AuthorID,
Content: r.Content,
Type: r.Type,
CreatedAt: r.CreatedAt,
UpdatedAt: r.UpdatedAt,
ParentID: r.ParentID,
WorkspaceID: r.WorkspaceID,
ResolvedAt: r.ResolvedAt,
ResolvedByType: r.ResolvedByType,
ResolvedByID: r.ResolvedByID,
})
}
// Only emit a cursor when the page is full. Fewer threads than
// requested ⇒ the SELECT exhausted matching threads, so there is
// no older page to scroll to.
//
// Additionally suppress the cursor when `since` is set and the head
// thread's last_activity_at is already <= since. The pagination
// walks threads in strictly decreasing last_activity_at, so every
// older page has last_activity_at strictly less than the head's —
// if the head itself can't satisfy `> since`, no older thread can
// either. Predicating on the head (not on whether `comments` is
// empty) also catches the mixed case where this page keeps rows
// from fresher threads but the head thread is already past `since`.
// Flagged by Elon in #2787's second review (MUL-2340 nit).
out := fetchCommentsResult{Comments: comments}
emitCursor := len(seenRoot) >= args.RecentN && headRoot.Valid && headLast.Valid
if emitCursor && args.Since.Valid && !headLast.Time.After(args.Since.Time) {
emitCursor = false
}
if emitCursor {
out.NextBefore = headLast.Time.UTC().Format(time.RFC3339Nano)
out.NextBeforeID = uuidToString(headRoot)
}
return out, nil
}
if args.RootsOnly {
// Root-only read for issue-level orientation. This intentionally
// stays separate from thread/recent modes: callers get the global
// top-level discussion first, then fetch a specific thread only when
// they need reply context. Each root carries reply_count +
// last_activity_at so the reader can triage which thread to drill into.
stats := map[string]rootStat{}
if args.Since.Valid {
rows, err := h.Queries.ListRootCommentsSinceForIssue(ctx, db.ListRootCommentsSinceForIssueParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
Since: args.Since,
RowLimit: commentHardCap,
})
if err != nil {
return fetchCommentsResult{}, err
}
comments := make([]db.Comment, len(rows))
for i, r := range rows {
comments[i] = db.Comment{
ID: r.ID, IssueID: r.IssueID, AuthorType: r.AuthorType, AuthorID: r.AuthorID,
Content: r.Content, Type: r.Type, CreatedAt: r.CreatedAt, UpdatedAt: r.UpdatedAt,
ParentID: r.ParentID, WorkspaceID: r.WorkspaceID, ResolvedAt: r.ResolvedAt,
ResolvedByType: r.ResolvedByType, ResolvedByID: r.ResolvedByID,
}
stats[uuidToString(r.ID)] = rootStat{ReplyCount: int(r.ReplyCount), LastActivityAt: r.LastActivityAt}
}
return fetchCommentsResult{Comments: comments, RootStats: stats}, nil
}
rows, err := h.Queries.ListRootCommentsForIssue(ctx, db.ListRootCommentsForIssueParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
RowLimit: commentHardCap,
})
if err != nil {
return fetchCommentsResult{}, err
}
comments := make([]db.Comment, len(rows))
for i, r := range rows {
comments[i] = db.Comment{
ID: r.ID, IssueID: r.IssueID, AuthorType: r.AuthorType, AuthorID: r.AuthorID,
Content: r.Content, Type: r.Type, CreatedAt: r.CreatedAt, UpdatedAt: r.UpdatedAt,
ParentID: r.ParentID, WorkspaceID: r.WorkspaceID, ResolvedAt: r.ResolvedAt,
ResolvedByType: r.ResolvedByType, ResolvedByID: r.ResolvedByID,
}
stats[uuidToString(r.ID)] = rootStat{ReplyCount: int(r.ReplyCount), LastActivityAt: r.LastActivityAt}
}
return fetchCommentsResult{Comments: comments, RootStats: stats}, nil
}
// Default + since paths preserved verbatim (no behavioural change for
// existing callers).
if args.Since.Valid {
comments, err := h.Queries.ListCommentsSinceForIssue(ctx, db.ListCommentsSinceForIssueParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
CreatedAt: args.Since,
Limit: commentHardCap,
})
return fetchCommentsResult{Comments: comments}, err
}
comments, err := h.Queries.ListCommentsForIssue(ctx, db.ListCommentsForIssueParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
Limit: commentHardCap,
})
return fetchCommentsResult{Comments: comments}, err
}
type CreateCommentRequest struct {
Content string `json:"content"`
Type string `json:"type"`
ParentID *string `json:"parent_id"`
AttachmentIDs []string `json:"attachment_ids"`
SuppressAgentIDs []string `json:"suppress_agent_ids"`
}
type CommentTriggerPreviewRequest struct {
Content string `json:"content"`
ParentID *string `json:"parent_id"`
EditingCommentID *string `json:"editing_comment_id"`
}
type CommentTriggerPreviewResponse struct {
Agents []CommentTriggerAgentResponse `json:"agents"`
// Blocked lists explicit @agent / @squad mentions that will NOT trigger if
// this comment is posted as-is (MUL-4525 §2). Additive: old clients ignore
// it. It lets the composer warn before sending instead of the user only
// discovering the silent no-op afterwards.
Blocked []CommentTriggerOutcome `json:"blocked,omitempty"`
}
type CommentTriggerAgentResponse struct {
ID string `json:"id"`
Name string `json:"name"`
AvatarURL *string `json:"avatar_url,omitempty"`
Source string `json:"source"`
Reason string `json:"reason"`
}
type commentAgentTriggerSource string
const (
commentTriggerSourceIssueAssignee commentAgentTriggerSource = "issue_assignee"
commentTriggerSourceMentionAgent commentAgentTriggerSource = "mention_agent"
commentTriggerSourceMentionSquadLeader commentAgentTriggerSource = "mention_squad_leader"
commentTriggerSourceThreadParent commentAgentTriggerSource = "thread_parent"
commentTriggerSourceConversation commentAgentTriggerSource = "conversation_continuation"
)
const defaultCommentRoutingEscalationDelay = 5 * time.Minute
func (h *Handler) commentRoutingEscalationDelay(ctx context.Context, workspaceID pgtype.UUID) time.Duration {
ws, err := h.Queries.GetWorkspace(ctx, workspaceID)
if err != nil || len(ws.Settings) == 0 {
return defaultCommentRoutingEscalationDelay
}
var settings struct {
CommentRouting struct {
EscalationSeconds *int `json:"escalation_seconds"`
} `json:"comment_routing"`
}
if err := json.Unmarshal(ws.Settings, &settings); err != nil || settings.CommentRouting.EscalationSeconds == nil {
return defaultCommentRoutingEscalationDelay
}
if *settings.CommentRouting.EscalationSeconds <= 0 {
return 0
}
return time.Duration(*settings.CommentRouting.EscalationSeconds) * time.Second
}
type commentEscalationFallback struct {
Agent db.Agent
Squad *db.Squad
}
type commentAgentTrigger struct {
Agent db.Agent
Source commentAgentTriggerSource
Squad *db.Squad
EscalationFallback *commentEscalationFallback
AlreadyPending bool
}
type commentTriggerComputeOptions struct {
ExcludeTriggerCommentID pgtype.UUID
// OriginatorUserID is the top-of-chain human user id for this trigger
// (MUL-3963). Only consulted for AGENT actors — canInvokeAgent judges A2A
// by the originator, not the immediate agent principal. Members are their
// own originator so this may be empty for member-authored triggers.
OriginatorUserID string
// AutopilotDelegationAuthorityUserID is the lineage-verified autopilot creator
// whose invoke rights an UNATTRIBUTED autopilot dispatch borrows for the A2A
// gate when it delegates mid-chain on the issue that autopilot created
// (MUL-4857). It is resolved SEPARATELY from OriginatorUserID, at the trusted
// request/comment boundary, from the server-trusted speaking task (see
// autopilotDelegationAuthority); it is empty whenever that lineage cannot be
// verified, which keeps the gate fail-closed. effectiveInvoker consults it ONLY
// when OriginatorUserID is empty. Authorization input only — attribution/audit
// read OriginatorUserID, never this, so the enqueued run stays unattributed.
AutopilotDelegationAuthorityUserID string
}
// effectiveInvoker is the human principal the A2A invoke gate (canInvokeAgent)
// keys on for this comment: the resolved top-of-chain human originator, or — only
// when the run carried no human originator — the lineage-verified autopilot
// delegation authority (MUL-4857). OriginatorUserID is left untouched so
// attribution stays accurate; the authority is a gate-only fallback. For member
// actors both are the member (or the fallback is unset), and canInvokeAgent
// ignores this value for members anyway.
func (o commentTriggerComputeOptions) effectiveInvoker() string {
if o.OriginatorUserID != "" {
return o.OriginatorUserID
}
return o.AutopilotDelegationAuthorityUserID
}
func commentAgentTriggerReason(trigger commentAgentTrigger) string {
switch trigger.Source {
case commentTriggerSourceIssueAssignee:
return "Current issue assignment will trigger this agent."
case commentTriggerSourceMentionAgent:
return "This agent was mentioned in the comment."
case commentTriggerSourceMentionSquadLeader:
return "A mentioned squad will trigger its leader."
case commentTriggerSourceThreadParent:
return "This reply will trigger the parent comment's author."
case commentTriggerSourceConversation:
return "This follow-up will continue the recent agent conversation."
default:
return "This comment will trigger this agent."
}
}
func commentAgentTriggerToResponse(trigger commentAgentTrigger) CommentTriggerAgentResponse {
return CommentTriggerAgentResponse{
ID: uuidToString(trigger.Agent.ID),
Name: trigger.Agent.Name,
AvatarURL: textToPtr(trigger.Agent.AvatarUrl),
Source: string(trigger.Source),
Reason: commentAgentTriggerReason(trigger),
}
}
func (h *Handler) PreviewCommentTriggers(w http.ResponseWriter, r *http.Request) {
issueID := chi.URLParam(r, "id")
issue, ok := h.loadIssueForUser(w, r, issueID)
if !ok {
return
}
userID, ok := requireUserID(w, r)
if !ok {
return
}
var req CommentTriggerPreviewRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeError(w, http.StatusBadRequest, "invalid request body")
return
}
var editingComment *db.Comment
var opts commentTriggerComputeOptions
if req.EditingCommentID != nil {
editingID, ok := parseUUIDOrBadRequest(w, *req.EditingCommentID, "editing_comment_id")
if !ok {
return
}
comment, err := h.Queries.GetCommentInWorkspace(r.Context(), db.GetCommentInWorkspaceParams{
ID: editingID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil || uuidToString(comment.IssueID) != uuidToString(issue.ID) {
writeError(w, http.StatusBadRequest, "invalid editing comment")
return
}
editingComment = &comment
opts.ExcludeTriggerCommentID = editingID
}
var parentID pgtype.UUID
if req.ParentID != nil {
parentID, ok = parseUUIDOrBadRequest(w, *req.ParentID, "parent_id")
if !ok {
return
}
if editingComment != nil && uuidToString(parentID) != uuidToString(editingComment.ParentID) {
writeError(w, http.StatusBadRequest, "parent_id does not match editing comment")
return
}
} else if editingComment != nil && editingComment.ParentID.Valid {
parentID = editingComment.ParentID
}
var parentComment *db.Comment
if parentID.Valid {
parent, err := h.Queries.GetComment(r.Context(), parentID)
if err != nil || uuidToString(parent.IssueID) != uuidToString(issue.ID) {
writeError(w, http.StatusBadRequest, "invalid parent comment")
return
}
parentComment = &parent
}
// Normalize with the SAME entry point CreateComment/UpdateComment apply
// before persisting (sanitizeNullBytes), so the preview computes triggers on
// the exact content that will be stored and enqueued on submit. Otherwise a
// mention hidden behind a byte the DB strips (e.g. a NUL inside
// mention://agent/<uuid>) reads as inert in preview but enqueues the agent on
// submit — a preview/side-effect divergence (GH #5388 review).
content := sanitizeNullBytes(req.Content)
if content == "" {
writeJSON(w, http.StatusOK, CommentTriggerPreviewResponse{Agents: []CommentTriggerAgentResponse{}})
return
}
actorType, actorID := h.resolveActor(r, userID, uuidToString(issue.WorkspaceID))
opts.OriginatorUserID = h.invokeOriginatorFromRequest(r, actorType, actorID)
opts.AutopilotDelegationAuthorityUserID = h.autopilotDelegationAuthorityFromRequest(r, issue, actorType, actorID)
triggers, targets := h.computeCommentAgentTriggers(r.Context(), issue, content, parentComment, actorType, actorID, opts)
resp := CommentTriggerPreviewResponse{
Agents: make([]CommentTriggerAgentResponse, 0, len(triggers)),
Blocked: commentBlockedTargetOutcomes(targets),
}
for _, trigger := range triggers {
resp.Agents = append(resp.Agents, commentAgentTriggerToResponse(trigger))
}
writeJSON(w, http.StatusOK, resp)
}
// taskCoversReplyParent reports whether parentID is a comment this task is
// authorized to reply under. A comment-triggered task may reply to its trigger
// comment OR to any earlier comment that was folded into the same run while it
// was still queued (coalesced_comment_ids). A coalesced run answers each root
// thread it covered inside that thread, so its replies legitimately target
// those threads' comments — not just the trigger (MUL-4348 per-thread fan-out).
//
// Every other parent on the task's own issue is still rejected: this is the
// defense against resumed-session --parent drift and cross-thread misplacement.
// The allow-list is exactly the set the run was given to answer, so it cannot
// reach arbitrary comments.
func taskCoversReplyParent(task db.AgentTaskQueue, parentID pgtype.UUID) bool {
if !parentID.Valid {
return false
}
target := uuidToString(parentID)
if task.TriggerCommentID.Valid && uuidToString(task.TriggerCommentID) == target {
return true
}
for _, id := range task.CoalescedCommentIds {
if id.Valid && uuidToString(id) == target {
return true
}
}
return false
}
func (h *Handler) CreateComment(w http.ResponseWriter, r *http.Request) {
issueID := chi.URLParam(r, "id")
issue, ok := h.loadIssueForUser(w, r, issueID)
if !ok {
return
}
userID, ok := requireUserID(w, r)
if !ok {
return
}
var req CreateCommentRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeError(w, http.StatusBadRequest, "invalid request body")
return
}
// Strip bytes PostgreSQL's TEXT column rejects before the empty check. The
// case reachable over the JSON API is an embedded NUL (0x00, SQLSTATE
// 22021) that survives a JSON round trip; sanitizeNullBytes also drops
// invalid UTF-8 as defense-in-depth. A stray such byte in agent-written
// content (notably via --content-file) otherwise fails the INSERT with an
// opaque 500 the CLI renders as "server unavailable" and retries forever —
// the plausible cause of GH #5388. Mirrors the skill-import sanitization;
// normalizing first means all-NUL content is correctly treated as empty.
req.Content = sanitizeNullBytes(req.Content)
if req.Content == "" {
writeError(w, http.StatusBadRequest, "content is required")
return
}
if req.Type == "" {
req.Type = "comment"
}
var parentID pgtype.UUID
var parentComment *db.Comment
if req.ParentID != nil {
var parsed pgtype.UUID
parsed, ok = parseUUIDOrBadRequest(w, *req.ParentID, "parent_id")
if !ok {
return
}
parentID = parsed
parent, err := h.Queries.GetComment(r.Context(), parentID)
if err != nil || uuidToString(parent.IssueID) != uuidToString(issue.ID) {
writeError(w, http.StatusBadRequest, "invalid parent comment")
return
}
parentComment = &parent
}
attachmentIDs, ok := parseUUIDSliceOrBadRequest(w, req.AttachmentIDs, "attachment_ids")
if !ok {
return
}
suppressAgentIDs, ok := parseUUIDSliceOrBadRequest(w, req.SuppressAgentIDs, "suppress_agent_ids")
if !ok {
return
}
// Determine author identity: agent (via X-Agent-ID header) or member.
authorType, authorID := h.resolveActor(r, userID, uuidToString(issue.WorkspaceID))
// Defense against resumed-session drift: when an agent posts from inside a
// comment-triggered task AND the comment is being posted on that same
// issue, the parent_id must exactly match the task's trigger comment.
// Resumed Claude sessions otherwise carry forward a previous turn's
// --parent UUID and silently misplace the reply.
//
// The task.IssueID scope is important: the CLI stamps X-Task-ID on every
// request, so an agent legitimately commenting on a different issue must
// not be blocked by its current task's trigger. Assignment-triggered
// tasks (no TriggerCommentID) are also unaffected.
// sourceTaskID captures the agent's currently-executing task when it posts
// via the CLI (X-Task-ID header). Stamping it on the comment row keeps the
// originator inheritance chain (resolveOriginatorFromTriggerComment →
// comment.source_task_id → parent task's originator_user_id) intact across
// the leader→worker mention hop. Without this stamp, a private squad
// leader's worker-agent whose completion wakes the leader via
// routeAssignedSquadLeaderFallback can't pass canInvokeAgent — the
// worker's task originator is unattributed, effectiveUser resolves to "",
// and the private-agent gate denies the wake (MUL-4015).
var sourceTaskID pgtype.UUID
if authorType == "agent" {
if taskIDHeader := r.Header.Get("X-Task-ID"); taskIDHeader != "" {
taskUUID, parseErr := util.ParseUUID(taskIDHeader)
if parseErr == nil {
task, err := h.Queries.GetAgentTask(r.Context(), taskUUID)
if err == nil && task.IssueID.Valid && uuidToString(task.IssueID) == uuidToString(issue.ID) {
if task.TriggerCommentID.Valid {
if !taskCoversReplyParent(task, parentID) {
// Keep this error actionable for agents (MUL-4417 / GH #5266).
writeError(w, http.StatusConflict,
"comment-triggered tasks cannot create top-level comments; set parent_id (--parent) to "+uuidToString(task.TriggerCommentID)+" or a coalesced comment id")
return
}
}
noAction, checkErr := service.HasSquadLeaderNoActionEvaluationForTask(r.Context(), h.Queries, task)
if checkErr != nil {
slog.Warn("checking squad leader no_action evaluation failed", append(logger.RequestAttrs(r),
"error", checkErr,
"task_id", taskIDHeader,
"issue_id", issueID,
)...)
} else if noAction {
writeError(w, http.StatusConflict, "squad leader recorded no_action; comments are not allowed for this task")
return
}
// Only stamp source_task_id for a task belonging to THIS
// issue. An agent legitimately commenting on a DIFFERENT
// issue than its current task must not stamp that task's
// id here — the resulting chain would then attribute the
// out-of-band comment to an unrelated task's originator.
sourceTaskID = taskUUID
}
}
}
}
// NOTE: Comment content is stored as Markdown source. XSS is handled at the
// rendering layer (rehype-sanitize) and at the editor layer
// (@tiptap/markdown with html:false). Running an HTML sanitizer here would
// entity-encode Markdown syntax characters (>, ", &, <) and corrupt the
// source. See issue #1303 / discussion in MUL-1119, MUL-1125.
// parent_id stores the exact comment being replied to. Thread-level behavior
// (for example auto-unresolving a resolved thread) resolves the root
// separately so storing a reply-to-reply does not destroy the direct-parent
// signal used by trigger decisions.
var rootComment *db.Comment
if parentID.Valid {
if root, err := h.Queries.GetThreadRoot(r.Context(), db.GetThreadRootParams{
CommentID: parentID,
WorkspaceID: issue.WorkspaceID,
}); err == nil {
rootComment = &root
}
}
comment, err := h.Queries.CreateComment(r.Context(), db.CreateCommentParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
AuthorType: authorType,
AuthorID: parseUUID(authorID),
Content: req.Content,
Type: req.Type,
ParentID: parentID,
SourceTaskID: sourceTaskID,
})
if err != nil {
slog.Warn("create comment failed", append(logger.RequestAttrs(r), "error", err, "issue_id", issueID)...)
writeError(w, http.StatusInternalServerError, "failed to create comment: "+err.Error())
return
}
// Link uploaded attachments to this comment.
if len(attachmentIDs) > 0 {
h.linkAttachmentsByIDs(r.Context(), comment.ID, issue.ID, attachmentIDs)
}
// Fetch linked attachments so the response includes them.
groupedAtt := h.groupAttachments(r, []pgtype.UUID{comment.ID})
resp := commentToResponse(comment, nil, groupedAtt[uuidToString(comment.ID)])
slog.Info("comment created", append(logger.RequestAttrs(r), "comment_id", uuidToString(comment.ID), "issue_id", issueID)...)
h.publish(protocol.EventCommentCreated, uuidToString(issue.WorkspaceID), authorType, authorID, map[string]any{
"comment": resp,
"issue_title": issue.Title,
"issue_assignee_type": textToPtr(issue.AssigneeType),
"issue_assignee_id": uuidToPtr(issue.AssigneeID),
"issue_status": issue.Status,
})
// A reply in a resolved thread re-opens it. Done after CreateComment commits
// so the reply is visible regardless of the unresolve outcome. Shared with
// the agent task path (TaskService.createAgentComment) — both reply paths
// must keep the resolved root in sync.
h.TaskService.AutoUnresolveThreadOnReply(r.Context(), rootComment, uuidToString(issue.WorkspaceID), authorType, authorID)
if authorType == "agent" {
h.TaskService.CancelDeferredEscalationsForIssueAgent(r.Context(), issue.ID, comment.AuthorID)
}
originatorUserID := h.invokeOriginatorFromRequest(r, authorType, authorID)
// MUL-4857: resolve the autopilot delegation authority from the SAME
// server-trusted X-Task-ID header the originator resolution uses, so an
// unattributed autopilot dispatch delegating mid-chain is keyed on its
// autopilot creator only when the speaking task's lineage checks out.
delegationAuthority := h.autopilotDelegationAuthorityFromRequest(r, issue, authorType, authorID)
// The comment is already saved; a blocked mention must not fail the whole
// request. Surface the per-target outcomes so the client can show partial
// success instead of a silent no-op (MUL-4525 §2).
resp.TriggerOutcomes = h.triggerTasksForComment(r.Context(), issue, comment, parentComment, authorType, authorID, originatorUserID, delegationAuthority, suppressAgentIDs)
writeJSON(w, http.StatusCreated, resp)
}
// noteCommentPrefix marks a comment as a human-only note. A comment whose first
// whitespace-delimited token is this prefix (case-insensitive) is stored like
// any other comment but never triggers an agent.
const noteCommentPrefix = "/note"
// isNoteComment reports whether content opts out of agent triggering via the
// reserved /note prefix. The prefix must be the comment's first token, so
// "/note check expiry", " /NOTE", and "/note" all match, while "/notes",
// "/ note", and "see foo/note" do not.
func isNoteComment(content string) bool {
trimmed := strings.TrimLeft(content, " \t\r\n")
firstToken := trimmed
if i := strings.IndexFunc(trimmed, unicode.IsSpace); i >= 0 {
firstToken = trimmed[:i]
}
return strings.EqualFold(firstToken, noteCommentPrefix)
}
// triggerTasksForComment resolves and enqueues the comment's agent triggers and
// returns the per-target outcomes for explicit @agent / @squad mentions
// (MUL-4525 §2): blocked mentions from resolution plus queued / coalesced /
// deferred / blocked from enqueue. UI-suppressed triggers (the user unchecked
// them) are removed before enqueue and produce no outcome.
func (h *Handler) triggerTasksForComment(ctx context.Context, issue db.Issue, comment db.Comment, parentComment *db.Comment, actorType, actorID, originatorUserID, delegationAuthorityUserID string, suppressAgentIDs []pgtype.UUID) []CommentTriggerOutcome {
if isNoteComment(comment.Content) {
return nil
}
triggers, targets := h.computeCommentAgentTriggers(ctx, issue, comment.Content, parentComment, actorType, actorID, commentTriggerComputeOptions{
ExcludeTriggerCommentID: comment.ID,
OriginatorUserID: originatorUserID,
AutopilotDelegationAuthorityUserID: delegationAuthorityUserID,
})
triggers = filterSuppressedCommentAgentTriggers(triggers, suppressAgentIDs)
enqueued := h.enqueueCommentAgentTriggers(ctx, issue, comment.ID, triggers)
return commentTriggerOutcomes(targets, enqueued)
}
func filterSuppressedCommentAgentTriggers(triggers []commentAgentTrigger, suppressAgentIDs []pgtype.UUID) []commentAgentTrigger {
if len(triggers) == 0 || len(suppressAgentIDs) == 0 {
return triggers
}
suppressed := make(map[string]struct{}, len(suppressAgentIDs))
for _, id := range suppressAgentIDs {
if id.Valid {
suppressed[uuidToString(id)] = struct{}{}
}
}
if len(suppressed) == 0 {
return triggers
}
filtered := make([]commentAgentTrigger, 0, len(triggers))
for _, trigger := range triggers {
if _, ok := suppressed[uuidToString(trigger.Agent.ID)]; ok {
continue
}
filtered = append(filtered, trigger)
}
return filtered
}
// commentEnqueueResult is the domain outcome of enqueuing ONE executing agent.
// execSquadID is the squad whose leader context the run actually carries (set
// only for a squad-leader execution), so a DIFFERENT squad that shares this
// leader can be reported honestly as coalesced rather than as if its own leader
// context ran.
type commentEnqueueResult struct {
status DispatchStatus
reason DispatchReasonCode
execSquadID string
}
// enqueueCommentAgentTriggers enqueues each resolved trigger (already deduped by
// executing agent) and returns the result keyed by executing agent id
// (MUL-4525 §2). Outcomes are later fanned from these to every explicit mention
// target that resolved to the agent, so coalescing a run never drops a named
// target's outcome. queued / coalesced / deferred are success-shaped (the run
// was handled, no duplicate task); only a real enqueue failure is blocked.
func (h *Handler) enqueueCommentAgentTriggers(ctx context.Context, issue db.Issue, triggerCommentID pgtype.UUID, triggers []commentAgentTrigger) map[string]commentEnqueueResult {
var escalationDelay time.Duration
escalationDelayLoaded := false
getEscalationDelay := func() time.Duration {
if !escalationDelayLoaded {
escalationDelay = h.commentRoutingEscalationDelay(ctx, issue.WorkspaceID)
escalationDelayLoaded = true
}
return escalationDelay
}
results := make(map[string]commentEnqueueResult, len(triggers))
record := func(trigger commentAgentTrigger, status DispatchStatus, reason DispatchReasonCode) {
execSquadID := ""
if trigger.Squad != nil {
execSquadID = uuidToString(trigger.Squad.ID)
}
results[uuidToString(trigger.Agent.ID)] = commentEnqueueResult{status: status, reason: reason, execSquadID: execSquadID}
}
for _, trigger := range triggers {
if trigger.AlreadyPending {
// MUL-4195: a queued/dispatched task for this (issue, agent)
// already exists. Historically we DROPPED the comment here, losing
// the user's follow-up instruction. Instead try to fold it into the
// queued (not-yet-claimed) task so a single run still covers every
// comment, re-stamping the run's originator/overlay to the new
// comment (mergeCommentIntoPendingTask).
//
// The merge reports HOW it resolved: a real merge is coalesced, a
// fail-closed / failed merge is blocked (attribution_blocked /
// internal_error) — never mislabeled as success (MUL-4525 §2, Elon
// round 5). Only "no queued task to fold into" falls through to the
// active-task decision below.
if status, reason, terminal := commentMergeTerminalOutcome(
h.mergeCommentIntoPendingTask(ctx, issue, trigger, triggerCommentID),
); terminal {
record(trigger, status, reason)
continue
}
// The merge found no queued task to fold into: the existing task
// is already dispatched/running (its claim response is built), or
// the queued row was just claimed. We must NOT enqueue a
// fresh queued task in that case — a dispatched sibling would trip
// the idx_one_pending_task_per_issue_agent unique index (dropping
// the comment again) and even where the index allows it we'd risk a
// duplicate concurrent run. When an active task exists, its
// completion reconcile (reconcileCommentsOnCompletion) is what
// guarantees this comment earns a bounded follow-up. Only when NO
// active task exists is a fresh enqueue both safe and necessary. On a
// query failure we fail closed (no fresh enqueue) and report a
// non-success internal_error rather than a fabricated deferred.
active, activeErr := h.hasActiveTaskForIssueAndAgent(ctx, issue.ID, trigger.Agent.ID)
if status, reason, enqueueFresh := decidePostMergeMiss(active, activeErr); !enqueueFresh {
record(trigger, status, reason)
continue
}
}
if err := h.enqueueSingleCommentTrigger(ctx, issue, triggerCommentID, trigger, getEscalationDelay); err != nil {
record(trigger, DispatchBlocked, commentEnqueueFailureReason(err))
continue
}
record(trigger, DispatchQueued, ReasonQueued)
}
return results
}
// commentTriggerOutcomes maps each explicit mention target to its final outcome
// (MUL-4525 §2): a target that resolved to an executing agent takes that agent's
// enqueue status, so several mentions coalescing into one run each still get
// their own outcome; a terminal target (blocked / self-suppressed) carries its
// own status. A target whose executing agent has no enqueue result — because the
// composer suppressed (unchecked) it — yields no outcome, since the user opted
// out deliberately.
func commentTriggerOutcomes(targets []commentMentionTarget, enqueued map[string]commentEnqueueResult) []CommentTriggerOutcome {
if len(targets) == 0 {
return nil
}
outcomes := make([]CommentTriggerOutcome, 0, len(targets))
for _, t := range targets {
if t.ExecAgentID != "" {
res, ok := enqueued[t.ExecAgentID]
if !ok {
continue
}
status, reason := res.status, res.reason
// A @squad whose shared leader ran, but under a DIFFERENT squad's
// context, did not get its own leader briefing injected — the single
// leader run (one task per issue+agent) merely folds it in. Report
// coalesced, not queued, so we never claim this squad's leader
// context executed (MUL-4525, Elon round 3).
if t.TargetType == "squad" && res.execSquadID != "" && res.execSquadID != t.TargetID && status == DispatchQueued {
status, reason = DispatchCoalesced, ReasonCoalesced
}
outcomes = append(outcomes, CommentTriggerOutcome{TargetType: t.TargetType, TargetID: t.TargetID, Status: status, ReasonCode: reason})
continue
}
outcomes = append(outcomes, CommentTriggerOutcome{TargetType: t.TargetType, TargetID: t.TargetID, Status: t.Status, ReasonCode: t.ReasonCode})
}
return outcomes
}
// commentBlockedTargetOutcomes is the composer-preview projection: the explicit
// mentions that will NOT trigger if the comment is posted as-is (MUL-4525 §2). A
// resolvable/executing target instead appears in the preview `agents` list, so
// only terminal blocked targets surface here.
func commentBlockedTargetOutcomes(targets []commentMentionTarget) []CommentTriggerOutcome {
var blocked []CommentTriggerOutcome
for _, t := range targets {
if t.Status == DispatchBlocked {
blocked = append(blocked, CommentTriggerOutcome{TargetType: t.TargetType, TargetID: t.TargetID, Status: t.Status, ReasonCode: t.ReasonCode})
}
}
return blocked
}
// commentEnqueueFailureReason types an enqueue error that reached the response
// (MUL-4525 §2). The admission gate (canInvokeAgent / archived / runtime) already
// ran during resolution, so a failure here is either a fail-closed attribution
// refusal (attribution_blocked, typed via errors.Is) or a rare race /
// infrastructure error that stays an unclassified internal error rather than
// leaking the raw message.
func commentEnqueueFailureReason(err error) DispatchReasonCode {
if errors.Is(err, service.ErrAttributionFailClosed) {
return ReasonAttributionBlocked
}
return ReasonInternalError
}
// hasActiveTaskForIssueAndAgent reports whether the (issue, agent) pair has any
// non-terminal task whose completion will drive completion reconciliation. It
// returns the query error rather than swallowing it (MUL-4525, Elon round 4):
// callers must fail closed on error (never enqueue a possibly-colliding
// duplicate) AND must not report a success — "cannot confirm whether a run is
// active" is never the same as "a run is active". See decidePostMergeMiss /
// decideSuppressedLeaderOutcome for the two decisions.
func (h *Handler) hasActiveTaskForIssueAndAgent(ctx context.Context, issueID, agentID pgtype.UUID) (bool, error) {
active, err := h.Queries.HasActiveTaskForIssueAndAgent(ctx, db.HasActiveTaskForIssueAndAgentParams{
IssueID: issueID,
AgentID: agentID,
})
if err != nil {
slog.Warn("has active task for issue+agent check failed",
"issue_id", uuidToString(issueID), "agent_id", uuidToString(agentID), "error", err)
return false, err
}
return active, nil
}
// decidePostMergeMiss decides what to do after a comment merge missed on a
// target that had a pending task (MUL-4525, Elon round 4). On a query failure
// (activeErr != nil) it FAILS CLOSED: never enqueue a fresh task — a duplicate
// concurrent run risk — and report a non-success internal_error, since we cannot
// confirm a run is active. A confirmed active task defers to that run's
// reconcile; only a confirmed-none enqueues a fresh follow-up.
func decidePostMergeMiss(active bool, activeErr error) (status DispatchStatus, reason DispatchReasonCode, enqueueFresh bool) {
switch {
case activeErr != nil:
return DispatchBlocked, ReasonInternalError, false
case active:
return DispatchDeferred, ReasonDeferred, false
default:
return "", "", true
}
}
// decideSuppressedLeaderOutcome maps the self-trigger-suppressed squad leader's
// active-task check to an honest outcome (MUL-4525, Elon round 4). A query
// failure is never success — it is internal_error, not a fabricated deferred.
// A confirmed active run defers (its reconcile covers the comment); otherwise
// nothing runs and the outcome is self_trigger_suppressed.
func decideSuppressedLeaderOutcome(active bool, activeErr error) (DispatchStatus, DispatchReasonCode) {
switch {
case activeErr != nil:
return DispatchBlocked, ReasonInternalError
case active:
return DispatchDeferred, ReasonAlreadyActive
default:
return DispatchBlocked, ReasonSelfTriggerSuppressed
}
}
// commentMergeResult distinguishes how a pending-task merge attempt resolved so
// the caller can report an HONEST outcome (MUL-4525, Elon round 5). A real merge
// is coalesced, but a REFUSED or FAILED merge — even when we correctly fail
// closed by keeping the original task and not enqueuing a duplicate — must NOT
// be reported as a success-shaped coalesced.
type commentMergeResult int
const (
// commentMergeSucceeded: the comment folded into the queued task → coalesced.
commentMergeSucceeded commentMergeResult = iota
// commentMergeNoPendingTask: no queued task to merge into anymore (it was
// claimed/started between the dedup check and now). The caller runs the
// active-task decision (defer vs fresh enqueue).
commentMergeNoPendingTask
// commentMergeAttributionBlocked: fail-closed attribution refused re-stamping
// the merge. The original task is kept and no fresh task is enqueued, but the
// re-attribution did NOT happen → outcome attribution_blocked, not success.
commentMergeAttributionBlocked
// commentMergeError: an unknown attribution/DB error. Fail closed (keep the
// task, no duplicate enqueue), but the merge did not complete → outcome
// internal_error, not success.
commentMergeError
)
// commentMergeTerminalOutcome maps a merge result that carries its own final
// outcome (everything except commentMergeNoPendingTask, which needs the
// active-task decision) to the reported (status, reason). terminal=false only
// for commentMergeNoPendingTask.
func commentMergeTerminalOutcome(result commentMergeResult) (status DispatchStatus, reason DispatchReasonCode, terminal bool) {
switch result {
case commentMergeSucceeded:
return DispatchCoalesced, ReasonCoalesced, true
case commentMergeAttributionBlocked:
return DispatchBlocked, ReasonAttributionBlocked, true
case commentMergeError:
return DispatchBlocked, ReasonInternalError, true
default: // commentMergeNoPendingTask
return "", "", false
}
}
// mergeCommentIntoPendingTask folds a newly-arrived comment into the existing
// QUEUED (not-yet-claimed) task for (issue, agent) instead of dropping it
// (MUL-4195). It reports HOW it resolved via commentMergeResult so the caller
// never mislabels a refused/failed merge as success (MUL-4525 §2). No path here
// enqueues a duplicate: on any failure the original task is kept intact, so the
// comment is still read by that run and its instruction is not lost — only the
// re-attribution / merge bookkeeping is declined, and that is surfaced honestly.
//
// Recompute-on-merge (MUL-4195 review must-fix #1): on success the run's
// originator_user_id, runtime_mcp_overlay and runtime_connected_apps are
// re-stamped to the NEW trigger comment's originator, and trigger_summary is
// refreshed — so a different member's comment safely folds into a task another
// member created, the coalescing run carrying the latest instruction's
// originator and matching connected-app overlay.
func (h *Handler) mergeCommentIntoPendingTask(ctx context.Context, issue db.Issue, trigger commentAgentTrigger, newTriggerCommentID pgtype.UUID) commentMergeResult {
// Re-attribute the coalescing run to the new comment's human atomically: the
// whole attribution snapshot moves, not just the person columns (MUL-4302). An
// issue-assignee reaction is comment_source; a mention / thread-parent /
// conversation hop is delegation.
isMention := trigger.Source != commentTriggerSourceIssueAssignee
attr, err := h.TaskService.AttributionForMergedComment(ctx, issue.WorkspaceID, newTriggerCommentID, isMention, trigger.Agent)
if err != nil {
// The new comment cannot be re-attributed. REFUSE the merge — keep the
// existing queued task on its original (precise) snapshot rather than
// re-stamp it to a degraded owner_fallback, and never spawn a duplicate.
// A fail-closed refusal is a distinct, honest outcome (attribution_blocked);
// any other error is unclassified (internal_error) — neither is success.
slog.Warn("refused comment merge: attribution failed, keeping original task snapshot",
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"new_trigger_comment_id", uuidToString(newTriggerCommentID),
"error", err)
if errors.Is(err, service.ErrAttributionFailClosed) {
return commentMergeAttributionBlocked
}
return commentMergeError
}
overlay, connectedApps := h.TaskService.BuildRuntimeMCPOverlayForMerge(ctx, attr.UserID, trigger.Agent)
row, err := h.Queries.MergeCommentIntoPendingTask(ctx, db.MergeCommentIntoPendingTaskParams{
IssueID: issue.ID,
AgentID: trigger.Agent.ID,
NewTriggerCommentID: newTriggerCommentID,
NewOriginatorUserID: attr.UserID,
NewAccountableUserID: attr.AccountableUserID,
NewOriginatorSource: pgtype.Text{String: attr.Source.String(), Valid: true},
NewDelegatedFromTaskID: attr.DelegatedFromTaskID,
NewRuleVersionID: attr.RuleVersionID,
NewTriggerEvidenceKind: pgtype.Text{String: string(attr.EvidenceKind), Valid: attr.EvidenceKind != ""},
NewTriggerEvidenceRefID: attr.EvidenceRefID,
NewTriggerSummary: h.TaskService.BuildCommentTriggerSummary(ctx, issue.WorkspaceID, newTriggerCommentID),
NewRuntimeMcpOverlay: overlay,
NewRuntimeConnectedApps: connectedApps,
})
if err != nil {
if isNotFound(err) {
// No pre-claim (queued/deferred) task to merge into. The caller
// defers to completion reconcile when an active task exists, or
// enqueues fresh when none does.
return commentMergeNoPendingTask
}
// Unknown error: the pending task most likely still exists, so do NOT
// risk enqueuing a duplicate — but the merge did not happen, so this is
// not a success.
slog.Warn("merge comment into pending task failed",
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"error", err)
return commentMergeError
}
slog.Info("merged comment into pending task",
"task_id", uuidToString(row.ID),
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"new_trigger_comment_id", uuidToString(newTriggerCommentID),
"coalesced_count", len(row.CoalescedCommentIds))
return commentMergeSucceeded
}
// enqueueSingleCommentTrigger creates a fresh task for one computed trigger.
// Split out of enqueueCommentAgentTriggers so the merge-not-drop path
// (MUL-4195) can fall back to it when a pending task vanished mid-flight.
// enqueueSingleCommentTrigger enqueues one resolved trigger and returns the
// PRIMARY enqueue error (nil on success) so the caller can surface a
// trigger_outcome (MUL-4525 §2). Secondary work (the deferred escalation
// fallback) stays best-effort logged and does not affect the returned error.
func (h *Handler) enqueueSingleCommentTrigger(ctx context.Context, issue db.Issue, triggerCommentID pgtype.UUID, trigger commentAgentTrigger, getEscalationDelay func() time.Duration) error {
switch trigger.Source {
case commentTriggerSourceIssueAssignee:
if trigger.Squad != nil {
if _, err := h.TaskService.EnqueueTaskForSquadLeader(ctx, issue, trigger.Agent.ID, trigger.Squad.ID, triggerCommentID); err != nil {
slog.Warn("enqueue squad leader task failed",
"issue_id", uuidToString(issue.ID),
"squad_id", uuidToString(trigger.Squad.ID),
"leader_id", uuidToString(trigger.Agent.ID),
"error", err)
return err
}
return nil
}
if _, err := h.TaskService.EnqueueTaskForIssue(ctx, issue, triggerCommentID); err != nil {
slog.Warn("enqueue agent task on comment failed", "issue_id", uuidToString(issue.ID), "error", err)
return err
}
case commentTriggerSourceMentionSquadLeader:
if _, err := h.TaskService.EnqueueTaskForSquadLeader(ctx, issue, trigger.Agent.ID, trigger.Squad.ID, triggerCommentID); err != nil {
slog.Warn("enqueue squad leader mention task failed",
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"error", err)
return err
}
case commentTriggerSourceMentionAgent:
if _, err := h.TaskService.EnqueueTaskForMention(ctx, issue, trigger.Agent.ID, triggerCommentID); err != nil {
slog.Warn("enqueue mention agent task failed",
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"error", err)
return err
}
case commentTriggerSourceThreadParent, commentTriggerSourceConversation:
var task db.AgentTaskQueue
var err error
if trigger.Source == commentTriggerSourceConversation && trigger.Squad != nil {
task, err = h.TaskService.EnqueueTaskForSquadLeader(ctx, issue, trigger.Agent.ID, trigger.Squad.ID, triggerCommentID)
} else {
task, err = h.TaskService.EnqueueTaskForThreadParent(ctx, issue, trigger.Agent.ID, triggerCommentID)
}
if err != nil {
slog.Warn("enqueue routed comment agent task failed",
"issue_id", uuidToString(issue.ID),
"agent_id", uuidToString(trigger.Agent.ID),
"source", trigger.Source,
"error", err)
return err
}
if trigger.EscalationFallback == nil || getEscalationDelay() <= 0 {
return nil
}
var squadID pgtype.UUID
if trigger.EscalationFallback.Squad != nil {
squadID = trigger.EscalationFallback.Squad.ID
}
if _, err := h.TaskService.EnqueueDeferredAssigneeFallback(ctx, issue, trigger.EscalationFallback.Agent.ID, squadID, task.ID, triggerCommentID, time.Now().Add(getEscalationDelay())); err != nil {
slog.Warn("enqueue deferred assignee fallback failed",
"issue_id", uuidToString(issue.ID),
"primary_agent_id", uuidToString(trigger.Agent.ID),
"fallback_agent_id", uuidToString(trigger.EscalationFallback.Agent.ID),
"error", err)
}
}
return nil
}
// computeCommentAgentTriggers resolves which agents a comment triggers (deduped
// by executing agent), plus the per-target list for every EXPLICIT @agent /
// @squad mention (MUL-4525 §2). Targets come only from the explicit-mention path
// — the implicit routing fallbacks (assignee, thread parent, conversation) were
// never named by the user, so a no-route there is not a silent no-op.
func (h *Handler) computeCommentAgentTriggers(ctx context.Context, issue db.Issue, content string, parentComment *db.Comment, actorType, actorID string, opts commentTriggerComputeOptions) ([]commentAgentTrigger, []commentMentionTarget) {
if isNoteComment(content) {
return nil, nil
}
// Autopilot delegation authority (MUL-4857) is applied by the gate via
// opts.effectiveInvoker(): when a run carried no human originator, the gate
// falls back to opts.AutopilotDelegationAuthorityUserID, which the caller has
// already resolved from a server-trusted, lineage-verified speaking task (see
// autopilotDelegationAuthority). Nothing is re-derived from issue provenance
// here, so an unrelated unattributed run cannot borrow a stranger autopilot
// creator's authority by commenting on that autopilot's issue.
mentions := util.ParseMentions(content)
if util.HasMentionAll(mentions) {
return nil, nil
}
if hasAgentOrSquadMention(mentions) {
return h.resolveMentionedAgentCommentTriggers(ctx, issue, mentions, actorType, actorID, opts)
}
if hasMemberMention(mentions) {
return nil, nil
}
if actorType != "member" {
// Agent-authored comments do not participate in the member-driven
// conversation routing (parent-author / thread-root continuation) or
// the member assignee fallback. They retain one narrow path restored
// after MUL-3794 (MUL-3879): a worker-agent result comment on a
// squad-assigned issue can still wake the assigned squad leader, so
// the leader→worker→leader coordination loop stays closed. The leader
// self-trigger guard lives in
// routeAssignedSquadLeaderFallback. Explicit @agent / @squad mentions
// are already handled above, so this never double-enqueues a mentioned
// target alongside the assigned leader.
if issue.AssigneeType.Valid && issue.AssigneeType.String == "squad" {
if trigger, ok := h.routeAssignedSquadLeaderFallback(ctx, issue, actorType, actorID, opts); ok {
return []commentAgentTrigger{trigger}, nil
}
}
return nil, nil
}
if parentComment != nil && parentComment.AuthorType == "agent" {
trigger, ok := h.routeReplyToParentAuthor(ctx, issue, parentComment, actorType, actorID, opts)
if !ok {
return nil, nil
}
if fallback, ok := h.routeAssigneeFallback(ctx, issue, actorType, actorID, opts); ok &&
uuidToString(fallback.Agent.ID) != uuidToString(trigger.Agent.ID) {
trigger.EscalationFallback = &commentEscalationFallback{
Agent: fallback.Agent,
Squad: fallback.Squad,
}
}
return []commentAgentTrigger{trigger}, nil
}
if parentComment != nil {
triggers, handled := h.routeThreadRootOwners(ctx, issue, parentComment, actorID, opts)
if handled {
if len(triggers) == 0 {
return nil, nil
}
if len(triggers) == 1 {
if fallback, ok := h.routeAssigneeFallback(ctx, issue, actorType, actorID, opts); ok &&
uuidToString(fallback.Agent.ID) != uuidToString(triggers[0].Agent.ID) {
triggers[0].EscalationFallback = &commentEscalationFallback{
Agent: fallback.Agent,
Squad: fallback.Squad,
}
}
}
return triggers, nil
}
}
if trigger, ok := h.routeAssigneeFallback(ctx, issue, actorType, actorID, opts); ok {
return []commentAgentTrigger{trigger}, nil
}
return nil, nil
}
func hasAgentOrSquadMention(mentions []util.Mention) bool {
for _, m := range mentions {
if m.Type == "agent" || m.Type == "squad" {
return true
}
}
return false
}
func hasMemberMention(mentions []util.Mention) bool {
for _, m := range mentions {
if m.Type == "member" {
return true
}
}
return false
}
func (h *Handler) routeReplyToParentAuthor(ctx context.Context, issue db.Issue, parent *db.Comment, authorType, authorID string, opts commentTriggerComputeOptions) (commentAgentTrigger, bool) {
if parent == nil || parent.AuthorType != "agent" || !parent.AuthorID.Valid {
return commentAgentTrigger{}, false
}
agent, err := h.Queries.GetAgentInWorkspace(ctx, db.GetAgentInWorkspaceParams{
ID: parent.AuthorID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil || !agent.RuntimeID.Valid || agent.ArchivedAt.Valid {
return commentAgentTrigger{}, false
}
if !h.canInvokeAgent(ctx, agent, authorType, authorID, opts.effectiveInvoker(), uuidToString(issue.WorkspaceID)) {
return commentAgentTrigger{}, false
}
hasPending, err := h.hasPendingTaskForIssueAndAgent(ctx, issue.ID, parent.AuthorID, opts)
if err != nil {
return commentAgentTrigger{}, false
}
return commentAgentTrigger{Agent: agent, Source: commentTriggerSourceThreadParent, AlreadyPending: hasPending}, true
}
type conversationRoutedAgentInfo struct {
SquadID pgtype.UUID
}
func (h *Handler) routeThreadRootOwners(ctx context.Context, issue db.Issue, parent *db.Comment, memberID string, opts commentTriggerComputeOptions) ([]commentAgentTrigger, bool) {
if parent == nil || !parent.ID.Valid {
return nil, false
}
root, err := h.Queries.GetThreadRoot(ctx, db.GetThreadRootParams{
CommentID: parent.ID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil || !root.ID.Valid || root.AuthorType != "member" {
return nil, false
}
return h.routeConversationOwnersForRoot(ctx, issue, root, memberID, opts)
}
func (h *Handler) routeConversationOwnersForRoot(ctx context.Context, issue db.Issue, root db.Comment, memberID string, opts commentTriggerComputeOptions) ([]commentAgentTrigger, bool) {
if !root.ID.Valid || root.AuthorType != "member" {
return nil, false
}
if trigger, hasExplicitOwner, ok := h.routeFirstExplicitRootMentionOwner(ctx, issue, root, memberID, opts); hasExplicitOwner {
if !ok {
return nil, true
}
return []commentAgentTrigger{trigger}, true
}
rootID := uuidToString(root.ID)
excludedID := uuidToString(opts.ExcludeTriggerCommentID)
tasks, err := h.Queries.ListTasksByIssue(ctx, issue.ID)
if err != nil {
return nil, false
}
routedAgents := make(map[string]conversationRoutedAgentInfo)
for _, task := range tasks {
if !task.TriggerCommentID.Valid || !task.AgentID.Valid {
continue
}
if excludedID != "" && uuidToString(task.TriggerCommentID) == excludedID {
continue
}
if uuidToString(task.TriggerCommentID) != rootID {
continue
}
agentID := uuidToString(task.AgentID)
info := routedAgents[agentID]
if !info.SquadID.Valid {
info.SquadID = task.SquadID
}
routedAgents[agentID] = info
}
if len(routedAgents) == 0 {
return nil, false
}
triggers := make([]commentAgentTrigger, 0, len(routedAgents))
for agentID, info := range routedAgents {
trigger, ok := h.routeConversationContinuationToAgent(ctx, issue, parseUUID(agentID), info.SquadID, memberID, opts)
if ok {
triggers = append(triggers, trigger)
}
}
return triggers, true
}
func (h *Handler) routeFirstExplicitRootMentionOwner(ctx context.Context, issue db.Issue, root db.Comment, memberID string, opts commentTriggerComputeOptions) (commentAgentTrigger, bool, bool) {
for _, mention := range util.ParseMentions(root.Content) {
switch mention.Type {
case "agent":
agentID, err := util.ParseUUID(mention.ID)
if err != nil {
return commentAgentTrigger{}, true, false
}
trigger, ok := h.routeConversationContinuationToAgent(ctx, issue, agentID, pgtype.UUID{}, memberID, opts)
return trigger, true, ok
case "squad":
squadID, err := util.ParseUUID(mention.ID)
if err != nil {
return commentAgentTrigger{}, true, false
}
squad, err := h.Queries.GetSquadInWorkspace(ctx, db.GetSquadInWorkspaceParams{
ID: squadID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil {
return commentAgentTrigger{}, true, false
}
trigger, ok := h.routeConversationContinuationToAgent(ctx, issue, squad.LeaderID, squadID, memberID, opts)
return trigger, true, ok
}
}
return commentAgentTrigger{}, false, false
}
func (h *Handler) routeConversationContinuationToAgent(ctx context.Context, issue db.Issue, agentID, squadID pgtype.UUID, memberID string, opts commentTriggerComputeOptions) (commentAgentTrigger, bool) {
if !agentID.Valid {
return commentAgentTrigger{}, false
}
agent, err := h.Queries.GetAgentInWorkspace(ctx, db.GetAgentInWorkspaceParams{
ID: agentID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil || !agent.RuntimeID.Valid || agent.ArchivedAt.Valid {
return commentAgentTrigger{}, false
}
if !h.canInvokeAgent(ctx, agent, "member", memberID, memberID, uuidToString(issue.WorkspaceID)) {
return commentAgentTrigger{}, false
}
hasPending, err := h.hasPendingTaskForIssueAndAgent(ctx, issue.ID, agentID, opts)
if err != nil {
return commentAgentTrigger{}, false
}
trigger := commentAgentTrigger{Agent: agent, Source: commentTriggerSourceConversation, AlreadyPending: hasPending}
if squadID.Valid {
if squad, err := h.Queries.GetSquadInWorkspace(ctx, db.GetSquadInWorkspaceParams{
ID: squadID,
WorkspaceID: issue.WorkspaceID,
}); err == nil {
trigger.Squad = &squad
}
}
return trigger, true
}
func (h *Handler) routeAssigneeFallback(ctx context.Context, issue db.Issue, authorType, authorID string, opts commentTriggerComputeOptions) (commentAgentTrigger, bool) {
if !issue.AssigneeType.Valid || !issue.AssigneeID.Valid {
return commentAgentTrigger{}, false
}
switch issue.AssigneeType.String {
case "agent":
agent, hasPending, ok := h.assigneeFallbackAgent(ctx, issue, authorType, authorID, opts)
if !ok {
return commentAgentTrigger{}, false
}
return commentAgentTrigger{Agent: agent, Source: commentTriggerSourceIssueAssignee, AlreadyPending: hasPending}, true
case "squad":
return h.routeAssignedSquadLeaderFallback(ctx, issue, authorType, authorID, opts)
default:
return commentAgentTrigger{}, false
}
}
func (h *Handler) routeAssignedSquadLeaderFallback(ctx context.Context, issue db.Issue, authorType, authorID string, opts commentTriggerComputeOptions) (commentAgentTrigger, bool) {
squad, err := h.Queries.GetSquadInWorkspace(ctx, db.GetSquadInWorkspaceParams{
ID: issue.AssigneeID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil {
return commentAgentTrigger{}, false
}
if authorType == "agent" && authorID == uuidToString(squad.LeaderID) &&
h.shouldSuppressSquadLeaderSelfTrigger(ctx, issue.ID, squad.LeaderID, squad.ID) {
return commentAgentTrigger{}, false
}
agent, err := h.Queries.GetAgentInWorkspace(ctx, db.GetAgentInWorkspaceParams{
ID: squad.LeaderID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil || !agent.RuntimeID.Valid || agent.ArchivedAt.Valid {
return commentAgentTrigger{}, false
}
if !h.canInvokeAgent(ctx, agent, authorType, authorID, opts.effectiveInvoker(), uuidToString(issue.WorkspaceID)) {
return commentAgentTrigger{}, false
}
hasPending, err := h.hasPendingTaskForIssueAndAgent(ctx, issue.ID, squad.LeaderID, opts)
if err != nil {
return commentAgentTrigger{}, false
}
return commentAgentTrigger{Agent: agent, Source: commentTriggerSourceIssueAssignee, Squad: &squad, AlreadyPending: hasPending}, true
}
func (h *Handler) hasPendingTaskForIssueAndAgent(ctx context.Context, issueID, agentID pgtype.UUID, opts commentTriggerComputeOptions) (bool, error) {
// Key dedup on the reviewed head so re-pushing to the PR mid-review
// invalidates dedup and a fresh run enqueues against the new HEAD (TEN-356).
headSha := h.TaskService.ResolveIssueReviewSHAParam(ctx, issueID)
if opts.ExcludeTriggerCommentID.Valid {
return h.Queries.HasPendingTaskForIssueAndAgentExcludingTriggerComment(ctx, db.HasPendingTaskForIssueAndAgentExcludingTriggerCommentParams{
IssueID: issueID,
AgentID: agentID,
ExcludeTriggerCommentID: opts.ExcludeTriggerCommentID,
HeadSha: headSha,
})
}
return h.Queries.HasPendingTaskForIssueAndAgent(ctx, db.HasPendingTaskForIssueAndAgentParams{
IssueID: issueID,
AgentID: agentID,
HeadSha: headSha,
})
}
// resolveMentionedAgentCommentTriggers parses explicit @agent and @squad
// mentions from the current comment and returns the runnable agent recipients.
// Skips agents with on_mention trigger disabled, and private agents mentioned
// by non-owner members (only the agent owner or workspace admin/owner can
// mention a private agent). Self-mentions are intentionally allowed so an
// agent running in one issue can explicitly enqueue itself on another (e.g.
// a child-issue run notifying the parent issue whose assignee is the same
// agent); runaway loops are prevented by HasPendingTaskForIssueAndAgent
// dedupe and the natural queued/dispatched coalescing of the task queue.
// Note: no issue status gate here — @mention is an explicit action and should
// work even on done/cancelled issues (the agent can reopen the issue if needed).
// commentMentionTarget is one EXPLICIT @agent / @squad mention and how it
// resolved (MUL-4525 §2). This is tracked separately from the execution
// triggers: several mentions can resolve to the same executing agent (e.g.
// @Agent A and @Squad S whose leader is A), and each still needs its own
// outcome even though the run is coalesced. Exactly one of the resolution
// fields is set:
// - ExecAgentID non-empty → the mention runs via that executing agent; its
// outcome mirrors the agent's enqueue status (queued/coalesced/deferred).
// - Status set (with ReasonCode) → a terminal, non-executing outcome
// (blocked, or an A2A self-suppressed squad leader that is deferred).
type commentMentionTarget struct {
TargetType string // "agent" | "squad"
TargetID string
ExecAgentID string
Status DispatchStatus
ReasonCode DispatchReasonCode
}
func (h *Handler) resolveMentionedAgentCommentTriggers(ctx context.Context, issue db.Issue, mentions []util.Mention, authorType, authorID string, opts commentTriggerComputeOptions) ([]commentAgentTrigger, []commentMentionTarget) {
wsID := uuidToString(issue.WorkspaceID)
triggers := make([]commentAgentTrigger, 0, len(mentions))
// seen dedups EXECUTION by resolved agent id: two mentions resolving to the
// same agent enqueue only one task. Mapping to the trigger's index lets a
// squad-leader mention UPGRADE an already-added plain @agent trigger for the
// same agent — the leader task is a strict superset (it sets is_leader_task
// and squad_id so the daemon injects the squad briefing), so the merged run
// must carry that role regardless of mention order.
seen := make(map[string]int, len(mentions))
add := func(trigger commentAgentTrigger) {
id := uuidToString(trigger.Agent.ID)
if idx, ok := seen[id]; ok {
if triggers[idx].Source != commentTriggerSourceMentionSquadLeader &&
trigger.Source == commentTriggerSourceMentionSquadLeader {
triggers[idx] = trigger
}
return
}
seen[id] = len(triggers)
triggers = append(triggers, trigger)
}
// targets record one outcome per EXPLICIT mention — deduped by the target
// the user named (type:id), NOT by executing agent — so no explicitly-named
// target is silently dropped even when its run coalesces with another's.
var targets []commentMentionTarget
targetSeen := make(map[string]struct{}, len(mentions))
addTarget := func(t commentMentionTarget) {
key := t.TargetType + ":" + t.TargetID
if _, ok := targetSeen[key]; ok {
return
}
targetSeen[key] = struct{}{}
targets = append(targets, t)
}
// blockTarget records a mention that will not fire. The invoke gate is
// evaluated BEFORE any archived/runtime state is read, so a caller who
// cannot invoke a private target learns only the generic
// invocation_not_allowed and can never enumerate the target's existence or
// state from the reason code.
blockTarget := func(targetType, targetID string, reason DispatchReasonCode) {
addTarget(commentMentionTarget{TargetType: targetType, TargetID: targetID, Status: DispatchBlocked, ReasonCode: reason})
}
for _, m := range mentions {
if m.Type == "squad" {
// @squad mention → trigger the squad's leader agent.
squadUUID := parseUUID(m.ID)
squad, err := h.Queries.GetSquadInWorkspace(ctx, db.GetSquadInWorkspaceParams{
ID: squadUUID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil {
blockTarget("squad", m.ID, ReasonTargetUnavailable)
continue
}
leaderID := squad.LeaderID
// A2A self-suppression: the author IS this squad's leader and its
// most recent task on this issue was a leader/generic role (NOT a
// fresh same-squad worker→leader handoff), so we do not re-fire the
// leader from its own @mention. The outcome must reflect reality, not
// assume success (MUL-4525): `deferred` only when a real non-terminal
// task is still active (its reconcile covers this comment); a query
// failure is a non-success internal_error, never a fabricated
// deferred; otherwise nothing runs → self_trigger_suppressed.
if authorType == "agent" && authorID == uuidToString(leaderID) &&
h.shouldSuppressSquadLeaderSelfTrigger(ctx, issue.ID, leaderID, squad.ID) {
active, activeErr := h.hasActiveTaskForIssueAndAgent(ctx, issue.ID, leaderID)
status, reason := decideSuppressedLeaderOutcome(active, activeErr)
addTarget(commentMentionTarget{TargetType: "squad", TargetID: m.ID, Status: status, ReasonCode: reason})
continue
}
agent, err := h.Queries.GetAgentInWorkspace(ctx, db.GetAgentInWorkspaceParams{
ID: leaderID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil {
blockTarget("squad", m.ID, ReasonTargetUnavailable)
continue
}
// Private-leader gate first (enumeration-safe: a caller who cannot
// invoke the leader never learns its archived/runtime state).
if !h.canInvokeAgent(ctx, agent, authorType, authorID, opts.effectiveInvoker(), wsID) {
blockTarget("squad", m.ID, ReasonInvocationNotAllowed)
continue
}
if agent.ArchivedAt.Valid {
blockTarget("squad", m.ID, ReasonTargetUnavailable)
continue
}
if !agent.RuntimeID.Valid {
blockTarget("squad", m.ID, ReasonRuntimeOffline)
continue
}
hasPending, err := h.hasPendingTaskForIssueAndAgent(ctx, issue.ID, leaderID, opts)
if err != nil {
blockTarget("squad", m.ID, ReasonInternalError)
continue
}
add(commentAgentTrigger{Agent: agent, Source: commentTriggerSourceMentionSquadLeader, Squad: &squad, AlreadyPending: hasPending})
addTarget(commentMentionTarget{TargetType: "squad", TargetID: m.ID, ExecAgentID: uuidToString(leaderID)})
continue
}
if m.Type != "agent" {
continue
}
agentUUID := parseUUID(m.ID)
// Load the agent scoped to the current issue's workspace. Using the
// bare GetAgent here would let a mention resolve to an agent in a
// different workspace, and the visibility check below would then be
// applied against the wrong workspace's roles (a workspace owner in
// THIS workspace would pass the gate for a private agent that lives
// in someone else's workspace).
agent, err := h.Queries.GetAgentInWorkspace(ctx, db.GetAgentInWorkspaceParams{
ID: agentUUID,
WorkspaceID: issue.WorkspaceID,
})
if err != nil {
// Do not reveal whether the id exists (it may be a private agent in
// another workspace): the generic invocation_not_allowed is returned.
blockTarget("agent", m.ID, ReasonInvocationNotAllowed)
continue
}
// Private-agent gate first, before any archived/runtime state is read.
if !h.canInvokeAgent(ctx, agent, authorType, authorID, opts.effectiveInvoker(), wsID) {
blockTarget("agent", m.ID, ReasonInvocationNotAllowed)
continue
}
if agent.ArchivedAt.Valid {
blockTarget("agent", m.ID, ReasonTargetUnavailable)
continue
}
if !agent.RuntimeID.Valid {
blockTarget("agent", m.ID, ReasonRuntimeOffline)
continue
}
hasPending, err := h.hasPendingTaskForIssueAndAgent(ctx, issue.ID, agentUUID, opts)
if err != nil {
blockTarget("agent", m.ID, ReasonInternalError)
continue
}
add(commentAgentTrigger{Agent: agent, Source: commentTriggerSourceMentionAgent, AlreadyPending: hasPending})
addTarget(commentMentionTarget{TargetType: "agent", TargetID: m.ID, ExecAgentID: uuidToString(agentUUID)})
}
return triggers, targets
}
func (h *Handler) UpdateComment(w http.ResponseWriter, r *http.Request) {
commentId := chi.URLParam(r, "commentId")
userID, ok := requireUserID(w, r)
if !ok {
return
}
commentUUID, ok := parseUUIDOrBadRequest(w, commentId, "comment id")
if !ok {
return
}
// Load comment scoped to current workspace.
workspaceID := h.resolveWorkspaceID(r)
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
if !ok {
return
}
existing, err := h.Queries.GetCommentInWorkspace(r.Context(), db.GetCommentInWorkspaceParams{
ID: commentUUID,
WorkspaceID: wsUUID,
})
if err != nil {
writeError(w, http.StatusNotFound, "comment not found")
return
}
member, ok := h.workspaceMember(w, r, workspaceID)
if !ok {
return
}
actorType, actorID := h.resolveActor(r, userID, workspaceID)
isAuthor := existing.AuthorType == actorType && uuidToString(existing.AuthorID) == actorID
isAdmin := roleAllowed(member.Role, "owner", "admin")
if !isAuthor && !isAdmin {
writeError(w, http.StatusForbidden, "only comment author or admin can edit")
return
}
var req struct {
Content string `json:"content"`
AttachmentIDs *[]string `json:"attachment_ids"`
SuppressAgentIDs []string `json:"suppress_agent_ids"`
}
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeError(w, http.StatusBadRequest, "invalid request body")
return
}
// See CreateComment: strip NUL / invalid-UTF-8 bytes PostgreSQL's TEXT column
// rejects before the empty check, so an edit that introduces such a byte
// can't 500 (GH #5388).
req.Content = sanitizeNullBytes(req.Content)
if req.Content == "" {
writeError(w, http.StatusBadRequest, "content is required")
return
}
var attachmentIDs []pgtype.UUID
replaceAttachments := req.AttachmentIDs != nil
if replaceAttachments {
var ok bool
attachmentIDs, ok = parseUUIDSliceOrBadRequest(w, *req.AttachmentIDs, "attachment_ids")
if !ok {
return
}
}
suppressAgentIDs, ok := parseUUIDSliceOrBadRequest(w, req.SuppressAgentIDs, "suppress_agent_ids")
if !ok {
return
}
// NOTE: See CreateComment — Markdown is sanitized at render/edit time, not here.
oldContent := existing.Content
// Preserve the existing authority lineage by default — this path is taken only
// for an UNCHANGED edit (no re-trigger). When the content changes below, the
// lineage is re-derived from the EDIT action itself (MUL-4857), never carried
// over from the comment's original authoring run.
sourceTaskID := existing.SourceTaskID
var triggerIssue *db.Issue
var cancelled []db.AgentTaskQueue
if oldContent != req.Content {
issue, err := h.Queries.GetIssue(r.Context(), existing.IssueID)
if err != nil {
slog.Warn("load issue for edit post-processing failed", "issue_id", uuidToString(existing.IssueID), "error", err)
writeError(w, http.StatusInternalServerError, "failed to load issue")
return
}
triggerIssue = &issue
// A content edit is a NEW action, so its delegation lineage must key on THIS
// edit. Only the AGENT author re-editing its OWN comment carries issue-scoped
// lineage forward (commentSourceTaskIDForIssue re-stamps the current editing
// task, and clears it on a cross-issue edit) — so preview, save, and the
// deferred completion-reconcile all resolve the authority from this one
// action. Any OTHER editor — a workspace owner/admin editing an AGENT's
// comment, or a member editing their own — CLEARS the lineage so the deferred
// reconcile fails closed instead of resurrecting the original autopilot run's
// creator authority. An admin holds manage rights over the comment, not
// invoke rights over the author's private agents (Elon must-fix, round 3).
if actorType == "agent" && isAuthor {
sourceTaskID = h.commentSourceTaskIDForIssue(r, issue)
} else {
sourceTaskID = pgtype.UUID{}
}
cancelled, err = h.TaskService.CancelTasksByTriggerComment(r.Context(), existing.ID)
if err != nil {
slog.Warn("cancel tasks for edited comment failed", "comment_id", uuidToString(existing.ID), "error", err)
writeError(w, http.StatusInternalServerError, "failed to prepare comment edit")
return
}
}
comment, err := h.Queries.UpdateComment(r.Context(), db.UpdateCommentParams{
ID: commentUUID,
Content: req.Content,
SourceTaskID: sourceTaskID,
})
if err != nil {
slog.Warn("update comment failed", append(logger.RequestAttrs(r), "error", err, "comment_id", commentId)...)
if triggerIssue != nil {
// Cancellation committed but the edit did not. Restore the complete
// original batch, including the still-valid unchanged comment.
h.retriggerCancelledTaskSurvivors(r.Context(), *triggerIssue, cancelled, pgtype.UUID{})
}
writeError(w, http.StatusInternalServerError, "failed to update comment")
return
}
retriggerEditedComment := func() []CommentTriggerOutcome {
if oldContent == comment.Content {
return nil
}
issue := *triggerIssue
var parentComment *db.Comment
if existing.ParentID.Valid {
parent, err := h.Queries.GetComment(r.Context(), existing.ParentID)
if err == nil {
parentComment = &parent
}
}
h.retriggerCancelledTaskSurvivors(r.Context(), issue, cancelled, existing.ID)
// MUL-4857: source_task_id was just re-derived from THIS edit above (the agent
// author re-stamps its current task; every other editor clears it), so
// resolving from the comment keys the delegation authority on the current
// editing action — identical to what the edit preview computed from the same
// request, and to what the completion-reconcile will restore. A cross-issue
// or non-author edit left it NULL, so this fails closed rather than borrowing
// the old authoring run's authority.
delegationAuthority := h.autopilotDelegationAuthorityFromComment(r.Context(), issue, comment)
return h.triggerTasksForComment(r.Context(), issue, comment, parentComment, actorType, actorID, h.invokeOriginatorFromRequest(r, actorType, actorID), delegationAuthority, suppressAgentIDs)
}
// Replace the comment attachment set when a modern client sends
// attachment_ids. Older clients omit the field; in that case preserve the
// existing attachment links rather than unlinking everything.
if replaceAttachments {
if err := h.Queries.ReplaceCommentAttachments(r.Context(), db.ReplaceCommentAttachmentsParams{
CommentID: comment.ID,
IssueID: existing.IssueID,
AttachmentIds: attachmentIDs,
}); err != nil {
slog.Error("failed to replace comment attachments", "error", err)
// UpdateComment already committed the new body. Even though attachment
// replacement failed, repair task routing for that persisted edit so a
// dispatched run cannot permanently keep the old comment version.
retriggerEditedComment()
writeError(w, http.StatusInternalServerError, "failed to update attachments")
return
}
}
// Fetch reactions and attachments for the updated comment.
grouped := h.groupReactions(r, []pgtype.UUID{comment.ID})
groupedAtt := h.groupAttachments(r, []pgtype.UUID{comment.ID})
cid := uuidToString(comment.ID)
resp := commentToResponse(comment, grouped[cid], groupedAtt[cid])
slog.Info("comment updated", append(logger.RequestAttrs(r), "comment_id", commentId)...)
h.publish(protocol.EventCommentUpdated, workspaceID, actorType, actorID, map[string]any{"comment": resp})
// The broadcast above intentionally omits trigger_outcomes — it is the
// editor's private feedback, not shared timeline state (MUL-4525 §2).
resp.TriggerOutcomes = retriggerEditedComment()
writeJSON(w, http.StatusOK, resp)
}
func (h *Handler) DeleteComment(w http.ResponseWriter, r *http.Request) {
commentId := chi.URLParam(r, "commentId")
userID, ok := requireUserID(w, r)
if !ok {
return
}
commentUUID, ok := parseUUIDOrBadRequest(w, commentId, "comment id")
if !ok {
return
}
// Load comment scoped to current workspace.
workspaceID := h.resolveWorkspaceID(r)
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
if !ok {
return
}
comment, err := h.Queries.GetCommentInWorkspace(r.Context(), db.GetCommentInWorkspaceParams{
ID: commentUUID,
WorkspaceID: wsUUID,
})
if err != nil {
writeError(w, http.StatusNotFound, "comment not found")
return
}
member, ok := h.workspaceMember(w, r, workspaceID)
if !ok {
return
}
actorType, actorID := h.resolveActor(r, userID, workspaceID)
isAuthor := comment.AuthorType == actorType && uuidToString(comment.AuthorID) == actorID
isAdmin := roleAllowed(member.Role, "owner", "admin")
if !isAuthor && !isAdmin {
writeError(w, http.StatusForbidden, "only comment author or admin can delete")
return
}
issue, err := h.Queries.GetIssue(r.Context(), comment.IssueID)
if err != nil {
slog.Warn("load issue for delete post-processing failed", "issue_id", uuidToString(comment.IssueID), "error", err)
writeError(w, http.StatusInternalServerError, "failed to load issue")
return
}
// Collect attachment URLs before CASCADE delete removes them.
attachmentURLs, _ := h.Queries.ListAttachmentURLsByCommentID(r.Context(), comment.ID)
// Cancel any active task whose planned batch contains this comment so the
// agent does not run with the now-deleted content already embedded. Must
// run before DeleteComment because the FK ON DELETE SET NULL would
// otherwise nullify trigger_comment_id and orphan those tasks in queued.
cancelled, cancelErr := h.TaskService.CancelTasksByTriggerComment(r.Context(), comment.ID)
if cancelErr != nil {
slog.Warn("cancel tasks for deleted trigger comment failed", append(logger.RequestAttrs(r), "error", cancelErr, "comment_id", commentId)...)
}
if err := h.Queries.DeleteComment(r.Context(), db.DeleteCommentParams{
ID: comment.ID,
WorkspaceID: comment.WorkspaceID,
}); err != nil {
slog.Warn("delete comment failed", append(logger.RequestAttrs(r), "error", err, "comment_id", commentId)...)
// Cancellation already committed but deletion did not. The comment is
// still valid, so rebuild the complete cancelled batch (including this
// trigger) before returning the storage error.
h.retriggerCancelledTaskSurvivors(r.Context(), issue, cancelled, pgtype.UUID{})
writeError(w, http.StatusInternalServerError, "failed to delete comment")
return
}
h.deleteS3Objects(r.Context(), attachmentURLs)
slog.Info("comment deleted", append(logger.RequestAttrs(r), "comment_id", commentId, "issue_id", uuidToString(comment.IssueID))...)
h.publish(protocol.EventCommentDeleted, workspaceID, actorType, actorID, map[string]any{
"comment_id": uuidToString(comment.ID),
"issue_id": uuidToString(comment.IssueID),
})
h.retriggerCancelledTaskSurvivors(r.Context(), issue, cancelled, comment.ID)
w.WriteHeader(http.StatusNoContent)
}
// retriggerCancelledTaskSurvivors repairs the surviving inputs from a
// batch containing a comment that was edited or deleted. Cancellation releases
// the one-pending-task constraint; every other comment is replayed through the
// normal authorization/routing path, scoped to the agent whose task carried
// it. Chronological replay makes those survivors coalesce back into one batch
// and lets the latest real comment restamp originator + connected-app context.
func (h *Handler) retriggerCancelledTaskSurvivors(ctx context.Context, issue db.Issue, cancelled []db.AgentTaskQueue, excludedCommentID pgtype.UUID) {
if len(cancelled) == 0 {
return
}
targetsByComment := make(map[string]map[string]pgtype.UUID)
for _, task := range cancelled {
if !task.AgentID.Valid {
continue
}
plannedCommentIDs := append([]pgtype.UUID{}, task.CoalescedCommentIds...)
if task.TriggerCommentID.Valid {
plannedCommentIDs = append(plannedCommentIDs, task.TriggerCommentID)
}
for _, commentID := range plannedCommentIDs {
if !commentID.Valid || (excludedCommentID.Valid && commentID == excludedCommentID) {
continue
}
commentKey := uuidToString(commentID)
if targetsByComment[commentKey] == nil {
targetsByComment[commentKey] = make(map[string]pgtype.UUID)
}
targetsByComment[commentKey][uuidToString(task.AgentID)] = task.AgentID
}
}
comments := make([]db.Comment, 0, len(targetsByComment))
for commentID := range targetsByComment {
comment, err := h.Queries.GetComment(ctx, parseUUID(commentID))
if err != nil {
slog.Warn("retrigger cancelled comment batch: load survivor failed",
"issue_id", uuidToString(issue.ID), "comment_id", commentID, "error", err)
continue
}
if comment.IssueID != issue.ID {
continue
}
comments = append(comments, comment)
}
sort.Slice(comments, func(i, j int) bool {
if !comments[i].CreatedAt.Time.Equal(comments[j].CreatedAt.Time) {
return comments[i].CreatedAt.Time.Before(comments[j].CreatedAt.Time)
}
return uuidToString(comments[i].ID) < uuidToString(comments[j].ID)
})
for i := range comments {
comment := comments[i]
if isNoteComment(comment.Content) {
continue
}
var parentComment *db.Comment
if comment.ParentID.Valid {
if parent, err := h.Queries.GetComment(ctx, comment.ParentID); err == nil {
parentComment = &parent
}
}
actorType := comment.AuthorType
actorID := uuidToString(comment.AuthorID)
originatorUserID := actorID
var delegationAuthority string
if actorType != "member" {
originatorUserID = uuidToString(h.TaskService.ResolveOriginatorFromTriggerComment(ctx, issue.WorkspaceID, comment.ID))
// MUL-4857: reconcile works from persisted comments, so the autopilot
// delegation authority is resolved from the stored comment.source_task_id.
delegationAuthority = h.autopilotDelegationAuthorityFromComment(ctx, issue, comment)
}
triggers, _ := h.computeCommentAgentTriggers(ctx, issue, comment.Content, parentComment, actorType, actorID, commentTriggerComputeOptions{
ExcludeTriggerCommentID: comment.ID,
OriginatorUserID: originatorUserID,
AutopilotDelegationAuthorityUserID: delegationAuthority,
})
targets := targetsByComment[uuidToString(comment.ID)]
scoped := make([]commentAgentTrigger, 0, len(targets))
for _, trigger := range triggers {
if _, ok := targets[uuidToString(trigger.Agent.ID)]; ok {
scoped = append(scoped, trigger)
}
}
if len(scoped) > 0 {
h.enqueueCommentAgentTriggers(ctx, issue, comment.ID, scoped)
}
}
}
// loadCommentForActor resolves a {commentId} URL param to a comment in the
// caller's workspace. Returns the comment, the workspace UUID, the actor
// identity, and ok. Resolve / unresolve handlers share this scaffolding so the
// workspace membership + tenant guard stay identical. Any comment (root or
// reply) may be resolved: resolving a root collapses the whole thread; resolving
// a reply marks it as the thread's resolution. Which one is the thread's
// resolution is a pure frontend derivation, so the backend stays a plain setter.
func (h *Handler) loadCommentForActor(w http.ResponseWriter, r *http.Request) (db.Comment, string, string, string, bool) {
commentId := chi.URLParam(r, "commentId")
userID, ok := requireUserID(w, r)
if !ok {
return db.Comment{}, "", "", "", false
}
commentUUID, ok := parseUUIDOrBadRequest(w, commentId, "comment id")
if !ok {
return db.Comment{}, "", "", "", false
}
workspaceID := h.resolveWorkspaceID(r)
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
if !ok {
return db.Comment{}, "", "", "", false
}
if _, ok := h.workspaceMember(w, r, workspaceID); !ok {
return db.Comment{}, "", "", "", false
}
comment, err := h.Queries.GetCommentInWorkspace(r.Context(), db.GetCommentInWorkspaceParams{
ID: commentUUID,
WorkspaceID: wsUUID,
})
if err != nil {
writeError(w, http.StatusNotFound, "comment not found")
return db.Comment{}, "", "", "", false
}
actorType, actorID := h.resolveActor(r, userID, workspaceID)
return comment, workspaceID, actorType, actorID, true
}
func (h *Handler) ResolveComment(w http.ResponseWriter, r *http.Request) {
comment, workspaceID, actorType, actorID, ok := h.loadCommentForActor(w, r)
if !ok {
return
}
wasResolved := comment.ResolvedAt.Valid
actorUUID, err := util.ParseUUID(actorID)
if err != nil {
writeError(w, http.StatusBadRequest, "invalid actor id")
return
}
// Single-resolution invariant: a thread has at most one resolved comment, so
// resolving this one must clear any other resolution in the same thread. Both
// writes run in one tx — clearing the old resolution and setting the new one
// is atomic, so a crash can never leave two resolutions (or none) visible.
tx, err := h.TxStarter.Begin(r.Context())
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to resolve comment")
return
}
defer tx.Rollback(r.Context())
qtx := h.Queries.WithTx(tx)
cleared, err := qtx.ClearOtherThreadResolutions(r.Context(), db.ClearOtherThreadResolutionsParams{
TargetID: comment.ID,
IssueID: comment.IssueID,
WorkspaceID: comment.WorkspaceID,
})
if err != nil {
slog.Warn("clear other thread resolutions failed", append(logger.RequestAttrs(r), "error", err, "comment_id", uuidToString(comment.ID))...)
writeError(w, http.StatusInternalServerError, "failed to resolve comment")
return
}
updated, err := qtx.ResolveComment(r.Context(), db.ResolveCommentParams{
ID: comment.ID,
ResolvedByType: pgtype.Text{String: actorType, Valid: true},
ResolvedByID: actorUUID,
})
if err != nil {
slog.Warn("resolve comment failed", append(logger.RequestAttrs(r), "error", err, "comment_id", uuidToString(comment.ID))...)
writeError(w, http.StatusInternalServerError, "failed to resolve comment")
return
}
if err := tx.Commit(r.Context()); err != nil {
slog.Warn("resolve comment commit failed", append(logger.RequestAttrs(r), "error", err, "comment_id", uuidToString(comment.ID))...)
writeError(w, http.StatusInternalServerError, "failed to resolve comment")
return
}
// Emit a comment:unresolved per cleared sibling so granular realtime
// consumers (which patch a single comment in place) drop the stale
// resolution instead of showing two. Published after commit so no event ever
// describes an uncommitted state.
for _, c := range cleared {
clearedID := uuidToString(c.ID)
clearedReactions := h.groupReactions(r, []pgtype.UUID{c.ID})
clearedAtt := h.groupAttachments(r, []pgtype.UUID{c.ID})
clearedResp := commentToResponse(c, clearedReactions[clearedID], clearedAtt[clearedID])
slog.Info("comment unresolved (replaced)", append(logger.RequestAttrs(r), "comment_id", clearedID)...)
h.publish(protocol.EventCommentUnresolved, workspaceID, actorType, actorID, map[string]any{"comment": clearedResp})
}
grouped := h.groupReactions(r, []pgtype.UUID{updated.ID})
groupedAtt := h.groupAttachments(r, []pgtype.UUID{updated.ID})
cid := uuidToString(updated.ID)
resp := commentToResponse(updated, grouped[cid], groupedAtt[cid])
// Suppress the target event on a re-resolve no-op so consumers do not
// re-process an unchanged thread (notifications, log spam). Cleared siblings
// still get their own events above — those rows did change.
if !wasResolved {
slog.Info("comment resolved", append(logger.RequestAttrs(r), "comment_id", cid)...)
h.publish(protocol.EventCommentResolved, workspaceID, actorType, actorID, map[string]any{"comment": resp})
}
writeJSON(w, http.StatusOK, resp)
}
func (h *Handler) UnresolveComment(w http.ResponseWriter, r *http.Request) {
comment, workspaceID, actorType, actorID, ok := h.loadCommentForActor(w, r)
if !ok {
return
}
wasResolved := comment.ResolvedAt.Valid
updated, err := h.Queries.UnresolveComment(r.Context(), comment.ID)
if err != nil {
slog.Warn("unresolve comment failed", append(logger.RequestAttrs(r), "error", err, "comment_id", uuidToString(comment.ID))...)
writeError(w, http.StatusInternalServerError, "failed to unresolve comment")
return
}
grouped := h.groupReactions(r, []pgtype.UUID{updated.ID})
groupedAtt := h.groupAttachments(r, []pgtype.UUID{updated.ID})
cid := uuidToString(updated.ID)
resp := commentToResponse(updated, grouped[cid], groupedAtt[cid])
if wasResolved {
slog.Info("comment unresolved", append(logger.RequestAttrs(r), "comment_id", cid)...)
h.publish(protocol.EventCommentUnresolved, workspaceID, actorType, actorID, map[string]any{"comment": resp})
}
writeJSON(w, http.StatusOK, resp)
}