mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-24 02:39:42 +02:00
* feat(slack): Socket Mode channel.Channel adapter (MUL-3516) First slice of the Slack adapter: implements channel.Channel (Type/Connect/Disconnect/Send/Capabilities) over Slack Socket Mode, normalizes inbound events to channel.InboundMessage (DM, channel @mention, thread reply; bot-loop + edit/delete guards), decodes the per-installation config/secret blob, and registers the Factory under TypeSlack. No engine, core, or channel_* schema change. Unit-tested (translation, capabilities, config decode, chunking, Send via httptest). Resolvers + engine wiring + Block Kit binding replier follow. Co-authored-by: multica-agent <github@multica.ai> * fix(slack): address adapter review (MUL-3516) - Propagate InboundHandler errors through dispatchEventsAPI/handleSocketEvent to Connect so an infra failure tears down the connection for Supervisor reconnect/backoff instead of being silently swallowed (ACK still happens first). - Capabilities: declare only CapText | CapThreadReply; drop CapRichCard/CapAttachment/CapMessageEdit until those Send paths are wired. - slackChatType: map mpim (multi-party DM) to group, not p2p, so the 'must address bot' filter applies; only 1:1 im is p2p. - Document the group-addressing decision: explicit @bot mention required in groups; mention-free thread continuation deferred to the session-aware layer. - Tests: handler-error propagation, slackChatType table, mpim-requires-mention, capabilities negative assertions. Co-authored-by: multica-agent <github@multica.ai> * refactor(channel): shared channel-agnostic ChatSession service (MUL-3516) Extract the session/append//issue machinery — currently locked inside the Feishu-pinned lark.chatSessionService — into a shared engine.ChatSession parameterized by channel_type + session titles, so every IM adapter reuses it instead of re-implementing it. Logic is verbatim (find-or-create session+binding with unique-violation race re-read; append+touch+reply-target+in-tx dedup Mark; /issue parse with bare-command previous-message fallback) but channel-neutral: command-parse source is supplied by the adapter (enrichment is platform-specific). Backed by a narrow SessionQueries interface so it is unit-tested with an in-memory fake (no DB). /issue parser moved to engine.ParseIssueCommand. Next: migrate Feishu onto it and wire Slack's ResolverSet, removing the lark duplicate. Co-authored-by: multica-agent <github@multica.ai> * fix(channel): decouple session binding key from outbound target (MUL-3516) Addresses Elon's round-2 review. engine.ChatSession.EnsureSession previously keyed the binding on a raw chat id (EnsureSessionInput.ChatID), so a resolver wiring Slack straight through would collapse every @bot thread in one channel into a single chat_session and overwrite last_thread_id. Make the API un-misusable: - EnsureSessionInput.ChatID -> BindingKey: the explicit session-isolation key (Feishu: chat id; Slack DM: channel id; Slack channel: channel id + thread root), documented so a raw threaded-platform chat id is never passed straight through. - Add EnsureSessionInput.BindingConfig (opaque) persisted on the binding's config column, so the real outbound channel/thread is preserved when BindingKey is composite — outbound routing stays separate from the isolation key. - channel.sql CreateChannelChatSessionBinding now writes config (additive, uses the existing NOT NULL column; lark caller passes '{}', no schema change, no Feishu regression). - Tests: TestEnsureSession_ThreadRootIsolation (two thread roots in one channel -> two sessions; same root reuses) and TestEnsureSession_StoresBindingConfig. No production wiring change yet (per review, the not-yet-wired shared service is an accepted preparatory state); this makes the API correct before Feishu/Slack are migrated onto it. Co-authored-by: multica-agent <github@multica.ai> * feat(slack): Slack ResolverSet with thread-root session isolation (MUL-3516) Wires Slack into the channel-agnostic engine.Router via a ResolverSet built on the generic channel_* queries (installation route by team_id, identity + workspace-membership recheck, two-phase dedup, audit) plus the shared engine.ChatSession. No new query, no schema change. slackSessionRouting is the per-message isolation rule (Elon round-2 / Niko round-3): a DM is one session per channel; a channel/group message is isolated by thread root (key = channel:threadRoot, root = inbound thread_ts or the message ts for a top-level @mention), so two @bot threads in one channel are two sessions. The real channel id rides in BindingConfig for outbound; the reply thread is returned separately. Tests cover DM/channel/thread routing, config, and that distinct thread roots isolate while a same-thread follow-up reuses its key. Not yet wired into router.go (still a preparatory commit, per review); Feishu migration onto the shared service, router/config wiring, and the Slack outbound path follow. Co-authored-by: multica-agent <github@multica.ai> * feat(slack): Markdown->mrkdwn outbound formatting (MUL-3516) Slack renders mrkdwn, not Markdown, so an unconverted agent reply shows literal ** , ## and [text](url). Add formatMrkdwn — a faithful Go port of Hermes Agent's slack format_message (MIT) — and apply it in slackChannel.Send before chunking/posting. Protects fenced+inline code, converted links, and existing Slack entities behind placeholders; converts headers/bold/italic/strike/links; escapes control chars. Unit tests cover each construct plus fenced-code protection and a link nested in bold. Co-authored-by: multica-agent <github@multica.ai> * docs(slack): preserve Hermes MIT notice for ported mrkdwn converter (MUL-3516) Addresses Niko's review. formatMrkdwn is a substantial port of Hermes Agent's slack format_message; MIT requires preserving the copyright + permission notice. Add the full Hermes MIT copyright/permission notice + source URL as a header on mrkdwn.go (no repo-level third-party notice file exists, and the header cannot get separated from the ported code). Also add the suggested Send-layer regression test (TestSend_AppliesMrkdwn) that pins the wiring: slackChannel.Send converts Markdown to mrkdwn before posting. Co-authored-by: multica-agent <github@multica.ai> * refactor(lark): migrate Feishu onto shared engine.ChatSession, drop duplicate (MUL-3516) Completes 'every IM reuses one shared session service' and removes the dual-path the reviewers flagged as temporary. Feishu's ResolverSet now drives the channel-agnostic engine.ChatSession (channel_type=feishu, Lark session titles preserved) instead of the Feishu-specific lark.chatSessionService, which is deleted. Behavior is unchanged: engine.ChatSession is the verbatim port of the old logic and is unit-tested; the new Feishu binder param-mapping (BindingKey=chat id, CommandText=un-enriched CommandBody from Raw) is covered by feishu_resolvers_test.go. - Delete chat_service.go (chatSessionService + helpers) and issue_command.go/_test.go (parser now engine.ParseIssueCommand). Relocate the shared TxStarter interface to tx.go (still used by binding-token + registration services). - chat.go keeps only the AuditLogger seam; remove the now-dead ChatSessionService / EnsureChatSessionParams / AppendUserMessageParams / AppendResult / IssueCommand types. - router.go constructs engine.NewChatSession for Feishu; inbound_enricher_test + doc.go updated. make-test parity: go build ./..., go vet, gofmt, and go test ./internal/integrations/{lark,channel/...,slack} all pass (full Feishu suite green). Co-authored-by: multica-agent <github@multica.ai> * feat(slack): wire Slack adapter + ResolverSet + outbound into router (MUL-3516) Activates the full Slack pipeline, gated by MULTICA_SLACK_SECRET_KEY (the bot/app-token decryption key). When unset the block is skipped, so existing deployments are unaffected and Feishu is untouched. - router.go registers slack.RegisterSlack (Socket Mode connect/send Factory) + channelRouter.Register(TypeSlack, NewSlackResolverSet) (inbound pipeline) + slack.NewOutbound(...).Register(bus) (outbound). - New slack/outbound.go: an EventChatDone subscriber mirroring the Feishu Patcher. It finds the Slack chat binding for the finished session, recovers the real channel from the binding config (the channel_chat_id may be a composite thread-isolation key) + the reply thread from last_thread_id, and posts via slackChannel.Send (reusing formatMrkdwn / chunking / threading). Sessions with no Slack binding are ignored, so it coexists with the Feishu Patcher on the shared bus. - Tests: posts to the bound channel/thread with the real channel id; ignores non-Slack sessions, empty completions, revoked installations, and non-chat events. Slack now shares engine.ChatSession, channel_* tables, IssueService and TaskService with Feishu. Remaining: config-driven installation provisioning (an operator currently creates the channel_type='slack' row; the config block shape — which workspace/agent — is a product decision) and a live end-to-end smoke. go build ./..., go vet, gofmt, and go test ./internal/integrations/{slack,channel/...,lark} all pass. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: J <j@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
126 lines
4.6 KiB
Go
126 lines
4.6 KiB
Go
// Package slack is the Slack implementation of channel.Channel — the second
|
|
// adapter driven by the channel-agnostic engine (MUL-3516), proving the
|
|
// MUL-3506 thesis that adding an IM is "implement Channel + register" with no
|
|
// engine, core, or channel_* schema change. It mirrors the Feishu reference
|
|
// adapter (server/internal/integrations/lark/feishu_channel.go): Connect runs
|
|
// the platform receive loop (here Slack Socket Mode, an outbound WebSocket
|
|
// long-conn that needs no public inbound URL) and hands every decoded event to
|
|
// the engine's shared inbound handler as a normalized channel.InboundMessage;
|
|
// Send posts a text reply via chat.postMessage. The design references the
|
|
// proven Slack adapter in Nous Research's Hermes Agent.
|
|
package slack
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
)
|
|
|
|
// installConfig is the JSON shape stored in channel_installation.config for a
|
|
// Slack installation. The cross-platform columns stay flat; everything
|
|
// Slack-specific lives in this opaque blob (the documented config boundary).
|
|
//
|
|
// app_id holds the Slack team_id — the per-installation routing key — so the
|
|
// generic GetChannelInstallationByAppID query (which reads config->>'app_id')
|
|
// and the (channel_type, config->>'app_id') unique index route Slack inbound
|
|
// events with NO new query and NO schema change. team_id is also kept as its
|
|
// own field for readability; the two carry the same value.
|
|
//
|
|
// Tokens are stored as base64-encoded secretbox ciphertext (never plaintext),
|
|
// mirroring Feishu's app_secret_encrypted. The bot token (xoxb-…) authorizes
|
|
// Web API calls (chat.postMessage); the app-level token (xapp-…) authorizes the
|
|
// Socket Mode connection.
|
|
type installConfig struct {
|
|
AppID string `json:"app_id"`
|
|
TeamID string `json:"team_id,omitempty"`
|
|
BotUserID string `json:"bot_user_id,omitempty"`
|
|
BotTokenEncrypted string `json:"bot_token_encrypted"`
|
|
AppTokenEncrypted string `json:"app_token_encrypted"`
|
|
}
|
|
|
|
// credentials is the decoded, decrypted form the adapter runs on. The
|
|
// installation IDENTITY (workspace / agent / installer) is deliberately absent:
|
|
// it is resolved per message by the Router's InstallationResolver, exactly as
|
|
// the Feishu adapter does.
|
|
type credentials struct {
|
|
TeamID string
|
|
BotUserID string
|
|
BotToken string
|
|
AppToken string
|
|
}
|
|
|
|
// Decrypter turns stored ciphertext into plaintext. The wiring injects a
|
|
// secretbox-backed implementation; tests inject an identity decrypter (or nil,
|
|
// which treats the stored bytes as plaintext).
|
|
type Decrypter func(ciphertext []byte) (plaintext []byte, err error)
|
|
|
|
// decodeCredentials parses the per-installation config blob and decrypts the
|
|
// stored tokens. It is the single place the Slack config JSON is interpreted.
|
|
func decodeCredentials(raw json.RawMessage, decrypt Decrypter) (credentials, error) {
|
|
if len(raw) == 0 {
|
|
return credentials{}, errors.New("slack: empty installation config")
|
|
}
|
|
var cfg installConfig
|
|
if err := json.Unmarshal(raw, &cfg); err != nil {
|
|
return credentials{}, fmt.Errorf("decode slack installation config: %w", err)
|
|
}
|
|
botToken, err := decryptToken(cfg.BotTokenEncrypted, decrypt)
|
|
if err != nil {
|
|
return credentials{}, fmt.Errorf("decrypt bot token: %w", err)
|
|
}
|
|
appToken, err := decryptToken(cfg.AppTokenEncrypted, decrypt)
|
|
if err != nil {
|
|
return credentials{}, fmt.Errorf("decrypt app token: %w", err)
|
|
}
|
|
teamID := cfg.TeamID
|
|
if teamID == "" {
|
|
teamID = cfg.AppID
|
|
}
|
|
return credentials{
|
|
TeamID: teamID,
|
|
BotUserID: cfg.BotUserID,
|
|
BotToken: botToken,
|
|
AppToken: appToken,
|
|
}, nil
|
|
}
|
|
|
|
// decryptToken base64-decodes the stored ciphertext (tolerating the MIME
|
|
// newline wrapping PostgreSQL's encode(...,'base64') emits) and runs it through
|
|
// the injected Decrypter. An empty stored value decodes to an empty token; a
|
|
// nil Decrypter treats the decoded bytes as plaintext (test convenience).
|
|
func decryptToken(enc string, decrypt Decrypter) (string, error) {
|
|
if enc == "" {
|
|
return "", nil
|
|
}
|
|
ciphertext, err := base64.StdEncoding.DecodeString(stripWhitespace(enc))
|
|
if err != nil {
|
|
return "", fmt.Errorf("base64 decode: %w", err)
|
|
}
|
|
if decrypt == nil {
|
|
return string(ciphertext), nil
|
|
}
|
|
plaintext, err := decrypt(ciphertext)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return string(plaintext), nil
|
|
}
|
|
|
|
// stripWhitespace removes ASCII whitespace so a MIME-wrapped base64 string
|
|
// (newlines every 64 chars) and an unwrapped one decode identically.
|
|
func stripWhitespace(s string) string {
|
|
var b strings.Builder
|
|
b.Grow(len(s))
|
|
for _, r := range s {
|
|
switch r {
|
|
case ' ', '\t', '\n', '\r':
|
|
continue
|
|
default:
|
|
b.WriteRune(r)
|
|
}
|
|
}
|
|
return b.String()
|
|
}
|