mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-25 12:05:06 +02:00
* fix(my-issues): use server-side filtering instead of client-side My Issues was fetching ALL workspace issues and filtering client-side, causing the Done column to show wrong counts (269 vs user's actual count) and only 2-3 done issues to appear from the first 50-item page. Backend: - Add creator_id and assignee_ids (uuid[]) filters to ListIssues, ListOpenIssues, and CountIssues SQL queries - Parse creator_id and assignee_ids (comma-separated) query params Frontend: - Add myIssueListOptions with per-scope server-filtered queries - Each tab now calls the API with the right filter: Assigned → assignee_id, Created → creator_id, My Agents → assignee_ids - Add useLoadMoreMyDoneIssues for server-filtered done pagination - WS events invalidate My Issues cache via issueKeys.myAll Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor(my-issues): merge duplicate load-more hooks into one Both board-view and list-view were unconditionally calling two hooks (useLoadMoreDoneIssues + useLoadMoreMyDoneIssues) and picking one at runtime. Merged into a single useLoadMoreDoneIssues with an optional myIssues param so only one hook runs per render. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
171 lines
7.1 KiB
TypeScript
171 lines
7.1 KiB
TypeScript
"use client";
|
|
|
|
import { useMemo } from "react";
|
|
import { ChevronRight, Plus } from "lucide-react";
|
|
import { Accordion } from "@base-ui/react/accordion";
|
|
import { Tooltip, TooltipTrigger, TooltipContent } from "@multica/ui/components/ui/tooltip";
|
|
import { Button } from "@multica/ui/components/ui/button";
|
|
import type { Issue, IssueStatus } from "@multica/core/types";
|
|
import { useLoadMoreDoneIssues } from "@multica/core/issues/mutations";
|
|
import type { MyIssuesFilter } from "@multica/core/issues/queries";
|
|
import { STATUS_CONFIG } from "@multica/core/issues/config";
|
|
import { useModalStore } from "@multica/core/modals";
|
|
import { useViewStore } from "@multica/core/issues/stores/view-store-context";
|
|
import { useIssueSelectionStore } from "@multica/core/issues/stores/selection-store";
|
|
import { sortIssues } from "../utils/sort";
|
|
import { StatusIcon } from "./status-icon";
|
|
import { ListRow, type ChildProgress } from "./list-row";
|
|
import { InfiniteScrollSentinel } from "./infinite-scroll-sentinel";
|
|
|
|
const EMPTY_PROGRESS_MAP = new Map<string, ChildProgress>();
|
|
|
|
export function ListView({
|
|
issues,
|
|
visibleStatuses,
|
|
childProgressMap = EMPTY_PROGRESS_MAP,
|
|
doneTotal: doneTotalOverride,
|
|
myIssuesScope,
|
|
myIssuesFilter,
|
|
}: {
|
|
issues: Issue[];
|
|
visibleStatuses: IssueStatus[];
|
|
childProgressMap?: Map<string, ChildProgress>;
|
|
/** Override the done-group count (e.g. with a server-filtered total). */
|
|
doneTotal?: number;
|
|
/** When set, use the My Issues load-more hook instead of the workspace one. */
|
|
myIssuesScope?: string;
|
|
myIssuesFilter?: MyIssuesFilter;
|
|
}) {
|
|
const sortBy = useViewStore((s) => s.sortBy);
|
|
const sortDirection = useViewStore((s) => s.sortDirection);
|
|
const listCollapsedStatuses = useViewStore(
|
|
(s) => s.listCollapsedStatuses
|
|
);
|
|
const toggleListCollapsed = useViewStore(
|
|
(s) => s.toggleListCollapsed
|
|
);
|
|
const selectedIds = useIssueSelectionStore((s) => s.selectedIds);
|
|
const select = useIssueSelectionStore((s) => s.select);
|
|
const deselect = useIssueSelectionStore((s) => s.deselect);
|
|
const myIssuesOpts = myIssuesScope ? { scope: myIssuesScope, filter: myIssuesFilter ?? {} } : undefined;
|
|
const { loadMore, hasMore, isLoading: loadingMore, doneTotal: hookDoneTotal } =
|
|
useLoadMoreDoneIssues(myIssuesOpts);
|
|
const displayDoneTotal = doneTotalOverride ?? hookDoneTotal;
|
|
|
|
const issuesByStatus = useMemo(() => {
|
|
const map = new Map<IssueStatus, Issue[]>();
|
|
for (const status of visibleStatuses) {
|
|
const filtered = issues.filter((i) => i.status === status);
|
|
map.set(status, sortIssues(filtered, sortBy, sortDirection));
|
|
}
|
|
return map;
|
|
}, [issues, visibleStatuses, sortBy, sortDirection]);
|
|
|
|
const expandedStatuses = useMemo(
|
|
() =>
|
|
visibleStatuses.filter(
|
|
(s) => !listCollapsedStatuses.includes(s)
|
|
),
|
|
[visibleStatuses, listCollapsedStatuses]
|
|
);
|
|
|
|
return (
|
|
<div className="flex-1 min-h-0 overflow-y-auto p-2">
|
|
<Accordion.Root
|
|
multiple
|
|
className="space-y-1"
|
|
value={expandedStatuses}
|
|
onValueChange={(value: string[]) => {
|
|
for (const status of visibleStatuses) {
|
|
const wasExpanded = expandedStatuses.includes(status);
|
|
const isExpanded = value.includes(status);
|
|
if (wasExpanded !== isExpanded) {
|
|
toggleListCollapsed(status as IssueStatus);
|
|
}
|
|
}
|
|
}}
|
|
>
|
|
{visibleStatuses.map((status) => {
|
|
const cfg = STATUS_CONFIG[status];
|
|
const statusIssues = issuesByStatus.get(status) ?? [];
|
|
const statusIssueIds = statusIssues.map((i) => i.id);
|
|
const selectedCount = statusIssueIds.filter((id) => selectedIds.has(id)).length;
|
|
const allSelected = statusIssues.length > 0 && selectedCount === statusIssues.length;
|
|
const someSelected = selectedCount > 0;
|
|
|
|
return (
|
|
<Accordion.Item key={status} value={status}>
|
|
<Accordion.Header className="group/header flex h-10 items-center rounded-lg bg-muted/40 transition-colors hover:bg-accent/30">
|
|
<div className="pl-3 flex items-center">
|
|
<input
|
|
type="checkbox"
|
|
checked={allSelected}
|
|
ref={(el) => {
|
|
if (el) el.indeterminate = someSelected && !allSelected;
|
|
}}
|
|
onChange={() => {
|
|
if (allSelected) {
|
|
deselect(statusIssueIds);
|
|
} else {
|
|
select(statusIssueIds);
|
|
}
|
|
}}
|
|
className="cursor-pointer accent-primary"
|
|
/>
|
|
</div>
|
|
<Accordion.Trigger className="group/trigger flex flex-1 items-center gap-2 px-2 h-full text-left outline-none">
|
|
<ChevronRight className="size-3.5 shrink-0 text-muted-foreground transition-transform group-aria-expanded/trigger:rotate-90" />
|
|
<span className={`inline-flex items-center gap-1.5 rounded px-2 py-0.5 text-xs font-semibold ${cfg.badgeBg} ${cfg.badgeText}`}>
|
|
<StatusIcon status={status} className="h-3 w-3" inheritColor />
|
|
{cfg.label}
|
|
</span>
|
|
<span className="text-xs text-muted-foreground">
|
|
{status === "done" ? displayDoneTotal : statusIssues.length}
|
|
</span>
|
|
</Accordion.Trigger>
|
|
<div className="pr-2">
|
|
<Tooltip>
|
|
<TooltipTrigger
|
|
render={
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
className="rounded-full text-muted-foreground opacity-0 group-hover/header:opacity-100 transition-opacity"
|
|
onClick={() =>
|
|
useModalStore
|
|
.getState()
|
|
.open("create-issue", { status })
|
|
}
|
|
/>
|
|
}
|
|
>
|
|
<Plus className="size-3.5" />
|
|
</TooltipTrigger>
|
|
<TooltipContent>Add issue</TooltipContent>
|
|
</Tooltip>
|
|
</div>
|
|
</Accordion.Header>
|
|
<Accordion.Panel className="pt-1">
|
|
{statusIssues.length > 0 ? (
|
|
<>
|
|
{statusIssues.map((issue) => (
|
|
<ListRow key={issue.id} issue={issue} childProgress={childProgressMap.get(issue.id)} />
|
|
))}
|
|
{status === "done" && hasMore && (
|
|
<InfiniteScrollSentinel onVisible={loadMore} loading={loadingMore} />
|
|
)}
|
|
</>
|
|
) : (
|
|
<p className="py-6 text-center text-xs text-muted-foreground">
|
|
No issues
|
|
</p>
|
|
)}
|
|
</Accordion.Panel>
|
|
</Accordion.Item>
|
|
);
|
|
})}
|
|
</Accordion.Root>
|
|
</div>
|
|
);
|
|
}
|