Files
multica/packages/views/modals/feedback.tsx
Bohan Jiang 3cb5dc3ad6 chore(analytics): retire redundant PostHog tracking (MUL-4127) (#4996)
* chore(analytics): retire redundant PostHog tracking (MUL-4127)

PostHog had become a chaotic, largely-unused second copy of data we already
query from the DB and Grafana. Remove the redundant instrumentation.

Server: every product event (signup, workspace_created, issue_created,
issue_executed, chat_message_sent, team_invite_*, onboarding_*, agent_created,
cloud_waitlist_joined, feedback_submitted, contact_sales_submitted,
squad_created, autopilot_created) is now in metricsOnlyEvents, so
metrics.RecordEvent still increments the Prometheus/Grafana counter but no longer
ships to PostHog. DB rows remain the source of truth. Runtime/autopilot/
agent_task lifecycle were already Prometheus-only.

Frontend: delete the PostHog-only funnel instrumentation — $pageview (+ web and
desktop trackers), download_intent_expressed/page_viewed/initiated, the
onboarding_started mirror, onboarding_runtime_path_selected/detected,
feedback_opened, and source_backfill_*. The source-backfill modal itself stays
(it PATCHes the questionnaire to the DB).

Kept on PostHog (frontend only): $exception autocapture and the
client_crash / client_unresponsive stability telemetry (no DB equivalent), plus
$identify/$set. captureSignupSource (attribution cookie) stays — it still feeds
the signup_source Prometheus label.

Verified: pnpm typecheck, pnpm lint (0 errors), vitest (core/views/web/desktop),
go test ./internal/analytics/... ./internal/metrics/...

Co-authored-by: multica-agent <github@multica.ai>

* docs(analytics): fix stale PostHog references after MUL-4127 (review follow-up)

Addresses review of #4996 — three spots still described server events as active
PostHog signals after they became metrics-only:

- docs/analytics.md: issue_executed is no longer a PostHog success signal; it is
  Prometheus-only (multica_issue_executed_total) + issue.first_executed_at, in
  both the event contract and the Reconciliation section.
- docs/analytics.md: the signup $set_once person properties (email, signup_source)
  are no longer emitted — signup is Prometheus-only; only the bucketed
  signup_source survives as the multica_signup_total label.
- server/internal/metrics/business_events.go: RecordEvent doc comment no longer
  claims it ships product events to PostHog / "PostHog is reserved for
  user/product-behaviour events" — every server event is now metrics-only.

Co-authored-by: multica-agent <github@multica.ai>

---------

Co-authored-by: J <j@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
2026-07-07 01:43:15 +08:00

171 lines
5.8 KiB
TypeScript

"use client";
import { useRef, useState } from "react";
import { toast } from "sonner";
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
} from "@multica/ui/components/ui/dialog";
import { Button } from "@multica/ui/components/ui/button";
import { FileUploadButton } from "@multica/ui/components/common/file-upload-button";
import {
ContentEditor,
type ContentEditorRef,
useFileDropZone,
FileDropOverlay,
} from "../editor";
import {
useCreateFeedback,
useFeedbackDraftStore,
FEEDBACK_KINDS,
type FeedbackKind,
} from "@multica/core/feedback";
import { useCurrentWorkspace } from "@multica/core/paths";
import { useFileUpload } from "@multica/core/hooks/use-file-upload";
import { api } from "@multica/core/api";
import { useT } from "../i18n";
import { formatShortcut, modKey, enterKey } from "@multica/core/platform";
const MAX_MESSAGE_LEN = 10000;
const FEEDBACK_KIND_SET = new Set<FeedbackKind>(FEEDBACK_KINDS);
function composeFeedbackInitialMessage(draftMessage: string, incomingInitialMessage: string) {
const draft = draftMessage.trim();
const incoming = incomingInitialMessage.trim();
if (!incoming) return draftMessage;
if (!draft) return incomingInitialMessage;
if (draft.includes(incoming)) return draftMessage;
return `${draftMessage}
---
${incomingInitialMessage}`;
}
export function FeedbackModal({
onClose,
data,
initialMessage,
}: {
onClose: () => void;
data?: Record<string, unknown> | null;
initialMessage?: string;
}) {
const { t } = useT("modals");
const workspace = useCurrentWorkspace();
const draft = useFeedbackDraftStore((s) => s.draft);
const setDraft = useFeedbackDraftStore((s) => s.setDraft);
const clearDraft = useFeedbackDraftStore((s) => s.clearDraft);
const editorRef = useRef<ContentEditorRef>(null);
const incomingInitialMessage =
initialMessage ?? (typeof data?.initialMessage === "string" ? data.initialMessage : "");
const kind = typeof data?.kind === "string" && FEEDBACK_KIND_SET.has(data.kind as FeedbackKind)
? (data.kind as FeedbackKind)
: undefined;
const seededMessage = composeFeedbackInitialMessage(draft.message, incomingInitialMessage);
const [message, setMessage] = useState(seededMessage);
const { isDragOver, dropZoneProps } = useFileDropZone({
onDrop: (files) => files.forEach((f) => editorRef.current?.uploadFile(f)),
});
const { uploadWithToast } = useFileUpload(api);
const mutation = useCreateFeedback();
const canSubmit =
message.trim().length > 0 &&
message.length <= MAX_MESSAGE_LEN &&
!mutation.isPending;
const handleSubmit = async () => {
if (!canSubmit) return;
if (editorRef.current?.hasActiveUploads()) {
toast.info(t(($) => $.feedback.toast_uploading));
return;
}
// Read from the editor ref at submit time — `message` state lags 150ms
// behind keystrokes due to `debounceMs`, so ⌘+Enter fired immediately
// after typing would otherwise submit stale content.
const latest = editorRef.current?.getMarkdown()?.trim() ?? "";
if (!latest) return;
if (latest.length > MAX_MESSAGE_LEN) {
toast.error(t(($) => $.feedback.toast_too_long));
return;
}
try {
await mutation.mutateAsync({
message: latest,
url: typeof window !== "undefined" ? window.location.href : undefined,
workspace_id: workspace?.id,
kind,
});
clearDraft();
toast.success(t(($) => $.feedback.toast_sent));
onClose();
} catch (err) {
const msg =
err instanceof Error && err.message
? err.message
: t(($) => $.feedback.toast_failed);
toast.error(msg);
}
};
return (
<Dialog open onOpenChange={(v) => !v && onClose()}>
<DialogContent className="sm:max-w-2xl !h-[28rem] p-0 gap-0 flex flex-col overflow-hidden">
<DialogHeader className="px-5 pt-4 pb-2 shrink-0">
<DialogTitle>{t(($) => $.feedback.title)}</DialogTitle>
<p className="mt-1 text-xs text-muted-foreground">
{t(($) => $.feedback.github_hint_prefix)}
<a
href="https://github.com/multica-ai/multica/issues"
target="_blank"
rel="noopener noreferrer"
className="text-brand underline decoration-brand/40 underline-offset-2 hover:decoration-brand"
>
{t(($) => $.feedback.github_hint_link)}
</a>
</p>
</DialogHeader>
<div className="flex-1 min-h-0 px-5 pb-3">
<div
{...dropZoneProps}
className="relative h-full overflow-y-auto rounded-lg border-1 border-border transition-colors focus-within:border-brand"
>
<ContentEditor
ref={editorRef}
defaultValue={seededMessage}
placeholder={t(($) => $.feedback.placeholder)}
onUpdate={(md) => { setMessage(md); setDraft({ message: md }); }}
onUploadFile={uploadWithToast}
onSubmit={handleSubmit}
debounceMs={150}
showBubbleMenu={false}
className="px-3 py-2"
/>
{isDragOver && <FileDropOverlay />}
</div>
</div>
<div className="flex items-center justify-between px-4 py-3 border-t shrink-0">
<FileUploadButton
size="sm"
multiple
onSelect={(file) => editorRef.current?.uploadFile(file)}
/>
<Button size="sm" onClick={handleSubmit} disabled={!canSubmit}>
{mutation.isPending ? t(($) => $.feedback.sending) : t(($) => $.feedback.send)}
<kbd className="ml-1 inline-flex h-4 items-center gap-0.5 rounded border border-border/50 bg-background/30 px-1 font-mono text-[10px] leading-none">
{formatShortcut(modKey, enterKey)}
</kbd>
</Button>
</div>
</DialogContent>
</Dialog>
);
}