mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-01 01:16:17 +02:00
* MUL-3903 refactor project issue surface state Co-authored-by: multica-agent <github@multica.ai> * Refactor project issue surface ownership Co-authored-by: multica-agent <github@multica.ai> * Extract shared issue surface entrypoints Co-authored-by: multica-agent <github@multica.ai> * Fix issue surface create defaults and selection reset Co-authored-by: multica-agent <github@multica.ai> * test(editor): add missing AbortSignal to suggestion items() calls The suggestion items() contract gained a required signal param; the mention/slash test call sites were never updated, breaking pnpm typecheck for @multica/views. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): server-side assignee_types filter on ListIssues ListGroupedIssues has taken assignee_types since squads shipped, but ListIssues never did — so the workspace Members/Agents tabs had to fetch the unfiltered workspace list and post-filter loaded pages client-side, which made column totals and load-more pagination reflect the unfiltered counts. Add the same parse + WHERE clause to ListIssues (count query shares the WHERE, so totals agree), thread the param through the TS client, and widen MyIssuesFilter so scoped list caches can carry it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): route issue cache writes through a membership-aware coordinator useUpdateIssue, useBatchUpdateIssues, and the WS issue:updated handler each maintained their own similar-but-diverging patch/invalidate rules. Consolidate them into cache-coordinator.ts (applyIssueChange / rollbackIssueChange / invalidateIssueDerivatives) so local writes and remote echoes follow one rules table by construction. The coordinator is membership-aware via surface/membership.ts (true | false | unknown against each list cache's own filter contract): - a change that moves an issue off a filtered surface removes the card surgically (bucket total decremented) — fixes assignee changes leaving stale cards on My Assigned with no local safety net (previously only the WS echo recovered it), and replaces the blanket invalidate-myAll net for project moves (MUL-3669) with per-key precision - possible entry into a loaded list marks that key stale — never hard-insert; page/slot is server knowledge - stale keys flush on settle for mutations (a mid-flight refetch would stomp the optimistic state) and immediately for WS - batch updates now patch detail + inbox like single updates; the off-screen bucket-count recovery previously exclusive to the WS path now covers local mutations too Preserved invariants: synchronous optimistic patches (dnd-kit), MUL-3375 control-field stripping, and no refetch of surgically reconciled lists (the drag-flicker fix). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): resolve surfaces via core query plan/repository with window-keyed remount Read-path convergence and the loading/empty semantics that fall out of it: - scope -> API params moves from scope.ts helpers into surface/query-plan.ts; workspace members/agents become server-filtered scoped plans (assignee_types) and the client postFilter machinery is deleted — tab counts and load-more are now exact - query selection moves behind surface/repository.ts; the views data hook no longer branches on workspace-vs-scoped plumbing - IssueSurfaceContent remounts on data-window change (wsId + scope): keepPreviousData placeholders keep sort/filter changes flicker-free within one window but must never let project A's (or workspace A's) cards impersonate B's with no loading state — cold window shows the skeleton, warm window hits cache instantly - isEmpty is only asserted from full-window data; the gantt scheduled-only projection can't prove the window is empty, so GanttView's own "no scheduled issues" empty state renders instead of the generic create-issue one - per-card project lookups hoist into a surface-level projectMap (drops a per-card useQuery), create-defaults typing tightens to IssueCreateDefaults Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * perf(issues): count-only arithmetic for off-window status/membership changes An issue beyond a list's loaded page window used to force a full first-page refetch just to fix two column counts. When the change is CERTAIN (base entity known, membership definitive) the coordinator now does the arithmetic locally: - stayed a member + status changed: move one unit of total between the two buckets (loaded arrays untouched; hasMore stays consistent) - left the list (reassigned / re-projected): old status bucket total -1 - member-to-member reassignment: counts unaffected, not even a stale key Entering a list and any uncertainty (no base, unknown membership) still refetch — the right page/slot is server knowledge. Branches on membership OUTCOMES, not on which field changed, so future dimensions (team) join automatically. Biggest win is the WS path: agents flipping off-screen statuses no longer trigger refetch storms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): deferred view-refresh indicator during placeholder revalidation Sort/date changes (and any grouped-board filter change) revalidate behind the previous snapshot — correct, but on a slow network the click felt dead: content stays put and isLoading never fires. Surface the state as isRefreshing (isPlaceholderData of the active query) and render a shared ViewRefreshIndicator in every issues header: a fixed-width slot (zero layout shift) whose spinner fades in after 300ms, so sub-second responses show nothing (NN/g) while slow ones get a working signal. Bound to the revalidation STATE, not to any particular control — any current or future server-side view change lights it automatically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: multica-agent <github@multica.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
218 lines
9.1 KiB
TypeScript
218 lines
9.1 KiB
TypeScript
import type { QueryClient } from "@tanstack/react-query";
|
|
import { issueKeys } from "./queries";
|
|
import { labelKeys } from "../labels/queries";
|
|
import { projectKeys } from "../projects/queries";
|
|
import {
|
|
applyIssueChange,
|
|
invalidateIssueDerivatives,
|
|
invalidateStaleListKeys,
|
|
} from "./cache-coordinator";
|
|
import {
|
|
addIssueToBuckets,
|
|
findIssueLocation,
|
|
patchIssueInBuckets,
|
|
} from "./cache-helpers";
|
|
import { cleanupDeletedIssueCaches } from "./delete-cache";
|
|
import type { Issue, IssueLabelsResponse, IssueMetadata, Label } from "../types";
|
|
import type { ListIssuesCache } from "../types";
|
|
|
|
export function onIssueCreated(
|
|
qc: QueryClient,
|
|
wsId: string,
|
|
issue: Issue,
|
|
) {
|
|
for (const [key, data] of qc.getQueriesData<ListIssuesCache>({ queryKey: issueKeys.list(wsId) })) {
|
|
if (data) qc.setQueryData<ListIssuesCache>(key, addIssueToBuckets(data, issue));
|
|
}
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.assigneeGroupsAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAssigneeGroupsAll(wsId) });
|
|
if (issue.project_id) {
|
|
qc.invalidateQueries({ queryKey: projectKeys.all(wsId) });
|
|
}
|
|
// Refresh every Project Gantt cache that might be observing this issue.
|
|
// We invalidate the whole prefix rather than the issue's own project
|
|
// because a fresh issue isn't necessarily scheduled yet; the active Gantt
|
|
// page (if any) will refetch and pick it up if it qualifies.
|
|
qc.invalidateQueries({ queryKey: issueKeys.projectGanttAll(wsId) });
|
|
if (issue.parent_issue_id) {
|
|
qc.invalidateQueries({ queryKey: issueKeys.children(wsId, issue.parent_issue_id) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.childProgress(wsId) });
|
|
}
|
|
}
|
|
|
|
export function onIssueUpdated(
|
|
qc: QueryClient,
|
|
wsId: string,
|
|
issue: Partial<Issue> & { id: string },
|
|
// assigneeChanged / statusChanged / projectChanged come from the server's
|
|
// issue:updated flags — authoritative "did this write move a membership
|
|
// dimension" signals. They feed the coordinator's changed-dims input so a
|
|
// non-membership change (title / position / priority / label) keeps every
|
|
// loaded list in place instead of refetching.
|
|
meta: {
|
|
assigneeChanged?: boolean;
|
|
statusChanged?: boolean;
|
|
projectChanged?: boolean;
|
|
} = {},
|
|
) {
|
|
// Look up the OLD parent + cached entity before mutating cache state, so we
|
|
// can keep the parent's children cache in sync (powers the sub-issues list
|
|
// shown on the parent issue page) and diff-fallback the change flags.
|
|
const listQueries = qc.getQueriesData<ListIssuesCache>({ queryKey: issueKeys.list(wsId) });
|
|
const firstListData = listQueries[0]?.[1];
|
|
const detailData = qc.getQueryData<Issue>(issueKeys.detail(wsId, issue.id));
|
|
const cachedIssue =
|
|
detailData ??
|
|
(firstListData ? findIssueLocation(firstListData, issue.id)?.issue : undefined);
|
|
const oldParentId =
|
|
detailData?.parent_issue_id ?? cachedIssue?.parent_issue_id ?? null;
|
|
// The NEW parent comes from the WS payload when parent_issue_id changed
|
|
const newParentId = issue.parent_issue_id ?? null;
|
|
const parentChanged =
|
|
issue.parent_issue_id !== undefined && newParentId !== oldParentId;
|
|
|
|
// Prefer the server's flags (authoritative, set on the wire). Fall back to
|
|
// diffing the payload against the cached copy only when a flag is absent
|
|
// (older backend): the diff is unreliable once a local optimistic move has
|
|
// overwritten the cached value, but it still covers remote/agent changes
|
|
// and keeps a new frontend on an old backend from regressing (MUL-3669 /
|
|
// #4548). The local move itself is covered by useUpdateIssue's own
|
|
// coordinator pass, which never depends on these flags.
|
|
const oldProjectId = detailData?.project_id ?? cachedIssue?.project_id ?? null;
|
|
const changed = {
|
|
assignee:
|
|
meta.assigneeChanged ??
|
|
(cachedIssue !== undefined &&
|
|
((issue.assignee_id !== undefined &&
|
|
issue.assignee_id !== cachedIssue.assignee_id) ||
|
|
(issue.assignee_type !== undefined &&
|
|
issue.assignee_type !== cachedIssue.assignee_type))),
|
|
project:
|
|
meta.projectChanged ??
|
|
(issue.project_id !== undefined && (issue.project_id ?? null) !== oldProjectId),
|
|
status:
|
|
meta.statusChanged ??
|
|
(cachedIssue !== undefined &&
|
|
issue.status !== undefined &&
|
|
issue.status !== cachedIssue.status),
|
|
};
|
|
|
|
// The coordinator applies the same rules table the local mutations use:
|
|
// surgical patch/rebucket where the card is loaded and still belongs,
|
|
// surgical remove where the change moved it off a filtered surface, and
|
|
// stale keys for the drift a patch cannot fix (enter/leave beyond the
|
|
// loaded window, undecidable membership, off-screen bucket counts). The
|
|
// server has already committed, so stale keys are flushed immediately.
|
|
const change = applyIssueChange(qc, wsId, issue.id, issue, {
|
|
changed,
|
|
baseIssue: cachedIssue,
|
|
});
|
|
invalidateStaleListKeys(qc, change.staleKeys);
|
|
invalidateIssueDerivatives(qc, wsId, {
|
|
statusOrProjectChanged:
|
|
issue.status !== undefined || issue.project_id !== undefined,
|
|
});
|
|
|
|
// Invalidate old parent's children (issue was removed from it)
|
|
if (oldParentId) {
|
|
if (parentChanged) {
|
|
qc.invalidateQueries({ queryKey: issueKeys.children(wsId, oldParentId) });
|
|
} else {
|
|
qc.setQueryData<Issue[]>(issueKeys.children(wsId, oldParentId), (old) =>
|
|
old?.map((c) => (c.id === issue.id ? { ...c, ...issue } : c)),
|
|
);
|
|
}
|
|
}
|
|
// Invalidate new parent's children (issue was added to it)
|
|
if (newParentId && parentChanged) {
|
|
qc.invalidateQueries({ queryKey: issueKeys.children(wsId, newParentId) });
|
|
}
|
|
if (oldParentId || newParentId) {
|
|
if (issue.status !== undefined || issue.parent_issue_id !== undefined) {
|
|
qc.invalidateQueries({ queryKey: issueKeys.childProgress(wsId) });
|
|
}
|
|
qc.invalidateQueries({ queryKey: issueKeys.childrenByParentsAll(wsId) });
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Patch an issue's labels in-place across the list cache, my-issues caches,
|
|
* the detail cache, and the per-issue label cache. Triggered by the
|
|
* `issue_labels:changed` WS event after attach/detach so list/board chips
|
|
* and the issue-detail Properties LabelPicker update without a refetch.
|
|
*
|
|
* The byIssue cache backs `LabelPicker`; without patching it, externally
|
|
* driven label changes (agents, other tabs) leave the picker stale until it
|
|
* remounts — `staleTime: Infinity` + `refetchOnWindowFocus: false` (see
|
|
* `query-client.ts`) means focus changes won't recover it.
|
|
*/
|
|
export function onIssueLabelsChanged(
|
|
qc: QueryClient,
|
|
wsId: string,
|
|
issueId: string,
|
|
labels: Label[],
|
|
) {
|
|
for (const [key, data] of qc.getQueriesData<ListIssuesCache>({ queryKey: issueKeys.list(wsId) })) {
|
|
if (data) qc.setQueryData<ListIssuesCache>(key, patchIssueInBuckets(data, issueId, { labels }));
|
|
}
|
|
qc.setQueryData<Issue>(issueKeys.detail(wsId, issueId), (old) =>
|
|
old ? { ...old, labels } : old,
|
|
);
|
|
qc.setQueryData<IssueLabelsResponse>(labelKeys.byIssue(wsId, issueId), (old) =>
|
|
old ? { ...old, labels } : old,
|
|
);
|
|
// Patch the Project Gantt caches in-place: the Gantt view applies
|
|
// `labelFilters` to the row data, so a stale `labels` array would silently
|
|
// hide or surface bars after another tab/agent attached or detached a
|
|
// label. Mutating in place (instead of invalidating) avoids a refetch of
|
|
// the entire scheduled set on every label toggle.
|
|
for (const [key, data] of qc.getQueriesData<Issue[]>({
|
|
queryKey: issueKeys.projectGanttAll(wsId),
|
|
})) {
|
|
if (!data) continue;
|
|
const next = data.map((issue) =>
|
|
issue.id === issueId ? { ...issue, labels } : issue,
|
|
);
|
|
qc.setQueryData<Issue[]>(key, next);
|
|
}
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.assigneeGroupsAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAssigneeGroupsAll(wsId) });
|
|
}
|
|
|
|
/**
|
|
* Apply a metadata snapshot to the issue detail + list + my-issues caches.
|
|
* The server emits this whenever a single key is set or deleted, so the
|
|
* payload is always the FULL post-mutation map — we replace, not merge.
|
|
*
|
|
* Used for the read-only metadata strip in issue detail. Updates that arrive
|
|
* while no view is mounted still keep the caches accurate so the next render
|
|
* shows the latest state without a refetch.
|
|
*/
|
|
export function onIssueMetadataChanged(
|
|
qc: QueryClient,
|
|
wsId: string,
|
|
issueId: string,
|
|
metadata: IssueMetadata,
|
|
) {
|
|
for (const [key, data] of qc.getQueriesData<ListIssuesCache>({ queryKey: issueKeys.list(wsId) })) {
|
|
if (data) qc.setQueryData<ListIssuesCache>(key, patchIssueInBuckets(data, issueId, { metadata }));
|
|
}
|
|
qc.setQueryData<Issue>(issueKeys.detail(wsId, issueId), (old) =>
|
|
old ? { ...old, metadata } : old,
|
|
);
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAll(wsId) });
|
|
}
|
|
|
|
export function onIssueDeleted(
|
|
qc: QueryClient,
|
|
wsId: string,
|
|
issueId: string,
|
|
) {
|
|
cleanupDeletedIssueCaches(qc, wsId, issueId);
|
|
qc.invalidateQueries({ queryKey: issueKeys.assigneeGroupsAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: issueKeys.myAssigneeGroupsAll(wsId) });
|
|
qc.invalidateQueries({ queryKey: projectKeys.all(wsId) });
|
|
}
|