mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-24 02:39:42 +02:00
* MUL-3903 refactor project issue surface state Co-authored-by: multica-agent <github@multica.ai> * Refactor project issue surface ownership Co-authored-by: multica-agent <github@multica.ai> * Extract shared issue surface entrypoints Co-authored-by: multica-agent <github@multica.ai> * Fix issue surface create defaults and selection reset Co-authored-by: multica-agent <github@multica.ai> * test(editor): add missing AbortSignal to suggestion items() calls The suggestion items() contract gained a required signal param; the mention/slash test call sites were never updated, breaking pnpm typecheck for @multica/views. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): server-side assignee_types filter on ListIssues ListGroupedIssues has taken assignee_types since squads shipped, but ListIssues never did — so the workspace Members/Agents tabs had to fetch the unfiltered workspace list and post-filter loaded pages client-side, which made column totals and load-more pagination reflect the unfiltered counts. Add the same parse + WHERE clause to ListIssues (count query shares the WHERE, so totals agree), thread the param through the TS client, and widen MyIssuesFilter so scoped list caches can carry it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): route issue cache writes through a membership-aware coordinator useUpdateIssue, useBatchUpdateIssues, and the WS issue:updated handler each maintained their own similar-but-diverging patch/invalidate rules. Consolidate them into cache-coordinator.ts (applyIssueChange / rollbackIssueChange / invalidateIssueDerivatives) so local writes and remote echoes follow one rules table by construction. The coordinator is membership-aware via surface/membership.ts (true | false | unknown against each list cache's own filter contract): - a change that moves an issue off a filtered surface removes the card surgically (bucket total decremented) — fixes assignee changes leaving stale cards on My Assigned with no local safety net (previously only the WS echo recovered it), and replaces the blanket invalidate-myAll net for project moves (MUL-3669) with per-key precision - possible entry into a loaded list marks that key stale — never hard-insert; page/slot is server knowledge - stale keys flush on settle for mutations (a mid-flight refetch would stomp the optimistic state) and immediately for WS - batch updates now patch detail + inbox like single updates; the off-screen bucket-count recovery previously exclusive to the WS path now covers local mutations too Preserved invariants: synchronous optimistic patches (dnd-kit), MUL-3375 control-field stripping, and no refetch of surgically reconciled lists (the drag-flicker fix). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): resolve surfaces via core query plan/repository with window-keyed remount Read-path convergence and the loading/empty semantics that fall out of it: - scope -> API params moves from scope.ts helpers into surface/query-plan.ts; workspace members/agents become server-filtered scoped plans (assignee_types) and the client postFilter machinery is deleted — tab counts and load-more are now exact - query selection moves behind surface/repository.ts; the views data hook no longer branches on workspace-vs-scoped plumbing - IssueSurfaceContent remounts on data-window change (wsId + scope): keepPreviousData placeholders keep sort/filter changes flicker-free within one window but must never let project A's (or workspace A's) cards impersonate B's with no loading state — cold window shows the skeleton, warm window hits cache instantly - isEmpty is only asserted from full-window data; the gantt scheduled-only projection can't prove the window is empty, so GanttView's own "no scheduled issues" empty state renders instead of the generic create-issue one - per-card project lookups hoist into a surface-level projectMap (drops a per-card useQuery), create-defaults typing tightens to IssueCreateDefaults Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * perf(issues): count-only arithmetic for off-window status/membership changes An issue beyond a list's loaded page window used to force a full first-page refetch just to fix two column counts. When the change is CERTAIN (base entity known, membership definitive) the coordinator now does the arithmetic locally: - stayed a member + status changed: move one unit of total between the two buckets (loaded arrays untouched; hasMore stays consistent) - left the list (reassigned / re-projected): old status bucket total -1 - member-to-member reassignment: counts unaffected, not even a stale key Entering a list and any uncertainty (no base, unknown membership) still refetch — the right page/slot is server knowledge. Branches on membership OUTCOMES, not on which field changed, so future dimensions (team) join automatically. Biggest win is the WS path: agents flipping off-screen statuses no longer trigger refetch storms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): deferred view-refresh indicator during placeholder revalidation Sort/date changes (and any grouped-board filter change) revalidate behind the previous snapshot — correct, but on a slow network the click felt dead: content stays put and isLoading never fires. Surface the state as isRefreshing (isPlaceholderData of the active query) and render a shared ViewRefreshIndicator in every issues header: a fixed-width slot (zero layout shift) whose spinner fades in after 300ms, so sub-second responses show nothing (NN/g) while slow ones get a working signal. Bound to the revalidation STATE, not to any particular control — any current or future server-side view change lights it automatically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: multica-agent <github@multica.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
165 lines
5.1 KiB
TypeScript
165 lines
5.1 KiB
TypeScript
"use client";
|
|
|
|
import { useCallback, useMemo, useState } from "react";
|
|
import { useStore } from "zustand";
|
|
import { ListTodo, Search } from "lucide-react";
|
|
import type { Issue } from "@multica/core/types";
|
|
import {
|
|
actorIssuesViewStore,
|
|
type ActorIssuesScope,
|
|
} from "@multica/core/issues/stores/actor-issues-view-store";
|
|
import { Button } from "@multica/ui/components/ui/button";
|
|
import { Input } from "@multica/ui/components/ui/input";
|
|
import { Tooltip, TooltipContent, TooltipTrigger } from "@multica/ui/components/ui/tooltip";
|
|
import {
|
|
IssueDisplayControls,
|
|
ViewRefreshIndicator,
|
|
} from "../issues/components/issues-header";
|
|
import { IssueSurface } from "../issues/surface/issue-surface";
|
|
import { matchesPinyin } from "../editor/extensions/pinyin-match";
|
|
import { useT } from "../i18n";
|
|
|
|
export type TaskActorType = "member" | "agent";
|
|
|
|
const SCOPE_VALUES: ActorIssuesScope[] = ["assigned", "created"];
|
|
|
|
function issueMatchesSearch(issue: Issue, rawQuery: string) {
|
|
const query = rawQuery.trim().toLowerCase();
|
|
if (!query) return true;
|
|
const title = issue.title ?? "";
|
|
return (
|
|
title.toLowerCase().includes(query) ||
|
|
issue.identifier.toLowerCase().includes(query) ||
|
|
matchesPinyin(title, query)
|
|
);
|
|
}
|
|
|
|
function ActorIssuesHeader({
|
|
issues,
|
|
search,
|
|
onSearchChange,
|
|
scope,
|
|
onScopeChange,
|
|
isRefreshing = false,
|
|
}: {
|
|
issues: Issue[];
|
|
search: string;
|
|
onSearchChange: (value: string) => void;
|
|
scope: ActorIssuesScope;
|
|
onScopeChange: (scope: ActorIssuesScope) => void;
|
|
isRefreshing?: boolean;
|
|
}) {
|
|
const { t } = useT("issues");
|
|
|
|
return (
|
|
<div className="flex h-12 shrink-0 items-center justify-between gap-3 border-b px-4">
|
|
<div className="flex items-center gap-3">
|
|
<div className="relative">
|
|
<Search className="pointer-events-none absolute left-2.5 top-1/2 h-3.5 w-3.5 -translate-y-1/2 text-muted-foreground" />
|
|
<Input
|
|
value={search}
|
|
onChange={(e) => onSearchChange(e.target.value)}
|
|
placeholder={t(($) => $.actor_issues.search_placeholder)}
|
|
className="h-8 w-64 pl-8 text-sm"
|
|
/>
|
|
</div>
|
|
<div className="flex items-center gap-1">
|
|
{SCOPE_VALUES.map((value) => (
|
|
<Tooltip key={value}>
|
|
<TooltipTrigger
|
|
render={
|
|
<Button
|
|
variant="outline"
|
|
size="sm"
|
|
className={
|
|
scope === value
|
|
? "bg-accent text-accent-foreground hover:bg-accent/80"
|
|
: "text-muted-foreground"
|
|
}
|
|
onClick={() => onScopeChange(value)}
|
|
>
|
|
{t(($) => $.actor_issues.scope[value].label)}
|
|
</Button>
|
|
}
|
|
/>
|
|
<TooltipContent side="bottom">
|
|
{t(($) => $.actor_issues.scope[value].description)}
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
))}
|
|
</div>
|
|
</div>
|
|
<div className="flex items-center">
|
|
<IssueDisplayControls scopedIssues={issues} hideViewToggle />
|
|
<ViewRefreshIndicator active={isRefreshing} />
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function ActorIssuesPanel({
|
|
actorType,
|
|
actorId,
|
|
}: {
|
|
actorType: TaskActorType;
|
|
actorId: string;
|
|
}) {
|
|
const { t } = useT("issues");
|
|
const scope = useStore(actorIssuesViewStore, (s) => s.scope);
|
|
const setScope = useStore(actorIssuesViewStore, (s) => s.setScope);
|
|
const [search, setSearch] = useState("");
|
|
const clientFilter = useCallback(
|
|
(issue: Issue) => issueMatchesSearch(issue, search),
|
|
[search],
|
|
);
|
|
const surfaceScope = useMemo(
|
|
() =>
|
|
({
|
|
type: "actor" as const,
|
|
actorType,
|
|
actorId,
|
|
relation: scope,
|
|
}),
|
|
[actorId, actorType, scope],
|
|
);
|
|
|
|
return (
|
|
<IssueSurface
|
|
scope={surfaceScope}
|
|
modes={["list"]}
|
|
batchToolbar="always"
|
|
contentClassName="p-1"
|
|
clientFilter={clientFilter}
|
|
showClientEmpty={() => search.trim() !== ""}
|
|
renderHeader={({ controller }) => (
|
|
<ActorIssuesHeader
|
|
issues={controller.surfaceIssues}
|
|
search={search}
|
|
onSearchChange={setSearch}
|
|
scope={scope}
|
|
onScopeChange={setScope}
|
|
isRefreshing={controller.isRefreshing}
|
|
/>
|
|
)}
|
|
renderEmpty={({ controller }) =>
|
|
controller.surfaceIssues.length === 0 ? (
|
|
<div className="flex flex-1 min-h-0 flex-col items-center justify-center gap-2 text-muted-foreground">
|
|
<ListTodo className="h-10 w-10 text-muted-foreground/40" />
|
|
<p className="text-sm">
|
|
{t(($) => $.actor_issues.empty[scope].title)}
|
|
</p>
|
|
<p className="text-xs">
|
|
{t(($) => $.actor_issues.empty[scope].description)}
|
|
</p>
|
|
</div>
|
|
) : (
|
|
<div className="flex flex-1 min-h-0 flex-col items-center justify-center gap-2 text-muted-foreground">
|
|
<Search className="h-10 w-10 text-muted-foreground/40" />
|
|
<p className="text-sm">{t(($) => $.actor_issues.search_empty)}</p>
|
|
</div>
|
|
)
|
|
}
|
|
/>
|
|
);
|
|
}
|