mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-23 01:59:24 +02:00
3a493ab417
Each issue row's IssueAgentActivityIndicator subscribed to the whole workspace agent-task snapshot via useQuery. Any task change swaps the snapshot array reference, so every observing row re-rendered — on a busy workspace the snapshot changes constantly, turning one task update into a full-list re-render and inflating the tab-switch commit. Narrow each row's subscription to this issue's tasks with a `select` (selectIssueTasks). React Query's structural sharing keeps the selected value referentially stable when the issue's own tasks are unchanged, so a snapshot invalidation now only re-renders the rows whose tasks actually moved. This is slice 1 of MUL-4474 (render de-amplification). Virtualization of list/board/swimlane/inbox and the non-position useSortable mount change are tracked separately — they need interactive drag + DevTools Performance verification that the headless runtime can't provide. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
85 lines
3.2 KiB
TypeScript
85 lines
3.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { AgentTask } from "@multica/core/types";
|
|
import { deriveIssueSurfaceActivity, selectIssueTasks } from "./activity";
|
|
|
|
function task(overrides: Partial<AgentTask>): AgentTask {
|
|
return {
|
|
id: overrides.id ?? "task-1",
|
|
workspace_id: "ws-1",
|
|
issue_id: undefined,
|
|
agent_id: "agent-1",
|
|
status: "queued",
|
|
trigger_type: "manual",
|
|
trigger_source: "manual",
|
|
trigger_ref: null,
|
|
prompt: null,
|
|
error: null,
|
|
created_at: "2026-01-01T00:00:00Z",
|
|
updated_at: "2026-01-01T00:00:00Z",
|
|
started_at: null,
|
|
completed_at: null,
|
|
...overrides,
|
|
} as AgentTask;
|
|
}
|
|
|
|
describe("deriveIssueSurfaceActivity", () => {
|
|
it("separates running work from queued-only issue activity", () => {
|
|
const activity = deriveIssueSurfaceActivity([
|
|
task({ id: "run-1", issue_id: "i-1", status: "running" }),
|
|
task({ id: "queue-1", issue_id: "i-2", status: "queued" }),
|
|
task({ id: "dispatch-1", issue_id: "i-2", status: "dispatched" }),
|
|
task({ id: "wait-1", issue_id: "i-3", status: "waiting_local_directory" }),
|
|
task({ id: "done-1", issue_id: "i-4", status: "completed" }),
|
|
task({ id: "no-issue", issue_id: undefined, status: "running" }),
|
|
]);
|
|
|
|
expect(activity.runningIssueIds).toEqual(new Set(["i-1"]));
|
|
expect(activity.activityByIssueId.get("i-1")).toMatchObject({
|
|
isWorking: true,
|
|
isQueued: false,
|
|
});
|
|
expect(activity.activityByIssueId.get("i-2")).toMatchObject({
|
|
isWorking: false,
|
|
isQueued: true,
|
|
});
|
|
expect(activity.activityByIssueId.get("i-3")).toMatchObject({
|
|
isWorking: false,
|
|
isQueued: true,
|
|
});
|
|
expect(activity.activityByIssueId.has("i-4")).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("selectIssueTasks", () => {
|
|
const snapshot: AgentTask[] = [
|
|
task({ id: "run-1", issue_id: "i-1", status: "running" }),
|
|
task({ id: "run-2", issue_id: "i-1", status: "running" }),
|
|
task({ id: "queue-1", issue_id: "i-1", status: "queued" }),
|
|
task({ id: "other-run", issue_id: "i-2", status: "running" }),
|
|
task({ id: "wait-1", issue_id: "i-3", status: "waiting_local_directory" }),
|
|
task({ id: "dispatch-1", issue_id: "i-3", status: "dispatched" }),
|
|
task({ id: "done-1", issue_id: "i-1", status: "completed" }),
|
|
task({ id: "no-issue", issue_id: undefined, status: "running" }),
|
|
];
|
|
|
|
it("returns only the running/queued tasks for the requested issue", () => {
|
|
const groups = selectIssueTasks(snapshot, "i-1");
|
|
expect(groups.running.map((t) => t.id)).toEqual(["run-1", "run-2"]);
|
|
expect(groups.queued.map((t) => t.id)).toEqual(["queue-1"]);
|
|
});
|
|
|
|
it("treats dispatched and waiting_local_directory as queued", () => {
|
|
const groups = selectIssueTasks(snapshot, "i-3");
|
|
expect(groups.running).toEqual([]);
|
|
expect(groups.queued.map((t) => t.id)).toEqual(["wait-1", "dispatch-1"]);
|
|
});
|
|
|
|
it("drops terminal statuses and tasks without an issue", () => {
|
|
const groups = selectIssueTasks(snapshot, "i-1");
|
|
expect(groups.running.map((t) => t.id)).not.toContain("done-1");
|
|
expect(groups.queued.map((t) => t.id)).not.toContain("done-1");
|
|
const noMatch = selectIssueTasks(snapshot, "does-not-exist");
|
|
expect(noMatch).toEqual({ running: [], queued: [] });
|
|
});
|
|
});
|