mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-16 14:49:09 +02:00
3c417ea631
Testing surfaced two problems with the per-thread fan-out:
1. Authorization (blocker): CreateComment rejected any agent comment on the
task's issue whose parent_id != task.TriggerCommentID, so replies to the
OTHER coalesced threads were denied ('parent_id must equal this task's
trigger comment id') and those threads never got a reply. Allow the trigger
comment OR any comment the task coalesced (taskCoversReplyParent: trigger ∪
coalesced_comment_ids); every other parent on the issue is still rejected,
so this stays scoped to the set the run was actually given to answer.
2. Ordering: the agent answered the newest (triggering) comment first. The
fan-out instruction now numbers the targets and explicitly requires posting
OLDEST thread first, the newest/triggering thread last, so replies land in
chronological order. commentReplyThreads already lists oldest-first.
Tests: TestTaskCoversReplyParent (allow-list) and chronological-order
assertions in the cross-thread prompt test.
Co-authored-by: Eve <eve@multica-ai.local>
Co-authored-by: multica-agent <github@multica.ai>
56 lines
2.0 KiB
Go
56 lines
2.0 KiB
Go
package handler
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/multica-ai/multica/server/internal/util"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
)
|
|
|
|
// TestTaskCoversReplyParent pins the comment-reply authorization allow-list
|
|
// (MUL-4348): a comment-triggered task may reply under its trigger comment OR
|
|
// under any earlier comment it coalesced, and nothing else. This is what lets
|
|
// a coalesced cross-thread run answer each thread in its own thread instead of
|
|
// being rejected with "parent_id must equal this task's trigger comment id".
|
|
func TestTaskCoversReplyParent(t *testing.T) {
|
|
trigger := "11111111-1111-1111-1111-111111111111"
|
|
c1 := "22222222-2222-2222-2222-222222222222"
|
|
c2 := "33333333-3333-3333-3333-333333333333"
|
|
stranger := "99999999-9999-9999-9999-999999999999"
|
|
|
|
task := db.AgentTaskQueue{
|
|
TriggerCommentID: util.MustParseUUID(trigger),
|
|
CoalescedCommentIds: []pgtype.UUID{
|
|
util.MustParseUUID(c1),
|
|
util.MustParseUUID(c2),
|
|
},
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
parent pgtype.UUID
|
|
want bool
|
|
}{
|
|
{"trigger comment allowed", util.MustParseUUID(trigger), true},
|
|
{"first coalesced comment allowed", util.MustParseUUID(c1), true},
|
|
{"second coalesced comment allowed", util.MustParseUUID(c2), true},
|
|
{"unrelated comment rejected", util.MustParseUUID(stranger), false},
|
|
{"invalid/empty parent rejected", pgtype.UUID{}, false},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := taskCoversReplyParent(task, tc.parent); got != tc.want {
|
|
t.Errorf("taskCoversReplyParent(%s) = %v, want %v", uuidToString(tc.parent), got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
|
|
// An assignment-triggered task (no trigger comment, no coalesced set) covers
|
|
// nothing here; the caller only consults this when TriggerCommentID is valid.
|
|
empty := db.AgentTaskQueue{}
|
|
if taskCoversReplyParent(empty, util.MustParseUUID(trigger)) {
|
|
t.Errorf("a task with no trigger/coalesced comments must not authorize any parent")
|
|
}
|
|
}
|