mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-13 19:43:27 +02:00
tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 written as arbitrary values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the ~1,900-call-site rename moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: 8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30 (text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small buttons and toggles. Half-pixel sizes are gone. This supersedes #6108, which was reverted by #6116 because the sidebar group labels rendered at the inherited 16px. The cause was not the scale but cn(): `text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a table listing only the default sizes, so it filed every role step under text-colour and dropped whichever of `text-caption` / `text-sidebar-foreground/70` came first. Registering the steps as a font-size class group restores the real conflict groups — size beats size, colour beats colour, the two coexist — and a test pins the list against the scale, since the failure is silent in source. Hand-written CSS is covered too. The transcript kept a 12.5px body long after every Tailwind call site was on the scale, so the "no half-pixel sizes" claim was true of the classes and false of the product; the editor's prose, code and mermaid ramps had the same blind spot, and seven of their eight values already equalled a step exactly. All now reference var(--text-*). The guard test reads raw `font-size:` declarations as well as class names, exempting only the 16px iOS input-zoom workaround in base.css and the landing pages' marketing ramp. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing display type (rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative emoji / serif-hero sizes. Verified on a running local stack: pinned sidebar rows and group labels measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit of every rendered font size across the product surfaces finds nothing off the scale; the only exceptions are avatar initials and emoji, which actor-avatar.tsx sizes proportionally to the avatar diameter by design. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
355 lines
14 KiB
TypeScript
355 lines
14 KiB
TypeScript
"use client";
|
|
|
|
import { useEffect, useMemo, useState } from "react";
|
|
import { ChevronDown, Cloud, Loader2, Lock, Search } from "lucide-react";
|
|
import { ProviderLogo } from "../../runtimes/components/provider-logo";
|
|
import { ActorAvatar } from "../../common/actor-avatar";
|
|
import { runtimeDisplayName } from "@multica/core/runtimes";
|
|
import type { MemberWithUser, RuntimeDevice } from "@multica/core/types";
|
|
import {
|
|
Popover,
|
|
PopoverTrigger,
|
|
PopoverContent,
|
|
} from "@multica/ui/components/ui/popover";
|
|
import { Label } from "@multica/ui/components/ui/label";
|
|
import { useT } from "../../i18n";
|
|
import {
|
|
buildRuntimeMachines,
|
|
filterRuntimeMachines,
|
|
runtimeRowLabel,
|
|
} from "../../runtimes/components/runtime-machines";
|
|
|
|
export type RuntimeFilter = "mine" | "all";
|
|
|
|
// Above this many runtimes the flat list becomes hard to scan, so we surface
|
|
// a search box. Machine grouping kicks in independently whenever more than one
|
|
// machine is present.
|
|
const SEARCH_THRESHOLD = 6;
|
|
|
|
export function RuntimePicker({
|
|
runtimes,
|
|
runtimesLoading,
|
|
members,
|
|
currentUserId,
|
|
selectedRuntimeId,
|
|
onSelect,
|
|
disabled = false,
|
|
}: {
|
|
runtimes: RuntimeDevice[];
|
|
runtimesLoading?: boolean;
|
|
members: MemberWithUser[];
|
|
currentUserId: string | null;
|
|
selectedRuntimeId: string;
|
|
onSelect: (id: string) => void;
|
|
/** Blocks opening the picker while the selection cannot be honoured yet
|
|
* (e.g. a builder reply or a runtime rebind is in flight). */
|
|
disabled?: boolean;
|
|
}) {
|
|
const { t } = useT("agents");
|
|
const [open, setOpen] = useState(false);
|
|
const [filter, setFilter] = useState<RuntimeFilter>("mine");
|
|
const [search, setSearch] = useState("");
|
|
|
|
const getOwnerMember = (ownerId: string | null) => {
|
|
if (!ownerId) return null;
|
|
return members.find((m) => m.user_id === ownerId) ?? null;
|
|
};
|
|
|
|
const hasOtherRuntimes = runtimes.some((r) => r.owner_id !== currentUserId);
|
|
|
|
// Base list honours the mine/all toggle and drives auto-selection; it is
|
|
// intentionally independent of the search box so typing never changes the
|
|
// seeded selection.
|
|
const filteredRuntimes = useMemo(
|
|
() => computeFilteredRuntimes(runtimes, filter, currentUserId),
|
|
[runtimes, filter, currentUserId],
|
|
);
|
|
|
|
// Group the (searched) base list by machine so 20+ runtimes read as a
|
|
// handful of named machines, online-first, current machine first.
|
|
const machines = useMemo(() => {
|
|
const all = buildRuntimeMachines(filteredRuntimes, {
|
|
now: Date.now(),
|
|
currentUserId,
|
|
});
|
|
return filterRuntimeMachines(all, search, "all");
|
|
}, [filteredRuntimes, search, currentUserId]);
|
|
|
|
const showSearch = runtimes.length > SEARCH_THRESHOLD;
|
|
|
|
const selectedRuntime =
|
|
runtimes.find((d) => d.id === selectedRuntimeId) ?? null;
|
|
|
|
// Sole source of truth for seeding the parent's selection when it's empty
|
|
// — first mount with no template runtime, runtimes arriving later over
|
|
// WS, or filter toggle clearing to a set with no usable item. Only fires
|
|
// when `selectedRuntimeId === ""` so a duplicate-mode pre-fill (template
|
|
// runtime) is never silently overwritten.
|
|
useEffect(() => {
|
|
if (selectedRuntimeId !== "") return;
|
|
const firstUsable = filteredRuntimes.find((r) =>
|
|
isRuntimeUsableForUser(r, currentUserId),
|
|
);
|
|
if (firstUsable) onSelect(firstUsable.id);
|
|
}, [filteredRuntimes, selectedRuntimeId, currentUserId, onSelect]);
|
|
|
|
// On filter toggle, recompute the picker's selection to a usable item
|
|
// in the new filter set. Pushes `""` when nothing matches; the seeding
|
|
// effect above is a no-op in that case (correct: no usable item to pick).
|
|
const handleFilterChange = (next: RuntimeFilter) => {
|
|
if (next === filter) return;
|
|
setFilter(next);
|
|
const nextList = computeFilteredRuntimes(runtimes, next, currentUserId);
|
|
const firstUsable = nextList.find((r) =>
|
|
isRuntimeUsableForUser(r, currentUserId),
|
|
);
|
|
onSelect(firstUsable?.id ?? "");
|
|
};
|
|
|
|
return (
|
|
<div className="flex flex-col min-w-0">
|
|
<div className="flex h-6 items-center justify-between">
|
|
<Label className="text-caption text-muted-foreground">
|
|
{t(($) => $.create_dialog.runtime_label)}
|
|
</Label>
|
|
{hasOtherRuntimes && (
|
|
// These are not just a view filter: changing tab re-selects the first
|
|
// usable runtime in the new list, so they are a second way to fire
|
|
// onSelect and must honour `disabled` alongside the trigger.
|
|
<div className="flex items-center gap-0.5 rounded-md bg-muted p-0.5">
|
|
<button
|
|
type="button"
|
|
disabled={disabled}
|
|
onClick={() => handleFilterChange("mine")}
|
|
className={`rounded px-2 py-0.5 text-caption font-medium transition-colors disabled:pointer-events-none disabled:opacity-50 ${
|
|
filter === "mine"
|
|
? "bg-background text-foreground shadow-sm"
|
|
: "text-muted-foreground hover:text-foreground"
|
|
}`}
|
|
>
|
|
{t(($) => $.create_dialog.runtime_filter_mine)}
|
|
</button>
|
|
<button
|
|
type="button"
|
|
disabled={disabled}
|
|
onClick={() => handleFilterChange("all")}
|
|
className={`rounded px-2 py-0.5 text-caption font-medium transition-colors disabled:pointer-events-none disabled:opacity-50 ${
|
|
filter === "all"
|
|
? "bg-background text-foreground shadow-sm"
|
|
: "text-muted-foreground hover:text-foreground"
|
|
}`}
|
|
>
|
|
{t(($) => $.create_dialog.runtime_filter_all)}
|
|
</button>
|
|
</div>
|
|
)}
|
|
</div>
|
|
<Popover
|
|
open={open && !disabled}
|
|
onOpenChange={(next) => {
|
|
if (disabled) return;
|
|
setOpen(next);
|
|
if (!next) setSearch("");
|
|
}}
|
|
>
|
|
<PopoverTrigger
|
|
disabled={disabled || (runtimes.length === 0 && !runtimesLoading)}
|
|
className="flex w-full min-w-0 items-center gap-3 rounded-lg border border-border bg-background px-3 py-2.5 mt-1.5 text-left text-body transition-colors hover:bg-muted disabled:pointer-events-none disabled:opacity-50"
|
|
>
|
|
{runtimesLoading ? (
|
|
<Loader2 className="h-4 w-4 shrink-0 animate-spin text-muted-foreground" />
|
|
) : selectedRuntime ? (
|
|
<ProviderLogo
|
|
provider={selectedRuntime.provider}
|
|
className="h-4 w-4 shrink-0"
|
|
/>
|
|
) : (
|
|
<Cloud className="h-4 w-4 shrink-0 text-muted-foreground" />
|
|
)}
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex items-center gap-2">
|
|
<span className="truncate font-medium">
|
|
{runtimesLoading
|
|
? t(($) => $.create_dialog.runtime_loading)
|
|
: selectedRuntime
|
|
? runtimeDisplayName(selectedRuntime)
|
|
: t(($) => $.create_dialog.runtime_none)}
|
|
</span>
|
|
{selectedRuntime?.runtime_mode === "cloud" && (
|
|
<span className="shrink-0 rounded bg-info/10 px-1.5 py-0.5 text-caption font-medium text-info">
|
|
{t(($) => $.create_dialog.runtime_cloud_badge)}
|
|
</span>
|
|
)}
|
|
</div>
|
|
{selectedRuntime && (
|
|
<div className="truncate text-caption text-muted-foreground">
|
|
{getOwnerMember(selectedRuntime.owner_id)?.name ??
|
|
selectedRuntime.device_info}
|
|
</div>
|
|
)}
|
|
</div>
|
|
<ChevronDown
|
|
className={`h-4 w-4 shrink-0 text-muted-foreground transition-transform ${
|
|
open ? "rotate-180" : ""
|
|
}`}
|
|
/>
|
|
</PopoverTrigger>
|
|
<PopoverContent
|
|
align="start"
|
|
className="w-[var(--anchor-width)] p-1 flex flex-col max-h-72"
|
|
>
|
|
{showSearch && (
|
|
<div className="relative mb-1 shrink-0">
|
|
<Search className="pointer-events-none absolute left-2.5 top-1/2 h-3.5 w-3.5 -translate-y-1/2 text-muted-foreground" />
|
|
<input
|
|
type="text"
|
|
autoFocus
|
|
value={search}
|
|
onChange={(e) => setSearch(e.target.value)}
|
|
placeholder={t(($) => $.create_dialog.runtime_search_placeholder)}
|
|
className="w-full rounded-md border border-border bg-background py-1.5 pl-8 pr-2 text-body outline-none focus:ring-1 focus:ring-ring"
|
|
/>
|
|
</div>
|
|
)}
|
|
<div className="min-h-0 flex-1 overflow-y-auto">
|
|
{machines.length === 0 ? (
|
|
<div className="px-3 py-6 text-center text-caption text-muted-foreground">
|
|
{t(($) => $.create_dialog.runtime_no_results)}
|
|
</div>
|
|
) : (
|
|
machines.map((machine) => (
|
|
<div key={machine.id}>
|
|
{/* Always show the machine header — even when a search or a
|
|
single-machine workspace narrows it to one group — so the
|
|
grouping stays consistent instead of collapsing to a flat
|
|
list. */}
|
|
<div className="flex items-center justify-between gap-2 px-2 pb-0.5 pt-2 text-micro font-medium text-muted-foreground">
|
|
<span className="truncate">{machine.title}</span>
|
|
<span className="shrink-0 tabular-nums">
|
|
{t(($) => $.create_dialog.runtime_group_online, {
|
|
online: machine.onlineCount,
|
|
total: machine.runtimes.length,
|
|
})}
|
|
</span>
|
|
</div>
|
|
{machine.runtimes.map((device) => {
|
|
const ownerMember = getOwnerMember(device.owner_id);
|
|
const disabled = !isRuntimeUsableForUser(
|
|
device,
|
|
currentUserId,
|
|
);
|
|
const disabledTitle = disabled
|
|
? t(($) => $.create_dialog.runtime_private_locked_tooltip)
|
|
: undefined;
|
|
return (
|
|
<button
|
|
key={device.id}
|
|
type="button"
|
|
disabled={disabled}
|
|
title={disabledTitle}
|
|
onClick={() => {
|
|
if (disabled) return;
|
|
onSelect(device.id);
|
|
setOpen(false);
|
|
}}
|
|
className={`flex w-full items-center gap-3 rounded-md px-3 py-2.5 text-left text-body transition-colors ${
|
|
disabled
|
|
? "cursor-not-allowed opacity-50"
|
|
: device.id === selectedRuntimeId
|
|
? "bg-accent"
|
|
: "hover:bg-accent/50"
|
|
}`}
|
|
>
|
|
<ProviderLogo
|
|
provider={device.provider}
|
|
className="h-4 w-4 shrink-0"
|
|
/>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex items-center gap-2">
|
|
<span className="truncate font-medium">
|
|
{runtimeRowLabel(device, machine.title)}
|
|
</span>
|
|
{device.runtime_mode === "cloud" && (
|
|
<span className="shrink-0 rounded bg-info/10 px-1.5 py-0.5 text-caption font-medium text-info">
|
|
{t(($) => $.create_dialog.runtime_cloud_badge)}
|
|
</span>
|
|
)}
|
|
{disabled && (
|
|
<span className="shrink-0 inline-flex items-center gap-1 rounded bg-muted px-1.5 py-0.5 text-micro font-medium text-muted-foreground">
|
|
<Lock className="h-3 w-3" />
|
|
{t(($) => $.create_dialog.runtime_private_badge)}
|
|
</span>
|
|
)}
|
|
</div>
|
|
<div className="mt-0.5 flex items-center gap-1 text-caption text-muted-foreground">
|
|
{ownerMember ? (
|
|
<>
|
|
<ActorAvatar
|
|
actorType="member"
|
|
actorId={ownerMember.user_id}
|
|
size="xs"
|
|
/>
|
|
<span className="truncate">
|
|
{ownerMember.name}
|
|
</span>
|
|
</>
|
|
) : (
|
|
<span className="truncate">
|
|
{device.device_info}
|
|
</span>
|
|
)}
|
|
</div>
|
|
</div>
|
|
<span
|
|
className={`h-2 w-2 shrink-0 rounded-full ${
|
|
device.status === "online"
|
|
? "bg-success"
|
|
: "bg-muted-foreground/40"
|
|
}`}
|
|
/>
|
|
</button>
|
|
);
|
|
})}
|
|
</div>
|
|
))
|
|
)}
|
|
</div>
|
|
</PopoverContent>
|
|
</Popover>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// Visibility gate exposed so the parent can defend Create against a locked
|
|
// selection (e.g. duplicate of an agent whose runtime is now private).
|
|
export function isRuntimeUsableForUser(
|
|
r: RuntimeDevice,
|
|
currentUserId: string | null,
|
|
): boolean {
|
|
if (!currentUserId) return true;
|
|
if (r.owner_id === currentUserId) return true;
|
|
return r.visibility === "public";
|
|
}
|
|
|
|
function computeFilteredRuntimes(
|
|
runtimes: RuntimeDevice[],
|
|
filter: RuntimeFilter,
|
|
currentUserId: string | null,
|
|
): RuntimeDevice[] {
|
|
const filtered =
|
|
filter === "mine" && currentUserId
|
|
? runtimes.filter((r) => r.owner_id === currentUserId)
|
|
: runtimes;
|
|
return filtered.toSorted((a, b) => {
|
|
const aMine = a.owner_id === currentUserId;
|
|
const bMine = b.owner_id === currentUserId;
|
|
if (aMine && !bMine) return -1;
|
|
if (!aMine && bMine) return 1;
|
|
const aUsable = isRuntimeUsableForUser(a, currentUserId);
|
|
const bUsable = isRuntimeUsableForUser(b, currentUserId);
|
|
if (aUsable && !bUsable) return -1;
|
|
if (!aUsable && bUsable) return 1;
|
|
return 0;
|
|
});
|
|
}
|