mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 10:59:06 +02:00
* feat(auth): support mcn_ Cloud Node PATs verified via Fleet
Adds a new token kind, mcn_ (multica cloud node), recognized in both
the regular Auth and DaemonAuth middlewares. mcn_ tokens are minted
and owned by Multica Cloud (not the local personal_access_tokens
table); the server validates them by POSTing to the Fleet's
/api/v1/pat/verify endpoint and uses the returned owner_id as
X-User-ID for downstream handlers.
Cloud is the authoritative owner of token status, so this is a
verifier-only path with no DB fallback:
* Fleet says valid:false -> 401 (token genuinely bad)
* Fleet unreachable / 5xx -> 503 (transient, retry)
* No MULTICA_CLOUD_FLEET_URL configured -> 401 (fail closed)
Verification results are cached in Redis for 60s under
mul:auth:mcn:<sha256> to bound the per-request load on Fleet without
extending the revocation window beyond what the Cloud doc allows.
Negative results are NOT cached, so a freshly minted token doesn't
get locked out by a stale 'token_not_found'.
Reuses MULTICA_CLOUD_FLEET_URL (the same env the cloud-runtime proxy
already uses) so deployments don't need a second config knob.
Tests cover the happy path, every documented invalid reason, 4xx/5xx
mapping, network error, decode error, ctx cancellation, the
fail-closed valid:true-without-owner_id case, trailing-slash URL
normalization, and the Redis cache short-circuit + negative
no-cache contract. Middleware tests pin the four 401/503/200 outcomes
in both Auth and DaemonAuth.
* auth(mcn): require owner_id to map to a real local user; drop X-User-PAT plumbing
Two related changes:
1. Cloud-verified owner_id is now checked against our local users table.
The Cloud owner_id and our users.id share the same UUID space by
contract; a missing local user means either the row was deleted
under an active node or something is forging owner_ids — either
way, fail closed.
CloudPATVerifier.Verify takes a new OwnerLookupFunc:
- returns (true, nil) -> success, cache + return
- returns (false, nil) -> ErrCloudPATInvalid (reason='owner_unknown'),
NOT cached (so a freshly-created user
doesn't get locked out for a TTL window)
- returns (_, error) -> ErrCloudPATUnavailable (transient,
middleware emits 503)
Both Auth and DaemonAuth wire ownerLookupFor(queries), a new shared
helper that wraps queries.GetUser, mapping pgx.ErrNoRows / unparseable
UUIDs to (false, nil) and other errors to a real Go error.
2. Removed all X-User-PAT plumbing. Cloud now mints node-scoped mcn_
PATs itself during /api/v1/nodes (see multica-cloud
docs/api/node-pat.md) and ships them into the EC2 instance via SSM,
so multica-api no longer needs to forward the caller's mul_ PAT.
Propagating a long-lived user PAT into a remote machine widened
the blast radius of any node compromise; that's gone now.
Removed:
- cloud_runtime.go: withUserPAT option, cloudRuntimeUserPAT,
generateCloudRuntimePAT, revokeGeneratedPAT
- cloudruntime/Request.UserPAT field + X-User-PAT header
- X-User-PAT from CORS allowed headers
- obsolete handler tests:
TestCreateCloudRuntimeNodeForwardsValidatedPAT
TestCreateCloudRuntimeNodeRejectsUnownedPAT
TestCreateCloudRuntimeNodeRejectsExpiredPAT
TestCreateCloudRuntimeNodeAutoGeneratesPAT
replaced with TestCreateCloudRuntimeNodeForwardsBody
- X-User-PAT references in packages/core/api/client.test.ts
Tests:
* 3 new verifier-level tests (owner_unknown not cached, lookup error
-> Unavailable, success path is cached for both fleet AND lookup)
* 5 new owner_lookup_test.go tests (nil queries, existing user,
missing user, malformed UUID, DB error)
* 1 new end-to-end DaemonAuth test (cloud says valid, no local user
-> 401)
* Existing X-User-PAT TS assertions removed; full vitest run passes.
* go test ./... and go vet ./... clean on the server module.
242 lines
9.4 KiB
Go
242 lines
9.4 KiB
Go
package middleware
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/golang-jwt/jwt/v5"
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/multica-ai/multica/server/internal/auth"
|
|
"github.com/multica-ai/multica/server/internal/util"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
)
|
|
|
|
func uuidToString(u pgtype.UUID) string { return util.UUIDToString(u) }
|
|
|
|
// Auth middleware validates JWT tokens or Personal Access Tokens.
|
|
// Token sources (in priority order):
|
|
// 1. Authorization: Bearer <token> header (PAT or JWT)
|
|
// 2. multica_auth HttpOnly cookie (JWT) — requires valid CSRF token for state-changing requests
|
|
//
|
|
// Sets X-User-ID and X-User-Email headers on the request for downstream handlers.
|
|
//
|
|
// patCache is optional; when non-nil, PAT lookups are cached with a short
|
|
// TTL (auth.AuthCacheTTL). On cache hit the middleware skips both the DB
|
|
// SELECT and the last_used_at UPDATE — last_used_at is therefore refreshed
|
|
// at most once per TTL window per token, not per request.
|
|
//
|
|
// cloudPAT is optional; when non-nil, tokens with the mcn_ prefix are
|
|
// validated by calling the Multica Cloud Fleet service rather than the
|
|
// local DB. When nil (Fleet URL unset) mcn_ tokens are rejected at the
|
|
// prefix branch — we don't fall through to the mul_ / JWT paths, since
|
|
// an mcn_ string is by construction not a valid mul_ PAT or JWT.
|
|
func Auth(queries *db.Queries, patCache *auth.PATCache, cloudPAT *auth.CloudPATVerifier) func(http.Handler) http.Handler {
|
|
return func(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// X-Actor-Source is server-set only — any value supplied by
|
|
// the client is untrusted and discarded before the auth
|
|
// branches run. Only the mat_ branch below re-sets it. This
|
|
// is what prevents a client from sending a normal mul_ PAT
|
|
// plus a forged `X-Actor-Source: member` (or anything else)
|
|
// to convince a downstream handler that its request came
|
|
// from a non-task-token path.
|
|
r.Header.Del("X-Actor-Source")
|
|
|
|
tokenString, fromCookie := extractToken(r)
|
|
if tokenString == "" {
|
|
slog.Debug("auth: no token found", "path", r.URL.Path)
|
|
http.Error(w, `{"error":"missing authorization"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
// Cookie-based auth requires CSRF validation for state-changing methods.
|
|
if fromCookie && !auth.ValidateCSRF(r) {
|
|
slog.Debug("auth: CSRF validation failed", "path", r.URL.Path)
|
|
http.Error(w, `{"error":"CSRF validation failed"}`, http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
// Agent task token: "mat_" prefix. Minted by the server at
|
|
// task-claim time and injected by the daemon into the agent
|
|
// process. Authoritative for actor identity — the bound
|
|
// (user_id, agent_id, task_id, workspace_id) triple is
|
|
// written into request headers here, OVERRIDING whatever the
|
|
// client sent, so a downstream actor-resolver cannot be
|
|
// tricked by a client that strips or forges X-Agent-ID /
|
|
// X-Task-ID. Owner-only endpoints (e.g. agent env
|
|
// management) reject requests authenticated this way; see
|
|
// `actorSourceFromRequest`. MUL-2600.
|
|
if strings.HasPrefix(tokenString, "mat_") {
|
|
if queries == nil {
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
hash := auth.HashToken(tokenString)
|
|
tt, err := queries.GetTaskTokenByHash(r.Context(), hash)
|
|
if err != nil {
|
|
slog.Warn("auth: invalid task token", "path", r.URL.Path, "error", err)
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
r.Header.Set("X-User-ID", uuidToString(tt.UserID))
|
|
r.Header.Set("X-Agent-ID", uuidToString(tt.AgentID))
|
|
r.Header.Set("X-Task-ID", uuidToString(tt.TaskID))
|
|
r.Header.Set("X-Workspace-ID", uuidToString(tt.WorkspaceID))
|
|
// X-Actor-Source flags the auth path so resolveActor and
|
|
// any owner-only handler can deny without re-querying the
|
|
// token table. The value "task_token" is the only signal
|
|
// this header is allowed to carry — strip anything else a
|
|
// client tried to send.
|
|
r.Header.Set("X-Actor-Source", "task_token")
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// Cloud Node PAT: "mcn_" prefix. Verified by calling the
|
|
// Multica Cloud Fleet service — Cloud (not us) is the
|
|
// authoritative owner of the token's status and owner_id
|
|
// binding. We never look at the local
|
|
// personal_access_tokens table for this prefix; an mcn_
|
|
// string is not a valid mul_ value, so falling through
|
|
// would just be a redundant DB miss. When the verifier
|
|
// is unconfigured (no MULTICA_CLOUD_FLEET_URL) we reject
|
|
// at this branch rather than treating the token as a
|
|
// JWT/PAT — failing closed avoids a misconfigured prod
|
|
// silently downgrading auth.
|
|
//
|
|
// After Cloud confirms the token, we also confirm that
|
|
// the returned owner_id maps to a real local user. The
|
|
// Cloud `owner_id` and our `users.id` share the same UUID
|
|
// space by contract, so this is a defense in depth: a
|
|
// missing user means the local row was deleted out from
|
|
// under a still-active node, or something is forging
|
|
// owner_ids — either way we must not let the request
|
|
// pass with a phantom X-User-ID.
|
|
if strings.HasPrefix(tokenString, auth.CloudPATPrefix) {
|
|
if cloudPAT == nil {
|
|
slog.Warn("auth: mcn_ token presented but cloud verifier not configured", "path", r.URL.Path)
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
identity, err := cloudPAT.Verify(r.Context(), tokenString, ownerLookupFor(queries))
|
|
if err != nil {
|
|
if errors.Is(err, auth.ErrCloudPATInvalid) {
|
|
slog.Warn("auth: cloud rejected mcn_ token", "path", r.URL.Path, "error", err)
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
// Cloud unreachable / 5xx / decode error. We surface
|
|
// 503 so callers (CLI / daemon) can retry — a 401
|
|
// here would tell them to throw out a valid token.
|
|
slog.Warn("auth: cloud pat verify unavailable", "path", r.URL.Path, "error", err)
|
|
http.Error(w, `{"error":"cloud pat verifier unavailable"}`, http.StatusServiceUnavailable)
|
|
return
|
|
}
|
|
r.Header.Set("X-User-ID", identity.OwnerID)
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// PAT: tokens starting with "mul_"
|
|
if strings.HasPrefix(tokenString, "mul_") {
|
|
hash := auth.HashToken(tokenString)
|
|
|
|
// Cache hit: TTL has not expired, the token was valid the
|
|
// last time we looked, and nothing has invalidated the
|
|
// entry since. Skip the DB SELECT and the last_used_at
|
|
// UPDATE — last_used_at is bumped once per TTL window.
|
|
if userID, ok := patCache.Get(r.Context(), hash); ok {
|
|
r.Header.Set("X-User-ID", userID)
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
if queries == nil {
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
pat, err := queries.GetPersonalAccessTokenByHash(r.Context(), hash)
|
|
if err != nil {
|
|
slog.Warn("auth: invalid PAT", "path", r.URL.Path, "error", err)
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
userID := uuidToString(pat.UserID)
|
|
r.Header.Set("X-User-ID", userID)
|
|
|
|
// Clamp cache TTL to the token's remaining lifetime so a
|
|
// PAT expiring in <AuthCacheTTL can't continue passing
|
|
// auth on a cache hit after expires_at.
|
|
var expiresAt time.Time
|
|
if pat.ExpiresAt.Valid {
|
|
expiresAt = pat.ExpiresAt.Time
|
|
}
|
|
patCache.Set(r.Context(), hash, userID, auth.TTLForExpiry(time.Now(), expiresAt))
|
|
|
|
// Cache miss = TTL expired (or first use after revoke /
|
|
// process restart). Refresh last_used_at; subsequent hits
|
|
// within the TTL window skip this write entirely.
|
|
go queries.UpdatePersonalAccessTokenLastUsed(context.Background(), pat.ID)
|
|
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// JWT
|
|
token, err := jwt.Parse(tokenString, func(token *jwt.Token) (any, error) {
|
|
if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
|
|
return nil, jwt.ErrSignatureInvalid
|
|
}
|
|
return auth.JWTSecret(), nil
|
|
})
|
|
if err != nil || !token.Valid {
|
|
slog.Warn("auth: invalid token", "path", r.URL.Path, "error", err)
|
|
http.Error(w, `{"error":"invalid token"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
claims, ok := token.Claims.(jwt.MapClaims)
|
|
if !ok {
|
|
slog.Warn("auth: invalid claims", "path", r.URL.Path)
|
|
http.Error(w, `{"error":"invalid claims"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
sub, ok := claims["sub"].(string)
|
|
if !ok || strings.TrimSpace(sub) == "" {
|
|
slog.Warn("auth: invalid claims", "path", r.URL.Path)
|
|
http.Error(w, `{"error":"invalid claims"}`, http.StatusUnauthorized)
|
|
return
|
|
}
|
|
r.Header.Set("X-User-ID", sub)
|
|
if email, ok := claims["email"].(string); ok {
|
|
r.Header.Set("X-User-Email", email)
|
|
}
|
|
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
}
|
|
|
|
// extractToken returns the bearer token and whether it came from a cookie.
|
|
// Priority: Authorization header > multica_auth cookie.
|
|
func extractToken(r *http.Request) (token string, fromCookie bool) {
|
|
if authHeader := r.Header.Get("Authorization"); authHeader != "" {
|
|
tokenString := strings.TrimPrefix(authHeader, "Bearer ")
|
|
if tokenString != authHeader {
|
|
return tokenString, false
|
|
}
|
|
}
|
|
|
|
if cookie, err := r.Cookie(auth.AuthCookieName); err == nil && cookie.Value != "" {
|
|
return cookie.Value, true
|
|
}
|
|
|
|
return "", false
|
|
}
|