mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 10:59:06 +02:00
* feat(issues): add sticky setting for the issue comment bar (MUL-4435) The bottom comment composer can now pin itself to the scroll viewport so it stays reachable while reading a long timeline. A pin toggle on the bar itself persists the preference (default: on) via a new localStorage-backed useCommentComposerStore. While pinned, the editor area is height-capped so long drafts scroll internally instead of covering the timeline. Co-authored-by: multica-agent <github@multica.ai> * refactor(settings): move the sticky comment bar toggle to Settings > Preferences (MUL-4435) Per review feedback: pinning the comment bar is a low-frequency choice, so the toggle moves off the bar itself into Settings > Preferences as a Switch row. The composer keeps reading the store for the sticky behavior and the 40vh editor cap; the pin button and its issues-locale tooltips are removed. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
246 lines
8.1 KiB
TypeScript
246 lines
8.1 KiB
TypeScript
import { forwardRef, useImperativeHandle, useRef, type ReactNode, type Ref } from "react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { fireEvent, screen, waitFor } from "@testing-library/react";
|
|
import type { UploadResult } from "@multica/core/hooks/use-file-upload";
|
|
import { useCommentComposerStore } from "@multica/core/issues/stores";
|
|
import { renderWithI18n } from "../../test/i18n";
|
|
import { CommentInput } from "./comment-input";
|
|
import { ReplyInput } from "./reply-input";
|
|
|
|
const uploadWithToast = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@multica/core/api", () => ({
|
|
api: {},
|
|
}));
|
|
|
|
vi.mock("@multica/core/hooks/use-file-upload", () => ({
|
|
useFileUpload: () => ({ uploadWithToast }),
|
|
}));
|
|
|
|
vi.mock("../../common/actor-avatar", () => ({
|
|
ActorAvatar: ({ actorType, actorId }: { actorType: string; actorId: string }) => (
|
|
<span data-testid="actor-avatar">
|
|
{actorType}:{actorId}
|
|
</span>
|
|
),
|
|
}));
|
|
|
|
vi.mock("../../editor", () => ({
|
|
useFileDropZone: () => ({
|
|
isDragOver: false,
|
|
dropZoneProps: { "data-testid": "drop-zone" },
|
|
}),
|
|
FileDropOverlay: () => null,
|
|
ContentEditor: forwardRef(function MockContentEditor(
|
|
{
|
|
defaultValue,
|
|
onUpdate,
|
|
placeholder,
|
|
onUploadFile,
|
|
}: {
|
|
defaultValue?: string;
|
|
onUpdate?: (markdown: string) => void;
|
|
placeholder?: string;
|
|
onUploadFile?: (file: File) => Promise<UploadResult | null>;
|
|
},
|
|
ref: Ref<unknown>,
|
|
) {
|
|
const valueRef = useRef(defaultValue ?? "");
|
|
|
|
useImperativeHandle(ref, () => ({
|
|
getMarkdown: () => valueRef.current,
|
|
clearContent: () => {
|
|
valueRef.current = "";
|
|
},
|
|
focus: () => {},
|
|
blur: () => {},
|
|
uploadFile: async (file: File) => {
|
|
const result = await onUploadFile?.(file);
|
|
if (!result) return;
|
|
valueRef.current = `${valueRef.current}\n${result.url}`.trim();
|
|
onUpdate?.(valueRef.current);
|
|
},
|
|
hasActiveUploads: () => false,
|
|
}));
|
|
|
|
return (
|
|
<textarea
|
|
data-testid="editor"
|
|
defaultValue={defaultValue}
|
|
placeholder={placeholder}
|
|
onChange={(event) => {
|
|
valueRef.current = event.target.value;
|
|
onUpdate?.(event.target.value);
|
|
}}
|
|
/>
|
|
);
|
|
}),
|
|
}));
|
|
|
|
function renderWithProviders(ui: ReactNode) {
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: { retry: false },
|
|
},
|
|
});
|
|
return renderWithI18n(
|
|
<QueryClientProvider client={queryClient}>{ui}</QueryClientProvider>,
|
|
);
|
|
}
|
|
|
|
function renderCommentInput(onSubmit = vi.fn().mockResolvedValue(true)) {
|
|
const view = renderWithProviders(<CommentInput issueId="issue-1" onSubmit={onSubmit} />);
|
|
return { ...view, onSubmit };
|
|
}
|
|
|
|
function renderReplyInput({
|
|
onSubmit = vi.fn().mockResolvedValue(true),
|
|
size = "sm",
|
|
}: {
|
|
onSubmit?: (content: string, attachmentIds?: string[], suppressAgentIds?: string[]) => Promise<boolean>;
|
|
size?: "sm" | "default";
|
|
} = {}) {
|
|
const view = renderWithProviders(
|
|
<ReplyInput
|
|
issueId="issue-1"
|
|
parentId="comment-1"
|
|
avatarType="member"
|
|
avatarId="user-1"
|
|
onSubmit={onSubmit}
|
|
size={size}
|
|
/>,
|
|
);
|
|
return { ...view, onSubmit };
|
|
}
|
|
|
|
function getSubmitButton(container: HTMLElement): HTMLButtonElement {
|
|
// Submit is always the last button in a composer's action cluster.
|
|
const buttons = container.querySelectorAll("button");
|
|
const button = buttons[buttons.length - 1];
|
|
if (!button) throw new Error("Expected submit button to render");
|
|
return button;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
uploadWithToast.mockReset();
|
|
localStorage.clear();
|
|
useCommentComposerStore.setState({ sticky: true });
|
|
});
|
|
|
|
describe("comment composers", () => {
|
|
it("renders the main comment composer without a manual expand control", () => {
|
|
const { container } = renderCommentInput();
|
|
|
|
expect(screen.getByPlaceholderText("Leave a comment...")).toBeInTheDocument();
|
|
expect(screen.getByRole("button", { name: "Attach file" })).toBeInTheDocument();
|
|
expect(container.querySelectorAll("button")).toHaveLength(2);
|
|
|
|
const shell = screen.getByTestId("drop-zone");
|
|
expect(shell.className).not.toMatch(/max-h-/);
|
|
expect(shell.className).not.toContain("h-[70vh]");
|
|
});
|
|
|
|
it("renders reply composer without a manual expand control", () => {
|
|
const { container } = renderReplyInput();
|
|
|
|
expect(screen.getByPlaceholderText("Leave a reply...")).toBeInTheDocument();
|
|
expect(screen.getByRole("button", { name: "Attach file" })).toBeInTheDocument();
|
|
expect(container.querySelectorAll("button")).toHaveLength(2);
|
|
|
|
const shell = screen.getByTestId("drop-zone");
|
|
expect(shell.className).not.toMatch(/max-h-/);
|
|
expect(shell.className).not.toContain("h-[60vh]");
|
|
});
|
|
|
|
it("lets default-size replies grow without a height cap", () => {
|
|
const { container } = renderReplyInput({ size: "default" });
|
|
|
|
expect(screen.getByPlaceholderText("Leave a reply...")).toBeInTheDocument();
|
|
expect(container.querySelectorAll("button")).toHaveLength(2);
|
|
|
|
const shell = screen.getByTestId("drop-zone");
|
|
expect(shell.className).not.toMatch(/max-h-/);
|
|
});
|
|
|
|
it("keeps main comment submission wired after removing expand", async () => {
|
|
const { container, onSubmit } = renderCommentInput();
|
|
|
|
fireEvent.change(screen.getByTestId("editor"), {
|
|
target: { value: "hello from composer" },
|
|
});
|
|
fireEvent.click(getSubmitButton(container));
|
|
|
|
await waitFor(() => {
|
|
expect(onSubmit).toHaveBeenCalledWith("hello from composer", undefined, undefined);
|
|
});
|
|
});
|
|
|
|
it("keeps reply submission wired after removing expand", async () => {
|
|
const { container, onSubmit } = renderReplyInput();
|
|
|
|
fireEvent.change(screen.getByTestId("editor"), {
|
|
target: { value: "thread reply" },
|
|
});
|
|
fireEvent.click(getSubmitButton(container));
|
|
|
|
await waitFor(() => {
|
|
expect(onSubmit).toHaveBeenCalledWith("thread reply", undefined, undefined);
|
|
});
|
|
});
|
|
|
|
it("locks the editor while the send is in flight, then clears on success", async () => {
|
|
let resolveSubmit: (ok: boolean) => void = () => {};
|
|
const onSubmit = vi.fn(
|
|
() => new Promise<boolean>((resolve) => { resolveSubmit = resolve; }),
|
|
);
|
|
const { container } = renderCommentInput(onSubmit);
|
|
|
|
fireEvent.change(screen.getByTestId("editor"), { target: { value: "sending" } });
|
|
fireEvent.click(getSubmitButton(container));
|
|
|
|
// In flight: text kept, editor wrapper locked (aria-busy), not cleared yet.
|
|
await waitFor(() =>
|
|
expect(screen.getByTestId("editor").closest("[aria-busy]")).toHaveAttribute(
|
|
"aria-busy",
|
|
"true",
|
|
),
|
|
);
|
|
expect(onSubmit).toHaveBeenCalledWith("sending", undefined, undefined);
|
|
|
|
resolveSubmit(true);
|
|
|
|
// Success: the composer clears (now empty → submit disabled, lock released).
|
|
await waitFor(() => expect(getSubmitButton(container)).toBeDisabled());
|
|
expect(screen.getByTestId("editor").closest("[aria-busy]")).toBeNull();
|
|
});
|
|
|
|
it("keeps the draft when the send fails (no optimistic clear)", async () => {
|
|
const onSubmit = vi.fn().mockResolvedValue(false);
|
|
const { container } = renderCommentInput(onSubmit);
|
|
|
|
fireEvent.change(screen.getByTestId("editor"), { target: { value: "will fail" } });
|
|
fireEvent.click(getSubmitButton(container));
|
|
|
|
await waitFor(() => expect(onSubmit).toHaveBeenCalled());
|
|
// Failed send must NOT clear — the box still has content, submit stays live.
|
|
await waitFor(() => expect(getSubmitButton(container)).not.toBeDisabled());
|
|
});
|
|
});
|
|
|
|
describe("sticky composer preference", () => {
|
|
it("caps the editor height while the sticky preference is on (default)", () => {
|
|
renderCommentInput();
|
|
|
|
// The height cap lives on the editor wrapper, not the card shell.
|
|
expect(screen.getByTestId("editor").parentElement?.className).toContain("max-h-[40vh]");
|
|
});
|
|
|
|
it("lets the editor grow when the preference is off", () => {
|
|
useCommentComposerStore.setState({ sticky: false });
|
|
renderCommentInput();
|
|
|
|
expect(screen.getByTestId("editor").parentElement?.className).not.toContain("max-h-[40vh]");
|
|
});
|
|
});
|