Files
multica/packages/views/issues/components/list-view.tsx
Naiyuan Qing ade6b34e5f MUL-3903: Extract shared issue surfaces (#4774)
* MUL-3903 refactor project issue surface state

Co-authored-by: multica-agent <github@multica.ai>

* Refactor project issue surface ownership

Co-authored-by: multica-agent <github@multica.ai>

* Extract shared issue surface entrypoints

Co-authored-by: multica-agent <github@multica.ai>

* Fix issue surface create defaults and selection reset

Co-authored-by: multica-agent <github@multica.ai>

* test(editor): add missing AbortSignal to suggestion items() calls

The suggestion items() contract gained a required signal param; the
mention/slash test call sites were never updated, breaking pnpm typecheck
for @multica/views.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(issues): server-side assignee_types filter on ListIssues

ListGroupedIssues has taken assignee_types since squads shipped, but
ListIssues never did — so the workspace Members/Agents tabs had to fetch
the unfiltered workspace list and post-filter loaded pages client-side,
which made column totals and load-more pagination reflect the unfiltered
counts.

Add the same parse + WHERE clause to ListIssues (count query shares the
WHERE, so totals agree), thread the param through the TS client, and
widen MyIssuesFilter so scoped list caches can carry it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(issues): route issue cache writes through a membership-aware coordinator

useUpdateIssue, useBatchUpdateIssues, and the WS issue:updated handler
each maintained their own similar-but-diverging patch/invalidate rules.
Consolidate them into cache-coordinator.ts (applyIssueChange /
rollbackIssueChange / invalidateIssueDerivatives) so local writes and
remote echoes follow one rules table by construction.

The coordinator is membership-aware via surface/membership.ts
(true | false | unknown against each list cache's own filter contract):

- a change that moves an issue off a filtered surface removes the card
  surgically (bucket total decremented) — fixes assignee changes leaving
  stale cards on My Assigned with no local safety net (previously only
  the WS echo recovered it), and replaces the blanket invalidate-myAll
  net for project moves (MUL-3669) with per-key precision
- possible entry into a loaded list marks that key stale — never
  hard-insert; page/slot is server knowledge
- stale keys flush on settle for mutations (a mid-flight refetch would
  stomp the optimistic state) and immediately for WS
- batch updates now patch detail + inbox like single updates; the
  off-screen bucket-count recovery previously exclusive to the WS path
  now covers local mutations too

Preserved invariants: synchronous optimistic patches (dnd-kit), MUL-3375
control-field stripping, and no refetch of surgically reconciled lists
(the drag-flicker fix).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(issues): resolve surfaces via core query plan/repository with window-keyed remount

Read-path convergence and the loading/empty semantics that fall out of
it:

- scope -> API params moves from scope.ts helpers into
  surface/query-plan.ts; workspace members/agents become server-filtered
  scoped plans (assignee_types) and the client postFilter machinery is
  deleted — tab counts and load-more are now exact
- query selection moves behind surface/repository.ts; the views data
  hook no longer branches on workspace-vs-scoped plumbing
- IssueSurfaceContent remounts on data-window change (wsId + scope):
  keepPreviousData placeholders keep sort/filter changes flicker-free
  within one window but must never let project A's (or workspace A's)
  cards impersonate B's with no loading state — cold window shows the
  skeleton, warm window hits cache instantly
- isEmpty is only asserted from full-window data; the gantt
  scheduled-only projection can't prove the window is empty, so GanttView's
  own "no scheduled issues" empty state renders instead of the generic
  create-issue one
- per-card project lookups hoist into a surface-level projectMap (drops
  a per-card useQuery), create-defaults typing tightens to
  IssueCreateDefaults

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* perf(issues): count-only arithmetic for off-window status/membership changes

An issue beyond a list's loaded page window used to force a full
first-page refetch just to fix two column counts. When the change is
CERTAIN (base entity known, membership definitive) the coordinator now
does the arithmetic locally:

- stayed a member + status changed: move one unit of total between the
  two buckets (loaded arrays untouched; hasMore stays consistent)
- left the list (reassigned / re-projected): old status bucket total -1
- member-to-member reassignment: counts unaffected, not even a stale key

Entering a list and any uncertainty (no base, unknown membership) still
refetch — the right page/slot is server knowledge. Branches on membership
OUTCOMES, not on which field changed, so future dimensions (team) join
automatically. Biggest win is the WS path: agents flipping off-screen
statuses no longer trigger refetch storms.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(issues): deferred view-refresh indicator during placeholder revalidation

Sort/date changes (and any grouped-board filter change) revalidate behind
the previous snapshot — correct, but on a slow network the click felt
dead: content stays put and isLoading never fires. Surface the state as
isRefreshing (isPlaceholderData of the active query) and render a shared
ViewRefreshIndicator in every issues header: a fixed-width slot (zero
layout shift) whose spinner fades in after 300ms, so sub-second responses
show nothing (NN/g) while slow ones get a working signal.

Bound to the revalidation STATE, not to any particular control — any
current or future server-side view change lights it automatically.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 14:11:10 +08:00

526 lines
16 KiB
TypeScript

"use client";
import { useState, useCallback, useMemo, useEffect, useRef } from "react";
import { ChevronRight, Plus } from "lucide-react";
import { Accordion } from "@base-ui/react/accordion";
import {
DndContext,
DragOverlay,
PointerSensor,
useDroppable,
useSensor,
useSensors,
type DragStartEvent,
type DragEndEvent,
type DragOverEvent,
} from "@dnd-kit/core";
import { SortableContext, verticalListSortingStrategy, arrayMove } from "@dnd-kit/sortable";
import { Tooltip, TooltipTrigger, TooltipContent } from "@multica/ui/components/ui/tooltip";
import { Button } from "@multica/ui/components/ui/button";
import type { Issue, IssueStatus, Project } from "@multica/core/types";
import { useLoadMoreByStatus } from "@multica/core/issues/mutations";
import type { IssueSortParam, MyIssuesFilter } from "@multica/core/issues/queries";
import { useViewStore } from "@multica/core/issues/stores/view-store-context";
import { StatusHeading } from "./status-heading";
import { ListRow, DraggableListRow, type ChildProgress } from "./list-row";
import { useDragSettle } from "./use-drag-settle";
import { InfiniteScrollSentinel } from "./infinite-scroll-sentinel";
import { useT } from "../../i18n";
import {
type DragMoveUpdates,
makeKanbanCollision,
statusGroupId,
buildColumns,
computePosition,
findColumn,
insertIdByPosition,
issueMatchesGroup,
getMoveUpdates,
} from "../utils/drag-utils";
import type { BoardColumnGroup } from "./board-column";
import { useIssueSurfaceSelection } from "../surface/selection-context";
import type { IssueCreateDefaults } from "../surface/types";
const EMPTY_PROGRESS_MAP = new Map<string, ChildProgress>();
const EMPTY_IDS: string[] = [];
function buildListGroups(visibleStatuses: IssueStatus[]): BoardColumnGroup[] {
return visibleStatuses.map((status) => ({
id: statusGroupId(status),
title: status,
status,
createData: { status },
}));
}
export function ListView({
issues,
visibleStatuses,
childProgressMap = EMPTY_PROGRESS_MAP,
projectMap,
myIssuesScope,
myIssuesFilter,
projectId,
onMoveIssue,
onCreateIssue,
sort,
}: {
issues: Issue[];
visibleStatuses: IssueStatus[];
childProgressMap?: Map<string, ChildProgress>;
projectMap?: Map<string, Project>;
myIssuesScope?: string;
myIssuesFilter?: MyIssuesFilter;
projectId?: string;
onMoveIssue?: (issueId: string, updates: DragMoveUpdates, onSettled?: () => void) => void;
onCreateIssue?: (defaults: IssueCreateDefaults) => void;
sort?: IssueSortParam;
}) {
const listCollapsedStatuses = useViewStore(
(s) => s.listCollapsedStatuses
);
const toggleListCollapsed = useViewStore(
(s) => s.toggleListCollapsed
);
const sortBy = useViewStore((s) => s.sortBy);
const { t } = useT("issues");
const sortFieldKey = sortBy === "created_at" ? "created" : sortBy;
const sortLabel = sortBy !== "position"
? t(($) => $.board.ordered_by, { field: t(($) => $.display[`sort_${sortFieldKey}` as keyof typeof $.display]) })
: null;
const expandedStatuses = useMemo(
() =>
visibleStatuses.filter(
(s) => !listCollapsedStatuses.includes(s)
),
[visibleStatuses, listCollapsedStatuses]
);
const myIssuesOpts = myIssuesScope
? { scope: myIssuesScope, filter: myIssuesFilter ?? {} }
: undefined;
const dragEnabled = !!onMoveIssue;
const groups = useMemo(
() => buildListGroups(visibleStatuses),
[visibleStatuses],
);
const groupIds = useMemo(
() => new Set(groups.map((g) => g.id)),
[groups],
);
const groupMap = useMemo(
() => new Map(groups.map((g) => [g.id, g])),
[groups],
);
// --- Drag state ---
const [activeIssue, setActiveIssue] = useState<Issue | null>(null);
// Shared drag/settle primitive (see use-drag-settle) — same machine as
// board-view, so the two surfaces can't drift apart.
const {
columns,
setColumns,
columnsRef,
isDraggingRef,
isSettlingRef,
recentlyMovedRef,
settleVersion,
beginSettle,
} = useDragSettle(() => buildColumns(issues, groups, "status"));
useEffect(() => {
if (!isDraggingRef.current && !isSettlingRef.current) {
setColumns(buildColumns(issues, groups, "status"));
}
}, [issues, groups, settleVersion, setColumns, isDraggingRef, isSettlingRef]);
const issueMap = useMemo(() => {
const map = new Map<string, Issue>();
for (const issue of issues) map.set(issue.id, issue);
return map;
}, [issues]);
const issueMapRef = useRef(issueMap);
if (!isDraggingRef.current && !isSettlingRef.current) {
issueMapRef.current = issueMap;
}
const collisionDetection = useMemo(
() => makeKanbanCollision(groupIds),
[groupIds],
);
const sensors = useSensors(
useSensor(PointerSensor, {
activationConstraint: { distance: 5 },
})
);
const handleDragStart = useCallback(
(event: DragStartEvent) => {
isDraggingRef.current = true;
const issue = issueMapRef.current.get(event.active.id as string) ?? null;
setActiveIssue(issue);
},
[isDraggingRef],
);
const handleDragOver = useCallback(
(event: DragOverEvent) => {
const { active, over } = event;
if (!over || recentlyMovedRef.current) return;
const activeId = active.id as string;
const overId = over.id as string;
setColumns((prev) => {
const activeCol = findColumn(prev, activeId, groupIds);
const overCol = findColumn(prev, overId, groupIds);
if (!activeCol || !overCol || activeCol === overCol) return prev;
if (sortBy !== "position") return prev;
recentlyMovedRef.current = true;
const oldIds = prev[activeCol]!.filter((id) => id !== activeId);
const newIds = [...prev[overCol]!];
const overIndex = newIds.indexOf(overId);
const insertIndex = overIndex >= 0 ? overIndex : newIds.length;
newIds.splice(insertIndex, 0, activeId);
return { ...prev, [activeCol]: oldIds, [overCol]: newIds };
});
},
[groupIds, sortBy, recentlyMovedRef, setColumns],
);
const handleDragEnd = useCallback(
(event: DragEndEvent) => {
const { active, over } = event;
isDraggingRef.current = false;
setActiveIssue(null);
const resetColumns = () =>
setColumns(buildColumns(issues, groups, "status"));
if (!over || !onMoveIssue) {
resetColumns();
return;
}
const activeId = active.id as string;
const overId = over.id as string;
const cols = columnsRef.current;
const activeCol = findColumn(cols, activeId, groupIds);
const overCol = findColumn(cols, overId, groupIds);
if (!activeCol || !overCol) {
resetColumns();
return;
}
let finalColumns = cols;
if (activeCol === overCol && sortBy === "position") {
const ids = cols[activeCol]!;
const oldIndex = ids.indexOf(activeId);
const newIndex = ids.indexOf(overId);
if (oldIndex !== -1 && newIndex !== -1 && oldIndex !== newIndex) {
const reordered = arrayMove(ids, oldIndex, newIndex);
finalColumns = { ...cols, [activeCol]: reordered };
setColumns(finalColumns);
}
}
const finalCol = sortBy === "position"
? findColumn(finalColumns, activeId, groupIds)
: overCol;
if (!finalCol) {
resetColumns();
return;
}
const finalGroup = groupMap.get(finalCol);
if (!finalGroup) {
resetColumns();
return;
}
const map = issueMapRef.current;
if (sortBy !== "position") {
const currentIssue = map.get(activeId);
if (!currentIssue || issueMatchesGroup(currentIssue, finalGroup)) {
resetColumns();
return;
}
// Optimistically move the row into the target group *now*. Without this
// the sortBy != "position" branch never touched local columns on drop,
// so the row sat in its origin group for the whole request and only
// jumped across when the mutation settled — the same "snaps back, then
// moves" glitch the board view had. Placement mirrors the cache
// (insertIdByPosition) so the settle rebuild is a visual no-op.
setColumns((prev) => {
const fromIds = (prev[activeCol] ?? []).filter((cid) => cid !== activeId);
const toIds = insertIdByPosition(
prev[finalCol] ?? [],
activeId,
currentIssue.position,
map,
);
return { ...prev, [activeCol]: fromIds, [finalCol]: toIds };
});
onMoveIssue(activeId, getMoveUpdates(finalGroup, currentIssue.position), beginSettle());
return;
}
const finalIds = finalColumns[finalCol]!;
const newPosition = computePosition(finalIds, activeId, map);
const currentIssue = map.get(activeId);
if (
currentIssue &&
issueMatchesGroup(currentIssue, finalGroup) &&
currentIssue.position === newPosition
) {
return;
}
// beginSettle() also bumps settleVersion on settle (board-view did, this
// branch did not) so a failed position move reverts instead of stranding
// the row at the drop target.
onMoveIssue(activeId, getMoveUpdates(finalGroup, newPosition), beginSettle());
},
[issues, groups, onMoveIssue, groupIds, groupMap, sortBy, beginSettle, setColumns, columnsRef, isDraggingRef],
);
const content = (
<Accordion.Root
multiple
className="space-y-1"
value={expandedStatuses}
onValueChange={(value: string[]) => {
if (isDraggingRef.current) return;
for (const status of visibleStatuses) {
const wasExpanded = expandedStatuses.includes(status);
const isExpanded = value.includes(status);
if (wasExpanded !== isExpanded) {
toggleListCollapsed(status as IssueStatus);
}
}
}}
>
{visibleStatuses.map((status) => {
const isExpanded = expandedStatuses.includes(status);
return (
<StatusAccordionItem
key={status}
status={status}
issueIds={columns[statusGroupId(status)] ?? EMPTY_IDS}
issueMap={issueMapRef.current}
childProgressMap={childProgressMap}
projectMap={projectMap}
myIssuesOpts={myIssuesOpts}
projectId={projectId}
onCreateIssue={onCreateIssue}
dragEnabled={dragEnabled}
isExpanded={isExpanded}
sortLabel={sortLabel}
sort={sort}
/>
);
})}
</Accordion.Root>
);
if (!dragEnabled) {
return (
<div className="flex-1 min-h-0 overflow-y-auto p-2 pt-0">
{content}
</div>
);
}
return (
<DndContext
sensors={sensors}
collisionDetection={collisionDetection}
onDragStart={handleDragStart}
onDragOver={handleDragOver}
onDragEnd={handleDragEnd}
>
<div className="flex-1 min-h-0 overflow-y-auto p-2 pt-0">
{content}
</div>
<DragOverlay dropAnimation={null}>
{activeIssue ? (
<div className="max-w-2xl rotate-1 cursor-grabbing opacity-90 shadow-lg shadow-black/10 rounded-md border border-border bg-card px-4 py-2">
<span className="text-xs text-muted-foreground mr-2">{activeIssue.identifier}</span>
<span className="text-sm">{activeIssue.title}</span>
</div>
) : null}
</DragOverlay>
</DndContext>
);
}
function StatusAccordionItem({
status,
issueIds,
issueMap,
childProgressMap,
projectMap,
myIssuesOpts,
projectId,
onCreateIssue,
dragEnabled,
isExpanded,
sortLabel,
sort,
}: {
status: IssueStatus;
issueIds: string[];
issueMap: Map<string, Issue>;
childProgressMap: Map<string, ChildProgress>;
projectMap?: Map<string, Project>;
myIssuesOpts?: { scope: string; filter: MyIssuesFilter };
projectId?: string;
onCreateIssue?: (defaults: IssueCreateDefaults) => void;
dragEnabled: boolean;
isExpanded: boolean;
sortLabel: string | null;
sort?: IssueSortParam;
}) {
const { t } = useT("issues");
const selection = useIssueSurfaceSelection();
const selectedIds = selection.selectedIds;
const select = selection.select;
const deselect = selection.deselect;
const { loadMore, hasMore, isLoading, total } = useLoadMoreByStatus(
status,
myIssuesOpts,
sort,
);
const issues = useMemo(
() => issueIds.flatMap((id) => {
const issue = issueMap.get(id);
return issue ? [issue] : [];
}),
[issueIds, issueMap],
);
const selectedCount = issueIds.filter((id) => selectedIds.has(id)).length;
const allSelected = issues.length > 0 && selectedCount === issues.length;
const someSelected = selectedCount > 0;
const { setNodeRef: setDroppableRef, isOver } = useDroppable({
id: statusGroupId(status),
disabled: !dragEnabled,
});
const disableSorting = !!sortLabel;
return (
<Accordion.Item value={status} ref={dragEnabled ? setDroppableRef : undefined}>
<Accordion.Header
className={`group/header sticky top-0 z-10 flex h-10 items-center rounded-lg bg-muted transition-colors hover:bg-accent ${
isOver && !isExpanded
? "ring-2 ring-brand/25 bg-accent/15"
: ""
}`}
>
<div className="pl-3 flex items-center">
<input
type="checkbox"
checked={allSelected}
ref={(el) => {
if (el) el.indeterminate = someSelected && !allSelected;
}}
onChange={() => {
if (allSelected) {
deselect(issueIds);
} else {
select(issueIds);
}
}}
className="cursor-pointer accent-primary"
/>
</div>
<Accordion.Trigger className="group/trigger flex flex-1 items-center gap-2 px-2 h-full text-left outline-none cursor-pointer">
<ChevronRight className="size-3.5 shrink-0 text-muted-foreground transition-transform group-aria-expanded/trigger:rotate-90" />
<StatusHeading status={status} count={total} />
</Accordion.Trigger>
{onCreateIssue && (
<div className="pr-2">
<Tooltip>
<TooltipTrigger
render={
<Button
variant="ghost"
size="icon-sm"
className="rounded-full text-muted-foreground opacity-0 group-hover/header:opacity-100 transition-opacity"
onClick={() => {
const defaults = {
status,
...(projectId ? { project_id: projectId } : {}),
};
onCreateIssue(defaults);
}}
/>
}
>
<Plus className="size-3.5" />
</TooltipTrigger>
<TooltipContent>{t(($) => $.list.add_issue_tooltip)}</TooltipContent>
</Tooltip>
</div>
)}
</Accordion.Header>
<Accordion.Panel>
{issues.length > 0 ? (
dragEnabled ? (
<SortableContext items={issueIds} strategy={verticalListSortingStrategy}>
{issues.map((issue) => (
<DraggableListRow
key={issue.id}
issue={issue}
childProgress={childProgressMap.get(issue.id)}
project={
issue.project_id ? projectMap?.get(issue.project_id) : undefined
}
disableSorting={disableSorting}
/>
))}
{hasMore && (
<InfiniteScrollSentinel onVisible={loadMore} loading={isLoading} />
)}
</SortableContext>
) : (
<>
{issues.map((issue) => (
<ListRow
key={issue.id}
issue={issue}
childProgress={childProgressMap.get(issue.id)}
project={
issue.project_id ? projectMap?.get(issue.project_id) : undefined
}
/>
))}
{hasMore && (
<InfiniteScrollSentinel onVisible={loadMore} loading={isLoading} />
)}
</>
)
) : (
<p className="py-6 text-center text-xs text-muted-foreground">
{t(($) => $.list.empty_status)}
</p>
)}
</Accordion.Panel>
</Accordion.Item>
);
}