mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-03 11:10:23 +02:00
* MUL-3903 refactor project issue surface state Co-authored-by: multica-agent <github@multica.ai> * Refactor project issue surface ownership Co-authored-by: multica-agent <github@multica.ai> * Extract shared issue surface entrypoints Co-authored-by: multica-agent <github@multica.ai> * Fix issue surface create defaults and selection reset Co-authored-by: multica-agent <github@multica.ai> * test(editor): add missing AbortSignal to suggestion items() calls The suggestion items() contract gained a required signal param; the mention/slash test call sites were never updated, breaking pnpm typecheck for @multica/views. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): server-side assignee_types filter on ListIssues ListGroupedIssues has taken assignee_types since squads shipped, but ListIssues never did — so the workspace Members/Agents tabs had to fetch the unfiltered workspace list and post-filter loaded pages client-side, which made column totals and load-more pagination reflect the unfiltered counts. Add the same parse + WHERE clause to ListIssues (count query shares the WHERE, so totals agree), thread the param through the TS client, and widen MyIssuesFilter so scoped list caches can carry it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): route issue cache writes through a membership-aware coordinator useUpdateIssue, useBatchUpdateIssues, and the WS issue:updated handler each maintained their own similar-but-diverging patch/invalidate rules. Consolidate them into cache-coordinator.ts (applyIssueChange / rollbackIssueChange / invalidateIssueDerivatives) so local writes and remote echoes follow one rules table by construction. The coordinator is membership-aware via surface/membership.ts (true | false | unknown against each list cache's own filter contract): - a change that moves an issue off a filtered surface removes the card surgically (bucket total decremented) — fixes assignee changes leaving stale cards on My Assigned with no local safety net (previously only the WS echo recovered it), and replaces the blanket invalidate-myAll net for project moves (MUL-3669) with per-key precision - possible entry into a loaded list marks that key stale — never hard-insert; page/slot is server knowledge - stale keys flush on settle for mutations (a mid-flight refetch would stomp the optimistic state) and immediately for WS - batch updates now patch detail + inbox like single updates; the off-screen bucket-count recovery previously exclusive to the WS path now covers local mutations too Preserved invariants: synchronous optimistic patches (dnd-kit), MUL-3375 control-field stripping, and no refetch of surgically reconciled lists (the drag-flicker fix). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(issues): resolve surfaces via core query plan/repository with window-keyed remount Read-path convergence and the loading/empty semantics that fall out of it: - scope -> API params moves from scope.ts helpers into surface/query-plan.ts; workspace members/agents become server-filtered scoped plans (assignee_types) and the client postFilter machinery is deleted — tab counts and load-more are now exact - query selection moves behind surface/repository.ts; the views data hook no longer branches on workspace-vs-scoped plumbing - IssueSurfaceContent remounts on data-window change (wsId + scope): keepPreviousData placeholders keep sort/filter changes flicker-free within one window but must never let project A's (or workspace A's) cards impersonate B's with no loading state — cold window shows the skeleton, warm window hits cache instantly - isEmpty is only asserted from full-window data; the gantt scheduled-only projection can't prove the window is empty, so GanttView's own "no scheduled issues" empty state renders instead of the generic create-issue one - per-card project lookups hoist into a surface-level projectMap (drops a per-card useQuery), create-defaults typing tightens to IssueCreateDefaults Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * perf(issues): count-only arithmetic for off-window status/membership changes An issue beyond a list's loaded page window used to force a full first-page refetch just to fix two column counts. When the change is CERTAIN (base entity known, membership definitive) the coordinator now does the arithmetic locally: - stayed a member + status changed: move one unit of total between the two buckets (loaded arrays untouched; hasMore stays consistent) - left the list (reassigned / re-projected): old status bucket total -1 - member-to-member reassignment: counts unaffected, not even a stale key Entering a list and any uncertainty (no base, unknown membership) still refetch — the right page/slot is server knowledge. Branches on membership OUTCOMES, not on which field changed, so future dimensions (team) join automatically. Biggest win is the WS path: agents flipping off-screen statuses no longer trigger refetch storms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): deferred view-refresh indicator during placeholder revalidation Sort/date changes (and any grouped-board filter change) revalidate behind the previous snapshot — correct, but on a slow network the click felt dead: content stays put and isLoading never fires. Surface the state as isRefreshing (isPlaceholderData of the active query) and render a shared ViewRefreshIndicator in every issues header: a fixed-width slot (zero layout shift) whose spinner fades in after 300ms, so sub-second responses show nothing (NN/g) while slow ones get a working signal. Bound to the revalidation STATE, not to any particular control — any current or future server-side view change lights it automatically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: multica-agent <github@multica.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
130 lines
3.3 KiB
TypeScript
130 lines
3.3 KiB
TypeScript
"use client";
|
|
|
|
import { useCallback, useMemo } from "react";
|
|
import { toast } from "sonner";
|
|
import type { UpdateIssueRequest } from "@multica/core/types";
|
|
import {
|
|
useBatchDeleteIssues,
|
|
useBatchUpdateIssues,
|
|
useUpdateIssue,
|
|
} from "@multica/core/issues/mutations";
|
|
import { useModalStore } from "@multica/core/modals";
|
|
import {
|
|
type IssueSurfaceActions,
|
|
type IssueSurfaceMutationOptions,
|
|
} from "./actions-context";
|
|
import type { IssueCreateDefaults } from "./types";
|
|
import { useT } from "../../i18n";
|
|
|
|
export type MoveIssueUpdates = Pick<
|
|
UpdateIssueRequest,
|
|
| "status"
|
|
| "assignee_type"
|
|
| "assignee_id"
|
|
| "position"
|
|
| "parent_issue_id"
|
|
| "project_id"
|
|
>;
|
|
|
|
export interface IssueSurfaceActionController {
|
|
actions: IssueSurfaceActions;
|
|
openCreateIssue: (defaults?: IssueCreateDefaults) => void;
|
|
moveIssue: (
|
|
issueId: string,
|
|
updates: MoveIssueUpdates,
|
|
onSettled?: () => void,
|
|
) => void;
|
|
}
|
|
|
|
export function useIssueSurfaceActions({
|
|
createDefaults,
|
|
}: {
|
|
createDefaults: IssueCreateDefaults;
|
|
}): IssueSurfaceActionController {
|
|
const { t } = useT("projects");
|
|
const updateIssueMutation = useUpdateIssue();
|
|
const batchUpdateMutation = useBatchUpdateIssues();
|
|
const batchDeleteMutation = useBatchDeleteIssues();
|
|
|
|
const updateIssue = useCallback(
|
|
(
|
|
issueId: string,
|
|
updates: Partial<UpdateIssueRequest>,
|
|
options?: IssueSurfaceMutationOptions,
|
|
) => {
|
|
updateIssueMutation.mutate(
|
|
{ id: issueId, ...updates },
|
|
{
|
|
onSuccess: () => options?.onSuccess?.(),
|
|
onError: (err) => {
|
|
toast.error(
|
|
err instanceof Error && err.message
|
|
? err.message
|
|
: (options?.errorMessage ??
|
|
t(($) => $.detail.toast_move_issue_failed)),
|
|
);
|
|
options?.onError?.(err);
|
|
},
|
|
onSettled: () => options?.onSettled?.(),
|
|
},
|
|
);
|
|
},
|
|
[t, updateIssueMutation],
|
|
);
|
|
|
|
const moveIssue = useCallback(
|
|
(
|
|
issueId: string,
|
|
updates: MoveIssueUpdates,
|
|
onSettled?: () => void,
|
|
) => {
|
|
updateIssue(issueId, updates, {
|
|
errorMessage: t(($) => $.detail.toast_move_issue_failed),
|
|
onSettled,
|
|
});
|
|
},
|
|
[t, updateIssue],
|
|
);
|
|
|
|
const openCreateIssue = useCallback(
|
|
(defaults?: IssueCreateDefaults) => {
|
|
useModalStore
|
|
.getState()
|
|
.open("create-issue", { ...createDefaults, ...defaults });
|
|
},
|
|
[createDefaults],
|
|
);
|
|
|
|
const actions = useMemo<IssueSurfaceActions>(
|
|
() => ({
|
|
isPending:
|
|
updateIssueMutation.isPending ||
|
|
batchUpdateMutation.isPending ||
|
|
batchDeleteMutation.isPending,
|
|
createIssue: openCreateIssue,
|
|
updateIssue,
|
|
moveIssue: (issueId, updates, options) =>
|
|
updateIssue(issueId, updates, {
|
|
errorMessage: t(($) => $.detail.toast_move_issue_failed),
|
|
...options,
|
|
}),
|
|
batchUpdate: async (issueIds, updates) => {
|
|
await batchUpdateMutation.mutateAsync({ ids: issueIds, updates });
|
|
},
|
|
batchDelete: async (issueIds) => {
|
|
await batchDeleteMutation.mutateAsync(issueIds);
|
|
},
|
|
}),
|
|
[
|
|
batchDeleteMutation,
|
|
batchUpdateMutation,
|
|
openCreateIssue,
|
|
t,
|
|
updateIssue,
|
|
updateIssueMutation.isPending,
|
|
],
|
|
);
|
|
|
|
return { actions, openCreateIssue, moveIssue };
|
|
}
|