mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-03 11:10:23 +02:00
* feat(chat): support images/files in agent chat replies (MUL-4287) Agents can now attach images/files to their chat replies, matching how comment attachments already work. The write-side gap was that the assistant chat_message is synthesized server-side from the completion callback's text output and never bound any attachments. Backend: - migration 150: nullable attachment.task_id (+ partial index), the transient handle that ties an agent's in-run upload to the reply it produces. - POST /api/upload-file accepts task_id: gated to the task's own agent, in this workspace, on a chat task; tags the row with task_id + chat_session_id. - CompleteTask (chat branch) binds the task's still-unclaimed attachments to the assistant message via BindChatAttachmentsToMessage (rejects rows already owned by an issue/comment/chat_message). An empty-output reply that produced files still creates a message so the images have an owner. FailTask binds nothing. CLI: - `multica attachment upload <path>` uploads a file for the current chat task (task from MULTICA_TASK_ID or --task) and prints id / markdown_url / a ready-to-paste markdown snippet. Prompt: - web/mobile chat prompt tells the agent how to attach a file to its reply. Mobile: - chat:done handler now always invalidates the messages list so attachments (absent from the event payload) refetch; mirrors web's self-heal. - chat bubbles render standalone attachment cards via the existing CommentAttachmentList (dedup vs inline references), matching web. Web/desktop needed no change — they already render message.attachments inline and via AttachmentList, and self-heal on chat:done. Tests: upload permission/isolation, bind-on-complete, empty-output+attachments, FailTask no-bind, null task_id untouched, already-owned not stolen, CLI output contract, mobile refetch-on-done. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(chat): address review blockers on chat reply attachments (MUL-4287) Two final-review blockers on PR #5164: 1. Mobile inline dedup only checked raw `url`, so an attachment referenced inline via `markdown_url` (exactly what the CLI snippet emits) rendered twice — once inline, once as a standalone card. Reuse the core `contentReferencesAttachment` helper so dedup covers every real reference form (stable /api/attachments/<id>/download path, url, download_url, markdown_url), matching web's AttachmentList. Extracted the filter into a pure `lib/attachment-dedup.ts` so it is unit-testable, and added a regression test covering `content` containing `attachment.markdown_url` (plus the other URL forms and same-identity sibling dedup). 2. CLI `attachment upload` emitted `![...]` image markdown for every file, producing a broken-image snippet for non-images. Emit image markdown only for image/* content types and a plain link otherwise, with a CLI contract test for both. Approved scope otherwise unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(chat): renumber attachment_task_id migration 150 -> 157 after main merge (MUL-4287) Merged latest main; main renumbered its migrations and now occupies 150-156, so 150_attachment_task_id collided with 150_agent_task_coalesced_comments and would fail TestMigrationNumericPrefixesStayUniqueAfterLegacySet. Renamed to the next unique prefix (157). No content change; migrate up applies cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(chat): render agent-produced files as attachment cards, not raw links The chat upload command handed the agent a bare `[name](url)` markdown snippet. Pasted mid-sentence it renders as a plain text link (not a card), and the referenced URL hides the auto-bound standalone attachment — so a file the agent produced could end up showing as nothing. Return the block-level `!file[name](url)` card syntax instead (images keep `` inline), and markdown-escape the filename so names with `[`/`]` don't truncate the label. The prompt and CLI help now state the file auto-attaches below the reply and the snippet is optional, only for placement. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chat): soften message-list scroll fade (32px → 16px) The 32px edge fade washed out full-bleed content (HTML / image previews) at the list edges. Halve the fade distance so it barely grazes previews while still hinting at more content above/below. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chat): renumber attachment_task_id migration 157 -> 158 main landed 157_agent_task_delivered_comments while this branch was open, colliding on prefix 157 and failing TestMigrationNumericPrefixesStayUniqueAfterLegacySet. Bump this PR's migration to the next free prefix (158). Rename only; the migration body (nullable attachment.task_id + partial index) is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chat): pin attachment upload to the token's task; build index concurrently Two code-review findings on the chat-attachment path (MUL-4287): - Isolation/privacy: POST /api/upload-file only checked the form task_id belonged to the caller's agent, not that it matched the task-scoped token's authoritative X-Task-ID. A run authorized for task A could tag an attachment onto task B (another chat task of the same agent, possibly another user's session), binding it into that reply on completion. Require the form task_id to equal the server-set X-Task-ID; add a same-agent/other-task 403 regression. - Migration: split the task_id lookup index into its own migration (159) built with CREATE INDEX CONCURRENTLY (repo convention) — it cannot share a multi-command file with the ADD COLUMN in 158. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chat): enforce task-token source on attachment upload; drop transient task_id FK (MUL-4287) Addresses the two remaining Preflight BLOCKERs on PR #5164. Security (file.go): the task_id upload path compared the form task_id to X-Task-ID but did not require X-Actor-Source=task_token. A normal JWT/mul_ PAT leaves that header empty and the middleware does NOT strip a client-forged X-Task-ID; resolveActor's fallback accepts a valid X-Agent-ID+X-Task-ID pair. So a member who learned a task ID could forge both and inject an attachment onto another chat task's assistant reply (cross-session/privacy leak). Now the branch requires X-Actor-Source=task_token first (mirrors chat_history.go's load-bearing boundary), then pins to the middleware-injected X-Task-ID. Tests now go through the real task-token headers and add a forged-JWT-403 regression. Migration (158): task_id is a transient binding handle (written once at upload against an already-validated task, read only during that task's own completion; durable owner is chat_message_id). There is no app-layer path that hard-deletes agent_task_queue rows, and orphan uploads are already reaped by attachment.chat_session_id's ON DELETE CASCADE — so an FK here would only add a cascade dependency the app never relies on plus write overhead on the hot attachment table. Drop the FK; task_id is now a plain UUID column. Added a regression test that an unbound task-tagged upload is reaped on chat_session delete. Index (159, CONCURRENTLY) unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(mobile): align !file card preprocess with web parser + CLI escaped labels (MUL-4287) Howard final-review blocker: mobile's `!file[...]` preprocess didn't keep up with the CLI's file-card output, so agent-produced non-image files rendered nowhere on mobile. - `FILE_LINE_RE` used `[^\]]+` for the label, so the CLI's escaped-bracket output `!file[a\]b.pdf](url)` (cmd_attachment.go escapeMarkdownLabel) never matched — the line stayed literal AND `standaloneAttachments` still hid the fallback card (the URL is in `content`), so the file showed nowhere. - Align the matcher with web's `packages/ui/markdown/file-cards.ts`: label allows backslash-escaped metacharacters (ReDoS-safe class), and the URL is restricted to the same allowlist (site-relative /uploads + /api/attachments/ <UUID>/download, plus absolute http(s)); disallowed schemes stay plain text. - Unescape the label to the real filename, then re-escape only the chars that would break a markdown LINK label (mobile emits `[📎 name](url)`, re-parsed by the renderer — unlike web's HTML data-filename), so a raw `]` never truncates the link text. No dedup change: once the inline `!file` renders, hiding the standalone card is correct. Added focused unit tests covering the escaped-label case, parens/ backslash unescape, the site-relative URL form, and disallowed-scheme rejection. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
182 lines
5.3 KiB
Go
182 lines
5.3 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/multica-ai/multica/server/internal/cli"
|
|
)
|
|
|
|
var attachmentCmd = &cobra.Command{
|
|
Use: "attachment",
|
|
Short: "Work with attachments",
|
|
}
|
|
|
|
var attachmentDownloadCmd = &cobra.Command{
|
|
Use: "download <attachment-id>",
|
|
Short: "Download an attachment to a local file",
|
|
Long: "Download an attachment by its ID to a local file.",
|
|
Example: ` # Download an image attachment to the current directory
|
|
$ multica attachment download abc123
|
|
|
|
# Download to a specific directory
|
|
$ multica attachment download abc123 -o /tmp/images`,
|
|
Args: exactArgs(1),
|
|
RunE: runAttachmentDownload,
|
|
}
|
|
|
|
var attachmentUploadCmd = &cobra.Command{
|
|
Use: "upload <path>",
|
|
Short: "Upload a file to attach to your chat reply",
|
|
Long: `Upload a local file so it is attached to the reply of the current chat task.
|
|
|
|
Intended for agents running inside a chat task: the file is tagged with the
|
|
task and, when the task completes, the server binds it to the assistant reply
|
|
it produces — it appears as an attachment card below your reply even if you
|
|
paste nothing. The command also returns a markdown snippet you may paste on its
|
|
own line to place the item: files use !file[name](url) (a card), images use
|
|
 (inline).
|
|
|
|
The task id is read from MULTICA_TASK_ID (set by the daemon inside a task);
|
|
override it with --task when needed.`,
|
|
Example: ` # Attach an image to the current chat reply
|
|
$ multica attachment upload ./chart.png`,
|
|
Args: exactArgs(1),
|
|
RunE: runAttachmentUpload,
|
|
}
|
|
|
|
func init() {
|
|
attachmentCmd.AddCommand(attachmentDownloadCmd)
|
|
attachmentCmd.AddCommand(attachmentUploadCmd)
|
|
|
|
attachmentDownloadCmd.Flags().StringP("output-dir", "o", ".", "Directory to save the downloaded file")
|
|
attachmentUploadCmd.Flags().String("task", "", "Chat task id to attach to (defaults to MULTICA_TASK_ID)")
|
|
}
|
|
|
|
func runAttachmentUpload(cmd *cobra.Command, args []string) error {
|
|
client, err := newAPIClient(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
taskID, _ := cmd.Flags().GetString("task")
|
|
if taskID == "" {
|
|
taskID = client.TaskID
|
|
}
|
|
if taskID == "" {
|
|
return fmt.Errorf("no chat task in context: run inside a chat task (MULTICA_TASK_ID set) or pass --task <id>")
|
|
}
|
|
|
|
path := args[0]
|
|
if isHTTPURL(path) {
|
|
return fmt.Errorf("upload accepts a local file path, not a URL: %s", path)
|
|
}
|
|
data, err := os.ReadFile(path)
|
|
if err != nil {
|
|
return fmt.Errorf("read file %s: %w", path, err)
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), cli.AtLeastAPITimeout(60*time.Second))
|
|
defer cancel()
|
|
|
|
att, err := client.UploadChatAttachment(ctx, data, path, taskID)
|
|
if err != nil {
|
|
return fmt.Errorf("upload attachment: %w", err)
|
|
}
|
|
|
|
filename := filepath.Base(path)
|
|
// Escape markdown label metacharacters in the filename so a name like
|
|
// `report[v2].pdf` does not truncate the snippet's label. Files render as a
|
|
// block-level attachment card via `!file[...]( )`; images render inline via
|
|
// ``.
|
|
label := escapeMarkdownLabel(filename)
|
|
markdown := fmt.Sprintf("!file[%s](%s)", label, att.MarkdownURL)
|
|
if strings.HasPrefix(att.ContentType, "image/") {
|
|
markdown = fmt.Sprintf("", label, att.MarkdownURL)
|
|
}
|
|
fmt.Fprintln(os.Stderr, "Uploaded:", filename)
|
|
|
|
return cli.PrintJSON(os.Stdout, map[string]any{
|
|
"id": att.ID,
|
|
"filename": filename,
|
|
"markdown_url": att.MarkdownURL,
|
|
"markdown": markdown,
|
|
})
|
|
}
|
|
|
|
// escapeMarkdownLabel escapes the metacharacters a markdown link/image label
|
|
// may not contain unescaped ([ ] ( ) and backslash), so a filename like
|
|
// `report[v2].pdf` stays a single valid label instead of truncating the
|
|
// snippet. Kept in sync with the renderers' unescape set
|
|
// (packages/ui/markdown/file-cards.ts).
|
|
func escapeMarkdownLabel(s string) string {
|
|
return strings.NewReplacer(
|
|
`\`, `\\`,
|
|
`[`, `\[`,
|
|
`]`, `\]`,
|
|
`(`, `\(`,
|
|
`)`, `\)`,
|
|
).Replace(s)
|
|
}
|
|
|
|
func runAttachmentDownload(cmd *cobra.Command, args []string) error {
|
|
client, err := newAPIClient(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), cli.AtLeastAPITimeout(60*time.Second))
|
|
defer cancel()
|
|
|
|
// Fetch attachment metadata (includes signed download_url).
|
|
var att map[string]any
|
|
if err := client.GetJSON(ctx, "/api/attachments/"+args[0], &att); err != nil {
|
|
return fmt.Errorf("get attachment: %w", err)
|
|
}
|
|
|
|
downloadURL := strVal(att, "download_url")
|
|
if downloadURL == "" {
|
|
return fmt.Errorf("attachment has no download URL")
|
|
}
|
|
|
|
filename := filepath.Base(strVal(att, "filename"))
|
|
if filename == "" || filename == "." {
|
|
filename = args[0]
|
|
}
|
|
|
|
// Download the file content.
|
|
data, err := client.DownloadFile(ctx, downloadURL)
|
|
if err != nil {
|
|
return fmt.Errorf("download file: %w", err)
|
|
}
|
|
|
|
// Write to the output directory.
|
|
outputDir, _ := cmd.Flags().GetString("output-dir")
|
|
destPath := filepath.Join(outputDir, filename)
|
|
|
|
if err := os.WriteFile(destPath, data, 0o644); err != nil {
|
|
return fmt.Errorf("write file: %w", err)
|
|
}
|
|
|
|
// Print the absolute path so agents can reference the file.
|
|
abs, err := filepath.Abs(destPath)
|
|
if err != nil {
|
|
abs = destPath
|
|
}
|
|
fmt.Fprintln(os.Stderr, "Downloaded:", abs)
|
|
|
|
// Also print as JSON for --output json compatibility.
|
|
return cli.PrintJSON(os.Stdout, map[string]any{
|
|
"id": strVal(att, "id"),
|
|
"filename": filename,
|
|
"path": abs,
|
|
"size": strVal(att, "size_bytes"),
|
|
})
|
|
}
|