mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-02 18:13:27 +02:00
* refactor(ui): converge ActorAvatar size to semantic tiers (MUL-4277) Replace the free-form numeric `size` on ActorAvatar with a constrained `AvatarSize` union (xs/sm/md/lg/xl/2xl) so avatar dimensions are chosen by role instead of ad-hoc pixels. This eliminates the magic-number drift where the same role rendered at different sizes across pages. - Add `@multica/ui/lib/avatar-size` (AvatarSize union + AVATAR_SIZE_PX map + default tier). - Base `ActorAvatar` (packages/ui) and business `ActorAvatar`/`AgentStatusDot` (packages/views) now take `AvatarSize`; internal font/icon math and the presence-dot threshold read px from the map. - Migrate all web/desktop call sites (packages/ui + packages/views) from numeric sizes to tiers using the role table (12,14->xs 16,18,20->sm 22,24,28->md 30,32,34->lg 40,44->xl 56,64->2xl). - Token-ise the derived consumers `AgentAvatarStack` and `IssueAgentActivityIndicator` (px looked up internally for overlap/+N math). Out of scope (per plan): ui/avatar.tsx primitive, account-tab/AvatarPicker, mobile, and component-name disambiguation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(ui): unify all avatars and the upload cropper to round (MUL-4277, MUL-4184) main's avatar-shape decision rendered non-human actors (agent, squad, system) and the workspace logo as rounded squares, and the upload cropper mirrored that with a square crop window. Per the updated decision (avatars_and_cropper_round_required), every avatar and the crop UI are now circular; the square path is removed rather than left as dead config. - Base ActorAvatar: always rounded-full (drop the isHuman/rounded-md split). - avatar-crop-dialog: remove the AvatarCropShape/square path; crop window is always cropShape="round". - avatar-upload-control: drop VARIANT_SHAPE; the control is always round and no longer threads a shape to the dialog (variant still drives the fallback). - Strip rounded-md/rounded-none square overrides from agent/squad/member ActorAvatar call sites; round the read-only agent/squad static wrappers. - WorkspaceAvatar: round the org logo so it matches the (now round) workspace upload/crop and the shared avatar shape. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(ui): make round avatar shape a hard invariant (MUL-4277) Close the two remaining square squad-avatar paths flagged in review and prevent call sites from re-squaring the avatar: - base ActorAvatar: keep `rounded-full` as the last class in cn() so a call-site `className` can no longer override the circle. - SquadHeaderAvatar: drop `className="rounded"` (was overriding the base circle into a small rounded square). - SquadsPage no-avatar fallback: route through the shared ActorAvatarBase (`isSquad size="lg"`) instead of a hand-written rounded-md tile, so the fallback matches the image path — one shape source of truth. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(views): round the agent/squad avatar loading skeletons (MUL-4277) The avatar placeholder skeletons on the agent/squad list, detail, and profile-card loading states were still rounded squares (rounded-md/lg) from the pre-round era, so the avatar visibly popped from square to circle on load — inconsistent with the round avatars and with the member/inbox/issue skeletons that already use rounded-full. Round all five: agents-page, agent-detail-page, squads-page, squad-detail-page, squad-profile-card. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
79 lines
2.1 KiB
TypeScript
79 lines
2.1 KiB
TypeScript
"use client";
|
|
|
|
import { useState, useEffect } from "react";
|
|
import { Bot, Users } from "lucide-react";
|
|
import { cn } from "@multica/ui/lib/utils";
|
|
import {
|
|
AVATAR_SIZE_PX,
|
|
DEFAULT_AVATAR_SIZE,
|
|
type AvatarSize,
|
|
} from "@multica/ui/lib/avatar-size";
|
|
import { MulticaIcon } from "./multica-icon";
|
|
|
|
interface ActorAvatarProps {
|
|
name: string;
|
|
initials: string;
|
|
avatarUrl?: string | null;
|
|
isAgent?: boolean;
|
|
isSystem?: boolean;
|
|
isSquad?: boolean;
|
|
size?: AvatarSize;
|
|
className?: string;
|
|
}
|
|
|
|
function ActorAvatar({
|
|
name,
|
|
initials,
|
|
avatarUrl,
|
|
isAgent,
|
|
isSystem,
|
|
isSquad,
|
|
size = DEFAULT_AVATAR_SIZE,
|
|
className,
|
|
}: ActorAvatarProps) {
|
|
const [imgError, setImgError] = useState(false);
|
|
const px = AVATAR_SIZE_PX[size];
|
|
|
|
useEffect(() => {
|
|
setImgError(false);
|
|
}, [avatarUrl]);
|
|
|
|
// Every actor — member, agent, squad, or system — renders as a circle. This
|
|
// is the single source of truth for avatar shape; the upload editors mirror
|
|
// it (packages/views/common/avatar-upload-control.tsx).
|
|
return (
|
|
<div
|
|
data-slot="avatar"
|
|
className={cn(
|
|
"inline-flex shrink-0 items-center justify-center font-medium overflow-hidden",
|
|
(!avatarUrl || imgError) && "bg-muted text-muted-foreground",
|
|
className,
|
|
// rounded-full stays last so a call-site `className` can never override
|
|
// the circle — avatar shape is a hard invariant, not a per-site choice.
|
|
"rounded-full"
|
|
)}
|
|
style={{ width: px, height: px, fontSize: px * 0.45 }}
|
|
title={name}
|
|
>
|
|
{avatarUrl && !imgError ? (
|
|
<img
|
|
src={avatarUrl}
|
|
alt={name}
|
|
className="h-full w-full object-cover"
|
|
onError={() => setImgError(true)}
|
|
/>
|
|
) : isSystem ? (
|
|
<MulticaIcon noSpin style={{ width: px * 0.55, height: px * 0.55 }} />
|
|
) : isAgent ? (
|
|
<Bot style={{ width: px * 0.55, height: px * 0.55 }} />
|
|
) : isSquad ? (
|
|
<Users style={{ width: px * 0.55, height: px * 0.55 }} />
|
|
) : (
|
|
initials
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export { ActorAvatar, type ActorAvatarProps };
|