Files
multica/packages/views/autopilots/components/subscriber-multi-select.tsx
Jiayuan Zhang 7803a5b9ea feat(ui): establish a role-named type scale and migrate ad-hoc font sizes (MUL-5451) (#6136)
tokens.css defined colours, radii and font families but not a single --text-*
step, so font sizes had no baseline to align to and grew wherever they were
needed: 51 distinct sizes across web + desktop, 370 written as arbitrary
values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px).
text-xs and text-sm carried nearly all UI text while the range between them —
11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not
come from having more sizes; past a handful, each extra size makes the
hierarchy blurrier.

Add ten role-named steps, each with its own line-height so leading cannot
fragment the way size did, and move every product-UI call site onto them.
Steps are named for what the text is for, not for a t-shirt size, because
that is what keeps the scale from drifting again.

Six steps deliberately keep the exact size/line-height pairs of the Tailwind
defaults they replace, so the ~1,900-call-site rename moves nothing on screen.
The visible changes are confined to former arbitrary values snapping to a step:
8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30
(text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small
buttons and toggles. Half-pixel sizes are gone.

This supersedes #6108, which was reverted by #6116 because the sidebar group
labels rendered at the inherited 16px. The cause was not the scale but cn():
`text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a
table listing only the default sizes, so it filed every role step under
text-colour and dropped whichever of `text-caption` /
`text-sidebar-foreground/70` came first. Registering the steps as a font-size
class group restores the real conflict groups — size beats size, colour beats
colour, the two coexist — and a test pins the list against the scale, since
the failure is silent in source.

Hand-written CSS is covered too. The transcript kept a 12.5px body long after
every Tailwind call site was on the scale, so the "no half-pixel sizes" claim
was true of the classes and false of the product; the editor's prose, code and
mermaid ramps had the same blind spot, and seven of their eight values already
equalled a step exactly. All now reference var(--text-*). The guard test reads
raw `font-size:` declarations as well as class names, exempting only the 16px
iOS input-zoom workaround in base.css and the landing pages' marketing ramp.

apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system)
keep Tailwind's default scale and are untouched. Landing display type
(rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative
emoji / serif-hero sizes.

Verified on a running local stack: pinned sidebar rows and group labels
measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit
of every rendered font size across the product surfaces finds nothing off the
scale; the only exceptions are avatar initials and emoji, which
actor-avatar.tsx sizes proportionally to the avatar diameter by design.

Co-authored-by: Lambda <lambda@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
2026-07-30 13:42:33 +08:00

126 lines
4.0 KiB
TypeScript

"use client";
import { useMemo, useState } from "react";
import { Plus, X } from "lucide-react";
import { useQuery } from "@tanstack/react-query";
import { useWorkspaceId } from "@multica/core/hooks";
import { memberListOptions } from "@multica/core/workspace/queries";
import { cn } from "@multica/ui/lib/utils";
import { ActorAvatar } from "../../common/actor-avatar";
import {
PropertyPicker,
PickerItem,
PickerEmpty,
} from "../../issues/components/pickers/property-picker";
import { matchesPinyin } from "../../editor/extensions/pinyin-match";
import { useT } from "../../i18n";
// Fully controlled — parent owns the selection state and ships it to the
// create/update mutation. Members-only on purpose (per RFC, MUL-2533).
export function SubscriberMultiSelect({
selectedIds,
onChange,
}: {
/** User IDs of the currently-selected member subscribers. */
selectedIds: ReadonlyArray<string>;
/** Called with the new full list whenever the selection changes. */
onChange: (next: string[]) => void;
}) {
const { t } = useT("autopilots");
const wsId = useWorkspaceId();
const { data: members = [] } = useQuery(memberListOptions(wsId));
const [open, setOpen] = useState(false);
const [filter, setFilter] = useState("");
const selectedSet = useMemo(() => new Set(selectedIds), [selectedIds]);
const query = filter.trim().toLowerCase();
const filteredMembers = useMemo(
() =>
members.filter(
(m) =>
query === "" ||
m.name.toLowerCase().includes(query) ||
matchesPinyin(m.name, query),
),
[members, query],
);
const selectedMembers = useMemo(
() => members.filter((m) => selectedSet.has(m.user_id)),
[members, selectedSet],
);
const toggle = (userId: string) => {
if (selectedSet.has(userId)) {
onChange(selectedIds.filter((id) => id !== userId));
} else {
onChange([...selectedIds, userId]);
}
};
const remove = (userId: string) => {
onChange(selectedIds.filter((id) => id !== userId));
};
return (
<div className="flex flex-wrap items-center gap-1.5">
{selectedMembers.map((m) => (
<span
key={m.user_id}
className="inline-flex items-center gap-1 rounded-full border bg-background px-2 py-0.5 text-caption"
>
<ActorAvatar actorType="member" actorId={m.user_id} size="xs" />
<span className="max-w-[10rem] truncate">{m.name}</span>
<button
type="button"
onClick={() => remove(m.user_id)}
className="text-muted-foreground hover:text-foreground transition-colors cursor-pointer"
aria-label={t(($) => $.dialog.subscribers_remove_tooltip)}
>
<X className="size-3" />
</button>
</span>
))}
<PropertyPicker
open={open}
onOpenChange={(v) => {
setOpen(v);
if (!v) setFilter("");
}}
width="w-64"
align="start"
searchable
searchPlaceholder={t(($) => $.dialog.subscribers_search_placeholder)}
onSearchChange={setFilter}
trigger={
<span
className={cn(
"inline-flex items-center gap-1 rounded-full border border-dashed px-2 py-0.5 text-caption text-muted-foreground",
"hover:border-primary/40 hover:text-foreground transition-colors cursor-pointer",
)}
>
<Plus className="size-3" />
{t(($) => $.dialog.subscribers_add)}
</span>
}
>
{filteredMembers.length === 0 ? (
<PickerEmpty />
) : (
filteredMembers.map((m) => (
<PickerItem
key={m.user_id}
selected={selectedSet.has(m.user_id)}
onClick={() => toggle(m.user_id)}
>
<ActorAvatar actorType="member" actorId={m.user_id} size="sm" />
<span className="truncate">{m.name}</span>
</PickerItem>
))
)}
</PropertyPicker>
</div>
);
}