Files
multica/packages/views/editor/html-preview-body.tsx
Jiayuan Zhang 7803a5b9ea feat(ui): establish a role-named type scale and migrate ad-hoc font sizes (MUL-5451) (#6136)
tokens.css defined colours, radii and font families but not a single --text-*
step, so font sizes had no baseline to align to and grew wherever they were
needed: 51 distinct sizes across web + desktop, 370 written as arbitrary
values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px).
text-xs and text-sm carried nearly all UI text while the range between them —
11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not
come from having more sizes; past a handful, each extra size makes the
hierarchy blurrier.

Add ten role-named steps, each with its own line-height so leading cannot
fragment the way size did, and move every product-UI call site onto them.
Steps are named for what the text is for, not for a t-shirt size, because
that is what keeps the scale from drifting again.

Six steps deliberately keep the exact size/line-height pairs of the Tailwind
defaults they replace, so the ~1,900-call-site rename moves nothing on screen.
The visible changes are confined to former arbitrary values snapping to a step:
8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30
(text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small
buttons and toggles. Half-pixel sizes are gone.

This supersedes #6108, which was reverted by #6116 because the sidebar group
labels rendered at the inherited 16px. The cause was not the scale but cn():
`text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a
table listing only the default sizes, so it filed every role step under
text-colour and dropped whichever of `text-caption` /
`text-sidebar-foreground/70` came first. Registering the steps as a font-size
class group restores the real conflict groups — size beats size, colour beats
colour, the two coexist — and a test pins the list against the scale, since
the failure is silent in source.

Hand-written CSS is covered too. The transcript kept a 12.5px body long after
every Tailwind call site was on the scale, so the "no half-pixel sizes" claim
was true of the classes and false of the product; the editor's prose, code and
mermaid ramps had the same blind spot, and seven of their eight values already
equalled a step exactly. All now reference var(--text-*). The guard test reads
raw `font-size:` declarations as well as class names, exempting only the 16px
iOS input-zoom workaround in base.css and the landing pages' marketing ramp.

apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system)
keep Tailwind's default scale and are untouched. Landing display type
(rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative
emoji / serif-hero sizes.

Verified on a running local stack: pinned sidebar rows and group labels
measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit
of every rendered font size across the product surfaces finds nothing off the
scale; the only exceptions are avatar initials and emoji, which
actor-avatar.tsx sizes proportionally to the avatar diameter by design.

Co-authored-by: Lambda <lambda@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
2026-07-30 13:42:33 +08:00

142 lines
4.1 KiB
TypeScript

"use client";
/**
* HtmlPreviewBody — single source of truth for rendering an HTML document
* inside a sandboxed iframe, regardless of whether the source is an inline
* string (```html fenced code block) or an attachment id (HTML attachment).
*
* The two paths used to duplicate iframe + sandbox + fragment-nav shim logic
* across html-block-preview.tsx, html-attachment-preview.tsx, and
* attachment-preview-modal.tsx. This component owns:
*
* - srcDoc + sandbox="allow-scripts" via CodeBlockIframe
* - withFragmentNavShim() so anchor links inside the iframe scroll instead
* of silently failing in the sandbox's opaque origin
* - loading / typed-error placeholders for attachment sources
*
* Callers (the toolbar wrappers) keep their own chrome — Copy / Source
* toggle for code blocks, Download / Open-in-new-tab for attachments — and
* just slot HtmlPreviewBody as the body.
*/
import { cn } from "@multica/ui/lib/utils";
import {
PreviewTooLargeError,
PreviewUnsupportedError,
} from "@multica/core/api";
import { useT } from "../i18n";
import { CodeBlockIframe } from "./code-block-iframe";
import { withFragmentNavShim } from "./utils/iframe-fragment-nav";
import { useAttachmentHtmlText } from "./hooks/use-attachment-html-text";
export type HtmlSource =
| { kind: "inline"; html: string }
| { kind: "attachment"; attachmentId: string };
interface HtmlPreviewBodyProps {
source: HtmlSource;
/** iframe title attribute (a11y). */
title: string;
/** Tailwind height/sizing classes for the iframe (e.g. "h-[480px]" or "h-full"). */
className?: string;
/** Override iframe styling (border / radius). Tailwind-merge resolves
* conflicts so callers can pass "rounded-none border-0" for full-screen. */
iframeClassName?: string;
/** Sizing for loading / error placeholders. Defaults to className. */
placeholderClassName?: string;
/** Optional data-testid on the error placeholder — preserved for
* html-attachment-preview.test.tsx which asserts the testid is present. */
errorTestId?: string;
}
export function HtmlPreviewBody({
source,
title,
className,
iframeClassName,
placeholderClassName,
errorTestId,
}: HtmlPreviewBodyProps) {
if (source.kind === "inline") {
return (
<CodeBlockIframe
html={withFragmentNavShim(source.html)}
title={title}
heightClassName={className}
className={iframeClassName}
/>
);
}
return (
<AttachmentBody
attachmentId={source.attachmentId}
title={title}
className={className}
iframeClassName={iframeClassName}
placeholderClassName={placeholderClassName ?? className}
errorTestId={errorTestId}
/>
);
}
function AttachmentBody({
attachmentId,
title,
className,
iframeClassName,
placeholderClassName,
errorTestId,
}: {
attachmentId: string;
title: string;
className?: string;
iframeClassName?: string;
placeholderClassName?: string;
errorTestId?: string;
}) {
const { t } = useT("editor");
const query = useAttachmentHtmlText(attachmentId);
if (query.isLoading) {
return (
<div
className={cn(
"flex items-center justify-center rounded-md border border-border bg-muted/30 text-caption text-muted-foreground",
placeholderClassName,
)}
>
{t(($) => $.attachment.preview_loading)}
</div>
);
}
if (query.error || !query.data) {
const message =
query.error instanceof PreviewTooLargeError
? t(($) => $.attachment.preview_too_large)
: query.error instanceof PreviewUnsupportedError
? t(($) => $.attachment.preview_unsupported)
: t(($) => $.attachment.preview_failed);
return (
<div
className={cn(
"flex items-center rounded-md border border-border bg-muted/30 px-3 text-caption text-muted-foreground",
placeholderClassName,
)}
data-testid={errorTestId}
>
<span className="truncate">{message}</span>
</div>
);
}
return (
<CodeBlockIframe
html={withFragmentNavShim(query.data.text)}
title={title}
heightClassName={className}
className={iframeClassName}
/>
);
}