mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-14 05:41:50 +02:00
7803a5b9ea
tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 written as arbitrary values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the ~1,900-call-site rename moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: 8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30 (text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small buttons and toggles. Half-pixel sizes are gone. This supersedes #6108, which was reverted by #6116 because the sidebar group labels rendered at the inherited 16px. The cause was not the scale but cn(): `text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a table listing only the default sizes, so it filed every role step under text-colour and dropped whichever of `text-caption` / `text-sidebar-foreground/70` came first. Registering the steps as a font-size class group restores the real conflict groups — size beats size, colour beats colour, the two coexist — and a test pins the list against the scale, since the failure is silent in source. Hand-written CSS is covered too. The transcript kept a 12.5px body long after every Tailwind call site was on the scale, so the "no half-pixel sizes" claim was true of the classes and false of the product; the editor's prose, code and mermaid ramps had the same blind spot, and seven of their eight values already equalled a step exactly. All now reference var(--text-*). The guard test reads raw `font-size:` declarations as well as class names, exempting only the 16px iOS input-zoom workaround in base.css and the landing pages' marketing ramp. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing display type (rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative emoji / serif-hero sizes. Verified on a running local stack: pinned sidebar rows and group labels measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit of every rendered font size across the product surfaces finds nothing off the scale; the only exceptions are avatar initials and emoji, which actor-avatar.tsx sizes proportionally to the avatar diameter by design. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
96 lines
3.1 KiB
TypeScript
96 lines
3.1 KiB
TypeScript
"use client";
|
|
|
|
import { Eye, MoreHorizontal } from "lucide-react";
|
|
import type { IssueStatus } from "@multica/core/types";
|
|
import { Button } from "@multica/ui/components/ui/button";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuTrigger,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
} from "@multica/ui/components/ui/dropdown-menu";
|
|
import { useViewStoreApi } from "@multica/core/issues/stores/view-store-context";
|
|
import { StatusIcon } from "./status-icon";
|
|
import { useT } from "../../i18n";
|
|
|
|
/**
|
|
* Single source of truth for the "Hidden columns" side panel rendered by
|
|
* the kanban-style views (board and swimlane).
|
|
*
|
|
* Each consumer renders its own per-row count via the {@link renderRow} slot —
|
|
* the board uses `useLoadMoreByStatus` to fetch the workspace-wide aggregate,
|
|
* while the swimlane uses an in-memory total derived from already-loaded
|
|
* issues. Centralising the chrome here keeps a future view (calendar /
|
|
* timeline / etc.) from forking yet another copy.
|
|
*/
|
|
export function HiddenColumnsPanel({
|
|
hiddenStatuses,
|
|
renderRow,
|
|
}: {
|
|
hiddenStatuses: IssueStatus[];
|
|
renderRow: (status: IssueStatus) => React.ReactNode;
|
|
}) {
|
|
const { t } = useT("issues");
|
|
return (
|
|
<div className="flex w-[240px] shrink-0 flex-col">
|
|
<div className="mb-2 flex items-center gap-2 px-1">
|
|
<span className="text-body font-medium text-muted-foreground">
|
|
{t(($) => $.board.hidden_columns_label)}
|
|
</span>
|
|
</div>
|
|
<div className="flex-1 space-y-0.5">
|
|
{hiddenStatuses.map((status) => renderRow(status))}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* One row inside {@link HiddenColumnsPanel}. Pure presentational — the caller
|
|
* computes `total` however it likes (cached query vs. in-memory aggregate).
|
|
*/
|
|
export function HiddenColumnRow({
|
|
status,
|
|
total,
|
|
}: {
|
|
status: IssueStatus;
|
|
total: number;
|
|
}) {
|
|
const { t } = useT("issues");
|
|
const viewStoreApi = useViewStoreApi();
|
|
return (
|
|
<div className="flex items-center justify-between rounded-lg px-2.5 py-2 hover:bg-muted/50">
|
|
<div className="flex items-center gap-2">
|
|
<StatusIcon status={status} className="h-3.5 w-3.5" />
|
|
<span className="text-body">{t(($) => $.status[status])}</span>
|
|
</div>
|
|
<div className="flex items-center gap-1.5">
|
|
<span className="text-caption text-muted-foreground">{total}</span>
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger
|
|
render={
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
aria-label={t(($) => $.board.show_column)}
|
|
className="rounded-full text-muted-foreground"
|
|
>
|
|
<MoreHorizontal className="size-3.5" />
|
|
</Button>
|
|
}
|
|
/>
|
|
<DropdownMenuContent align="end">
|
|
<DropdownMenuItem
|
|
onClick={() => viewStoreApi.getState().showStatus(status)}
|
|
>
|
|
<Eye className="size-3.5" />
|
|
{t(($) => $.board.show_column)}
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|