mirror of
https://github.com/multica-ai/multica.git
synced 2026-06-17 03:38:32 +02:00
* refactor(server): make ParseUUID error-returning to prevent silent data loss (MUL-1410) util.ParseUUID previously swallowed errors and returned a zero pgtype.UUID on invalid input. When this zero UUID reached a write query (DELETE/UPDATE), the SQL matched zero rows and the handler returned 2xx success — producing silent data corruption. #1661 (DeleteIssue with identifier-style ID) was the visible symptom; PR #1680 patched that one site, this commit closes the class of bug. Changes: - util.ParseUUID now returns (pgtype.UUID, error). Add util.MustParseUUID for trusted round-trips that should panic on invalid input. - handler/handler.go: parseUUID wrapper now calls MustParseUUID — any unguarded user-input string reaching it surfaces as a recovered panic (chi middleware.Recoverer → 500) instead of silently corrupting data. Add parseUUIDOrBadRequest(w, s, fieldName) for handler entry points. - Convert every Queries.Delete*/Update* call site reachable from raw user input (autopilot, comment, project, skill, skill_file, label, pin, attachment, feedback, issue assignee, daemon runtime, workspace) to validate UUIDs explicitly with parseUUIDOrBadRequest, returning 400 on invalid input. Where a resolved entity.ID is already in scope, write queries now use it directly instead of re-parsing the URL string. - Update getWorkspaceMember + loadIssueForUser to handle invalid UUIDs gracefully (404/400 instead of panic). - Update util/middleware/cmd-level callers (subscriber_listeners, notification_listeners, activity_listeners, scope_authorizer, middleware/workspace) to use the error-returning API. - Add server/internal/util/pgx_test.go covering valid/invalid input and the MustParseUUID panic contract. - Add TestDeleteIssueByIdentifier + TestDeleteIssueRejectsInvalidUUID regression tests in handler_test.go (the original #1661 bug + the invalid-input case). - Document the handler UUID parsing convention in CLAUDE.md so the rule is enforceable in future PR review. * fix(server): address GPT-Boy review of #1748 P1 fixes from PR #1748 review: 1. Migrate remaining request-boundary UUIDs to parseUUIDOrBadRequest so malformed input returns 400 instead of panic/500. Was missing on: - issue.go: workspace_id in CreateIssue/ChildIssueProgress/ListIssues/ SearchIssues/BatchUpdateIssues/BatchDeleteIssues; project_id / parent_issue_id / lead_id / assignee_id / assignee_ids / creator_id filters; batch issue_ids and assignee/parent/project fields in BatchUpdateIssues (skip on bad input via util.ParseUUID, matching the existing per-row continue semantics). - project.go: project id + workspace_id in GetProject/UpdateProject/ DeleteProject; lead_id in CreateProject/UpdateProject; workspace_id in ListProjects + SearchProjects. - handler.go: resolveActor now uses util.ParseUUID for X-Agent-ID / X-Task-ID headers; invalid UUID falls back to "member" (matches pre-existing semantics) instead of panicking. - issue.go: validateAssigneePair returns 400 on invalid workspace_id instead of panicking. 2. Fix issue:deleted WS event payloads to emit uuidToString(issue.ID) instead of the raw URL string. After an identifier-path delete ("MUL-7"), the previous payload would have leaked the identifier to subscribers, leaving stale entries in frontend caches that key by UUID. Updated DeleteIssue (issue.go:1341) and BatchDeleteIssues (issue.go:1641). The slog "issue deleted" log line also now records the resolved UUID so logs match the WS payload. 3. Extend TestDeleteIssueByIdentifier to subscribe to the bus and assert issue:deleted.payload.issue_id is the resolved UUID, not the identifier. * fix(server): validate remaining reviewed UUID inputs * fix(server): validate remaining handler UUID inputs * fix(server): finish request boundary UUID audit * fix(server): validate remaining request body UUIDs * fix(server): validate runtime path UUIDs * fix(server): validate remaining audit UUID inputs --------- Co-authored-by: Eve <eve@multica.ai>
448 lines
14 KiB
Go
448 lines
14 KiB
Go
package handler
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"log/slog"
|
|
"net/http"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/jackc/pgx/v5"
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/multica-ai/multica/server/internal/logger"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
"github.com/multica-ai/multica/server/pkg/protocol"
|
|
)
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Types
|
|
// ---------------------------------------------------------------------------
|
|
|
|
type LabelResponse struct {
|
|
ID string `json:"id"`
|
|
WorkspaceID string `json:"workspace_id"`
|
|
Name string `json:"name"`
|
|
Color string `json:"color"`
|
|
CreatedAt string `json:"created_at"`
|
|
UpdatedAt string `json:"updated_at"`
|
|
}
|
|
|
|
func labelToResponse(l db.IssueLabel) LabelResponse {
|
|
return LabelResponse{
|
|
ID: uuidToString(l.ID),
|
|
WorkspaceID: uuidToString(l.WorkspaceID),
|
|
Name: l.Name,
|
|
Color: l.Color,
|
|
CreatedAt: timestampToString(l.CreatedAt),
|
|
UpdatedAt: timestampToString(l.UpdatedAt),
|
|
}
|
|
}
|
|
|
|
func labelsToResponse(list []db.IssueLabel) []LabelResponse {
|
|
out := make([]LabelResponse, len(list))
|
|
for i, l := range list {
|
|
out[i] = labelToResponse(l)
|
|
}
|
|
return out
|
|
}
|
|
|
|
type CreateLabelRequest struct {
|
|
Name string `json:"name"`
|
|
Color string `json:"color"`
|
|
}
|
|
|
|
type UpdateLabelRequest struct {
|
|
Name *string `json:"name"`
|
|
Color *string `json:"color"`
|
|
}
|
|
|
|
// 6-digit hex, with or without leading '#'.
|
|
var hexColorRE = regexp.MustCompile(`^#?[0-9a-fA-F]{6}$`)
|
|
|
|
// normalizeColor returns a canonical "#rrggbb" form or an error if invalid.
|
|
//
|
|
// LOAD-BEARING INVARIANT: LabelChip renders `style={{ backgroundColor: color }}`
|
|
// directly in the frontend. If this regex is ever relaxed to accept arbitrary
|
|
// CSS (named colors, `url(...)`, etc.), that inline style becomes an injection
|
|
// surface. Keep the regex strict.
|
|
func normalizeColor(c string) (string, error) {
|
|
c = strings.TrimSpace(c)
|
|
if !hexColorRE.MatchString(c) {
|
|
return "", errors.New("color must be a 6-digit hex value like #3b82f6")
|
|
}
|
|
if !strings.HasPrefix(c, "#") {
|
|
c = "#" + c
|
|
}
|
|
return strings.ToLower(c), nil
|
|
}
|
|
|
|
const maxLabelNameLen = 32
|
|
|
|
// validateLabelName trims and validates a label name. Returns the trimmed
|
|
// name or an error suitable for a 400 response.
|
|
func validateLabelName(raw string) (string, error) {
|
|
name := strings.TrimSpace(raw)
|
|
if name == "" {
|
|
return "", errors.New("name is required")
|
|
}
|
|
if len(name) > maxLabelNameLen {
|
|
return "", errors.New("name must be 32 characters or fewer")
|
|
}
|
|
// TODO(labels): consider restricting to a charset that excludes newlines,
|
|
// tabs, and control characters. Emoji are left allowed — users can pick
|
|
// `🐛 bug` if they want. Tracked as a follow-up so we don't gate this PR.
|
|
return name, nil
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Handlers — label CRUD
|
|
// ---------------------------------------------------------------------------
|
|
|
|
func (h *Handler) ListLabels(w http.ResponseWriter, r *http.Request) {
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
labels, err := h.Queries.ListLabels(r.Context(), parseUUID(workspaceID))
|
|
if err != nil {
|
|
slog.Warn("ListLabels failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to list labels")
|
|
return
|
|
}
|
|
resp := labelsToResponse(labels)
|
|
writeJSON(w, http.StatusOK, map[string]any{"labels": resp, "total": len(resp)})
|
|
}
|
|
|
|
func (h *Handler) GetLabel(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
idUUID, ok := parseUUIDOrBadRequest(w, id, "label id")
|
|
if !ok {
|
|
return
|
|
}
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
label, err := h.Queries.GetLabel(r.Context(), db.GetLabelParams{
|
|
ID: idUUID, WorkspaceID: wsUUID,
|
|
})
|
|
if err != nil {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
writeError(w, http.StatusNotFound, "label not found")
|
|
return
|
|
}
|
|
slog.Warn("GetLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to get label")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, labelToResponse(label))
|
|
}
|
|
|
|
func (h *Handler) CreateLabel(w http.ResponseWriter, r *http.Request) {
|
|
var req CreateLabelRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body")
|
|
return
|
|
}
|
|
name, err := validateLabelName(req.Name)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
color, err := normalizeColor(req.Color)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
label, err := h.Queries.CreateLabel(r.Context(), db.CreateLabelParams{
|
|
WorkspaceID: parseUUID(workspaceID),
|
|
Name: name,
|
|
Color: color,
|
|
})
|
|
if err != nil {
|
|
if isUniqueViolation(err) {
|
|
writeError(w, http.StatusConflict, "a label with that name already exists")
|
|
return
|
|
}
|
|
slog.Warn("CreateLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to create label")
|
|
return
|
|
}
|
|
resp := labelToResponse(label)
|
|
h.publish(protocol.EventLabelCreated, workspaceID, "member", userID, map[string]any{"label": resp})
|
|
writeJSON(w, http.StatusCreated, resp)
|
|
}
|
|
|
|
func (h *Handler) UpdateLabel(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
|
|
var req UpdateLabelRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body")
|
|
return
|
|
}
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
idUUID, ok := parseUUIDOrBadRequest(w, id, "label id")
|
|
if !ok {
|
|
return
|
|
}
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
params := db.UpdateLabelParams{
|
|
ID: idUUID,
|
|
WorkspaceID: wsUUID,
|
|
}
|
|
if req.Name != nil {
|
|
name, err := validateLabelName(*req.Name)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
params.Name = pgtype.Text{String: name, Valid: true}
|
|
}
|
|
if req.Color != nil {
|
|
color, err := normalizeColor(*req.Color)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
params.Color = pgtype.Text{String: color, Valid: true}
|
|
}
|
|
|
|
// Branch on pgx.ErrNoRows directly from the UPDATE — the WHERE clause
|
|
// already enforces (id, workspace_id), so a missing row means either the
|
|
// label doesn't exist or it's not in this workspace. Dropping the prior
|
|
// GetLabel precheck removes a TOCTOU window and saves a round-trip.
|
|
label, err := h.Queries.UpdateLabel(r.Context(), params)
|
|
if err != nil {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
writeError(w, http.StatusNotFound, "label not found")
|
|
return
|
|
}
|
|
if isUniqueViolation(err) {
|
|
writeError(w, http.StatusConflict, "a label with that name already exists")
|
|
return
|
|
}
|
|
slog.Warn("UpdateLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to update label")
|
|
return
|
|
}
|
|
resp := labelToResponse(label)
|
|
h.publish(protocol.EventLabelUpdated, workspaceID, "member", userID, map[string]any{"label": resp})
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
func (h *Handler) DeleteLabel(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
idUUID, ok := parseUUIDOrBadRequest(w, id, "label id")
|
|
if !ok {
|
|
return
|
|
}
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
// DeleteLabel is :one RETURNING id — ErrNoRows means the label wasn't in
|
|
// this workspace (404). Any other error is a real 500.
|
|
if _, err := h.Queries.DeleteLabel(r.Context(), db.DeleteLabelParams{
|
|
ID: idUUID, WorkspaceID: wsUUID,
|
|
}); err != nil {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
writeError(w, http.StatusNotFound, "label not found")
|
|
return
|
|
}
|
|
slog.Warn("DeleteLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to delete label")
|
|
return
|
|
}
|
|
h.publish(protocol.EventLabelDeleted, workspaceID, "member", userID, map[string]any{"label_id": uuidToString(idUUID)})
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Handlers — issue↔label attach/detach
|
|
// ---------------------------------------------------------------------------
|
|
|
|
type AttachLabelRequest struct {
|
|
LabelID string `json:"label_id"`
|
|
}
|
|
|
|
// listLabelsForIssueSafe reads the attached-label list and handles the error
|
|
// by logging + returning nil. Callers use this after a successful attach/detach
|
|
// mutation: if the read fails, the mutation is already committed, so returning
|
|
// nil → clients refetch via query invalidation, and we skip broadcasting an
|
|
// empty list that would incorrectly overwrite every subscriber's optimistic
|
|
// state.
|
|
func (h *Handler) listLabelsForIssueSafe(r *http.Request, issueID, workspaceID pgtype.UUID) ([]db.IssueLabel, bool) {
|
|
labels, err := h.Queries.ListLabelsByIssue(r.Context(), db.ListLabelsByIssueParams{
|
|
IssueID: issueID,
|
|
WorkspaceID: workspaceID,
|
|
})
|
|
if err != nil {
|
|
slog.Warn("ListLabelsByIssue failed after mutation", append(logger.RequestAttrs(r), "error", err, "issue_id", uuidToString(issueID))...)
|
|
return nil, false
|
|
}
|
|
return labels, true
|
|
}
|
|
|
|
// ListLabelsForIssue returns the labels currently attached to an issue.
|
|
func (h *Handler) ListLabelsForIssue(w http.ResponseWriter, r *http.Request) {
|
|
issueID := chi.URLParam(r, "id")
|
|
// Authorize via the issue — if it's not in this workspace, the caller
|
|
// shouldn't see its labels.
|
|
issue, ok := h.loadIssueForUser(w, r, issueID)
|
|
if !ok {
|
|
return
|
|
}
|
|
labels, err := h.Queries.ListLabelsByIssue(r.Context(), db.ListLabelsByIssueParams{
|
|
IssueID: issue.ID,
|
|
WorkspaceID: issue.WorkspaceID,
|
|
})
|
|
if err != nil {
|
|
slog.Warn("ListLabelsForIssue failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to list labels")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, map[string]any{"labels": labelsToResponse(labels)})
|
|
}
|
|
|
|
// AttachLabel attaches a label to an issue.
|
|
func (h *Handler) AttachLabel(w http.ResponseWriter, r *http.Request) {
|
|
issueID := chi.URLParam(r, "id")
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
var req AttachLabelRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body")
|
|
return
|
|
}
|
|
if req.LabelID == "" {
|
|
writeError(w, http.StatusBadRequest, "label_id is required")
|
|
return
|
|
}
|
|
|
|
// Both the issue and label must belong to this workspace.
|
|
issue, ok := h.loadIssueForUser(w, r, issueID)
|
|
if !ok {
|
|
return
|
|
}
|
|
labelID, ok := parseUUIDOrBadRequest(w, req.LabelID, "label_id")
|
|
if !ok {
|
|
return
|
|
}
|
|
if _, err := h.Queries.GetLabel(r.Context(), db.GetLabelParams{
|
|
ID: labelID, WorkspaceID: issue.WorkspaceID,
|
|
}); err != nil {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
writeError(w, http.StatusNotFound, "label not found")
|
|
return
|
|
}
|
|
slog.Warn("GetLabel in AttachLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to attach label")
|
|
return
|
|
}
|
|
|
|
if err := h.Queries.AttachLabelToIssue(r.Context(), db.AttachLabelToIssueParams{
|
|
IssueID: issue.ID,
|
|
LabelID: labelID,
|
|
WorkspaceID: issue.WorkspaceID,
|
|
}); err != nil {
|
|
slog.Warn("AttachLabelToIssue failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to attach label")
|
|
return
|
|
}
|
|
|
|
// Read the updated label list; on read failure, the attach is already
|
|
// committed — return success without a labels body (clients refetch via
|
|
// query invalidation) and skip the broadcast so we don't overwrite every
|
|
// subscriber's optimistic state with an incorrect empty list.
|
|
labels, ok2 := h.listLabelsForIssueSafe(r, issue.ID, issue.WorkspaceID)
|
|
if !ok2 {
|
|
writeJSON(w, http.StatusOK, map[string]any{})
|
|
return
|
|
}
|
|
resp := labelsToResponse(labels)
|
|
h.publish(protocol.EventIssueLabelsChanged, uuidToString(issue.WorkspaceID), "member", userID, map[string]any{
|
|
"issue_id": uuidToString(issue.ID),
|
|
"labels": resp,
|
|
})
|
|
writeJSON(w, http.StatusOK, map[string]any{"labels": resp})
|
|
}
|
|
|
|
// DetachLabel removes a label from an issue.
|
|
func (h *Handler) DetachLabel(w http.ResponseWriter, r *http.Request) {
|
|
issueID := chi.URLParam(r, "id")
|
|
labelID := chi.URLParam(r, "labelId")
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
// Verify both issue and label belong to this workspace before detaching
|
|
// (mirror of AttachLabel). Without this, a crafted request with a foreign
|
|
// labelID would no-op and return 200 — "silent success" is worse than an
|
|
// explicit 404.
|
|
issue, ok := h.loadIssueForUser(w, r, issueID)
|
|
if !ok {
|
|
return
|
|
}
|
|
labelUUID, ok := parseUUIDOrBadRequest(w, labelID, "label id")
|
|
if !ok {
|
|
return
|
|
}
|
|
if _, err := h.Queries.GetLabel(r.Context(), db.GetLabelParams{
|
|
ID: labelUUID, WorkspaceID: issue.WorkspaceID,
|
|
}); err != nil {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
writeError(w, http.StatusNotFound, "label not found")
|
|
return
|
|
}
|
|
slog.Warn("GetLabel in DetachLabel failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to detach label")
|
|
return
|
|
}
|
|
|
|
if err := h.Queries.DetachLabelFromIssue(r.Context(), db.DetachLabelFromIssueParams{
|
|
IssueID: issue.ID,
|
|
LabelID: labelUUID,
|
|
WorkspaceID: issue.WorkspaceID,
|
|
}); err != nil {
|
|
slog.Warn("DetachLabelFromIssue failed", append(logger.RequestAttrs(r), "error", err)...)
|
|
writeError(w, http.StatusInternalServerError, "failed to detach label")
|
|
return
|
|
}
|
|
|
|
labels, ok2 := h.listLabelsForIssueSafe(r, issue.ID, issue.WorkspaceID)
|
|
if !ok2 {
|
|
writeJSON(w, http.StatusOK, map[string]any{})
|
|
return
|
|
}
|
|
resp := labelsToResponse(labels)
|
|
h.publish(protocol.EventIssueLabelsChanged, uuidToString(issue.WorkspaceID), "member", userID, map[string]any{
|
|
"issue_id": uuidToString(issue.ID),
|
|
"labels": resp,
|
|
})
|
|
writeJSON(w, http.StatusOK, map[string]any{"labels": resp})
|
|
}
|