multica/server/internal/daemon/local_skill_report_test.go

package daemon

import (
	"context"
	"log/slog"
	"net/http"
	"net/http/httptest"
	"strings"
	"sync/atomic"
	"testing"
	"time"
)

// withFastLocalSkillReportBackoffs swaps in zero-delay retries for the
// duration of a test so the suite doesn't pay real sleep latency. Restores
// the production schedule on cleanup.
func withFastLocalSkillReportBackoffs(t *testing.T) {
	t.Helper()
	prev := runtimeReportBackoffs
	runtimeReportBackoffs = []time.Duration{0, 0, 0, 0}
	t.Cleanup(func() { runtimeReportBackoffs = prev })
}

// localSkillReportDaemon wires a Daemon instance around an httptest.Server
// that records every inbound request and lets the test script status codes
// to return. That lets us exercise the retry path end-to-end against the
// real daemon.Client code, not a mock.
func localSkillReportDaemon(t *testing.T, handler http.HandlerFunc) (*Daemon, *int32) {
	t.Helper()
	var calls int32
	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		atomic.AddInt32(&calls, 1)
		handler(w, r)
	}))
	t.Cleanup(srv.Close)
	return &Daemon{
		client: NewClient(srv.URL),
		logger: slog.Default(),
	}, &calls
}

func TestReportLocalSkillListResult_RetriesOn500AndEventuallySucceeds(t *testing.T) {
	withFastLocalSkillReportBackoffs(t)

	var hits int32
	d, calls := localSkillReportDaemon(t, func(w http.ResponseWriter, _ *http.Request) {
		// Fail twice with 500, then succeed. Matches the concrete failure
		// mode the review is pinning: the server returns 500 while the
		// store write is being retried on its end, and the daemon must
		// hold on long enough to see it land.
		n := atomic.AddInt32(&hits, 1)
		if n <= 2 {
			http.Error(w, "{}", http.StatusInternalServerError)
			return
		}
		w.WriteHeader(http.StatusOK)
		w.Write([]byte(`{"status":"ok"}`))
	})

	d.reportLocalSkillListResult(context.Background(), Runtime{ID: "rt-1"}, "req-1", map[string]any{"status": "completed"})

	if got := atomic.LoadInt32(calls); got != 3 {
		t.Fatalf("expected 3 attempts (2 failures + 1 success), got %d", got)
	}
}

func TestReportLocalSkillListResult_DoesNotRetryOn4xx(t *testing.T) {
	withFastLocalSkillReportBackoffs(t)

	d, calls := localSkillReportDaemon(t, func(w http.ResponseWriter, _ *http.Request) {
		// 404 is permanent — the request expired, was cross-workspace, or
		// the server never saw it. Retrying just wastes heartbeat cycles.
		http.Error(w, `{"error":"request not found"}`, http.StatusNotFound)
	})

	d.reportLocalSkillListResult(context.Background(), Runtime{ID: "rt-1"}, "req-1", map[string]any{"status": "completed"})

	if got := atomic.LoadInt32(calls); got != 1 {
		t.Fatalf("expected exactly 1 attempt (4xx is terminal), got %d", got)
	}
}

func TestReportLocalSkillImportResult_RetriesOn500AndEventuallySucceeds(t *testing.T) {
	withFastLocalSkillReportBackoffs(t)

	var hits int32
	d, calls := localSkillReportDaemon(t, func(w http.ResponseWriter, _ *http.Request) {
		n := atomic.AddInt32(&hits, 1)
		if n == 1 {
			http.Error(w, "{}", http.StatusBadGateway)
			return
		}
		w.WriteHeader(http.StatusOK)
		w.Write([]byte(`{"status":"ok"}`))
	})

	d.reportLocalSkillImportResult(context.Background(), Runtime{ID: "rt-1"}, "req-1", map[string]any{"status": "completed"})

	if got := atomic.LoadInt32(calls); got != 2 {
		t.Fatalf("expected 2 attempts, got %d", got)
	}
}

func TestReportLocalSkillResult_GivesUpAfterAllAttemptsFail(t *testing.T) {
	withFastLocalSkillReportBackoffs(t)

	d, calls := localSkillReportDaemon(t, func(w http.ResponseWriter, _ *http.Request) {
		http.Error(w, "{}", http.StatusInternalServerError)
	})

	d.reportLocalSkillListResult(context.Background(), Runtime{ID: "rt-1"}, "req-1", map[string]any{"status": "completed"})

	// Each element in runtimeReportBackoffs is one attempt — a persistent
	// outage should burn through every slot and then stop (logging Error).
	if got := atomic.LoadInt32(calls); int(got) != len(runtimeReportBackoffs) {
		t.Fatalf("expected %d attempts, got %d", len(runtimeReportBackoffs), got)
	}
}

func TestReportLocalSkillResult_AbortsOnContextCancel(t *testing.T) {
	// Keep one real delay in the schedule so cancel lands mid-backoff.
	prev := runtimeReportBackoffs
	runtimeReportBackoffs = []time.Duration{0, 200 * time.Millisecond}
	t.Cleanup(func() { runtimeReportBackoffs = prev })

	d, calls := localSkillReportDaemon(t, func(w http.ResponseWriter, _ *http.Request) {
		http.Error(w, "{}", http.StatusInternalServerError)
	})

	ctx, cancel := context.WithCancel(context.Background())
	go func() {
		time.Sleep(30 * time.Millisecond)
		cancel()
	}()
	d.reportLocalSkillListResult(ctx, Runtime{ID: "rt-1"}, "req-1", map[string]any{"status": "completed"})

	// Exactly the first attempt should have hit the server; the cancel
	// interrupts the sleep before the second attempt fires.
	if got := atomic.LoadInt32(calls); got != 1 {
		t.Fatalf("expected exactly 1 attempt before cancel, got %d", got)
	}
}

func TestReportLocalSkillResult_SendsCorrectPath(t *testing.T) {
	withFastLocalSkillReportBackoffs(t)

	var listPath, importPath string
	d, _ := localSkillReportDaemon(t, func(w http.ResponseWriter, r *http.Request) {
		// Smoke: make sure we're hitting the right daemon-side endpoint.
		// Protects against a future refactor silently pointing reports at
		// the wrong URL.
		if strings.Contains(r.URL.Path, "/import/") {
			importPath = r.URL.Path
		} else {
			listPath = r.URL.Path
		}
		w.WriteHeader(http.StatusOK)
		w.Write([]byte(`{"status":"ok"}`))
	})

	ctx := context.Background()
	d.reportLocalSkillListResult(ctx, Runtime{ID: "rt-a"}, "req-list", map[string]any{"status": "completed"})
	d.reportLocalSkillImportResult(ctx, Runtime{ID: "rt-a"}, "req-import", map[string]any{"status": "completed"})

	if !strings.HasSuffix(listPath, "/api/daemon/runtimes/rt-a/local-skills/req-list/result") {
		t.Fatalf("list path = %q", listPath)
	}
	if !strings.HasSuffix(importPath, "/api/daemon/runtimes/rt-a/local-skills/import/req-import/result") {
		t.Fatalf("import path = %q", importPath)
	}
}