mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-03 19:20:07 +02:00
485f0f3124
* fix(search): stop Home/End propagation in command palette inputs cmdk's root CommandPrimitive captures Home/End at the container level for list navigation (jumping to first/last item). When the search input is focused those keys never reach the native text-input handler, so the text caret does not move to the beginning/end of the query. Fix: add an onKeyDown handler on CommandPrimitive.Input that calls stopPropagation() for Home and End before the event reaches cmdk's root listener. The existing caller-supplied onKeyDown is still called so callers can layer their own handlers. Applied in two places: - packages/ui/components/ui/command.tsx (CommandInput wrapper — generic command palette used across the app) - packages/views/search/search-command.tsx (SearchCommand — Ctrl+K global search palette; uses CommandPrimitive.Input directly) Fixes #5655 * test(search): cover Home/End caret handling in command palette inputs Add regression coverage for the Home/End fix (MUL-5260, PR #5870): - search-command.test.tsx: Home/End move the query caret and do NOT hijack cmdk result selection, while ArrowUp/ArrowDown still navigate. - command-input.test.tsx: the shared CommandInput stops Home/End from bubbling to cmdk's root handler while still forwarding every key to a caller-provided onKeyDown; other keys keep bubbling. Lives in @multica/views because @multica/ui has no test runner. Verified as a genuine guard: reverting the fix hunks fails exactly these new assertions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: NevilleQingNY <nevilleqing@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>