mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-05 09:30:05 +02:00
tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 written as arbitrary values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the ~1,900-call-site rename moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: 8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30 (text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small buttons and toggles. Half-pixel sizes are gone. This supersedes #6108, which was reverted by #6116 because the sidebar group labels rendered at the inherited 16px. The cause was not the scale but cn(): `text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a table listing only the default sizes, so it filed every role step under text-colour and dropped whichever of `text-caption` / `text-sidebar-foreground/70` came first. Registering the steps as a font-size class group restores the real conflict groups — size beats size, colour beats colour, the two coexist — and a test pins the list against the scale, since the failure is silent in source. Hand-written CSS is covered too. The transcript kept a 12.5px body long after every Tailwind call site was on the scale, so the "no half-pixel sizes" claim was true of the classes and false of the product; the editor's prose, code and mermaid ramps had the same blind spot, and seven of their eight values already equalled a step exactly. All now reference var(--text-*). The guard test reads raw `font-size:` declarations as well as class names, exempting only the 16px iOS input-zoom workaround in base.css and the landing pages' marketing ramp. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing display type (rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative emoji / serif-hero sizes. Verified on a running local stack: pinned sidebar rows and group labels measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit of every rendered font size across the product surfaces finds nothing off the scale; the only exceptions are avatar initials and emoji, which actor-avatar.tsx sizes proportionally to the avatar diameter by design. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
143 lines
5.2 KiB
TypeScript
143 lines
5.2 KiB
TypeScript
"use client";
|
|
|
|
import { useState } from "react";
|
|
import { NodeViewWrapper, NodeViewContent } from "@tiptap/react";
|
|
import type { NodeViewProps } from "@tiptap/react";
|
|
import { Code as CodeIcon, Copy, Check, Eye } from "lucide-react";
|
|
import { cn } from "@multica/ui/lib/utils";
|
|
import { copyText } from "@multica/ui/lib/clipboard";
|
|
import { useDebouncedValue } from "../../common/use-debounced-value";
|
|
import { useT } from "../../i18n";
|
|
import { MermaidDiagram } from "../mermaid-diagram";
|
|
import { CodeBlockIframe } from "../code-block-iframe";
|
|
|
|
// Coalesces fast keystrokes before re-rendering live previews.
|
|
// `mermaid.initialize()` mutates a process-global config, so back-to-back
|
|
// renders during typing can race a concurrent ReadonlyContent render
|
|
// (e.g. a comment card) and clobber its theme variables. 200ms keeps the
|
|
// "live preview" feel while making concurrent inits unlikely in practice.
|
|
// HTML preview reuses the same debounce: re-keying iframe.srcDoc on every
|
|
// keystroke causes the iframe to re-load and flicker.
|
|
const PREVIEW_DEBOUNCE_MS = 200;
|
|
|
|
const HTML_PREVIEW_HEIGHT = "h-[480px]";
|
|
|
|
function CodeBlockView({ node }: NodeViewProps) {
|
|
const { t } = useT("editor");
|
|
const [copied, setCopied] = useState(false);
|
|
// HTML blocks default to "preview"; the user can flip to "source" to
|
|
// edit the markup directly. Note: the source `<pre>` MUST stay mounted
|
|
// (just hidden) so ProseMirror keeps its NodeView bindings — unmounting
|
|
// it would break editing.
|
|
const [view, setView] = useState<"preview" | "source">("preview");
|
|
const language = node.attrs.language || "";
|
|
const isMermaid = language === "mermaid";
|
|
const isHtml = language === "html";
|
|
const chart = node.textContent;
|
|
const debouncedChart = useDebouncedValue(
|
|
isMermaid ? chart : "",
|
|
PREVIEW_DEBOUNCE_MS,
|
|
);
|
|
const debouncedHtml = useDebouncedValue(
|
|
isHtml ? chart : "",
|
|
PREVIEW_DEBOUNCE_MS,
|
|
);
|
|
|
|
const handleCopy = async () => {
|
|
const text = node.textContent;
|
|
if (!text) return;
|
|
if (await copyText(text)) {
|
|
setCopied(true);
|
|
setTimeout(() => setCopied(false), 2000);
|
|
}
|
|
};
|
|
|
|
const showHtmlPreview = isHtml && view === "preview";
|
|
const toggleView = () =>
|
|
setView((v) => (v === "preview" ? "source" : "preview"));
|
|
|
|
return (
|
|
<NodeViewWrapper className="code-block-wrapper group/code relative my-3">
|
|
{isMermaid && debouncedChart.trim() && (
|
|
<div
|
|
contentEditable={false}
|
|
className="mermaid-diagram-preview mb-1"
|
|
>
|
|
<MermaidDiagram chart={debouncedChart} />
|
|
</div>
|
|
)}
|
|
{isHtml && showHtmlPreview && (
|
|
// CSS-hidden when toggled off so the `<pre>` below stays mounted —
|
|
// unmounting either side would either lose ProseMirror bindings
|
|
// (source) or thrash iframe.srcDoc (preview).
|
|
<div contentEditable={false} className="mb-1">
|
|
<CodeBlockIframe
|
|
html={debouncedHtml}
|
|
title="HTML preview"
|
|
heightClassName={HTML_PREVIEW_HEIGHT}
|
|
/>
|
|
</div>
|
|
)}
|
|
<div
|
|
contentEditable={false}
|
|
className="code-block-header absolute top-0 right-0 z-10 flex items-center gap-1.5 px-2 py-1.5 opacity-0 transition-opacity group-hover/code:opacity-100 focus-within:opacity-100"
|
|
>
|
|
{language && (
|
|
<span className="text-caption text-muted-foreground select-none">
|
|
{language}
|
|
</span>
|
|
)}
|
|
{isHtml && (
|
|
<button
|
|
type="button"
|
|
onClick={toggleView}
|
|
className="flex h-6 w-6 items-center justify-center rounded text-muted-foreground hover:bg-muted hover:text-foreground transition-colors"
|
|
title={
|
|
view === "preview"
|
|
? t(($) => $.code_block.show_source)
|
|
: t(($) => $.code_block.show_preview)
|
|
}
|
|
aria-label={
|
|
view === "preview"
|
|
? t(($) => $.code_block.show_source)
|
|
: t(($) => $.code_block.show_preview)
|
|
}
|
|
>
|
|
{view === "preview" ? (
|
|
<CodeIcon className="h-3.5 w-3.5" />
|
|
) : (
|
|
<Eye className="h-3.5 w-3.5" />
|
|
)}
|
|
</button>
|
|
)}
|
|
<button
|
|
type="button"
|
|
onClick={handleCopy}
|
|
className="flex h-6 w-6 items-center justify-center rounded text-muted-foreground hover:bg-muted hover:text-foreground transition-colors"
|
|
title={t(($) => $.code_block.copy_code)}
|
|
aria-label={t(($) => $.code_block.copy_code)}
|
|
>
|
|
{copied ? (
|
|
<Check className="h-3.5 w-3.5" />
|
|
) : (
|
|
<Copy className="h-3.5 w-3.5" />
|
|
)}
|
|
</button>
|
|
</div>
|
|
{/* `<pre>` + NodeViewContent must remain mounted so the user can keep
|
|
editing the code block contents. When the HTML preview is showing
|
|
we just visually hide it — ProseMirror still tracks it. */}
|
|
<pre
|
|
spellCheck={false}
|
|
className={cn(showHtmlPreview && "sr-only")}
|
|
aria-hidden={showHtmlPreview ? "true" : undefined}
|
|
>
|
|
{/* @ts-expect-error -- NodeViewContent supports as="code" at runtime */}
|
|
<NodeViewContent as="code" />
|
|
</pre>
|
|
</NodeViewWrapper>
|
|
);
|
|
}
|
|
|
|
export { CodeBlockView };
|