mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 19:06:06 +02:00
7803a5b9ea
tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 written as arbitrary values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the ~1,900-call-site rename moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: 8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30 (text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small buttons and toggles. Half-pixel sizes are gone. This supersedes #6108, which was reverted by #6116 because the sidebar group labels rendered at the inherited 16px. The cause was not the scale but cn(): `text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a table listing only the default sizes, so it filed every role step under text-colour and dropped whichever of `text-caption` / `text-sidebar-foreground/70` came first. Registering the steps as a font-size class group restores the real conflict groups — size beats size, colour beats colour, the two coexist — and a test pins the list against the scale, since the failure is silent in source. Hand-written CSS is covered too. The transcript kept a 12.5px body long after every Tailwind call site was on the scale, so the "no half-pixel sizes" claim was true of the classes and false of the product; the editor's prose, code and mermaid ramps had the same blind spot, and seven of their eight values already equalled a step exactly. All now reference var(--text-*). The guard test reads raw `font-size:` declarations as well as class names, exempting only the 16px iOS input-zoom workaround in base.css and the landing pages' marketing ramp. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing display type (rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative emoji / serif-hero sizes. Verified on a running local stack: pinned sidebar rows and group labels measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit of every rendered font size across the product surfaces finds nothing off the scale; the only exceptions are avatar initials and emoji, which actor-avatar.tsx sizes proportionally to the avatar diameter by design. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>
75 lines
2.7 KiB
TypeScript
75 lines
2.7 KiB
TypeScript
"use client";
|
|
|
|
import {
|
|
ONBOARDING_STEP_ORDER,
|
|
type OnboardingStep,
|
|
} from "@multica/core/onboarding";
|
|
import { cn } from "@multica/ui/lib/utils";
|
|
import { useT } from "../../i18n";
|
|
|
|
/**
|
|
* Horizontal step indicator shown at the top of every onboarding step
|
|
* except Welcome.
|
|
*
|
|
* Layout: a row of dots on the left (one per step in
|
|
* `ONBOARDING_STEP_ORDER`) and a plaintext "Step N of M" counter on
|
|
* the right. The dots show three states driven by the current step's
|
|
* position in the canonical order:
|
|
*
|
|
* - `done` filled with primary color (index < current)
|
|
* - `current` filled + ring for emphasis (index === current)
|
|
* - `pending` hollow / muted (index > current)
|
|
*
|
|
* The indicator derives both its dots and text from the same source —
|
|
* the canonical ONBOARDING_STEP_ORDER plus the caller-provided
|
|
* `currentStep` — so adding, removing, or reordering a step only
|
|
* requires editing the array.
|
|
*
|
|
* Not rendered on the Welcome screen: the caller (OnboardingFlow)
|
|
* decides whether to include this component based on whether the
|
|
* current render step is "welcome". See flow orchestrator for the
|
|
* mapping from local UI step to the canonical `OnboardingStep`.
|
|
*/
|
|
export function StepHeader({ currentStep }: { currentStep: OnboardingStep }) {
|
|
const { t } = useT("onboarding");
|
|
const total = ONBOARDING_STEP_ORDER.length;
|
|
const currentIndex = ONBOARDING_STEP_ORDER.indexOf(currentStep);
|
|
// Defensive: unknown step → render a disabled-looking header rather
|
|
// than throw. Happens if the caller's local step union and the store
|
|
// enum drift during refactors.
|
|
const safeIndex = currentIndex === -1 ? 0 : currentIndex;
|
|
|
|
return (
|
|
<div
|
|
role="progressbar"
|
|
aria-valuemin={1}
|
|
aria-valuemax={total}
|
|
aria-valuenow={safeIndex + 1}
|
|
aria-label={t(($) => $.step_header.step_of, { current: safeIndex + 1, total })}
|
|
className="flex w-full items-center justify-between py-2"
|
|
>
|
|
<div className="flex items-center gap-2">
|
|
{ONBOARDING_STEP_ORDER.map((stepId, i) => {
|
|
const isDone = i < safeIndex;
|
|
const isCurrent = i === safeIndex;
|
|
return (
|
|
<span
|
|
key={stepId}
|
|
aria-hidden
|
|
className={cn(
|
|
"h-2 w-2 rounded-full transition-colors",
|
|
isDone && "bg-primary",
|
|
isCurrent && "bg-primary ring-2 ring-primary/30 ring-offset-2 ring-offset-background",
|
|
!isDone && !isCurrent && "bg-muted",
|
|
)}
|
|
/>
|
|
);
|
|
})}
|
|
</div>
|
|
<span className="text-caption font-medium text-muted-foreground">
|
|
{t(($) => $.step_header.step_of, { current: safeIndex + 1, total })}
|
|
</span>
|
|
</div>
|
|
);
|
|
}
|