mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-05 13:29:44 +02:00
6620997503
* feat(issues): render labels on list/board with bulk server-side fetch ListIssues / ListOpenIssues / GetIssue now bulk-fetch labels per response via a new ListLabelsForIssues query so the client gets labels in a single round-trip instead of N requests per visible issue. List-row and board-card read issue.labels directly; an issue_labels:changed WS handler patches the list and detail caches in place so chips stay live across tabs, and attach/detach mutations mirror their result into the same caches for immediate same-tab feedback. Adds a "Labels" toggle to the card properties dropdown (defaults on). * fix(issues): preserve cached labels and refresh on label edit/delete Three fixes from gpt-boy's review of #1741: 1. IssueResponse.Labels was a non-omitempty slice, so paths that didn't load labels (UpdateIssue, batch updates, the issue:updated WS broadcast) serialized labels:null. onIssueUpdated then merged that null into the list/detail caches, wiping chips on every other tab whenever any non- label field changed. Switched to *[]LabelResponse + omitempty: nil = field absent (client merge keeps existing labels); non-nil (incl. empty slice) = authoritative. 2. issue.labels is a denormalized snapshot, but useUpdateLabel / useDeleteLabel and the WS label:* prefix only touched labelKeys, leaving stale chips in list/board after rename/recolor/delete. Mutations now also invalidate issueKeys.all(wsId), and the realtime refreshMap maps the label prefix to both labels and issues invalidation for cross-tab. 3. Persisted cardProperties from before this branch lacks the new `labels` key. Render fell back to `?? true` but the dropdown switch read it raw and showed unchecked. Added a custom Zustand merge that deep-merges cardProperties so newly added toggles inherit defaults for existing users; dropped the `?? true` fallbacks now that the store guarantees the key.
80 lines
2.7 KiB
SQL
80 lines
2.7 KiB
SQL
-- name: ListLabels :many
|
|
SELECT * FROM issue_label
|
|
WHERE workspace_id = $1
|
|
ORDER BY LOWER(name) ASC;
|
|
|
|
-- name: GetLabel :one
|
|
SELECT * FROM issue_label
|
|
WHERE id = $1 AND workspace_id = $2;
|
|
|
|
-- name: CreateLabel :one
|
|
INSERT INTO issue_label (workspace_id, name, color)
|
|
VALUES ($1, $2, $3)
|
|
RETURNING *;
|
|
|
|
-- name: UpdateLabel :one
|
|
UPDATE issue_label SET
|
|
name = COALESCE(sqlc.narg('name'), name),
|
|
color = COALESCE(sqlc.narg('color'), color),
|
|
updated_at = now()
|
|
WHERE id = $1 AND workspace_id = $2
|
|
RETURNING *;
|
|
|
|
-- name: DeleteLabel :one
|
|
-- :one RETURNING id so the handler distinguishes pgx.ErrNoRows (→ 404) from
|
|
-- infrastructure errors (→ 500), and avoids a TOCTOU precheck.
|
|
DELETE FROM issue_label
|
|
WHERE id = $1 AND workspace_id = $2
|
|
RETURNING id;
|
|
|
|
-- name: AttachLabelToIssue :exec
|
|
-- Workspace-guarded INSERT: the WHERE EXISTS clauses ensure both the issue
|
|
-- and the label belong to the given workspace. A future caller that forgets
|
|
-- handler-level prechecks still cannot attach labels across workspaces.
|
|
INSERT INTO issue_to_label (issue_id, label_id)
|
|
SELECT sqlc.arg('issue_id')::uuid, sqlc.arg('label_id')::uuid
|
|
WHERE EXISTS (
|
|
SELECT 1 FROM issue i
|
|
WHERE i.id = sqlc.arg('issue_id')::uuid
|
|
AND i.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
)
|
|
AND EXISTS (
|
|
SELECT 1 FROM issue_label l
|
|
WHERE l.id = sqlc.arg('label_id')::uuid
|
|
AND l.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
)
|
|
ON CONFLICT DO NOTHING;
|
|
|
|
-- name: DetachLabelFromIssue :exec
|
|
-- Workspace-guarded DELETE: only deletes if the issue is in the given
|
|
-- workspace. Mirror of the attach query.
|
|
DELETE FROM issue_to_label
|
|
WHERE issue_id = sqlc.arg('issue_id')::uuid
|
|
AND label_id = sqlc.arg('label_id')::uuid
|
|
AND EXISTS (
|
|
SELECT 1 FROM issue i
|
|
WHERE i.id = sqlc.arg('issue_id')::uuid
|
|
AND i.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
);
|
|
|
|
-- name: ListLabelsByIssue :many
|
|
-- Workspace filter at the SQL layer (mirrors GetProjectInWorkspace). Any caller
|
|
-- that passes the wrong workspace gets an empty list rather than leaking labels.
|
|
SELECT l.*
|
|
FROM issue_label l
|
|
JOIN issue_to_label il ON il.label_id = l.id
|
|
WHERE il.issue_id = sqlc.arg('issue_id')::uuid
|
|
AND l.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
ORDER BY LOWER(l.name) ASC;
|
|
|
|
-- name: ListLabelsForIssues :many
|
|
-- Bulk variant: fetch labels for many issues in one round-trip so the issue
|
|
-- list endpoints can fold labels into each row without N+1 queries from the
|
|
-- client. Workspace-guarded the same way as ListLabelsByIssue.
|
|
SELECT il.issue_id, l.*
|
|
FROM issue_label l
|
|
JOIN issue_to_label il ON il.label_id = l.id
|
|
WHERE il.issue_id = ANY(sqlc.arg('issue_ids')::uuid[])
|
|
AND l.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
ORDER BY il.issue_id, LOWER(l.name) ASC;
|