mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-05 13:29:44 +02:00
* feat(agents): rewrite template catalog as 25 lightweight starters Replaces every Phase-1 template with a curated set built around the "persona + intake + scaffold + hard negatives" instruction shape. Cross- platform survey (Cursor / Cline / Roo / Continue / Custom GPTs) showed the industry baseline for starter agents is "few but sharp" — single intent, no methodology buy-in, mostly prompt-only. The original catalog went the opposite direction (avg 2.5 skills, six-skill Full-stack methodology stack) and felt heavy for first-time use. Catalog shape: - 25 templates across 7 categories: Engineering (8), Product (4), Writing (5), Design (3), Communication (2), Team (1), Productivity (2). New Product / Design / Communication / Team domains fill gaps the old Eng-heavy catalog ignored. - 16 / 25 are prompt-only (no skill fan-out). Avg 0.56 skill per template vs. 2.5 prior. Heaviest is 2 skills, only for templates whose intent cannot be expressed in instructions alone (Playwright runner, single- file HTML bundlers, design + UX-guidelines pair). - Universal top-frequency intents that the old catalog missed are now covered: Code Explainer (intent #1 across every platform surveyed), Translator (中英), Summarizer, Writing Critic, PRD Drafter/Critic, RCA Writer, ADR Writer, PR Description Writer, Commit Message Writer. Loader allows 0-skill templates: - server/internal/agenttmpl/loader.go drops the "must declare at least one skill" validation; comment explains the picker's "Prompt only" rendering path. - loader_test.go: removed the corresponding negative case, added TestLoadFromFS_PromptOnlyTemplate as a regression guard. - agent_template.go handler is unchanged — every len(tmpl.Skills) call site was already 0-safe (empty fan-out short-circuits the fetch phase and the in-tx loop both skip cleanly). Frontend: - template-picker.tsx: 18 new lucide icons (BookOpen, Bug, GitPullRequest, GitCommit, AlertTriangle, Scale, ClipboardList, Microscope, UserRound, Target, Highlighter, Languages, AlignLeft, GraduationCap, Lightbulb, Type, MessageSquare, Briefcase). Card renders a "Prompt only" badge when skills.length === 0 instead of "0 skills". - template-detail.tsx: skill list section is hidden entirely for prompt- only templates — a header reading "Includes 0 skills" above an empty list was just visual noise. Instructions section below carries the agent's identity for these. - locales/en + zh-Hans agents.json: new create_dialog.template_card. prompt_only key ("Prompt only" / "纯指令"). Verification: - go test ./internal/agenttmpl/ — 9/9 pass, including TestLoad_RealTemplates which fails closed if any new JSON is malformed. - pnpm typecheck — all 6 packages clean. - pnpm --filter @multica/views test — 482/482 pass. - pnpm lint — 0 errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(agents): add category filter pills to template picker 25 templates across 7 categories made the picker scroll-heavy on first open. Add a single-select category filter row above the grid so a PM can isolate Product templates in one click, an engineer can jump straight to Engineering, etc. Visual reuses the IssuesHeader scope-toggle pattern verbatim — Button variant="outline" + active class swap (bg-accent / text-muted-foreground) — so the affordance reads the same as the existing filter pills in issues / squads / runtimes / my-issues. flex-wrap keeps the 8 pills (All + 7 categories) honest on narrow widths. Counts are inlined into the label ("Engineering (8)") rather than shown as a separate badge — single-line-tall pills look right next to the picker grid, and surfacing the per-category density up front doubles as a hint at the catalog's "less but sharper" intent. When a specific category is active, the grid renders flat (no section headers) — the active pill already names what's on screen, and a header reading "Engineering" above an only-Engineering grid is visual duplication. "All" falls back to the prior grouped layout. State is component-local (no URL sync, no persistence) since the picker is dialog-internal transient state — closing the dialog naturally resets the filter, which is the expected behaviour for a "choose from a catalog" surface. i18n: new `create_dialog.template_picker.filter_all` key in en + zh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
129 lines
3.6 KiB
Go
129 lines
3.6 KiB
Go
package agenttmpl
|
|
|
|
import (
|
|
"embed"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/fs"
|
|
"regexp"
|
|
"sort"
|
|
"strings"
|
|
)
|
|
|
|
//go:embed templates/*.json
|
|
var templateFS embed.FS
|
|
|
|
var slugPattern = regexp.MustCompile(`^[a-z0-9]+(?:-[a-z0-9]+)*$`)
|
|
|
|
// Registry is the in-memory store of loaded templates. It's read-only after
|
|
// construction — the only mutator is Load(), called once at server startup.
|
|
// Concurrent reads after that are safe without locking.
|
|
type Registry struct {
|
|
bySlug map[string]Template
|
|
order []string // slugs in deterministic load order, used by List()
|
|
}
|
|
|
|
// Load parses every *.json file under templates/ and returns a populated
|
|
// Registry. Any malformed template (bad JSON, missing required fields,
|
|
// slug/filename mismatch) aborts startup — we'd rather fail loudly at boot
|
|
// than serve a half-broken picker.
|
|
func Load() (*Registry, error) {
|
|
return loadFromFS(templateFS, "templates")
|
|
}
|
|
|
|
func loadFromFS(fsys fs.FS, dir string) (*Registry, error) {
|
|
entries, err := fs.ReadDir(fsys, dir)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("agenttmpl: read templates dir: %w", err)
|
|
}
|
|
|
|
reg := &Registry{bySlug: make(map[string]Template)}
|
|
|
|
// Sort filenames so List() output is deterministic regardless of FS order.
|
|
names := make([]string, 0, len(entries))
|
|
for _, e := range entries {
|
|
if e.IsDir() {
|
|
continue
|
|
}
|
|
if !strings.HasSuffix(e.Name(), ".json") {
|
|
continue
|
|
}
|
|
names = append(names, e.Name())
|
|
}
|
|
sort.Strings(names)
|
|
|
|
for _, name := range names {
|
|
path := dir + "/" + name
|
|
data, err := fs.ReadFile(fsys, path)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("agenttmpl: read %s: %w", path, err)
|
|
}
|
|
|
|
var t Template
|
|
if err := json.Unmarshal(data, &t); err != nil {
|
|
return nil, fmt.Errorf("agenttmpl: parse %s: %w", path, err)
|
|
}
|
|
|
|
if err := validate(t, name); err != nil {
|
|
return nil, fmt.Errorf("agenttmpl: %s: %w", path, err)
|
|
}
|
|
|
|
if _, dup := reg.bySlug[t.Slug]; dup {
|
|
return nil, fmt.Errorf("agenttmpl: duplicate slug %q (file %s)", t.Slug, path)
|
|
}
|
|
|
|
reg.bySlug[t.Slug] = t
|
|
reg.order = append(reg.order, t.Slug)
|
|
}
|
|
|
|
return reg, nil
|
|
}
|
|
|
|
// validate enforces the invariants that the rest of the handler / UI assume.
|
|
// Cheap to run at boot — every check pays for itself the first time someone
|
|
// adds a malformed template in a PR.
|
|
func validate(t Template, filename string) error {
|
|
if t.Slug == "" {
|
|
return fmt.Errorf("missing slug")
|
|
}
|
|
if !slugPattern.MatchString(t.Slug) {
|
|
return fmt.Errorf("slug %q must be lowercase kebab-case (a-z, 0-9, -)", t.Slug)
|
|
}
|
|
// Slug must equal the filename basename so URL routing matches file
|
|
// layout. Catches typos and lets `git mv` rename templates safely.
|
|
if filename != t.Slug+".json" {
|
|
return fmt.Errorf("slug %q does not match filename %q", t.Slug, filename)
|
|
}
|
|
if strings.TrimSpace(t.Name) == "" {
|
|
return fmt.Errorf("missing name")
|
|
}
|
|
if strings.TrimSpace(t.Instructions) == "" {
|
|
return fmt.Errorf("missing instructions")
|
|
}
|
|
// 0-skill templates are legitimate — most starter templates are
|
|
// prompt-only (instructions alone, no skill fan-out). See
|
|
// docs/agent-quick-create-plan.md and the picker UI's "Prompt only"
|
|
// rendering for zero-length skill arrays.
|
|
for i, s := range t.Skills {
|
|
if strings.TrimSpace(s.SourceURL) == "" {
|
|
return fmt.Errorf("skill[%d]: missing source_url", i)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// List returns all templates in deterministic load order.
|
|
func (r *Registry) List() []Template {
|
|
out := make([]Template, 0, len(r.order))
|
|
for _, slug := range r.order {
|
|
out = append(out, r.bySlug[slug])
|
|
}
|
|
return out
|
|
}
|
|
|
|
// Get returns the template with the given slug, or false if not found.
|
|
func (r *Registry) Get(slug string) (Template, bool) {
|
|
t, ok := r.bySlug[slug]
|
|
return t, ok
|
|
}
|