mirror of
https://github.com/multica-ai/multica.git
synced 2026-06-17 11:48:42 +02:00
936ccce8fa
PR #1744 fixed literal `\n\n` rendering for the CLI surfaces (`issue create / update --description`, `issue comment add --content`) but the agent-completion path bypasses the CLI entirely: the daemon POSTs the agent's stdout to `/api/daemon/tasks/:id/complete`, and `TaskService. CompleteTask` writes `payload.Output` straight into `createAgentComment` and `CreateChatMessage` without decoding. Models (e.g. Codex) routinely emit Python/JSON-style `\n` literals in their final output, which then land in the DB as the 4-char escape sequence and render as one wall of text in the issue/chat panel — exactly the bug report in #1820. - Move `unescapeFlagText` from `server/cmd/multica/cmd_issue.go` to `server/internal/util/text.go` as `UnescapeBackslashEscapes` so the CLI and the service layer share one implementation. The full contract-boundary test suite moves with it. - Apply `UnescapeBackslashEscapes` to `payload.Output` before it reaches `createAgentComment` and `CreateChatMessage` in `TaskService.CompleteTask`. Same `\n / \r / \t / \\` decoding as the CLI; other escape sequences (`\d`, `\w`, `\u`, etc.) pass through verbatim so regex/format strings in agent output survive. Closes #1820
50 lines
2.2 KiB
Go
50 lines
2.2 KiB
Go
package util
|
|
|
|
import "testing"
|
|
|
|
func TestUnescapeBackslashEscapes(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
in string
|
|
want string
|
|
}{
|
|
{"empty", "", ""},
|
|
{"no escapes", "hello world", "hello world"},
|
|
{"single newline", `line1\nline2`, "line1\nline2"},
|
|
{"double newline becomes paragraph", `para1\n\npara2`, "para1\n\npara2"},
|
|
{"tab and carriage return", `a\tb\rc`, "a\tb\rc"},
|
|
{"escaped backslash preserved as literal", `keep\\nliteral`, `keep\nliteral`},
|
|
{"trailing lone backslash kept verbatim", `tail\`, `tail\`},
|
|
{"unknown escape kept verbatim", `\x not touched`, `\x not touched`},
|
|
{"mixed real and escaped newlines", "real\n" + `and\nescaped`, "real\nand\nescaped"},
|
|
{"unicode untouched", `中文段落\n下一段`, "中文段落\n下一段"},
|
|
// Contract boundary: only \n \r \t \\ are decoded. Common regex /
|
|
// path / formatter escape sequences such as \d, \w, \s, \u, \0 must
|
|
// pass through verbatim — this lets users paste regex snippets or
|
|
// printf-style format strings into --content without surprise
|
|
// mutation. Anyone who genuinely wants the literal characters \\n
|
|
// can either double the backslash or pipe the body via stdin.
|
|
{"regex digit class untouched", `\d+\s*\w+`, `\d+\s*\w+`},
|
|
{"unicode escape untouched", `café`, `café`},
|
|
{"null escape untouched", `\0 sentinel`, `\0 sentinel`},
|
|
{"windows path no special chars", `C:\Users\bob`, `C:\Users\bob`},
|
|
{"backslash-quote pair untouched", `quote\"inside`, `quote\"inside`},
|
|
// Documented sharp edge of the contract: a path or string that
|
|
// embeds a literal backslash-n IS rewritten because the helper
|
|
// cannot distinguish "model emitted \n thinking it would become a
|
|
// newline" from "user pasted a path that happens to start with
|
|
// \new". Callers who need the literal sequence must double the
|
|
// backslash (`\\new`) or pipe the body via --content-stdin /
|
|
// --description-stdin. This test pins that intentional behavior.
|
|
{"path starting with backslash-n is mutated", `C:\new\folder`, "C:\new\\folder"},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := UnescapeBackslashEscapes(tt.in)
|
|
if got != tt.want {
|
|
t.Errorf("UnescapeBackslashEscapes(%q) = %q, want %q", tt.in, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|