mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-27 13:06:20 +02:00
3b08456264
Submitting a composer mid-upload silently lost the file: the editor holds a `blob:` placeholder that gets stripped during serialization, and the attachment id does not exist yet, so the send succeeded without the file. Chat and Quick Create gated this; manual issue create, Feedback's button, comments, replies and comment edit did not. Gate every action that FIXES a draft — Send/Create/Save, Cmd/Ctrl+Enter, Enter on the title, and the manual/agent mode switches — behind one source of truth: the editor document, which IS the upload queue. ContentEditor publishes queue transitions via `onUploadingChange` (a transaction listener, not `onUpdate` — that path is debounced and skips no-change emissions, and a failed upload leaves byte-identical markdown, so the un-gate would never fire). `useUploadGate` pairs that render state with an `isBlocked()` re-read at submit time, since the shortcut paths never consult the button. The publisher emits its current answer on subscribe rather than only on flips: hosts outlive editor instances (comment edit remounts on cancel, chat swaps by key on agent switch), and an editor torn down mid-upload would otherwise leave submit wedged shut with no pending node left to reopen it. Also fixes the failure toast that never fired: `uploadWithToast` only reported errors if a caller passed `onError`, and none did, so failed uploads removed their placeholder and vanished unexplained. `useEditorUpload` now supplies it once for every composer. Per MUL-4808: drops Quick Create's upload-time lock on the attach button (files can queue), and leaves description autosave ungated by design. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
61 lines
2.6 KiB
TypeScript
61 lines
2.6 KiB
TypeScript
"use client";
|
|
|
|
/**
|
|
* The submit gate for composers that accept attachments (MUL-4808).
|
|
*
|
|
* While a file is still uploading, the editor holds a `blob:` placeholder and
|
|
* the attachment's id does not exist yet. Serializing at that moment strips
|
|
* the blob (see ContentEditor's stripBlobUrls) and binds no id, so the send
|
|
* succeeds while the file silently disappears from what the recipient gets.
|
|
* Every action that FIXES a draft — send, create, save, and the mode switch
|
|
* that re-serializes a draft into another form — must therefore wait.
|
|
*
|
|
* Two signals, because they answer different questions:
|
|
*
|
|
* `uploading` — reactive, drives the rendered button (disabled / "Uploading…"
|
|
* / aria-busy). Sourced from the editor document via
|
|
* `onUploadingChange`, which is the actual upload queue.
|
|
*
|
|
* `isBlocked()` — imperative, read INSIDE the submit handler. A rendered
|
|
* disabled state is a frame behind: Cmd+Enter and Enter-on-title
|
|
* bypass the button entirely, and a click can land in the same
|
|
* tick an upload starts. This reads the document at invocation
|
|
* time, which is the only answer that can't be stale.
|
|
*
|
|
* Hosts must use both. Gating the button alone leaves the shortcut paths open;
|
|
* gating the handler alone leaves a live-looking button that silently no-ops.
|
|
*
|
|
* Kept free of `api` / i18n / toast imports on purpose — the failure toast
|
|
* lives in `use-editor-upload` — so host tests can run the real gate against a
|
|
* mocked editor without pulling the API singleton into the module graph.
|
|
*/
|
|
|
|
import { useCallback, useState, type RefObject } from "react";
|
|
import type { ContentEditorRef } from "./content-editor";
|
|
|
|
interface UploadGate {
|
|
/** True while any attachment in this editor is mid-upload. Render state. */
|
|
uploading: boolean;
|
|
/** Pass to `<ContentEditor onUploadingChange={...} />`. */
|
|
onUploadingChange: (uploading: boolean) => void;
|
|
/** Submit-time truth. Call at the top of every submit/save/switch handler. */
|
|
isBlocked: () => boolean;
|
|
}
|
|
|
|
/**
|
|
* Reactive + submit-time upload state for one editor.
|
|
*
|
|
* The returned `isBlocked` reads the editor ref rather than `uploading` on
|
|
* purpose — see the module docstring.
|
|
*/
|
|
function useUploadGate(editorRef: RefObject<ContentEditorRef | null>): UploadGate {
|
|
const [uploading, setUploading] = useState(false);
|
|
const isBlocked = useCallback(
|
|
() => editorRef.current?.hasActiveUploads() === true,
|
|
[editorRef],
|
|
);
|
|
return { uploading, onUploadingChange: setUploading, isBlocked };
|
|
}
|
|
|
|
export { useUploadGate, type UploadGate };
|