Files
multica/packages/views/issues/components/attribution-badge.test.tsx
Naiyuan Qing 887c9228b8 feat(views): transcript reading hierarchy — presenter, expand modes, log-scale markdown (#5871)
* feat(views): transcript reading hierarchy — presenter, expand modes, log-scale markdown

The transcript rendered all five event kinds as identical truncated
one-liners: agent replies and errors were clipped to half a sentence and
only readable through an 11px bordered scroll box, indistinguishable in
weight from dozens of tool rows.

- trace-event-presenter.ts: pure presentation rules — kind, verbatim
  tool labels, newline-free one-line summaries, shell-wrapper stripping
  for command summaries, and per-kind default expansion.
- Smart reading hierarchy: agent text renders in place through
  RichContent (compact density + transcript-prose log scale: headings
  demoted to body size, 12.5px/11px two-step type ramp) and errors read
  unboxed; thinking and tool rows stay folded to one line.
- Expand mode menu replaces the expand-visible toggle: a persisted
  three-way preference (smart / expand all / collapse all) with per-item
  descriptions; row-level toggles override it until the mode changes.
  transcript-view-store migrates the legacy defaultExpanded boolean.
- Tool params/output expand into a quiet borderless surface; long
  content fades behind "Show all" instead of a nested scrollbar.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(views): transcript header — status-first identity row, facts as typography, list toolbar

The header mixed five different natures in one visual container: status
pill, attribution badge, nine equal-weight metadata chips (including
truncated agent-description prose and a hostname), and the list controls
— everything a rounded bordered capsule, so information and controls
were indistinguishable and wrapped into a ragged 2-3 lines.

Restructure into three fixed-purpose rows:
- Identity: status pill anchors the left edge (the fact every viewer
  opens the dialog for), then the agent through its existing avatar
  component (hover card for details; fixes the empty-name case via
  agentInfo fallback) and a new borderless `inline` AttributionBadge
  variant. Close stays at the right.
- Facts: one dot-separated plain-text line — provider, runtime mode
  (hostname in hover title), duration, counts, timestamp; the workdir
  path collapses into a copy icon with the path as tooltip. The
  agent-description chip is gone (it lives in the avatar hover card).
- List toolbar: expand mode / sort / filter / copy move to their own
  row attached to the list they operate.

Only controls keep borders; only status keeps color; entities render
through their identity components; facts are typography.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(views): transcript header — two-tier by necessity (ⓘ popover), trigger source, full status machine

Following PR #5747's design lesson: split header metadata by whether a
viewer needs it BEFORE reading. The flat facts line put diagnostics
(provider, runtime hostname, mode, workdir, timestamps) on the
always-visible surface with equal weight.

- Identity row (tier 1): status · agent · trigger source · attribution.
  Trigger source ("Initial run" / "From a comment" / "Retry" / ...)
  answers "why does this run exist" — restored from #5747, was dropped.
- Status badge now covers the full state machine (queued / dispatched /
  cancelled / waiting), not just running/completed/failed.
- ⓘ Run-details popover (tier 2): runtime, provider, mode, workdir
  (copyable), created/started/completed — off the default surface.
- Toolbar left carries duration + event/tool counts (a read-before-you-
  read summary), so the control row balances instead of stranding the
  controls at the right with empty left space.

Persisted preferences (sort, filter selection, preserve-filters, expand
density) are untouched — same controls, same behavior.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(views): transcript summary/controls — JSON preview, unify sort button, attribution to ⓘ

- Tool-result summary took the first non-empty line, so pretty-printed
  JSON previewed as a lone "[" or "{". Collapse whitespace instead so it
  reads "[ { "id": ... } ]".
- Sort was a segmented tab strip, reading as a different control family.
  Make it a single two-state toggle button on the shared toolbar chassis
  (shows current direction, flips on click) — every toolbar control now
  shares one chassis with a type-appropriate affordance (toggle / menu /
  action), not one forced shape.
- Attribution left the identity row. The accountable human is audit
  metadata, not read-time context, and "on behalf of" misread the
  direction; the trigger *mechanism* stays on the identity row, the
  *person* moves to the ⓘ popover as "Triggered by".
- Drop the tool-call count from the toolbar: redundant with the event
  count and informs no reading decision.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(views): transcript toolbar uses the shared Button component + labels fix

Toolbar controls were hand-rolled <button>s, so they never got the
project's built-in aria-expanded active state — opening a menu left the
trigger looking idle. Route every control through the shared Button:

- Density / filter / ⓘ / close → Button variant="ghost" via the trigger
  render prop, so an open menu shows the muted active background for free.
- Active filter → Button variant="brand" (the design-system ON state),
  replacing the ad-hoc blue classes.
- Sort → ghost Button on the same chassis (was a segmented tab strip).
- Copy → ghost Button.

Wording:
- Sort reads "Oldest first" / "Newest first" (was the ambiguous
  "chronological / time order").
- Expand-mode "Smart" → "Focus" — names the result, not a hollow adjective.

Start/created/completed timestamps remain in the ⓘ Run-details popover.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(views): filters always persist, drop "on behalf of" wording, surface run time

Three follow-ups from review:
- Remove the "Preserve filters" toggle. Persisting the filter selection
  is the only sensible behavior (a facet a run lacks already no-ops), so
  it should not be a user-facing switch. Filters now always persist;
  drop preserveFilters + the session-vs-persisted branching from the
  store and dialog.
- Inline attribution showed "on behalf of <name>", which read backwards
  and doubled up under the ⓘ "Triggered by" label. Render just the
  avatar + name; the source stays in the tooltip.
- Surface the run time (started ?? created) on the toolbar left next to
  duration and event count — "when did this happen" is read-before-you-
  read context. Full-precision timestamps remain in the ⓘ popover.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(views): triggered-by back on the identity row, labeled toolbar facts

- The accountable human returns to the identity row next to the trigger
  mechanism (status · agent · trigger · person), where it's visible
  rather than buried in the ⓘ popover.
- Toolbar facts now carry explicit labels — "Created <time> · Took
  <duration> · N events" — instead of bare values the reader had to
  infer.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(views): transcript identity row reads as one sentence, not three peers

The row put the agent, the trigger word, and the person at near-equal
weight with two same-size avatars, so it read as a jumble of names with
"comment-triggered" floating between them.

- The agent is the sole primary identity (avatar + medium weight).
- Trigger + person collapse into one muted secondary unit set apart from
  the agent, ordered "<person> · <how>".
- Drop the person's avatar here (new AttributionBadge `hideAvatar`) so
  two same-size faces don't read as two agents; the name alone, being
  muted, can't be confused with the agent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(views): copy-all exports full event bodies, not truncated summaries

handleCopyAll built its text from traceEventSummary — the one-line,
whitespace-collapsed, 200-char row preview — so every copied tool output
and agent reply was truncated with "...". Add traceEventCopyText, which
returns the complete body (full tool input JSON / result output / prose),
redact it like the detail view, and join events with blank lines.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore(views): remove orphaned tool_calls i18n keys, fix inline-variant JSDoc

Review follow-ups (no behavior change):
- Delete tool_calls_one/tool_calls_other from all four locales — the
  metadata chip that used them was removed earlier in this branch.
- Correct the AttributionBadge inline-variant JSDoc: it renders the bare
  name (no "on behalf of" wrapper), matching the implementation and test.
- en events_one grammar: "1 event" not "1 events".

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(views): fold copy timestamps into full-body copy (merge #5873)

Reconcile #5873's "timestamps in copied events" (merged to main) with
this branch's full-body copy rewrite: traceEventCopyText now prefixes
each line with the RFC 3339 timestamp when created_at is valid, on top of
the complete (untruncated) body, events separated by a blank line. The
two #5873 copy tests are updated to the full-body format; the orphaned
formatEventForClipboard helper is removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 16:12:10 +08:00

170 lines
6.3 KiB
TypeScript

// @vitest-environment jsdom
import { cleanup, screen } from "@testing-library/react";
import { afterEach, describe, expect, it, vi } from "vitest";
import type { TaskAttribution } from "@multica/core/types";
import { renderWithI18n } from "../../test/i18n";
// The avatar is presentational plumbing here; stub it so the tests assert the
// badge's own text/tone rather than the shared avatar's fallback behavior.
vi.mock("@multica/ui/components/common/actor-avatar", () => ({
ActorAvatar: ({ name }: { name: string }) => (
<span data-testid="actor-avatar">{name}</span>
),
}));
import { AttributionBadge } from "./attribution-badge";
afterEach(cleanup);
describe("AttributionBadge", () => {
it("renders nothing when the task has no attribution", () => {
const { container } = renderWithI18n(<AttributionBadge />);
expect(container).toBeEmptyDOMElement();
});
it("shows who the run is on behalf of, with the source as a tooltip", () => {
const attribution: TaskAttribution = {
source: "direct_human",
precise: true,
initiator: { id: "u1", name: "Ada Lovelace" },
};
renderWithI18n(<AttributionBadge attribution={attribution} />);
expect(screen.getByText("On behalf of Ada Lovelace")).toBeInTheDocument();
expect(screen.getByTitle("Direct member action")).toBeInTheDocument();
});
it("marks a fallback guess (owner_fallback) with a warning tone", () => {
const attribution: TaskAttribution = {
source: "owner_fallback",
precise: false,
initiator: { id: "u2", name: "Grace" },
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} />,
);
expect(screen.getByText("On behalf of Grace")).toBeInTheDocument();
expect(container.querySelector(".text-warning")).not.toBeNull();
expect(screen.getByTitle("No precise owner — attributed to the agent owner"))
.toBeInTheDocument();
});
it("shows a backfilled attribution in the normal tone, not a warning (MUL-4768)", () => {
// Backfill is non-precise for the coverage metric — a historical, after-the-
// fact record — but that does not make the displayed name wrong, so it must
// read like any other resolved attribution rather than a yellow warning.
const attribution: TaskAttribution = {
source: "backfill",
precise: false,
initiator: { id: "u5", name: "Bohan" },
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} />,
);
expect(screen.getByText("On behalf of Bohan")).toBeInTheDocument();
// No warning tone — the confusing yellow that flagged backfilled runs is gone.
expect(container.querySelector(".text-warning")).toBeNull();
expect(container.querySelector(".text-muted-foreground")).not.toBeNull();
// The "backfilled" nuance still lives in the tooltip for anyone who looks.
expect(screen.getByTitle("Backfilled attribution")).toBeInTheDocument();
});
it("avatar variant shows no warning ring for a backfilled attribution (MUL-4768)", () => {
const attribution: TaskAttribution = {
source: "backfill",
precise: false,
initiator: { id: "u5", name: "Bohan" },
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} variant="avatar" />,
);
expect(container.querySelector(".ring-warning\\/60")).toBeNull();
});
it("falls back to a generic name when the initiator has no display name", () => {
const attribution: TaskAttribution = {
source: "delegation",
precise: true,
initiator: { id: "u3" },
};
renderWithI18n(<AttributionBadge attribution={attribution} />);
expect(screen.getByText("On behalf of someone")).toBeInTheDocument();
});
it("inline variant renders the bare name (no on-behalf-of wrapper), source in tooltip", () => {
const attribution: TaskAttribution = {
source: "direct_human",
precise: true,
initiator: { id: "u1", name: "Ada Lovelace" },
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} variant="inline" />,
);
// The caller supplies the label; the value is just the person (the mocked
// avatar also echoes the name, hence getAllByText).
expect(screen.getAllByText("Ada Lovelace").length).toBeGreaterThan(0);
expect(screen.queryByText("On behalf of Ada Lovelace")).toBeNull();
// Typography, not a chip: the inline shape must not render a Badge border.
expect(container.querySelector("[data-slot='badge']")).toBeNull();
});
it("renders nothing when no responsible member resolved (MUL-4765)", () => {
const attribution: TaskAttribution = {
source: "unattributed",
precise: false,
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} />,
);
// An unassigned run is a normal state, not a warning — the badge stays silent
// rather than showing a "No responsible member" chip.
expect(container).toBeEmptyDOMElement();
});
it("degrades gracefully for an unknown source label", () => {
const attribution: TaskAttribution = {
source: "future_source",
precise: true,
initiator: { id: "u4", name: "Ada" },
};
renderWithI18n(<AttributionBadge attribution={attribution} />);
// Unknown sources fall through to the raw label so nothing renders blank.
expect(screen.getByTitle("future_source")).toBeInTheDocument();
});
it("avatar variant renders just the accountable member's avatar", () => {
const attribution: TaskAttribution = {
source: "direct_human",
precise: true,
initiator: { id: "u1", name: "Ada Lovelace" },
};
renderWithI18n(
<AttributionBadge attribution={attribution} variant="avatar" />,
);
// Only the avatar (name plumbs through the stub) — no "on behalf of" chip.
expect(screen.getByTestId("actor-avatar")).toHaveTextContent("Ada Lovelace");
expect(screen.queryByText("On behalf of Ada Lovelace")).toBeNull();
});
it("avatar variant renders nothing without an accountable member", () => {
const attribution: TaskAttribution = {
source: "unattributed",
precise: false,
};
const { container } = renderWithI18n(
<AttributionBadge attribution={attribution} variant="avatar" />,
);
expect(container).toBeEmptyDOMElement();
});
});