mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-27 21:33:41 +02:00
* Reapply "perf(issues): virtualize inbox/list/board/swimlane (MUL-4474, 方案2) (#…" (#5395)
This reverts commit c10bfa8f56.
Co-authored-by: multica-agent <github@multica.ai>
* fix(issues): seed virtualized lists so route-return doesn't flash blank (MUL-4750)
The relanded MUL-4474 virtualization flashed an empty card area (group /
column headers present, rows blank) when returning to /issues or crossing
inbox<->issues. Two stacked blank windows caused it:
1. The scroll element reaches Virtuoso via a callback ref that lands in
state, so the first render after a remount has customScrollParent === null
and the code rendered nothing.
2. Even once mounted, Virtuoso renders 0 rows until its post-paint
ResizeObserver measures the viewport.
Fix both, four surfaces (list / board / swimlane / inbox):
- New shared <VirtuosoSeed> renders a bounded slice of the real rows while the
scroll parent is still null, reusing each caller's own itemContent /
computeItemKey so a seeded row is identical to its virtualized counterpart.
- Pass initialItemCount={Math.min(len, SEED)} so the measurement frame keeps
those rows instead of collapsing to empty.
SEED is capped at 30 and floored by Math.min, so small workspaces
(hasMore=false) and short columns never over-mount — the path that crashed on
real Desktop before. restoreStateFrom (tab-switch Activity restore) is
intentionally out of scope for this round.
Verified: @multica/views tsc --noEmit, eslint, and full vitest (1936 tests)
pass. Real-Desktop route-return / DnD / keyboard / scroll-position regression
pass still owed on device.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
* perf(issues): defer per-card popup mounting, share one context menu per surface
Tab-switching to a board froze the main thread for seconds: every card
eagerly mounted ~6 popup roots (context menu, pickers, hover cards) plus
per-card query subscriptions, multiplied by seed x columns x remount.
- DeferredPopup: pickers render a pixel-identical static trigger and mount
the real popover on first pointerenter/keydown (Base UI opens on click,
so the warm mount always wins the race)
- AssigneePicker/PriorityPicker/DateOnlyPicker defer when uncontrolled;
AssigneePicker's members/agents/squads/frequency subscriptions now only
start on interaction
- IssueActionsContextMenu: one controlled ContextMenu per surface anchored
at the cursor via a virtual anchor; items delegate (issue, position) up.
Known debt: iOS Safari long-press no longer opens it
- ActorAvatar hover cards warm-mount on pointerenter with a manual
first-dwell timer matching Base UI's OPEN_DELAY
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(issues): stabilize board column scrollbar across mounts
Column scrollbars redrew visibly on every surface mount (route switches,
first open): the seed frame's scroll height covered only the seeded cards,
then Virtuoso spaced out the full count.
- VirtuosoSeed: optional estimatedItemHeight renders a trailing spacer so
the seed frame's scroll height already approximates the full list
- Board columns: seed capped at 10 (one column viewport of ~110px cards,
not the 36px-row-sized generic 30) and the same estimate feeds Virtuoso's
defaultItemHeight so both phases agree until real measurements land
- Columns at <=30 cards skip virtualization entirely and render plainly
(same itemContent), making their scroll height browser-measured truth in
every scenario -- the per-column split Linear ships
(data-virtual-cluster=false for small clusters)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* perf(editor): reduce issue detail mount cost
Parse long Markdown in smaller chunks without the duplicate initial sync, defer title and empty composer editors until intent, and keep the description editor eager to avoid layout shifts.
* chore(desktop): add navigation boundary lint rule (MUL-4741 Phase 2 prereq)
The tab Coordinator protocol requires that application code never
navigates directly (invariant 1: a Router location change without a
Coordinator token is a protocol error). Enforce it statically:
- renderer app code may not import useNavigate/Navigate from
react-router-dom nor call router.navigate; src/platform is exempt
- the five known legacy sites (the RFC §8.1 migration checklist,
cross-validated: the rule fires on exactly those and nothing else)
carry inline eslint-disable directives tagged MUL-4741 — the Phase 2
migration removes them one by one, and this rule holding with zero
disables is the machine check that the migration is complete
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(views): open deferred pickers on click, align triggerRender types
Pointerenter warm-mounting swapped the trigger element mid-gesture: real
browsers re-hit-test so the click lands on the new trigger, but synthetic
pointer sequences (tests, assistive tech) keep dispatching on the detached
node and the first click dies. Upgrade now happens on click/Enter/Space
only — the same timing as Base UI's own trigger — with the in-flight click
stopped so the popup's just-mounted outside-press dismissal doesn't close
it in the same breath.
Also widen triggerRender to ReactElement<Record<string, unknown>> (React
19 defaults ReactElement props to unknown) and mount the
IssueContextMenuProvider in the swimlane test harness like IssueSurface
does in production.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor(desktop): single-router tab sessions with Coordinator protocol (MUL-4741 Phase 2)
Replace the per-tab-router + <Activity> keep-alive model with the approved
single-router session architecture:
- TabSession: tabs are pure serializable state (url, resourceKey, virtual
history stack, scroll memento). Persist v4 does the one-time legacy
view-state import from v3; mountGeneration is deliberately unpersisted.
- Coordinator (platform/tab-coordinator.ts) is the only router writer: it
reconciles THE app router to the active session URL with navigation
tokens; a location change without a token is a protocol error handled by
bounded recovery (invariant 1). The router history is never used — every
reconcile is a replace; back/forward are session-stack operations.
- ActiveTabHost mounts exactly one tab, keyed on tabId:mountGeneration.
reload() = generation bump + active-scope query invalidation (never
router.revalidate, never a global cache invalidation). Warm switches
restore scroll pre-paint; cold restores pre-size containers from the
memento's saved scrollHeight and settle when data lands.
- resourceKey dedup (pathname only) replaces exact-path dedup: opening
/slug/issues?filter=b focuses the existing issues tab (RFC §8.2,
deliberate semantic change).
- All five §8.1 legacy navigation sites migrated (index <Navigate>, error
page recovery, workspace-layout login bounce, overlay parking, shell
back/forward); their MUL-4741 ratchet eslint-disables are removed, so the
navigation boundary rule now holds with zero exemptions outside
src/platform.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(issues): register board columns and list scroller for scroll mementos
Per-container scroll registration for the MUL-4741 tab session memento:
board columns key by group id (each column's offset restores
independently, the per-column split Linear ships), the list view keys as
"list". Chat and issue-detail already carry the marker.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(tabs): pull-based scroll restoration fed into virtualized lists (MUL-4741)
Rebuild the restore side of the memento protocol on first principles (the
model Linear ships): a saved offset is an INPUT to the mounting view, not a
post-hoc DOM mutation from outside.
- ScrollRestorationProvider (views/platform): views pull their saved offset
while mounting. Virtualized lists feed it into Virtuoso's initialScrollTop
so the first render already materializes the rows around it — this
replaces the pushed spacer+scrollTop hook, whose foreign spacer deadlocked
against Virtuoso's own height model (restore landed the viewport in
phantom space, Virtuoso rendered nothing, and the spacer's removal
condition could never be met → blank issue detail). Plain containers
assign the offset at ref-attach, pre-paint. Web has no provider and
behaves as before.
- Memento keys gain a route dimension (`${pathname}::${containerKey}`) and
capture now also fires before in-tab navigation, so back/forward restores
each route's own offsets and same-named containers on different routes
no longer collide.
- commitScrollMemento uses REPLACE-per-route semantics: a container
scrolled back to 0 clears its stale offset instead of resurrecting the
old position on the next visit.
- List view gets the same estimate alignment as the board (36px rows into
the seed spacer and defaultItemHeight), which keeps the shared scroller's
height truthful from the first frame so the restored offset sticks.
Known gap: chat's bottom-anchored list captures offsets but has no restore
consumer — intentional, it re-anchors to bottom on mount.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* perf(editor): make unlabelled code fences plaintext instead of auto-detected
Follow-up to the issue-detail mount work: lowlight's highlightAuto runs
every registered grammar over the full block for code fences without a
language, which dominated mount cost on code-heavy comments. Extract a
shared syntax-highlight module whose auto fallback deterministically
renders plaintext; explicitly labelled languages highlight as before.
Also ignore .gstack/.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* perf(issues): lazy-mount column-header popups, right-size swimlane seed
Trace analysis of tab/view switching (30s session): a swimlane mount spent
its largest slice on eagerly-mounted header machinery — ~170 tooltip roots
(one per lane x status cell add-button), 13 column dropdown-menus, and up
to 30 fully-materialized lanes from the generic seed count.
- DeferredTooltip (views/common): renders only the trigger until first
hover, then mounts a controlled Tooltip anchored to the SAME element
(no trigger swap, so mid-gesture events never land on a detached node);
ui TooltipContent grows an `anchor` passthrough for it.
- Board/list/swimlane header add-buttons and hide-column dropdowns now
defer via DeferredTooltip / DeferredPopup (which gains an ariaHasPopup
option for menu triggers).
- Swimlane lane seed drops 30 -> 6 (a lane row is ~300px+; a viewport fits
~3) on both the pre-scroll seed and Virtuoso's initialItemCount.
- openTab gains an `activate` option so "open and focus" paths (pinned-tab
redirect, explicit open-in-new-tab) are ONE store write instead of
openTab + setActiveTab back-to-back — one full subscriber pass per user
action instead of two.
- Dev-only breadcrumb logs IssueSurfaceContent's remount key: the trace
showed the surface mounting twice inside one task, and the my-issues
relation toggle is one confirmed key-flip source; the log ties the next
trace's mounts to exact key transitions.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* perf(issues): stop double full-tree render passes on surface interactions
Trace forensics on view switching showed every interaction paying TWO full
surface render passes (React's own Cascading Update marker sits between
them): entering swimlane flips controller-level loading state (loadProjects
enables the projects query), and any such flag flip re-rendered the entire
unmemoized view tree (~600-1000ms dev per pass).
- Memoize BoardView / ListView / SwimLaneView: controller/data outputs are
already useMemo/useCallback-stable, so a controller flag flip now
re-renders the header, not the whole board. The one unstable prop —
BoardView's inline assigneeGroups.flatMap — moves into a useMemo.
- Selection reset on mount swapped the initial empty Set for a NEW empty
Set, buying a guaranteed extra full pass per surface mount; functional
bail keeps the reference when nothing was selected.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* perf(ui): drive sidebar resize by direct DOM writes, drop motion/react
Trace analysis showed sidebar motion.div mounts costing ~1s across a
session. Width previews during drag now write straight to the two layout
shells (CSS disables their transitions while data-sidebar-resizing is set);
React only sees the single committed width on pointer-up, and framer-motion
leaves the sidebar entirely.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(issues): wire swimlane's outer scroller into tab scroll restoration
Review blocker on #5403: board/list/issue-detail register their scroll
containers with the tab session memento protocol, but the swimlane outer
scroller did not — under the single-router architecture an inactive tab
unmounts, so a deep-scrolled swimlane returned at top after a tab switch
or reload.
Same wiring as the other surfaces: data-tab-scroll-root="swimlane" for
capture, useRestoredScrollRef in the scroller's attach callback for the
pre-paint assignment, and the saved offset into the lane Virtuoso's
initialScrollTop. Regression test asserts both the capture marker and the
restored offset.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
375 lines
15 KiB
TypeScript
375 lines
15 KiB
TypeScript
"use client";
|
||
|
||
import { memo, useCallback, useMemo, useState, type ReactNode } from "react";
|
||
import { Virtuoso } from "react-virtuoso";
|
||
import { EyeOff, MoreHorizontal, Plus, UserMinus } from "lucide-react";
|
||
import { useDroppable } from "@dnd-kit/core";
|
||
import { SortableContext, verticalListSortingStrategy } from "@dnd-kit/sortable";
|
||
import type {
|
||
Issue,
|
||
IssueAssigneeType,
|
||
IssueStatus,
|
||
Project,
|
||
} from "@multica/core/types";
|
||
import { Button } from "@multica/ui/components/ui/button";
|
||
import {
|
||
DropdownMenu,
|
||
DropdownMenuTrigger,
|
||
DropdownMenuContent,
|
||
DropdownMenuItem,
|
||
} from "@multica/ui/components/ui/dropdown-menu";
|
||
import { STATUS_CONFIG } from "@multica/core/issues/config";
|
||
import { useViewStoreApi } from "@multica/core/issues/stores/view-store-context";
|
||
import { StatusHeading } from "./status-heading";
|
||
import { DraggableBoardCard } from "./board-card";
|
||
import type { ChildProgress } from "./list-row";
|
||
import { useT } from "../../i18n";
|
||
import { ActorAvatar } from "../../common/actor-avatar";
|
||
import { useRestoredScrollOffset, useRestoredScrollRef } from "../../platform";
|
||
import { DeferredPopup } from "../../common/deferred-popup";
|
||
import { DeferredTooltip } from "../../common/deferred-tooltip";
|
||
import { VirtuosoSeed } from "../../common/virtuoso-seed";
|
||
import type { IssueCreateDefaults } from "../surface/types";
|
||
|
||
// Insertion-position prediction intentionally omitted. The server's
|
||
// ORDER BY uses PostgreSQL's en_US.utf8 collation (glibc), which
|
||
// cannot be faithfully replicated in JavaScript (ICU/V8). Showing an
|
||
// inaccurate indicator is worse than showing none.
|
||
|
||
export const BOARD_COL_WIDTH = 280;
|
||
export const BOARD_CARD_WIDTH = BOARD_COL_WIDTH - 16 - 8; // col(280) - col p-2(16) - droppable p-1(8)
|
||
|
||
// Board cards are ~90-140px tall, so ~10 fill a column viewport — unlike the
|
||
// generic VIRTUOSO_SEED_COUNT (30, sized for 36px list rows). The seed mounts
|
||
// synchronously per column on every surface remount, so oversizing it
|
||
// multiplies straight into tab-switch cost (columns × seed × per-card mount).
|
||
const BOARD_SEED_COUNT = 10;
|
||
|
||
// Median card height (incl. the 8px pt-2 gap) for pre-measurement scroll
|
||
// sizing only: the seed's trailing spacer and Virtuoso's defaultItemHeight
|
||
// share it so total scroll height — and the scrollbar thumb — stays steady
|
||
// across the seed → Virtuoso handoff instead of jumping when the unseeded
|
||
// rows suddenly get spaced out. Real measurements refine it afterwards.
|
||
const BOARD_CARD_ESTIMATED_HEIGHT = 110;
|
||
|
||
// Columns at or below this render every card plainly — no Virtuoso, no seed
|
||
// handoff, no estimated heights. Scroll height is then always browser-measured
|
||
// truth, so the column's scrollbar can never jump on mount, route return, or
|
||
// tab restore. Virtualization only pays for itself on large columns (Linear
|
||
// does the same per-column split: `data-virtual-cluster="false"` for small
|
||
// columns, padding-spacer virtualization for big ones). ~30 ≈ 3 viewports of
|
||
// cards; a full plain mount at that size is cheap now that per-card popups
|
||
// mount lazily. Known edge: a load-more append that crosses the threshold
|
||
// swaps the column to the virtualized path, which may adjust the scrollbar
|
||
// once — accepted, since it only happens mid-scroll at the column bottom.
|
||
const BOARD_VIRTUALIZE_THRESHOLD = 30;
|
||
|
||
// Passed to <Virtuoso components> when the column has no footer. Must be a
|
||
// STABLE object, never `undefined`: an explicit `undefined` prop overwrites
|
||
// react-virtuoso's internal `{}` default and its startup destructure of
|
||
// `EmptyPlaceholder`/`Footer` throws (MUL-4474).
|
||
const EMPTY_VIRTUOSO_COMPONENTS = {};
|
||
|
||
export interface BoardColumnGroup {
|
||
id: string;
|
||
title: string;
|
||
status?: IssueStatus;
|
||
assigneeType?: IssueAssigneeType | null;
|
||
assigneeId?: string | null;
|
||
/** Set when the board is grouped by a select-type custom property. */
|
||
propertyId?: string;
|
||
/** Option id for this column; null = the "No value" column. */
|
||
propertyOptionId?: string | null;
|
||
propertyOptionColor?: string;
|
||
totalCount?: number;
|
||
createData?: IssueCreateDefaults;
|
||
}
|
||
|
||
export const BoardColumn = memo(function BoardColumn({
|
||
group,
|
||
issueIds,
|
||
issueMap,
|
||
childProgressMap,
|
||
projectMap,
|
||
totalCount,
|
||
footer,
|
||
projectId,
|
||
onCreateIssue,
|
||
sortLabel,
|
||
}: {
|
||
group: BoardColumnGroup;
|
||
issueIds: string[];
|
||
issueMap: Map<string, Issue>;
|
||
childProgressMap?: Map<string, ChildProgress>;
|
||
projectMap?: Map<string, Project>;
|
||
totalCount?: number;
|
||
footer?: ReactNode;
|
||
/** When set, the per-column "+" pre-fills the project on the create form. */
|
||
projectId?: string;
|
||
onCreateIssue?: (defaults: IssueCreateDefaults) => void;
|
||
sortLabel?: string | null;
|
||
}) {
|
||
const status = group.status;
|
||
const cfg = status ? STATUS_CONFIG[status] : null;
|
||
const { setNodeRef, isOver } = useDroppable({ id: group.id });
|
||
const viewStoreApi = useViewStoreApi();
|
||
const { t } = useT("issues");
|
||
|
||
// Resolve IDs to Issue objects, preserving parent-provided order
|
||
const resolvedIssues = useMemo(
|
||
() =>
|
||
issueIds.flatMap((id) => {
|
||
const issue = issueMap.get(id);
|
||
return issue ? [issue] : [];
|
||
}),
|
||
[issueIds, issueMap],
|
||
);
|
||
|
||
// The column's scroll container is both dnd-kit's droppable and Virtuoso's
|
||
// customScrollParent, so a merged callback ref feeds the element to both.
|
||
// useDroppable's setNodeRef is stable across renders. Keeping the droppable
|
||
// on the always-mounted scroll container (not on individual cards) is what
|
||
// lets cross-column drops survive virtualization — only the cards inside
|
||
// window in/out of the DOM.
|
||
const [scrollEl, setScrollEl] = useState<HTMLDivElement | null>(null);
|
||
// Pull-based scroll restoration (MUL-4741): assign the saved offset at
|
||
// ref-attach (the seed + estimate spacer give the column a truthful height
|
||
// on its first commit, so the assignment sticks pre-paint) and feed the
|
||
// same offset into the Virtuoso as its initial position.
|
||
const scrollMementoKey = `board:${group.id}`;
|
||
const restoredScrollTop = useRestoredScrollOffset(scrollMementoKey);
|
||
const restoreScrollRef = useRestoredScrollRef(scrollMementoKey);
|
||
const mergedRef = useCallback(
|
||
(el: HTMLDivElement | null) => {
|
||
setNodeRef(el);
|
||
setScrollEl(el);
|
||
restoreScrollRef(el);
|
||
},
|
||
[setNodeRef, restoreScrollRef],
|
||
);
|
||
// Infinite-scroll sentinel rides Virtuoso's Footer slot so it sits at the
|
||
// real end of the virtualized list and its IntersectionObserver still fires
|
||
// loadMore when scrolled to the bottom.
|
||
const footerComponents = useMemo(
|
||
() => (footer ? { Footer: () => <>{footer}</> } : EMPTY_VIRTUOSO_COMPONENTS),
|
||
[footer],
|
||
);
|
||
|
||
const computeItemKey = (_index: number, issue: Issue) => issue.id;
|
||
const itemContent = (index: number, issue: Issue) => (
|
||
// pt-2 on every card but the first reproduces the previous `space-y-2`
|
||
// gap; padding (not margin) is inside Virtuoso's measured item box so its
|
||
// height math stays correct.
|
||
<div className={index === 0 ? undefined : "pt-2"}>
|
||
<DraggableBoardCard
|
||
issue={issue}
|
||
childProgress={childProgressMap?.get(issue.id)}
|
||
project={
|
||
issue.project_id ? projectMap?.get(issue.project_id) : undefined
|
||
}
|
||
disableSorting={!!sortLabel}
|
||
/>
|
||
</div>
|
||
);
|
||
|
||
return (
|
||
<div style={{ width: BOARD_COL_WIDTH }} className={`flex shrink-0 flex-col rounded-xl ${cfg?.columnBg ?? "bg-muted/40"} p-2`}>
|
||
<div className="mb-2 flex items-center justify-between px-1.5">
|
||
<BoardGroupHeading group={group} count={totalCount ?? issueIds.length} />
|
||
|
||
{/* Right: add + menu */}
|
||
<div className="flex items-center gap-1">
|
||
{/* Column-header popups mount lazily: a board/swimlane renders one
|
||
header per column and almost none of these menus/tooltips are
|
||
ever opened — eagerly mounting them dominated surface mount
|
||
cost (DeferredPopup / DeferredTooltip). */}
|
||
{status && (
|
||
<DeferredPopup
|
||
ariaHasPopup="menu"
|
||
triggerRender={
|
||
<Button variant="ghost" size="icon-sm" className="rounded-full text-muted-foreground">
|
||
<MoreHorizontal className="size-3.5" />
|
||
</Button>
|
||
}
|
||
>
|
||
{(open, onOpenChange) => (
|
||
<DropdownMenu open={open} onOpenChange={onOpenChange}>
|
||
<DropdownMenuTrigger
|
||
render={
|
||
<Button variant="ghost" size="icon-sm" className="rounded-full text-muted-foreground">
|
||
<MoreHorizontal className="size-3.5" />
|
||
</Button>
|
||
}
|
||
/>
|
||
<DropdownMenuContent align="end">
|
||
<DropdownMenuItem onClick={() => viewStoreApi.getState().hideStatus(status)}>
|
||
<EyeOff className="size-3.5" />
|
||
{t(($) => $.board.hide_column)}
|
||
</DropdownMenuItem>
|
||
</DropdownMenuContent>
|
||
</DropdownMenu>
|
||
)}
|
||
</DeferredPopup>
|
||
)}
|
||
{onCreateIssue && (
|
||
<DeferredTooltip
|
||
content={t(($) => $.board.add_issue_tooltip)}
|
||
trigger={
|
||
<Button
|
||
variant="ghost"
|
||
size="icon-sm"
|
||
className="rounded-full text-muted-foreground"
|
||
onClick={() => {
|
||
const data = {
|
||
...(group.createData ?? {}),
|
||
...(projectId ? { project_id: projectId } : {}),
|
||
};
|
||
onCreateIssue(data);
|
||
}}
|
||
>
|
||
<Plus className="size-3.5" />
|
||
</Button>
|
||
}
|
||
/>
|
||
)}
|
||
</div>
|
||
</div>
|
||
<div className="relative min-h-[200px] flex-1 rounded-lg">
|
||
{isOver && sortLabel && (
|
||
<div className="pointer-events-none absolute inset-0 z-10 flex items-center justify-center rounded-lg bg-background/40">
|
||
<span className="rounded-md bg-popover px-2.5 py-1 text-xs font-medium text-popover-foreground shadow-sm border border-border">
|
||
{sortLabel}
|
||
</span>
|
||
</div>
|
||
)}
|
||
<div
|
||
ref={mergedRef}
|
||
// Per-column scroll registration for the tab session memento
|
||
// (MUL-4741): the group id is the stable memento key, so every
|
||
// column's offset survives tab switches/reloads independently.
|
||
data-tab-scroll-root={scrollMementoKey}
|
||
className={`absolute inset-0 overflow-y-auto rounded-lg p-1 transition-colors ${
|
||
isOver && sortLabel
|
||
? "ring-2 ring-brand/25 bg-accent/15"
|
||
: isOver
|
||
? "bg-accent/60"
|
||
: ""
|
||
}`}
|
||
>
|
||
{resolvedIssues.length > 0 ? (
|
||
<SortableContext items={issueIds} strategy={verticalListSortingStrategy}>
|
||
{resolvedIssues.length <= BOARD_VIRTUALIZE_THRESHOLD ? (
|
||
/* Small column: plain full render (reusing the same
|
||
itemContent, so it is byte-identical to the virtualized
|
||
rows). No handoff, no estimates — see
|
||
BOARD_VIRTUALIZE_THRESHOLD. The footer (infinite-scroll
|
||
sentinel) renders at the real end of the flow, where its
|
||
IntersectionObserver works the same as in Virtuoso's
|
||
Footer slot. */
|
||
<>
|
||
<VirtuosoSeed
|
||
data={resolvedIssues}
|
||
itemContent={itemContent}
|
||
computeItemKey={computeItemKey}
|
||
count={resolvedIssues.length}
|
||
/>
|
||
{footer}
|
||
</>
|
||
) : scrollEl ? (
|
||
<Virtuoso
|
||
customScrollParent={scrollEl}
|
||
data={resolvedIssues}
|
||
computeItemKey={computeItemKey}
|
||
initialScrollTop={restoredScrollTop}
|
||
initialItemCount={Math.min(resolvedIssues.length, BOARD_SEED_COUNT)}
|
||
defaultItemHeight={BOARD_CARD_ESTIMATED_HEIGHT}
|
||
increaseViewportBy={{ top: 300, bottom: 300 }}
|
||
components={footerComponents}
|
||
itemContent={itemContent}
|
||
/>
|
||
) : (
|
||
/* Large column, merged scroll ref not settled yet after a
|
||
remount: seed a bounded slice of real cards so the column
|
||
never paints blank; once the ref lands, mount the Virtuoso
|
||
with a matching `initialItemCount` to survive the
|
||
measurement frame (MUL-4750). */
|
||
<VirtuosoSeed
|
||
data={resolvedIssues}
|
||
itemContent={itemContent}
|
||
computeItemKey={computeItemKey}
|
||
count={BOARD_SEED_COUNT}
|
||
estimatedItemHeight={BOARD_CARD_ESTIMATED_HEIGHT}
|
||
/>
|
||
)}
|
||
</SortableContext>
|
||
) : (
|
||
<>
|
||
{issueIds.length === 0 && (
|
||
<p className="py-8 text-center text-xs text-muted-foreground">
|
||
{t(($) => $.board.empty_column)}
|
||
</p>
|
||
)}
|
||
{footer}
|
||
</>
|
||
)}
|
||
</div>
|
||
</div>
|
||
</div>
|
||
);
|
||
});
|
||
|
||
function BoardGroupHeading({
|
||
group,
|
||
count,
|
||
}: {
|
||
group: BoardColumnGroup;
|
||
count: number;
|
||
}) {
|
||
if (group.status) {
|
||
return <StatusHeading status={group.status} count={count} />;
|
||
}
|
||
|
||
if (group.propertyId !== undefined) {
|
||
return (
|
||
<div className="flex min-w-0 items-center gap-2">
|
||
<span
|
||
className="size-2.5 shrink-0 rounded-full bg-muted-foreground/30"
|
||
style={group.propertyOptionColor ? { backgroundColor: group.propertyOptionColor } : undefined}
|
||
/>
|
||
<span className="truncate text-sm font-medium" title={group.title}>
|
||
{group.title}
|
||
</span>
|
||
<span className="shrink-0 rounded-full bg-background px-1.5 py-0.5 text-[11px] font-medium tabular-nums text-muted-foreground">
|
||
{count}
|
||
</span>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
const actorIcon =
|
||
group.assigneeType && group.assigneeId ? (
|
||
<ActorAvatar
|
||
actorType={group.assigneeType}
|
||
actorId={group.assigneeId}
|
||
size="sm"
|
||
showStatusDot={group.assigneeType === "agent"}
|
||
/>
|
||
) : (
|
||
<span className="flex size-[18px] shrink-0 items-center justify-center rounded-full bg-background text-muted-foreground">
|
||
<UserMinus className="size-3.5" />
|
||
</span>
|
||
);
|
||
|
||
return (
|
||
<div className="flex min-w-0 items-center gap-2">
|
||
{actorIcon}
|
||
<span className="truncate text-sm font-medium" title={group.title}>
|
||
{group.title}
|
||
</span>
|
||
<span className="shrink-0 rounded-full bg-background px-1.5 py-0.5 text-[11px] font-medium tabular-nums text-muted-foreground">
|
||
{count}
|
||
</span>
|
||
</div>
|
||
);
|
||
}
|