mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-27 13:06:20 +02:00
ActorAvatarBase hardcoded `title={name}` on the avatar div, so every one of
the 155 avatar renders emitted a browser tooltip. On the 34 call sites that
also pass `enableHoverCard`, the native title sat on the inner div while the
PreviewCard trigger sat on an ancestor span — different elements, so neither
suppressed the other and both surfaces showed at once.
Same class of bug in two more places: AgentStatusDot added a third `title`
inside the same trigger on the 16 sites that also pass `showStatusDot`, and
RepoUrlText rendered a `title` carrying the exact string its Tooltip already
showed.
Phase 1 scope only — remove the three duplicate titles. PreviewCard trigger
semantics, `profileLink`, ancestor detection, the 159 call sites, and the
remaining native-title cleanup are deliberately untouched.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
226 lines
7.3 KiB
TypeScript
226 lines
7.3 KiB
TypeScript
import React from "react";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { render, screen } from "@testing-library/react";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { renderWithI18n } from "../test/i18n";
|
|
|
|
const longRepoUrl =
|
|
"https://github.com/multica-ai/a-very-long-repository-name-that-needs-a-tooltip";
|
|
const apiRepoUrl = "https://github.com/multica-ai/api";
|
|
const webRepoUrl = "https://github.com/multica-ai/web";
|
|
|
|
vi.mock("@tanstack/react-query", () => ({
|
|
useQuery: () => ({ data: [] }),
|
|
}));
|
|
|
|
vi.mock("@multica/core/projects/mutations", () => ({
|
|
useCreateProject: () => ({ mutateAsync: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("@multica/core/projects", () => ({
|
|
useProjectDraftStore: (selector: (state: unknown) => unknown) =>
|
|
selector({
|
|
draft: {
|
|
title: "",
|
|
description: "",
|
|
status: "planned",
|
|
priority: "medium",
|
|
leadType: undefined,
|
|
leadId: undefined,
|
|
icon: undefined,
|
|
},
|
|
setDraft: vi.fn(),
|
|
clearDraft: vi.fn(),
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@multica/core/hooks", () => ({
|
|
useWorkspaceId: () => "workspace-1",
|
|
}));
|
|
|
|
vi.mock("@multica/core/paths", () => ({
|
|
useCurrentWorkspace: () => ({
|
|
id: "workspace-1",
|
|
name: "Test Workspace",
|
|
slug: "test-workspace",
|
|
repos: [{ url: longRepoUrl }, { url: apiRepoUrl }, { url: webRepoUrl }],
|
|
}),
|
|
useWorkspacePaths: () => ({
|
|
projectDetail: (id: string) => `/test-workspace/projects/${id}`,
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@multica/core/workspace/queries", () => ({
|
|
memberListOptions: () => ({ queryKey: ["members"], queryFn: vi.fn() }),
|
|
agentListOptions: () => ({ queryKey: ["agents"], queryFn: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("@multica/core/workspace/hooks", () => ({
|
|
useActorName: () => ({ getActorName: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("../navigation", () => ({
|
|
useNavigation: () => ({ push: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("../editor", () => {
|
|
const ContentEditor = React.forwardRef<HTMLTextAreaElement, { placeholder?: string }>(
|
|
({ placeholder }, ref) => <textarea ref={ref} placeholder={placeholder} />,
|
|
);
|
|
ContentEditor.displayName = "ContentEditor";
|
|
|
|
return {
|
|
ContentEditor,
|
|
TitleEditor: ({
|
|
placeholder,
|
|
onChange,
|
|
}: {
|
|
placeholder?: string;
|
|
onChange?: (value: string) => void;
|
|
}) => <input placeholder={placeholder} onChange={(e) => onChange?.(e.target.value)} />,
|
|
};
|
|
});
|
|
|
|
vi.mock("../issues/components/priority-icon", () => ({
|
|
PriorityIcon: () => <span data-testid="priority-icon" />,
|
|
}));
|
|
|
|
vi.mock("../common/actor-avatar", () => ({
|
|
ActorAvatar: () => <span data-testid="actor-avatar" />,
|
|
}));
|
|
|
|
// Stub the date pickers so this test doesn't pull the real Calendar (and its
|
|
// buttonVariants import) into the modal's module graph; the pickers have their
|
|
// own test. The stubs render the placeholder label so the pills are assertable.
|
|
vi.mock("../projects/components/project-start-date-picker", () => ({
|
|
ProjectStartDatePicker: () => <button type="button">Start date</button>,
|
|
}));
|
|
|
|
vi.mock("../projects/components/project-due-date-picker", () => ({
|
|
ProjectDueDatePicker: () => <button type="button">Due date</button>,
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/ui/dialog", () => ({
|
|
Dialog: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DialogContent: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DialogTitle: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/ui/dropdown-menu", () => ({
|
|
DropdownMenu: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
DropdownMenuTrigger: ({ render }: { render: React.ReactNode }) => <>{render}</>,
|
|
DropdownMenuContent: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
DropdownMenuItem: ({
|
|
children,
|
|
onClick,
|
|
}: {
|
|
children: React.ReactNode;
|
|
onClick?: () => void;
|
|
}) => (
|
|
<button type="button" onClick={onClick}>
|
|
{children}
|
|
</button>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/ui/popover", () => ({
|
|
Popover: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
PopoverTrigger: ({ render }: { render: React.ReactNode }) => <>{render}</>,
|
|
PopoverContent: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/ui/tooltip", () => ({
|
|
Tooltip: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
TooltipTrigger: ({ render }: { render: React.ReactNode }) => <>{render}</>,
|
|
TooltipContent: ({ children }: { children: React.ReactNode }) => (
|
|
<div role="tooltip">{children}</div>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/ui/button", () => ({
|
|
Button: ({
|
|
children,
|
|
disabled,
|
|
onClick,
|
|
type = "button",
|
|
}: {
|
|
children: React.ReactNode;
|
|
disabled?: boolean;
|
|
onClick?: () => void;
|
|
type?: "button" | "submit" | "reset";
|
|
}) => (
|
|
<button type={type} disabled={disabled} onClick={onClick}>
|
|
{children}
|
|
</button>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@multica/ui/components/common/emoji-picker", () => ({
|
|
EmojiPicker: () => null,
|
|
}));
|
|
|
|
vi.mock("@multica/ui/lib/utils", () => ({
|
|
cn: (...values: Array<string | false | null | undefined>) =>
|
|
values.filter(Boolean).join(" "),
|
|
}));
|
|
|
|
vi.mock("sonner", () => ({
|
|
toast: {
|
|
success: vi.fn(),
|
|
error: vi.fn(),
|
|
},
|
|
}));
|
|
|
|
import { CreateProjectModal } from "./create-project";
|
|
|
|
describe("CreateProjectModal", () => {
|
|
it("exposes full repository URLs in the repository picker", () => {
|
|
render(<CreateProjectModal onClose={vi.fn()} />);
|
|
|
|
// The Tooltip is the single reveal mechanism. A native `title` carrying the
|
|
// same URL would stack a browser tooltip on top of it (MUL-4836).
|
|
expect(screen.getByRole("tooltip", { name: longRepoUrl })).toBeInTheDocument();
|
|
expect(screen.queryByTitle(longRepoUrl)).toBeNull();
|
|
});
|
|
|
|
it("reveals the start/due date pickers from the ⋯ overflow menu", async () => {
|
|
const user = userEvent.setup();
|
|
renderWithI18n(<CreateProjectModal onClose={vi.fn()} />);
|
|
|
|
// Dates are collapsed behind the overflow by default (progressive disclosure).
|
|
expect(screen.queryByRole("button", { name: "Start date" })).not.toBeInTheDocument();
|
|
expect(screen.queryByRole("button", { name: "Due date" })).not.toBeInTheDocument();
|
|
|
|
await user.click(screen.getByRole("button", { name: /Set start date/ }));
|
|
expect(screen.getByRole("button", { name: "Start date" })).toBeInTheDocument();
|
|
|
|
await user.click(screen.getByRole("button", { name: /Set due date/ }));
|
|
expect(screen.getByRole("button", { name: "Due date" })).toBeInTheDocument();
|
|
});
|
|
|
|
it("filters workspace repositories by search text", async () => {
|
|
const user = userEvent.setup();
|
|
|
|
renderWithI18n(<CreateProjectModal onClose={vi.fn()} />);
|
|
|
|
const repoSearchInput = screen.getByRole("textbox", { name: "Search repositories..." });
|
|
|
|
await user.type(repoSearchInput, "api");
|
|
|
|
expect(
|
|
screen.getByRole("button", { name: (name) => name.includes(apiRepoUrl) }),
|
|
).toBeInTheDocument();
|
|
expect(
|
|
screen.queryByRole("button", { name: (name) => name.includes(webRepoUrl) }),
|
|
).not.toBeInTheDocument();
|
|
expect(
|
|
screen.queryByRole("button", { name: (name) => name.includes(longRepoUrl) }),
|
|
).not.toBeInTheDocument();
|
|
|
|
await user.clear(repoSearchInput);
|
|
await user.type(repoSearchInput, "no-match");
|
|
|
|
expect(screen.getByText("No repositories match your search.")).toBeInTheDocument();
|
|
});
|
|
});
|