Files
multica/server/internal/integrations/slack/outbound.go
beast 387e4fee5d fix(channels): keep direct chat replies in Multica (MUL-4988) (#5645)
Classify outbound replies by task origin (chat_input_task_id) before consulting a channel binding, so web/mobile direct-chat completions and failures stay inside Multica even when the session was originally created from Lark or Slack. Channel-created tasks continue to deliver. Closes #5644.
2026-07-20 14:00:54 +08:00

189 lines
6.4 KiB
Go

package slack
import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
"time"
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgtype"
"github.com/slack-go/slack"
"github.com/multica-ai/multica/server/internal/events"
"github.com/multica-ai/multica/server/internal/integrations/channel"
"github.com/multica-ai/multica/server/internal/util"
db "github.com/multica-ai/multica/server/pkg/db/generated"
"github.com/multica-ai/multica/server/pkg/protocol"
)
// outboundQueries is the slice of generated queries the Slack outbound
// subscriber needs. *db.Queries satisfies it.
type outboundQueries interface {
GetAgentTask(ctx context.Context, id pgtype.UUID) (db.AgentTaskQueue, error)
GetChannelChatSessionBindingBySession(ctx context.Context, arg db.GetChannelChatSessionBindingBySessionParams) (db.ChannelChatSessionBinding, error)
GetChannelInstallation(ctx context.Context, arg db.GetChannelInstallationParams) (db.ChannelInstallation, error)
}
// replySender posts one reply. Satisfied by *slackSender, so the outbound path
// reuses Send's Markdown->mrkdwn conversion, chunking, and threading.
type replySender interface {
Send(ctx context.Context, out channel.OutboundMessage) (channel.SendResult, error)
}
// Outbound delivers an agent's chat reply back to Slack — the outbound half of
// the round trip. It mirrors the Feishu Patcher: on EventChatDone it finds the
// Slack chat binding for the finished task's session and posts the reply into
// the originating channel/thread. Sessions with no Slack binding are ignored,
// so it coexists with the Feishu Patcher on the shared event bus. It is only
// registered when Slack is configured.
type Outbound struct {
q outboundQueries
decrypt Decrypter
logger *slog.Logger
newSender func(creds credentials) replySender
}
// NewOutbound builds the Slack outbound subscriber over the generated queries
// and the bot/app-token decrypter.
func NewOutbound(q outboundQueries, decrypt Decrypter, logger *slog.Logger) *Outbound {
if logger == nil {
logger = slog.Default()
}
o := &Outbound{q: q, decrypt: decrypt, logger: logger}
o.newSender = func(c credentials) replySender {
// Only the bot token is needed to post; inbound Socket Mode uses the
// installation's separate app-level token (see slack_channel.go).
return newSlackSender(c, slack.New(c.BotToken), logger)
}
return o
}
// Register subscribes to the chat-done event on the bus.
func (o *Outbound) Register(bus *events.Bus) {
bus.Subscribe(protocol.EventChatDone, o.handleEvent)
}
func (o *Outbound) handleEvent(e events.Event) {
// Bus delivery is synchronous, so a stuck Slack HTTP call must not wedge the
// publish call site: use a fresh ctx with a tight timeout.
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
if err := o.processEvent(ctx, e); err != nil {
o.logger.WarnContext(ctx, "slack outbound: reply delivery failed",
"error", err, "chat_session_id", e.ChatSessionID)
}
}
func (o *Outbound) processEvent(ctx context.Context, e events.Event) error {
sessionID, err := util.ParseUUID(e.ChatSessionID)
if err != nil || !sessionID.Valid {
// Issue / autopilot tasks carry no chat_session.
return nil
}
binding, err := o.q.GetChannelChatSessionBindingBySession(ctx, db.GetChannelChatSessionBindingBySessionParams{
ChatSessionID: sessionID,
ChannelType: string(TypeSlack),
})
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return nil // not a Slack session (Feishu / web-only)
}
return fmt.Errorf("lookup slack chat binding: %w", err)
}
content := chatDoneContent(e.Payload)
if content == "" {
return nil // nothing to say (empty completion)
}
// Only bound, non-empty completions reach here, so classify the task origin
// before loading credentials or sending. Web/mobile direct-chat tasks can
// reuse a session that originated in Slack, but their replies belong only in
// Multica. Outbound delivery fails closed when the origin cannot be
// established; channel-created tasks leave chat_input_task_id NULL and send.
taskID, ok := chatDoneTaskID(e)
if !ok {
return nil
}
task, err := o.q.GetAgentTask(ctx, taskID)
if err != nil {
return fmt.Errorf("load agent task: %w", err)
}
if task.ChatInputTaskID.Valid {
return nil
}
inst, err := o.q.GetChannelInstallation(ctx, db.GetChannelInstallationParams{
ID: binding.InstallationID,
ChannelType: string(TypeSlack),
})
if err != nil {
return fmt.Errorf("load slack installation: %w", err)
}
if inst.Status != "active" {
return nil // revoked between trigger and reply
}
creds, err := decodeCredentials(inst.Config, o.decrypt)
if err != nil {
return fmt.Errorf("decode slack credentials: %w", err)
}
channelID, threadTS := outboundTarget(binding)
if _, err := o.newSender(creds).Send(ctx, channel.OutboundMessage{
ChatID: channelID,
Text: content,
ThreadID: threadTS,
}); err != nil {
return fmt.Errorf("post slack reply: %w", err)
}
return nil
}
// chatDoneTaskID extracts the task id from the event envelope or the typed/map
// payload emitted by TaskService. Outbound delivery fails closed when the task
// origin cannot be established.
func chatDoneTaskID(e events.Event) (pgtype.UUID, bool) {
raw := e.TaskID
if raw == "" {
switch p := e.Payload.(type) {
case protocol.ChatDonePayload:
raw = p.TaskID
case map[string]any:
raw, _ = p["task_id"].(string)
}
}
id, err := util.ParseUUID(raw)
return id, err == nil && id.Valid
}
// outboundTarget recovers the real send target from the chat binding. The
// channel_chat_id may be a composite "channel:threadRoot" isolation key, so the
// real channel id is read from the binding config (slackBindingConfig); the
// reply thread is the recorded last_thread_id.
func outboundTarget(b db.ChannelChatSessionBinding) (channelID, threadTS string) {
channelID = b.ChannelChatID
if len(b.Config) > 0 {
var cfg slackBindingConfig
if err := json.Unmarshal(b.Config, &cfg); err == nil && cfg.ChannelID != "" {
channelID = cfg.ChannelID
}
}
if b.LastThreadID.Valid {
threadTS = b.LastThreadID.String
}
return channelID, threadTS
}
// chatDoneContent extracts the reply text from an EventChatDone payload (the
// typed payload, or its map form after a serialization round trip).
func chatDoneContent(payload any) string {
switch p := payload.(type) {
case protocol.ChatDonePayload:
return p.Content
case map[string]any:
if s, ok := p["content"].(string); ok {
return s
}
}
return ""
}