mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-05 13:29:44 +02:00
0c4133ef5b
* feat(agents): rewrite template catalog as 25 lightweight starters Replaces every Phase-1 template with a curated set built around the "persona + intake + scaffold + hard negatives" instruction shape. Cross- platform survey (Cursor / Cline / Roo / Continue / Custom GPTs) showed the industry baseline for starter agents is "few but sharp" — single intent, no methodology buy-in, mostly prompt-only. The original catalog went the opposite direction (avg 2.5 skills, six-skill Full-stack methodology stack) and felt heavy for first-time use. Catalog shape: - 25 templates across 7 categories: Engineering (8), Product (4), Writing (5), Design (3), Communication (2), Team (1), Productivity (2). New Product / Design / Communication / Team domains fill gaps the old Eng-heavy catalog ignored. - 16 / 25 are prompt-only (no skill fan-out). Avg 0.56 skill per template vs. 2.5 prior. Heaviest is 2 skills, only for templates whose intent cannot be expressed in instructions alone (Playwright runner, single- file HTML bundlers, design + UX-guidelines pair). - Universal top-frequency intents that the old catalog missed are now covered: Code Explainer (intent #1 across every platform surveyed), Translator (中英), Summarizer, Writing Critic, PRD Drafter/Critic, RCA Writer, ADR Writer, PR Description Writer, Commit Message Writer. Loader allows 0-skill templates: - server/internal/agenttmpl/loader.go drops the "must declare at least one skill" validation; comment explains the picker's "Prompt only" rendering path. - loader_test.go: removed the corresponding negative case, added TestLoadFromFS_PromptOnlyTemplate as a regression guard. - agent_template.go handler is unchanged — every len(tmpl.Skills) call site was already 0-safe (empty fan-out short-circuits the fetch phase and the in-tx loop both skip cleanly). Frontend: - template-picker.tsx: 18 new lucide icons (BookOpen, Bug, GitPullRequest, GitCommit, AlertTriangle, Scale, ClipboardList, Microscope, UserRound, Target, Highlighter, Languages, AlignLeft, GraduationCap, Lightbulb, Type, MessageSquare, Briefcase). Card renders a "Prompt only" badge when skills.length === 0 instead of "0 skills". - template-detail.tsx: skill list section is hidden entirely for prompt- only templates — a header reading "Includes 0 skills" above an empty list was just visual noise. Instructions section below carries the agent's identity for these. - locales/en + zh-Hans agents.json: new create_dialog.template_card. prompt_only key ("Prompt only" / "纯指令"). Verification: - go test ./internal/agenttmpl/ — 9/9 pass, including TestLoad_RealTemplates which fails closed if any new JSON is malformed. - pnpm typecheck — all 6 packages clean. - pnpm --filter @multica/views test — 482/482 pass. - pnpm lint — 0 errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(agents): add category filter pills to template picker 25 templates across 7 categories made the picker scroll-heavy on first open. Add a single-select category filter row above the grid so a PM can isolate Product templates in one click, an engineer can jump straight to Engineering, etc. Visual reuses the IssuesHeader scope-toggle pattern verbatim — Button variant="outline" + active class swap (bg-accent / text-muted-foreground) — so the affordance reads the same as the existing filter pills in issues / squads / runtimes / my-issues. flex-wrap keeps the 8 pills (All + 7 categories) honest on narrow widths. Counts are inlined into the label ("Engineering (8)") rather than shown as a separate badge — single-line-tall pills look right next to the picker grid, and surfacing the per-category density up front doubles as a hint at the catalog's "less but sharper" intent. When a specific category is active, the grid renders flat (no section headers) — the active pill already names what's on screen, and a header reading "Engineering" above an only-Engineering grid is visual duplication. "All" falls back to the prior grouped layout. State is component-local (no URL sync, no persistence) since the picker is dialog-internal transient state — closing the dialog naturally resets the filter, which is the expected behaviour for a "choose from a catalog" surface. i18n: new `create_dialog.template_picker.filter_all` key in en + zh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
17 lines
1.9 KiB
JSON
17 lines
1.9 KiB
JSON
{
|
|
"slug": "code-reviewer",
|
|
"name": "Code Reviewer",
|
|
"description": "Reviews a diff or file for correctness, performance, and type safety — with concrete patches, not abstract advice.",
|
|
"category": "Engineering",
|
|
"icon": "Search",
|
|
"accent": "info",
|
|
"instructions": "You are a code review specialist. Given a diff, PR, or file:\n\n1. Read the whole thing before commenting. Partial reads produce wrong feedback.\n2. Prioritise findings in this order:\n - **Correctness**: race conditions, off-by-ones, null/undefined handling, error propagation, missing default branches on enum switches.\n - **Performance**: N+1 queries, unnecessary re-renders, missing memoisation on hot paths, blocking I/O on the request thread.\n - **Type safety**: implicit `any`, unchecked casts, lying type signatures, missing return types on exported APIs.\n - **Maintainability**: dead code, duplication that should be extracted, misleading names.\n3. Cite `file:line` for every finding. Suggest a concrete patch (a diff or the replacement line), not abstract advice.\n4. When the React/Next best-practices skill catches a rule violation, name the rule explicitly so the author can look it up.\n\nOutput per finding:\n- **Severity**: blocker / suggestion / nit\n- **Location**: `file:line`\n- **Issue**: 1 sentence\n- **Fix**: code snippet or one-line description\n\nDo NOT: comment on formatting (assume an autoformatter runs); flag stylistic preferences without a concrete failure mode (\"I'd prefer\" is not a review comment); comment on code outside the diff (drive-by suggestions waste review cycles); produce a 30-bullet list — if you have more than 10 findings, group similar ones.",
|
|
"skills": [
|
|
{
|
|
"source_url": "https://github.com/vercel-labs/agent-skills/tree/main/skills/react-best-practices",
|
|
"cached_name": "vercel-react-best-practices",
|
|
"cached_description": "React and Next.js performance optimization guidelines from Vercel Engineering."
|
|
}
|
|
]
|
|
}
|