Files
multica/server/internal/daemon/execenv/codex_skill_strip_test.go
Bohan Jiang e4103f6ad7 fix(execenv): strip [[skills.config]] from per-task codex config.toml (#1816)
Codex Desktop writes one [[skills.config]] entry per known skill into
~/.codex/config.toml. File-backed entries get path = "...", but
plugin-backed entries (e.g. name = "superpowers:brainstorming") only get
a name. Codex CLI 0.114's TOML deserializer treats path as required, so
it rejects the plugin entries with "missing field path" and fails
thread/start.

The daemon copies ~/.codex/config.toml verbatim into each task's
isolated codex-home, which propagated those broken entries into the
per-task config and blocked every Codex agent run for affected users.

Strip the whole [[skills.config]] array on copy. Multica writes the
agent's currently assigned skills directly to codex-home/skills/ and
Codex auto-discovers them from there, so the user-level skill registry
is redundant for a per-task run.

Closes #1753
2026-04-29 14:06:29 +08:00

200 lines
4.0 KiB
Go

package execenv
import (
"os"
"path/filepath"
"strings"
"testing"
)
func TestStripSkillsConfigEntries(t *testing.T) {
t.Parallel()
tests := []struct {
name string
in string
want string
}{
{
name: "no skills config — returned unchanged",
in: "model = \"o3\"\n",
want: "model = \"o3\"\n",
},
{
name: "drops well-formed file-backed entry",
in: `model = "o3"
[[skills.config]]
path = "/Users/x/SKILL.md"
enabled = true
`,
want: `model = "o3"
`,
},
{
name: "drops plugin entry that lacks path",
in: `[[skills.config]]
name = "superpowers:brainstorming"
enabled = false
[profiles.default]
model = "o3"
`,
want: `[profiles.default]
model = "o3"
`,
},
{
name: "drops a mix of consecutive entries and preserves surrounding tables",
in: `model = "o3"
[[skills.config]]
path = "/Users/x/SKILL.md"
enabled = false
[[skills.config]]
path = "/Users/y/SKILL.md"
enabled = false
[[skills.config]]
name = "superpowers:brainstorming"
enabled = false
[profiles.default]
model = "o3"
[mcp_servers.foo]
command = "foo"
`,
want: `model = "o3"
[profiles.default]
model = "o3"
[mcp_servers.foo]
command = "foo"
`,
},
{
name: "skills.config at EOF",
in: `model = "o3"
[[skills.config]]
name = "superpowers:dispatching-parallel-agents"
enabled = false
`,
want: `model = "o3"
`,
},
{
name: "preserves unrelated [skills] table (single brackets)",
in: `[skills]
discovery_path = "skills"
`,
want: `[skills]
discovery_path = "skills"
`,
},
{
name: "fully empty after strip returns empty string",
in: `[[skills.config]]
name = "x"
enabled = false
`,
want: ``,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
got := stripSkillsConfigEntries(tt.in)
if got != tt.want {
t.Errorf("stripSkillsConfigEntries result mismatch\n--- got ---\n%s\n--- want ---\n%s", got, tt.want)
}
})
}
}
func TestSanitizeCopiedCodexConfig(t *testing.T) {
t.Parallel()
dir := t.TempDir()
configPath := filepath.Join(dir, "config.toml")
original := `model = "o3"
[[skills.config]]
name = "superpowers:brainstorming"
enabled = false
[[skills.config]]
path = "/Users/x/SKILL.md"
enabled = true
[profiles.default]
model = "o3"
`
if err := os.WriteFile(configPath, []byte(original), 0o644); err != nil {
t.Fatalf("write fixture: %v", err)
}
if err := sanitizeCopiedCodexConfig(configPath); err != nil {
t.Fatalf("sanitizeCopiedCodexConfig failed: %v", err)
}
data, err := os.ReadFile(configPath)
if err != nil {
t.Fatalf("read result: %v", err)
}
got := string(data)
if strings.Contains(got, "[[skills.config]]") {
t.Errorf("expected all [[skills.config]] entries to be removed, got:\n%s", got)
}
if !strings.Contains(got, `[profiles.default]`) {
t.Errorf("unrelated tables should be preserved, got:\n%s", got)
}
if !strings.Contains(got, `model = "o3"`) {
t.Errorf("top-level keys should be preserved, got:\n%s", got)
}
}
func TestSanitizeCopiedCodexConfigNoop(t *testing.T) {
t.Parallel()
dir := t.TempDir()
configPath := filepath.Join(dir, "config.toml")
original := "model = \"o3\"\n"
if err := os.WriteFile(configPath, []byte(original), 0o644); err != nil {
t.Fatalf("write fixture: %v", err)
}
infoBefore, err := os.Stat(configPath)
if err != nil {
t.Fatalf("stat before: %v", err)
}
if err := sanitizeCopiedCodexConfig(configPath); err != nil {
t.Fatalf("sanitizeCopiedCodexConfig failed: %v", err)
}
infoAfter, err := os.Stat(configPath)
if err != nil {
t.Fatalf("stat after: %v", err)
}
if !infoAfter.ModTime().Equal(infoBefore.ModTime()) {
t.Errorf("file should not be rewritten when there is nothing to strip")
}
data, _ := os.ReadFile(configPath)
if string(data) != original {
t.Errorf("content drifted: got %q, want %q", data, original)
}
}
func TestSanitizeCopiedCodexConfigMissingFile(t *testing.T) {
t.Parallel()
missing := filepath.Join(t.TempDir(), "does-not-exist.toml")
if err := sanitizeCopiedCodexConfig(missing); err != nil {
t.Errorf("missing file should be a no-op, got error: %v", err)
}
}