mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-31 00:40:46 +02:00
* perf(views): virtualize issue detail timeline with react-virtuoso The unvirtualized timeline at issue-detail.tsx full-mounted every entry, freezing first paint for several seconds at 500+ comments (markdown parse + lowlight per CommentCard on mount). Production p99 is ~30 comments but the all-time max is ~1.1k and the server hard-caps at 2000 — long-tail issues were unusable. Swap the inline `.map` for `<Virtuoso customScrollParent>` driven by a flattened TimelineItem discriminated union. TanStack Query stays the source of truth; existing memo machinery (`prevThreadRepliesRef`, `EMPTY_REPLIES`) and WS handlers are untouched. `followOutput="auto"` matches Slack/Discord — users at the bottom auto-follow new comments, users mid-scroll are not yanked back down. Comment drafts move to a new persisted Zustand store (`comment-draft-store`) so virtualization-driven unmount can no longer drop in-progress edits or new comments. Hydrates via ContentEditor `defaultValue`, flushes on update / blur / visibilitychange. Deep-link from inbox is rewritten from `getElementById` + `scrollIntoView` to `virtuosoRef.scrollToIndex` with a double-rAF mitigation for the Virtuoso #883 initial-scroll race. Highlight flash bumped 2s→3s to outlast mount latency on cold cards. Cmd-F shows a once-per-session toast on long timelines since browser find-in-page can't reach off-screen virtualized items. Real in-app search lands in a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(views): repair deep-link scroll and isolate comment drafts The first virtualization landing had three latent issues that runtime testing on perf fixtures (10 → 5000 comments) exposed: 1. Deep-link landing position was wrong by ~380px on every issue. In customScrollParent mode Virtuoso computes scrollTop from the list's internal coordinate space only — it doesn't account for sibling content (title editor, description, sub-issues, agent card) sitting above the list inside the same scroll parent. The useEffect now uses Virtuoso scrollToIndex only to MOUNT the target into the DOM, then polls a `data-comment-id` anchor and delegates positioning to the browser's scrollIntoView, which honors getBoundingClientRect and lands accurately every time. 2. Scroll-up was being yanked back to the deep-link anchor on every ResizeObserver tick. Root cause was `followOutput="auto"`, which stays "stuck to bottom" once the deep-link lands there and resets scrollTop to maxScrollTop on each height change. Issue detail is document-shaped, not chat-shaped, so removing followOutput altogether is the right tradeoff. Likewise `initialTopMostItemIndex` acts as a persistent anchor in customScrollParent mode (Virtuoso #458) — dropped entirely and replaced with imperative scroll. `defaultItemHeight` is also dropped so Virtuoso probes real heights instead of estimating + correcting visually. 3. Reply-comment deep-links from the inbox would short-circuit because the reply id isn't in the flat items[] array. Added a replyToRoot map so deep-link falls back to the enclosing thread's root index, scrolls there, and lets the reply's own ring fire once the thread is in view. Also fixes a latent cross-issue draft leak in `<CommentInput>`: web's /issues/[id] route doesn't remount IssueDetail on issueId change, so without an explicit `key={id}` the editor kept the previous issue's in-memory content and the next keystroke would flush it under the new issue's draft key. The same fix incidentally repairs the pre-existing "submit composer from issue A while viewing issue B" submit-target bug. Highlight UX polish: bg-brand/5 was too faint to notice; ring upgraded to ring-brand/60 as the sole signal. transition-colors didn't actually animate ring/box-shadow — switched to transition-shadow duration-500 ease-out so highlight has visible fade in / fade out. Flash duration 3s → 4s. Polling failure now still sets highlight + warns so a manual scroll to the target still flashes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
188 lines
6.9 KiB
TypeScript
188 lines
6.9 KiB
TypeScript
"use client";
|
|
|
|
import { useRef, useState, useCallback, useEffect } from "react";
|
|
import { ArrowUp, Loader2, Maximize2, Minimize2 } from "lucide-react";
|
|
import { ContentEditor, type ContentEditorRef, useFileDropZone, FileDropOverlay } from "../../editor";
|
|
import { FileUploadButton } from "@multica/ui/components/common/file-upload-button";
|
|
import { Tooltip, TooltipTrigger, TooltipContent } from "@multica/ui/components/ui/tooltip";
|
|
import { ActorAvatar } from "../../common/actor-avatar";
|
|
import { useFileUpload } from "@multica/core/hooks/use-file-upload";
|
|
import { api } from "@multica/core/api";
|
|
import { useCommentDraftStore, type CommentDraftKey } from "@multica/core/issues/stores";
|
|
import { cn } from "@multica/ui/lib/utils";
|
|
import { useT } from "../../i18n";
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Types
|
|
// ---------------------------------------------------------------------------
|
|
|
|
interface ReplyInputProps {
|
|
issueId: string;
|
|
placeholder?: string;
|
|
avatarType: string;
|
|
avatarId: string;
|
|
onSubmit: (content: string, attachmentIds?: string[]) => Promise<void>;
|
|
size?: "sm" | "default";
|
|
/** When set, hydrates/persists the in-progress reply via the draft store.
|
|
* Required for replies inside virtualized timeline threads, where the
|
|
* enclosing CommentCard may unmount on scroll-out. */
|
|
draftKey?: CommentDraftKey;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// ReplyInput
|
|
// ---------------------------------------------------------------------------
|
|
|
|
function ReplyInput({
|
|
issueId,
|
|
placeholder,
|
|
avatarType,
|
|
avatarId,
|
|
onSubmit,
|
|
size = "default",
|
|
draftKey,
|
|
}: ReplyInputProps) {
|
|
const { t } = useT("issues");
|
|
const placeholderText = placeholder ?? t(($) => $.reply.placeholder);
|
|
const editorRef = useRef<ContentEditorRef>(null);
|
|
// If a draft key is provided, hydrate from store on mount (defaultValue is
|
|
// the only injection point on ContentEditorRef) and flush on every onUpdate.
|
|
const initialDraft = draftKey
|
|
? useCommentDraftStore.getState().getDraft(draftKey)
|
|
: undefined;
|
|
const setDraft = useCommentDraftStore((s) => s.setDraft);
|
|
const clearDraft = useCommentDraftStore((s) => s.clearDraft);
|
|
const [isEmpty, setIsEmpty] = useState(!initialDraft?.trim());
|
|
const [isExpanded, setIsExpanded] = useState(false);
|
|
const [submitting, setSubmitting] = useState(false);
|
|
const uploadMapRef = useRef<Map<string, string>>(new Map());
|
|
const { uploadWithToast } = useFileUpload(api);
|
|
const { isDragOver, dropZoneProps } = useFileDropZone({
|
|
onDrop: (files) => files.forEach((f) => editorRef.current?.uploadFile(f)),
|
|
});
|
|
|
|
// Flush on tab close / mobile background — same rationale as CommentInput.
|
|
useEffect(() => {
|
|
if (!draftKey) return;
|
|
const flush = () => {
|
|
const md = editorRef.current?.getMarkdown();
|
|
if (md && md.trim().length > 0) setDraft(draftKey, md);
|
|
};
|
|
const onVis = () => { if (document.visibilityState === "hidden") flush(); };
|
|
document.addEventListener("visibilitychange", onVis);
|
|
window.addEventListener("pagehide", flush);
|
|
return () => {
|
|
document.removeEventListener("visibilitychange", onVis);
|
|
window.removeEventListener("pagehide", flush);
|
|
};
|
|
}, [draftKey, setDraft]);
|
|
|
|
const handleUpload = useCallback(async (file: File) => {
|
|
const result = await uploadWithToast(file, { issueId });
|
|
if (result) {
|
|
uploadMapRef.current.set(result.link, result.id);
|
|
}
|
|
return result;
|
|
}, [uploadWithToast, issueId]);
|
|
|
|
const handleSubmit = async () => {
|
|
const content = editorRef.current?.getMarkdown()?.replace(/(\n\s*)+$/, "").trim();
|
|
if (!content || submitting) return;
|
|
// Only send attachment IDs for uploads still present in the content.
|
|
const activeIds: string[] = [];
|
|
for (const [url, id] of uploadMapRef.current) {
|
|
if (content.includes(url)) activeIds.push(id);
|
|
}
|
|
setSubmitting(true);
|
|
try {
|
|
await onSubmit(content, activeIds.length > 0 ? activeIds : undefined);
|
|
editorRef.current?.clearContent();
|
|
setIsEmpty(true);
|
|
uploadMapRef.current.clear();
|
|
if (draftKey) clearDraft(draftKey);
|
|
} finally {
|
|
setSubmitting(false);
|
|
}
|
|
};
|
|
|
|
const avatarSize = size === "sm" ? 22 : 28;
|
|
|
|
return (
|
|
<div className="group/editor flex items-start gap-2.5">
|
|
<ActorAvatar
|
|
actorType={avatarType}
|
|
actorId={avatarId}
|
|
size={avatarSize}
|
|
className="mt-0.5 shrink-0"
|
|
/>
|
|
<div
|
|
{...dropZoneProps}
|
|
className={cn(
|
|
"relative min-w-0 flex-1 flex flex-col",
|
|
isExpanded
|
|
? "h-[60vh]"
|
|
: size === "sm" ? "max-h-40" : "max-h-56",
|
|
(!isEmpty || isExpanded) && "pb-7",
|
|
)}
|
|
>
|
|
<div className="flex-1 min-h-0 overflow-y-auto">
|
|
<ContentEditor
|
|
ref={editorRef}
|
|
defaultValue={initialDraft}
|
|
placeholder={placeholderText}
|
|
onUpdate={(md) => {
|
|
setIsEmpty(!md.trim());
|
|
if (draftKey) {
|
|
if (md.trim().length > 0) setDraft(draftKey, md);
|
|
else clearDraft(draftKey);
|
|
}
|
|
}}
|
|
onSubmit={handleSubmit}
|
|
onUploadFile={handleUpload}
|
|
debounceMs={100}
|
|
currentIssueId={issueId}
|
|
/>
|
|
</div>
|
|
<div className="absolute bottom-0 right-0 flex items-center gap-1">
|
|
<Tooltip>
|
|
<TooltipTrigger
|
|
render={
|
|
<button
|
|
type="button"
|
|
onClick={() => {
|
|
setIsExpanded((v) => !v);
|
|
editorRef.current?.focus();
|
|
}}
|
|
className="inline-flex h-6 w-6 items-center justify-center rounded-sm text-muted-foreground opacity-70 hover:opacity-100 hover:bg-accent/60 transition-all cursor-pointer"
|
|
>
|
|
{isExpanded ? <Minimize2 className="h-3.5 w-3.5" /> : <Maximize2 className="h-3.5 w-3.5" />}
|
|
</button>
|
|
}
|
|
/>
|
|
<TooltipContent side="top">{isExpanded ? t(($) => $.reply.collapse_tooltip) : t(($) => $.reply.expand_tooltip)}</TooltipContent>
|
|
</Tooltip>
|
|
<FileUploadButton
|
|
size="sm"
|
|
onSelect={(file) => editorRef.current?.uploadFile(file)}
|
|
/>
|
|
<button
|
|
type="button"
|
|
disabled={isEmpty || submitting}
|
|
onClick={handleSubmit}
|
|
className="inline-flex h-6 w-6 items-center justify-center rounded-full text-muted-foreground hover:bg-accent hover:text-foreground transition-colors disabled:opacity-50 disabled:pointer-events-none"
|
|
>
|
|
{submitting ? (
|
|
<Loader2 className="h-3.5 w-3.5 animate-spin" />
|
|
) : (
|
|
<ArrowUp className="h-3.5 w-3.5" />
|
|
)}
|
|
</button>
|
|
</div>
|
|
{isDragOver && <FileDropOverlay />}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export { ReplyInput, type ReplyInputProps };
|