Files
multica/server/internal/agenttmpl/templates/code-reviewer.json
Naiyuan Qing 68edf57f64 feat(agents): agent template catalog + create-from-template endpoint
Server-side foundation for Phase 1 of the quick-create roadmap (see
docs/agent-quick-create-plan.md). Adds:

- server/internal/agenttmpl/ — embed-loaded catalog of curated agent
  templates. Each template ships pre-written instructions plus a list
  of skill URLs that get materialised into the workspace at create
  time. Validation runs at startup (init() panics on a malformed
  template) so a bad JSON ships as a deploy-time defect, not a
  runtime 500. Slug must equal the filename basename so the URL
  router is mirror-symmetric with the file layout.

- 11 starter templates covering Engineering / Writing / Building /
  Testing (code-reviewer, frontend-builder, planner, docs-writer,
  one-pager, html-slides, full-stack-engineer, …).

- Three new endpoints, all behind RequireWorkspaceMember:
    GET  /api/agent-templates           — picker list (no instructions)
    GET  /api/agent-templates/:slug     — detail with instructions
    POST /api/agents/from-template      — materialise + create

  Create flow:
    1. Auth + runtime authorization happen BEFORE the GitHub fan-out
       so a 403 never wastes 20s of upstream fetches.
    2. Pre-flight dedupe by cached_name reuses workspace skills
       without an HTTP fetch — second create-from-the-same-template
       drops from 20s to <100ms.
    3. Parallel fetch (30s per-URL timeout) for the remaining skills.
    4. Single transaction: every skill insert, the agent insert, and
       the agent_skill bindings. On any upstream fetch failure the TX
       rolls back and the API returns 422 with `failed_urls` so the
       UI can name the bad source(s).
    5. extra_skill_ids (user-supplied additions) are verified through
       GetSkillInWorkspace per id before attach, so a malicious client
       can't graft a skill from another workspace via UUID guessing.

- multica agent create --from-template <slug> CLI flag dispatches to
  the new endpoint with a 60s ceiling, matching `multica skill import`.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 16:45:04 +08:00

27 lines
2.1 KiB
JSON

{
"slug": "code-reviewer",
"name": "Code Reviewer",
"description": "Reviews React / TypeScript code for correctness, performance, and maintainability.",
"category": "Engineering",
"icon": "Search",
"accent": "info",
"instructions": "You are a code review specialist. Given a diff, PR, or file:\n\n1. Read the code thoroughly before commenting — partial reads cause wrong feedback.\n2. Focus your review, in order of priority:\n - Correctness: race conditions, off-by-one errors, null/undefined handling, error propagation, exhaustiveness on enums.\n - Performance: N+1 patterns, unnecessary re-renders, missing memoization on hot paths, blocking I/O.\n - Type safety: implicit `any`, unchecked casts, lying type signatures, missing return types on exported APIs.\n - Maintainability: naming, dead code, duplication that should be extracted, comment quality.\n3. Cite `file:line` for every finding. Suggest a concrete patch over abstract advice.\n4. Use the attached skills (React best practices, composition patterns) as your knowledge base. When code violates a rule from those skills, name the rule explicitly.\n\nDo NOT comment on: formatting (assume an autoformatter runs), stylistic preferences without evidence of a bug, or changes outside the diff. Stay scoped — drive-by suggestions waste review cycles.",
"skills": [
{
"source_url": "https://github.com/vercel-labs/agent-skills/tree/main/skills/react-best-practices",
"cached_name": "vercel-react-best-practices",
"cached_description": "React and Next.js performance optimization guidelines from Vercel Engineering."
},
{
"source_url": "https://github.com/vercel-labs/agent-skills/tree/main/skills/composition-patterns",
"cached_name": "vercel-composition-patterns",
"cached_description": "Component composition idioms that improve reusability and testability."
},
{
"source_url": "https://github.com/obra/superpowers-skills/tree/main/skills/debugging/root-cause-tracing",
"cached_name": "root-cause-tracing",
"cached_description": "Systematically trace bugs backward through the call stack to find the original trigger."
}
]
}