mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-05 09:30:05 +02:00
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary navigation and working surface, on the "associations bind at creation time only" model. Model - Issue <-> space is the only enforced ownership (per-space numbering). Parent/child and project<->space associations only seed defaults at creation; cross-space/child and project-association validations are removed. - Moving an issue renumbers it and records the old identifier in issue_identifier_alias; API/CLI lookups and GitHub branch/PR auto-linking fall back to the alias, so old identifiers resolve forever. - Membership drives only the sidebar and personal defaults — never access. Anyone can configure any space's member set wholesale (PUT /api/spaces/{id}/members); saving an empty set archives the space behind a confirm. - Per-user space order (workspace_space_member.sort_order, fractional): drag-sorted sidebar, "my first space" is the personal issue-creation default; the workspace default space backs headless creation (agents/CLI/Slack) and system placement. Surfaces - Sidebar: joined-spaces section (drag reorder, row -> space page, per-group persisted collapse), Workspace group with a More menu, Settings demoted to a footer icon. - /space/:key/{issues,projects,autopilots,settings} — space surfaces reuse shared page components; a routed /space/new create page (replacing the earlier create-space modal), reserved key "NEW" so it can never collide with a real space's /space/:key detail page. - Issue detail moves to /issue/:id (identifier-first, Linear-style; old /issues/:id redirects); create dialogs lead with a required space pill. - Agent runtime brief now carries Space context (id/key/name) through the daemon claim -> TaskContextForEnv -> prompt pipeline, with a "## Space Context" section and --space on issue create/update in both brief renderers, matching Project's existing treatment. - zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx. Fixes along the way - Cache membership judgment gains the space dimension + space_changed WS flag. - Silent skip on default-space lookup during invite acceptance is now a hard failure (no space-less members). - Backfilled space_id into ~28 raw-SQL Go test fixtures across internal/handler and cmd/server that predated migration 132's NOT NULL cutover. - Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/ unmount cycle on resolution failure) and gave it its own loading skeleton instead of a blank screen while resolving. - reserved-slugs generator's stale hardcoded doc-comment example synced back to /create-space. Verification - go build ./..., go vet ./..., go test ./... all clean. - pnpm typecheck (core/views/web/desktop) clean. - packages/views: 162 files / 1656 tests passing. - pnpm generate:reserved-slugs produces no diff. Follow-ups tracked in docs/follow-ups/space-rollout.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
86 lines
2.9 KiB
TypeScript
86 lines
2.9 KiB
TypeScript
import type { ZodType } from "zod";
|
|
import { type Logger, noopLogger } from "../logger";
|
|
|
|
// Module-level logger for schema warnings. Defaults to no-op so test
|
|
// runs don't spam stderr; the platform layer wires a real logger via
|
|
// `setSchemaLogger` at app boot.
|
|
let schemaLogger: Logger = noopLogger;
|
|
|
|
export function setSchemaLogger(logger: Logger): void {
|
|
schemaLogger = logger;
|
|
}
|
|
|
|
export interface ParseOptions {
|
|
/** Endpoint identifier used in the warning log so we can grep for which
|
|
* contract drifted in production telemetry. */
|
|
endpoint: string;
|
|
}
|
|
|
|
/**
|
|
* Validate a JSON value parsed from an API response against a zod schema,
|
|
* returning the parsed value on success or `fallback` on failure.
|
|
*
|
|
* On failure we log a warning with the endpoint and zod's structured error,
|
|
* but never throw — the UI layer must keep rendering. This is the boundary
|
|
* defense that turns "API contract drifted" from a white-screen incident
|
|
* into a degraded-but-rendering page.
|
|
*
|
|
* The return type is anchored to `T` (inferred from `fallback`), not to the
|
|
* schema's `z.infer` type. Schemas are intentionally **lenient** — string
|
|
* enums kept as `z.string()` so an unknown enum value still parses, etc. —
|
|
* so the parsed runtime value can be wider than the strict TS type at the
|
|
* call site. The caller asserts compatibility by typing the fallback to the
|
|
* expected `T`; downstream code is already responsible for handling unknown
|
|
* enum values via `default`-bearing switches and optional chaining.
|
|
*
|
|
* See CLAUDE.md "API Response Compatibility" for when to reach for this.
|
|
*/
|
|
export function parseWithFallback<T>(
|
|
data: unknown,
|
|
schema: ZodType,
|
|
fallback: T,
|
|
opts: ParseOptions,
|
|
): T {
|
|
const result = schema.safeParse(data);
|
|
if (result.success) return result.data as T;
|
|
schemaLogger.warn(
|
|
`API response failed schema validation: ${opts.endpoint}`,
|
|
{
|
|
endpoint: opts.endpoint,
|
|
issues: result.error.issues,
|
|
received: data,
|
|
},
|
|
);
|
|
return fallback;
|
|
}
|
|
|
|
/**
|
|
* Validate a mutation response against a zod schema, warning (not throwing) on
|
|
* drift. Unlike `parseWithFallback`, there is no synthetic fallback: a write
|
|
* response has no safe empty stand-in — an `id: ""` placeholder would corrupt
|
|
* the caches these responses feed. On drift we log via the same channel as
|
|
* `parseWithFallback` and return the raw value cast to `T`; the caller's
|
|
* optimistic cache patch plus `onSettled` invalidation remain the authoritative
|
|
* safety net.
|
|
*
|
|
* See CLAUDE.md "API Compatibility" for when to reach for this over
|
|
* `parseWithFallback`.
|
|
*/
|
|
export function parseOrWarn<T>(
|
|
data: unknown,
|
|
schema: ZodType,
|
|
opts: ParseOptions,
|
|
): T {
|
|
const result = schema.safeParse(data);
|
|
if (result.success) return result.data as T;
|
|
schemaLogger.warn(
|
|
`API response failed schema validation: ${opts.endpoint}`,
|
|
{
|
|
endpoint: opts.endpoint,
|
|
issues: result.error.issues,
|
|
received: data,
|
|
},
|
|
);
|
|
return data as T;
|
|
}
|