Files
multica/packages/core/issues/surface/query-plan.ts
Naiyuan Qing afc7ac4bd0 feat: space rollout — space-first navigation, per-user membership, move-to-space (MUL-4142)
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary
navigation and working surface, on the "associations bind at creation
time only" model.

Model
- Issue <-> space is the only enforced ownership (per-space numbering).
  Parent/child and project<->space associations only seed defaults at
  creation; cross-space/child and project-association validations are
  removed.
- Moving an issue renumbers it and records the old identifier in
  issue_identifier_alias; API/CLI lookups and GitHub branch/PR
  auto-linking fall back to the alias, so old identifiers resolve forever.
- Membership drives only the sidebar and personal defaults — never
  access. Anyone can configure any space's member set wholesale
  (PUT /api/spaces/{id}/members); saving an empty set archives the
  space behind a confirm.
- Per-user space order (workspace_space_member.sort_order, fractional):
  drag-sorted sidebar, "my first space" is the personal issue-creation
  default; the workspace default space backs headless creation
  (agents/CLI/Slack) and system placement.

Surfaces
- Sidebar: joined-spaces section (drag reorder, row -> space page,
  per-group persisted collapse), Workspace group with a More menu,
  Settings demoted to a footer icon.
- /space/:key/{issues,projects,autopilots,settings} — space surfaces
  reuse shared page components; a routed /space/new create page
  (replacing the earlier create-space modal), reserved key "NEW" so it
  can never collide with a real space's /space/:key detail page.
- Issue detail moves to /issue/:id (identifier-first, Linear-style; old
  /issues/:id redirects); create dialogs lead with a required space pill.
- Agent runtime brief now carries Space context (id/key/name) through
  the daemon claim -> TaskContextForEnv -> prompt pipeline, with a
  "## Space Context" section and --space on issue create/update in both
  brief renderers, matching Project's existing treatment.
- zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx.

Fixes along the way
- Cache membership judgment gains the space dimension + space_changed
  WS flag.
- Silent skip on default-space lookup during invite acceptance is now a
  hard failure (no space-less members).
- Backfilled space_id into ~28 raw-SQL Go test fixtures across
  internal/handler and cmd/server that predated migration 132's NOT
  NULL cutover.
- Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/
  unmount cycle on resolution failure) and gave it its own loading
  skeleton instead of a blank screen while resolving.
- reserved-slugs generator's stale hardcoded doc-comment example synced
  back to /create-space.

Verification
- go build ./..., go vet ./..., go test ./... all clean.
- pnpm typecheck (core/views/web/desktop) clean.
- packages/views: 162 files / 1656 tests passing.
- pnpm generate:reserved-slugs produces no diff.

Follow-ups tracked in docs/follow-ups/space-rollout.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-08 20:57:38 +08:00

181 lines
5.1 KiB
TypeScript

import type { CreateIssueRequest } from "../../types";
import type {
AssigneeGroupedIssuesFilter,
MyIssuesFilter,
} from "../queries";
import { issueScopeKey, type IssueScope } from "./scope";
export type IssueSurfaceQueryPlan =
| {
kind: "workspace";
scopeKey: string;
queryScope: undefined;
queryFilter: MyIssuesFilter;
groupedScopeFilter: AssigneeGroupedIssuesFilter;
loadMoreScope: undefined;
loadMoreFilter: undefined;
userId: undefined;
createDefaults: Partial<CreateIssueRequest>;
}
| {
kind: "scoped";
scopeKey: string;
queryScope: string;
queryFilter: MyIssuesFilter;
groupedScopeFilter: AssigneeGroupedIssuesFilter;
loadMoreScope: string;
loadMoreFilter: MyIssuesFilter;
userId?: string;
createDefaults: Partial<CreateIssueRequest>;
};
function myRelationPlan(
scope: Extract<IssueScope, { type: "my" }>,
): Pick<
Extract<IssueSurfaceQueryPlan, { kind: "scoped" }>,
"queryScope" | "queryFilter" | "userId" | "createDefaults"
> {
switch (scope.relation) {
case "assigned":
return {
queryScope: "assigned",
queryFilter: { assignee_id: scope.userId },
userId: undefined,
createDefaults: {
assignee_type: "member",
assignee_id: scope.userId,
},
};
case "created":
return {
queryScope: "created",
queryFilter: { creator_id: scope.userId },
userId: undefined,
createDefaults: {},
};
case "involved":
return {
queryScope: "agents",
queryFilter: { involves_user_id: scope.userId },
userId: undefined,
createDefaults: {},
};
case "all":
return {
queryScope: "all",
queryFilter: {},
userId: scope.userId,
createDefaults: {},
};
}
}
export function buildIssueSurfaceQueryPlan(
scope: IssueScope,
): IssueSurfaceQueryPlan {
const scopeKey = issueScopeKey(scope);
switch (scope.type) {
case "workspace": {
// Members/Agents tabs are server-filtered scoped lists — assignee_types
// is a real API param on both the list and grouped endpoints, so each
// tab gets its own cache entry with correct per-status totals and
// load-more pagination. Only the unfiltered "all" tab uses the shared
// workspace list cache.
if (scope.actorKind === "members" || scope.actorKind === "agents") {
const queryFilter: MyIssuesFilter =
scope.actorKind === "members"
? { assignee_types: ["member"] }
: { assignee_types: ["agent", "squad"] };
return {
kind: "scoped",
scopeKey,
queryScope: scopeKey,
queryFilter,
groupedScopeFilter: queryFilter,
loadMoreScope: scopeKey,
loadMoreFilter: queryFilter,
userId: undefined,
createDefaults: {},
};
}
return {
kind: "workspace",
scopeKey,
queryScope: undefined,
queryFilter: {},
groupedScopeFilter: {},
loadMoreScope: undefined,
loadMoreFilter: undefined,
userId: undefined,
createDefaults: {},
};
}
case "project": {
const queryFilter = { project_id: scope.projectId };
return {
kind: "scoped",
scopeKey,
queryScope: scopeKey,
queryFilter,
groupedScopeFilter: queryFilter,
loadMoreScope: scopeKey,
loadMoreFilter: queryFilter,
userId: undefined,
createDefaults: { project_id: scope.projectId },
};
}
case "my": {
const plan = myRelationPlan(scope);
return {
kind: "scoped",
scopeKey,
...plan,
groupedScopeFilter: plan.queryFilter,
loadMoreScope: plan.queryScope,
loadMoreFilter: plan.queryFilter,
};
}
case "actor": {
const queryFilter =
scope.relation === "assigned"
? { assignee_id: scope.actorId }
: { creator_id: scope.actorId };
return {
kind: "scoped",
scopeKey,
queryScope: scopeKey,
queryFilter,
groupedScopeFilter: queryFilter,
loadMoreScope: scopeKey,
loadMoreFilter: queryFilter,
userId: undefined,
createDefaults:
scope.relation === "assigned"
? {
assignee_type: scope.actorType,
assignee_id: scope.actorId,
}
: {},
};
}
case "space": {
// Mirrors the project plan: space_id is a real server filter on both
// the list and grouped endpoints, so the space surface gets its own
// cache entry, and issues created from it default into the space.
const queryFilter = { space_id: scope.spaceId };
return {
kind: "scoped",
scopeKey,
queryScope: scopeKey,
queryFilter,
groupedScopeFilter: queryFilter,
loadMoreScope: scopeKey,
loadMoreFilter: queryFilter,
userId: undefined,
createDefaults: { space_id: scope.spaceId },
};
}
}
}