mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 19:06:06 +02:00
afc7ac4bd0
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary navigation and working surface, on the "associations bind at creation time only" model. Model - Issue <-> space is the only enforced ownership (per-space numbering). Parent/child and project<->space associations only seed defaults at creation; cross-space/child and project-association validations are removed. - Moving an issue renumbers it and records the old identifier in issue_identifier_alias; API/CLI lookups and GitHub branch/PR auto-linking fall back to the alias, so old identifiers resolve forever. - Membership drives only the sidebar and personal defaults — never access. Anyone can configure any space's member set wholesale (PUT /api/spaces/{id}/members); saving an empty set archives the space behind a confirm. - Per-user space order (workspace_space_member.sort_order, fractional): drag-sorted sidebar, "my first space" is the personal issue-creation default; the workspace default space backs headless creation (agents/CLI/Slack) and system placement. Surfaces - Sidebar: joined-spaces section (drag reorder, row -> space page, per-group persisted collapse), Workspace group with a More menu, Settings demoted to a footer icon. - /space/:key/{issues,projects,autopilots,settings} — space surfaces reuse shared page components; a routed /space/new create page (replacing the earlier create-space modal), reserved key "NEW" so it can never collide with a real space's /space/:key detail page. - Issue detail moves to /issue/:id (identifier-first, Linear-style; old /issues/:id redirects); create dialogs lead with a required space pill. - Agent runtime brief now carries Space context (id/key/name) through the daemon claim -> TaskContextForEnv -> prompt pipeline, with a "## Space Context" section and --space on issue create/update in both brief renderers, matching Project's existing treatment. - zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx. Fixes along the way - Cache membership judgment gains the space dimension + space_changed WS flag. - Silent skip on default-space lookup during invite acceptance is now a hard failure (no space-less members). - Backfilled space_id into ~28 raw-SQL Go test fixtures across internal/handler and cmd/server that predated migration 132's NOT NULL cutover. - Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/ unmount cycle on resolution failure) and gave it its own loading skeleton instead of a blank screen while resolving. - reserved-slugs generator's stale hardcoded doc-comment example synced back to /create-space. Verification - go build ./..., go vet ./..., go test ./... all clean. - pnpm typecheck (core/views/web/desktop) clean. - packages/views: 162 files / 1656 tests passing. - pnpm generate:reserved-slugs produces no diff. Follow-ups tracked in docs/follow-ups/space-rollout.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
77 lines
2.6 KiB
TypeScript
77 lines
2.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Space } from "../types";
|
|
import { creationDefaultSpaceId, resolveCreationSpaceId } from "./default-space";
|
|
|
|
function space(overrides: Partial<Space>): Space {
|
|
return {
|
|
id: "space-id",
|
|
workspace_id: "ws-1",
|
|
name: "Space",
|
|
key: "SPC",
|
|
description: "",
|
|
icon: null,
|
|
issue_counter: 0,
|
|
archived_at: null,
|
|
created_by: null,
|
|
created_at: "2026-01-01T00:00:00Z",
|
|
updated_at: "2026-01-01T00:00:00Z",
|
|
is_member: false,
|
|
sort_order: 0,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("creationDefaultSpaceId", () => {
|
|
it("prefers the first space in the user's personal sort order", () => {
|
|
const spaces = [
|
|
space({ id: "a", is_member: true, sort_order: 2 }),
|
|
space({ id: "b", is_member: true, sort_order: 1 }),
|
|
space({ id: "c", is_member: false, created_at: "2020-01-01T00:00:00Z" }),
|
|
];
|
|
expect(creationDefaultSpaceId(spaces)).toBe("b");
|
|
});
|
|
|
|
it("falls back to the earliest-created active space when the user has no membership rows", () => {
|
|
const spaces = [
|
|
space({ id: "newer", is_member: false, created_at: "2026-02-01T00:00:00Z" }),
|
|
space({ id: "older", is_member: false, created_at: "2026-01-01T00:00:00Z" }),
|
|
];
|
|
expect(creationDefaultSpaceId(spaces)).toBe("older");
|
|
});
|
|
|
|
it("ignores archived spaces in both the personal and earliest-created fallbacks", () => {
|
|
const spaces = [
|
|
space({ id: "archived-mine", is_member: true, sort_order: 0, archived_at: "2026-01-01T00:00:00Z" }),
|
|
space({ id: "archived-oldest", created_at: "2020-01-01T00:00:00Z", archived_at: "2026-01-01T00:00:00Z" }),
|
|
space({ id: "active", created_at: "2026-01-02T00:00:00Z" }),
|
|
];
|
|
expect(creationDefaultSpaceId(spaces)).toBe("active");
|
|
});
|
|
|
|
it("returns undefined when there are no active spaces", () => {
|
|
expect(creationDefaultSpaceId([])).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe("resolveCreationSpaceId", () => {
|
|
const spaces = [space({ id: "fallback", created_at: "2026-01-01T00:00:00Z" })];
|
|
|
|
it("prioritizes structural context over the creation default", () => {
|
|
expect(
|
|
resolveCreationSpaceId(spaces, {
|
|
parentSpaceId: "parent",
|
|
projectSpaceId: "project",
|
|
lastSpaceId: "last",
|
|
}),
|
|
).toBe("parent");
|
|
expect(resolveCreationSpaceId(spaces, { projectSpaceId: "project", lastSpaceId: "last" })).toBe(
|
|
"project",
|
|
);
|
|
expect(resolveCreationSpaceId(spaces, { lastSpaceId: "last" })).toBe("last");
|
|
});
|
|
|
|
it("falls through to the creation default when no context applies", () => {
|
|
expect(resolveCreationSpaceId(spaces, {})).toBe("fallback");
|
|
});
|
|
});
|