Files
multica/server/internal/handler/invitation.go
Naiyuan Qing afc7ac4bd0 feat: space rollout — space-first navigation, per-user membership, move-to-space (MUL-4142)
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary
navigation and working surface, on the "associations bind at creation
time only" model.

Model
- Issue <-> space is the only enforced ownership (per-space numbering).
  Parent/child and project<->space associations only seed defaults at
  creation; cross-space/child and project-association validations are
  removed.
- Moving an issue renumbers it and records the old identifier in
  issue_identifier_alias; API/CLI lookups and GitHub branch/PR
  auto-linking fall back to the alias, so old identifiers resolve forever.
- Membership drives only the sidebar and personal defaults — never
  access. Anyone can configure any space's member set wholesale
  (PUT /api/spaces/{id}/members); saving an empty set archives the
  space behind a confirm.
- Per-user space order (workspace_space_member.sort_order, fractional):
  drag-sorted sidebar, "my first space" is the personal issue-creation
  default; the workspace default space backs headless creation
  (agents/CLI/Slack) and system placement.

Surfaces
- Sidebar: joined-spaces section (drag reorder, row -> space page,
  per-group persisted collapse), Workspace group with a More menu,
  Settings demoted to a footer icon.
- /space/:key/{issues,projects,autopilots,settings} — space surfaces
  reuse shared page components; a routed /space/new create page
  (replacing the earlier create-space modal), reserved key "NEW" so it
  can never collide with a real space's /space/:key detail page.
- Issue detail moves to /issue/:id (identifier-first, Linear-style; old
  /issues/:id redirects); create dialogs lead with a required space pill.
- Agent runtime brief now carries Space context (id/key/name) through
  the daemon claim -> TaskContextForEnv -> prompt pipeline, with a
  "## Space Context" section and --space on issue create/update in both
  brief renderers, matching Project's existing treatment.
- zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx.

Fixes along the way
- Cache membership judgment gains the space dimension + space_changed
  WS flag.
- Silent skip on default-space lookup during invite acceptance is now a
  hard failure (no space-less members).
- Backfilled space_id into ~28 raw-SQL Go test fixtures across
  internal/handler and cmd/server that predated migration 132's NOT
  NULL cutover.
- Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/
  unmount cycle on resolution failure) and gave it its own loading
  skeleton instead of a blank screen while resolving.
- reserved-slugs generator's stale hardcoded doc-comment example synced
  back to /create-space.

Verification
- go build ./..., go vet ./..., go test ./... all clean.
- pnpm typecheck (core/views/web/desktop) clean.
- packages/views: 162 files / 1656 tests passing.
- pnpm generate:reserved-slugs produces no diff.

Follow-ups tracked in docs/follow-ups/space-rollout.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-08 20:57:38 +08:00

570 lines
19 KiB
Go

package handler
import (
"encoding/json"
"log/slog"
"net/http"
"strings"
"time"
"github.com/go-chi/chi/v5"
"github.com/jackc/pgx/v5/pgtype"
"github.com/multica-ai/multica/server/internal/analytics"
"github.com/multica-ai/multica/server/internal/logger"
obsmetrics "github.com/multica-ai/multica/server/internal/metrics"
db "github.com/multica-ai/multica/server/pkg/db/generated"
"github.com/multica-ai/multica/server/pkg/protocol"
)
// InvitationResponse is the JSON shape returned for a workspace invitation.
type InvitationResponse struct {
ID string `json:"id"`
WorkspaceID string `json:"workspace_id"`
InviterID string `json:"inviter_id"`
InviteeEmail string `json:"invitee_email"`
InviteeUserID *string `json:"invitee_user_id"`
Role string `json:"role"`
Status string `json:"status"`
CreatedAt string `json:"created_at"`
UpdatedAt string `json:"updated_at"`
ExpiresAt string `json:"expires_at"`
// Enriched fields (present in list responses).
InviterName string `json:"inviter_name,omitempty"`
InviterEmail string `json:"inviter_email,omitempty"`
WorkspaceName string `json:"workspace_name,omitempty"`
}
func invitationToResponse(inv db.WorkspaceInvitation) InvitationResponse {
return InvitationResponse{
ID: uuidToString(inv.ID),
WorkspaceID: uuidToString(inv.WorkspaceID),
InviterID: uuidToString(inv.InviterID),
InviteeEmail: inv.InviteeEmail,
InviteeUserID: uuidToPtr(inv.InviteeUserID),
Role: inv.Role,
Status: inv.Status,
CreatedAt: timestampToString(inv.CreatedAt),
UpdatedAt: timestampToString(inv.UpdatedAt),
ExpiresAt: timestampToString(inv.ExpiresAt),
}
}
// ---------------------------------------------------------------------------
// CreateInvitation replaces the old "instant-add" CreateMember flow.
// POST /api/workspaces/{id}/members (same endpoint, new behaviour)
// ---------------------------------------------------------------------------
func (h *Handler) CreateInvitation(w http.ResponseWriter, r *http.Request) {
workspaceID := workspaceIDFromURL(r, "id")
requester, ok := h.workspaceMember(w, r, workspaceID)
if !ok {
return
}
var req CreateMemberRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeError(w, http.StatusBadRequest, "invalid request body")
return
}
email := strings.ToLower(strings.TrimSpace(req.Email))
if email == "" {
writeError(w, http.StatusBadRequest, "email is required")
return
}
role, valid := normalizeMemberRole(req.Role)
if !valid {
writeError(w, http.StatusBadRequest, "invalid member role")
return
}
if role == "owner" {
writeError(w, http.StatusBadRequest, "cannot invite as owner")
return
}
// Check if the user is already a member.
existingUser, err := h.Queries.GetUserByEmail(r.Context(), email)
if err == nil {
_, memberErr := h.Queries.GetMemberByUserAndWorkspace(r.Context(), db.GetMemberByUserAndWorkspaceParams{
UserID: existingUser.ID,
WorkspaceID: requester.WorkspaceID,
})
if memberErr == nil {
writeError(w, http.StatusConflict, "user is already a member")
return
}
}
// Drop any past-due pending invitations to 'expired' first. The partial unique
// index idx_invitation_unique_pending only filters by status = 'pending', so a
// stale row would otherwise block CreateInvitation below — see issue #2055.
if err := h.Queries.ExpireStalePendingInvitations(r.Context(), db.ExpireStalePendingInvitationsParams{
WorkspaceID: requester.WorkspaceID,
InviteeEmail: email,
}); err != nil {
slog.Warn("expire stale invitations failed", append(logger.RequestAttrs(r), "error", err, "workspace_id", workspaceID, "email", email)...)
writeError(w, http.StatusInternalServerError, "failed to create invitation")
return
}
// Check if there is still a live pending invitation.
_, err = h.Queries.GetPendingInvitationByEmail(r.Context(), db.GetPendingInvitationByEmailParams{
WorkspaceID: requester.WorkspaceID,
InviteeEmail: email,
})
if err == nil {
writeError(w, http.StatusConflict, "invitation already pending for this email")
return
}
// Resolve invitee_user_id if the user already exists.
var inviteeUserID pgtype.UUID
if existingUser.ID.Valid {
inviteeUserID = existingUser.ID
}
inv, err := h.Queries.CreateInvitation(r.Context(), db.CreateInvitationParams{
WorkspaceID: requester.WorkspaceID,
InviterID: requester.UserID,
InviteeEmail: email,
InviteeUserID: inviteeUserID,
Role: role,
})
if err != nil {
if isUniqueViolation(err) {
writeError(w, http.StatusConflict, "invitation already pending for this email")
return
}
slog.Warn("create invitation failed", append(logger.RequestAttrs(r), "error", err, "workspace_id", workspaceID, "email", email)...)
writeError(w, http.StatusInternalServerError, "failed to create invitation")
return
}
slog.Info("invitation created", append(logger.RequestAttrs(r), "invitation_id", uuidToString(inv.ID), "workspace_id", workspaceID, "email", email, "role", role)...)
resp := invitationToResponse(inv)
// Notify the invitee in real time if they are a registered user.
userID := requestUserID(r)
eventPayload := map[string]any{"invitation": resp}
var workspaceName string
if ws, err := h.Queries.GetWorkspace(r.Context(), requester.WorkspaceID); err == nil {
workspaceName = ws.Name
eventPayload["workspace_name"] = ws.Name
}
h.publish(protocol.EventInvitationCreated, uuidToString(requester.WorkspaceID), "member", userID, eventPayload)
obsmetrics.RecordEvent(h.Analytics, h.Metrics, analytics.TeamInviteSent(
uuidToString(requester.UserID),
uuidToString(requester.WorkspaceID),
email,
"email",
))
// Send invitation email (fire-and-forget).
if h.EmailService != nil && workspaceName != "" {
inviterName := email // fallback
if inviter, err := h.Queries.GetUser(r.Context(), requester.UserID); err == nil {
inviterName = inviter.Name
}
invID := uuidToString(inv.ID)
go func() {
if err := h.EmailService.SendInvitationEmail(email, inviterName, workspaceName, invID); err != nil {
slog.Warn("failed to send invitation email", "email", email, "error", err)
}
}()
}
writeJSON(w, http.StatusCreated, resp)
}
// ---------------------------------------------------------------------------
// ListWorkspaceInvitations — pending invitations for a workspace (admin view).
// GET /api/workspaces/{id}/invitations
// ---------------------------------------------------------------------------
func (h *Handler) ListWorkspaceInvitations(w http.ResponseWriter, r *http.Request) {
workspaceID := workspaceIDFromURL(r, "id")
workspaceUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
if !ok {
return
}
rows, err := h.Queries.ListPendingInvitationsByWorkspace(r.Context(), workspaceUUID)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to list invitations")
return
}
resp := make([]InvitationResponse, len(rows))
for i, row := range rows {
resp[i] = InvitationResponse{
ID: uuidToString(row.ID),
WorkspaceID: uuidToString(row.WorkspaceID),
InviterID: uuidToString(row.InviterID),
InviteeEmail: row.InviteeEmail,
InviteeUserID: uuidToPtr(row.InviteeUserID),
Role: row.Role,
Status: row.Status,
CreatedAt: timestampToString(row.CreatedAt),
UpdatedAt: timestampToString(row.UpdatedAt),
ExpiresAt: timestampToString(row.ExpiresAt),
InviterName: row.InviterName,
InviterEmail: row.InviterEmail,
}
}
writeJSON(w, http.StatusOK, resp)
}
// ---------------------------------------------------------------------------
// RevokeInvitation — admin cancels a pending invitation.
// DELETE /api/workspaces/{id}/invitations/{invitationId}
// ---------------------------------------------------------------------------
func (h *Handler) RevokeInvitation(w http.ResponseWriter, r *http.Request) {
workspaceID := workspaceIDFromURL(r, "id")
invitationID := chi.URLParam(r, "invitationId")
workspaceUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
if !ok {
return
}
invitationUUID, ok := parseUUIDOrBadRequest(w, invitationID, "invitation id")
if !ok {
return
}
inv, err := h.Queries.GetInvitation(r.Context(), invitationUUID)
if err != nil || uuidToString(inv.WorkspaceID) != uuidToString(workspaceUUID) || inv.Status != "pending" {
writeError(w, http.StatusNotFound, "invitation not found")
return
}
if err := h.Queries.RevokeInvitation(r.Context(), inv.ID); err != nil {
writeError(w, http.StatusInternalServerError, "failed to revoke invitation")
return
}
slog.Info("invitation revoked", "invitation_id", invitationID, "workspace_id", workspaceID)
userID := requestUserID(r)
h.publish(protocol.EventInvitationRevoked, uuidToString(workspaceUUID), "member", userID, map[string]any{
"invitation_id": uuidToString(inv.ID),
"invitee_email": inv.InviteeEmail,
"invitee_user_id": uuidToPtr(inv.InviteeUserID),
})
w.WriteHeader(http.StatusNoContent)
}
// ---------------------------------------------------------------------------
// GetMyInvitation — get a single invitation by ID (for the invite accept page).
// GET /api/invitations/{id}
// ---------------------------------------------------------------------------
func (h *Handler) GetMyInvitation(w http.ResponseWriter, r *http.Request) {
userID, ok := requireUserID(w, r)
if !ok {
return
}
invitationID := chi.URLParam(r, "id")
invitationUUID, ok := parseUUIDOrBadRequest(w, invitationID, "invitation id")
if !ok {
return
}
inv, err := h.Queries.GetInvitation(r.Context(), invitationUUID)
if err != nil {
writeError(w, http.StatusNotFound, "invitation not found")
return
}
// Verify the invitation belongs to the current user.
user, err := h.Queries.GetUser(r.Context(), parseUUID(userID))
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to load user")
return
}
if strings.ToLower(user.Email) != inv.InviteeEmail && uuidToString(inv.InviteeUserID) != userID {
writeError(w, http.StatusForbidden, "invitation does not belong to you")
return
}
resp := invitationToResponse(inv)
// Enrich with workspace name and inviter name.
if ws, err := h.Queries.GetWorkspace(r.Context(), inv.WorkspaceID); err == nil {
resp.WorkspaceName = ws.Name
}
if inviter, err := h.Queries.GetUser(r.Context(), inv.InviterID); err == nil {
resp.InviterName = inviter.Name
resp.InviterEmail = inviter.Email
}
writeJSON(w, http.StatusOK, resp)
}
// ---------------------------------------------------------------------------
// ListMyInvitations — current user's pending invitations across all workspaces.
// GET /api/invitations
// ---------------------------------------------------------------------------
func (h *Handler) ListMyInvitations(w http.ResponseWriter, r *http.Request) {
userID, ok := requireUserID(w, r)
if !ok {
return
}
user, err := h.Queries.GetUser(r.Context(), parseUUID(userID))
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to load user")
return
}
rows, err := h.Queries.ListPendingInvitationsForUser(r.Context(), db.ListPendingInvitationsForUserParams{
InviteeUserID: user.ID,
InviteeEmail: user.Email,
})
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to list invitations")
return
}
resp := make([]InvitationResponse, len(rows))
for i, row := range rows {
resp[i] = InvitationResponse{
ID: uuidToString(row.ID),
WorkspaceID: uuidToString(row.WorkspaceID),
InviterID: uuidToString(row.InviterID),
InviteeEmail: row.InviteeEmail,
InviteeUserID: uuidToPtr(row.InviteeUserID),
Role: row.Role,
Status: row.Status,
CreatedAt: timestampToString(row.CreatedAt),
UpdatedAt: timestampToString(row.UpdatedAt),
ExpiresAt: timestampToString(row.ExpiresAt),
WorkspaceName: row.WorkspaceName,
InviterName: row.InviterName,
InviterEmail: row.InviterEmail,
}
}
writeJSON(w, http.StatusOK, resp)
}
// ---------------------------------------------------------------------------
// AcceptInvitation — user accepts a pending invitation.
// POST /api/invitations/{id}/accept
// ---------------------------------------------------------------------------
func (h *Handler) AcceptInvitation(w http.ResponseWriter, r *http.Request) {
userID, ok := requireUserID(w, r)
if !ok {
return
}
invitationID := chi.URLParam(r, "id")
invitationUUID, ok := parseUUIDOrBadRequest(w, invitationID, "invitation id")
if !ok {
return
}
inv, err := h.Queries.GetInvitation(r.Context(), invitationUUID)
if err != nil {
writeError(w, http.StatusNotFound, "invitation not found")
return
}
// Verify the invitation belongs to the current user.
user, err := h.Queries.GetUser(r.Context(), parseUUID(userID))
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to load user")
return
}
if strings.ToLower(user.Email) != inv.InviteeEmail && uuidToString(inv.InviteeUserID) != userID {
writeError(w, http.StatusForbidden, "invitation does not belong to you")
return
}
if inv.Status != "pending" {
writeError(w, http.StatusBadRequest, "invitation is not pending")
return
}
// Check expiry.
if inv.ExpiresAt.Valid && inv.ExpiresAt.Time.Before(time.Now()) {
writeError(w, http.StatusGone, "invitation has expired")
return
}
// Use a transaction: mark accepted + create member atomically.
tx, err := h.TxStarter.Begin(r.Context())
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to accept invitation")
return
}
defer tx.Rollback(r.Context())
qtx := h.Queries.WithTx(tx)
accepted, err := qtx.AcceptInvitation(r.Context(), inv.ID)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to accept invitation")
return
}
member, err := qtx.CreateMember(r.Context(), db.CreateMemberParams{
WorkspaceID: accepted.WorkspaceID,
UserID: user.ID,
Role: accepted.Role,
})
if err != nil {
if isUniqueViolation(err) {
writeError(w, http.StatusConflict, "you are already a member of this workspace")
return
}
writeError(w, http.StatusInternalServerError, "failed to create membership")
return
}
// Every system-placed member joins the default space: the sidebar shows
// joined spaces only, and issue creation needs a per-user default. Hard
// failure (rolls the whole accept back) — a missing default space is data
// corruption, and silently skipping would mint a space-less member.
defSpace, err := qtx.GetDefaultWorkspaceSpace(r.Context(), accepted.WorkspaceID)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to resolve default space")
return
}
spaceRole := "member"
if accepted.Role == "owner" || accepted.Role == "admin" {
spaceRole = "lead"
}
if _, err := addSpaceMember(r.Context(), qtx, accepted.WorkspaceID, defSpace.ID, user.ID, spaceRole); err != nil {
writeError(w, http.StatusInternalServerError, "failed to join default space")
return
}
// Accepting an invite marks the invitee as onboarded. The web /
// desktop workspace layout has a hard onboarded_at gate; without
// this mark, an invitee landing on their first workspace would be
// redirected back to /onboarding to fill out a questionnaire for a
// workspace someone else already set up. Atomic with CreateMember so
// `member` and `onboarded_at` can never disagree. COALESCE in
// MarkUserOnboarded keeps the call idempotent for users joining
// additional workspaces after their first.
firstOnboardingCompletion := !user.OnboardedAt.Valid
onboardedUser, err := qtx.MarkUserOnboarded(r.Context(), user.ID)
if err != nil {
slog.Warn("accept invitation: mark user onboarded failed", append(logger.RequestAttrs(r), "error", err, "workspace_id", uuidToString(accepted.WorkspaceID))...)
writeError(w, http.StatusInternalServerError, "failed to mark user onboarded")
return
}
if err := tx.Commit(r.Context()); err != nil {
writeError(w, http.StatusInternalServerError, "failed to accept invitation")
return
}
slog.Info("invitation accepted", "invitation_id", invitationID, "user_id", userID, "workspace_id", uuidToString(accepted.WorkspaceID))
wsID := uuidToString(accepted.WorkspaceID)
memberResp := memberWithUserResponse(member, user)
// Broadcast member:added so existing clients update their member lists.
eventPayload := map[string]any{"member": memberResp}
if ws, err := h.Queries.GetWorkspace(r.Context(), accepted.WorkspaceID); err == nil {
eventPayload["workspace_name"] = ws.Name
}
h.publish(protocol.EventMemberAdded, wsID, "member", userID, eventPayload)
// Notify the workspace about the acceptance.
h.publish(protocol.EventInvitationAccepted, wsID, "member", userID, map[string]any{
"invitation_id": uuidToString(accepted.ID),
"member": memberResp,
})
// days_since_invite rounds down to whole days so the funnel segments
// "accepted same day" cleanly from "accepted later". inv.CreatedAt is
// the invitation row's insertion time so this is safe to compute here.
var daysSinceInvite int64
if inv.CreatedAt.Valid {
daysSinceInvite = int64(time.Since(inv.CreatedAt.Time).Hours() / 24)
}
obsmetrics.RecordEvent(h.Analytics, h.Metrics, analytics.TeamInviteAccepted(
userID,
wsID,
daysSinceInvite,
))
if firstOnboardingCompletion {
onboardedAt := ""
if onboardedUser.OnboardedAt.Valid {
onboardedAt = onboardedUser.OnboardedAt.Time.UTC().Format("2006-01-02T15:04:05Z07:00")
}
obsmetrics.RecordEvent(h.Analytics, h.Metrics, analytics.OnboardingCompleted(
userID,
wsID,
analytics.OnboardingPathInviteAccept,
onboardedAt,
onboardedUser.CloudWaitlistEmail.Valid,
))
}
writeJSON(w, http.StatusOK, memberResp)
}
// ---------------------------------------------------------------------------
// DeclineInvitation — user declines a pending invitation.
// POST /api/invitations/{id}/decline
// ---------------------------------------------------------------------------
func (h *Handler) DeclineInvitation(w http.ResponseWriter, r *http.Request) {
userID, ok := requireUserID(w, r)
if !ok {
return
}
invitationID := chi.URLParam(r, "id")
invitationUUID, ok := parseUUIDOrBadRequest(w, invitationID, "invitation id")
if !ok {
return
}
inv, err := h.Queries.GetInvitation(r.Context(), invitationUUID)
if err != nil {
writeError(w, http.StatusNotFound, "invitation not found")
return
}
// Verify the invitation belongs to the current user.
user, err := h.Queries.GetUser(r.Context(), parseUUID(userID))
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to load user")
return
}
if strings.ToLower(user.Email) != inv.InviteeEmail && uuidToString(inv.InviteeUserID) != userID {
writeError(w, http.StatusForbidden, "invitation does not belong to you")
return
}
if inv.Status != "pending" {
writeError(w, http.StatusBadRequest, "invitation is not pending")
return
}
declined, err := h.Queries.DeclineInvitation(r.Context(), inv.ID)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to decline invitation")
return
}
slog.Info("invitation declined", "invitation_id", invitationID, "user_id", userID)
wsID := uuidToString(declined.WorkspaceID)
h.publish(protocol.EventInvitationDeclined, wsID, "member", userID, map[string]any{
"invitation_id": uuidToString(declined.ID),
"invitee_email": declined.InviteeEmail,
})
w.WriteHeader(http.StatusNoContent)
}