mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-03 19:20:07 +02:00
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary navigation and working surface, on the "associations bind at creation time only" model. Model - Issue <-> space is the only enforced ownership (per-space numbering). Parent/child and project<->space associations only seed defaults at creation; cross-space/child and project-association validations are removed. - Moving an issue renumbers it and records the old identifier in issue_identifier_alias; API/CLI lookups and GitHub branch/PR auto-linking fall back to the alias, so old identifiers resolve forever. - Membership drives only the sidebar and personal defaults — never access. Anyone can configure any space's member set wholesale (PUT /api/spaces/{id}/members); saving an empty set archives the space behind a confirm. - Per-user space order (workspace_space_member.sort_order, fractional): drag-sorted sidebar, "my first space" is the personal issue-creation default; the workspace default space backs headless creation (agents/CLI/Slack) and system placement. Surfaces - Sidebar: joined-spaces section (drag reorder, row -> space page, per-group persisted collapse), Workspace group with a More menu, Settings demoted to a footer icon. - /space/:key/{issues,projects,autopilots,settings} — space surfaces reuse shared page components; a routed /space/new create page (replacing the earlier create-space modal), reserved key "NEW" so it can never collide with a real space's /space/:key detail page. - Issue detail moves to /issue/:id (identifier-first, Linear-style; old /issues/:id redirects); create dialogs lead with a required space pill. - Agent runtime brief now carries Space context (id/key/name) through the daemon claim -> TaskContextForEnv -> prompt pipeline, with a "## Space Context" section and --space on issue create/update in both brief renderers, matching Project's existing treatment. - zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx. Fixes along the way - Cache membership judgment gains the space dimension + space_changed WS flag. - Silent skip on default-space lookup during invite acceptance is now a hard failure (no space-less members). - Backfilled space_id into ~28 raw-SQL Go test fixtures across internal/handler and cmd/server that predated migration 132's NOT NULL cutover. - Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/ unmount cycle on resolution failure) and gave it its own loading skeleton instead of a blank screen while resolving. - reserved-slugs generator's stale hardcoded doc-comment example synced back to /create-space. Verification - go build ./..., go vet ./..., go test ./... all clean. - pnpm typecheck (core/views/web/desktop) clean. - packages/views: 162 files / 1656 tests passing. - pnpm generate:reserved-slugs produces no diff. Follow-ups tracked in docs/follow-ups/space-rollout.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
59 lines
1.8 KiB
Go
59 lines
1.8 KiB
Go
package handler
|
|
|
|
import (
|
|
"errors"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/multica-ai/multica/server/internal/service"
|
|
)
|
|
|
|
// TestSpaceResolveMessage locks the single unified wording each service
|
|
// space-resolution error maps to, including the guided ambiguous message that
|
|
// names the candidate Space keys. Unrecognized errors return "".
|
|
func TestSpaceResolveMessage(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
err error
|
|
want string
|
|
}{
|
|
{"not found", service.ErrSpaceNotFound, "space not found in this workspace"},
|
|
{"archived", service.ErrSpaceArchived, "space is archived"},
|
|
{
|
|
"ambiguous names keys",
|
|
&service.ProjectSpaceAmbiguousError{SpaceKeys: []string{"ENG", "GROWTH"}},
|
|
"project has multiple spaces (ENG, GROWTH); specify space_id",
|
|
},
|
|
{"unrelated", errors.New("boom"), ""},
|
|
{"nil", nil, ""},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := spaceResolveMessage(tc.err); got != tc.want {
|
|
t.Fatalf("spaceResolveMessage(%v) = %q, want %q", tc.err, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestWriteSpaceResolveError verifies the writer emits a 400 for space-resolution
|
|
// errors and reports false (writing nothing) for anything else so callers can
|
|
// fall through to their own handling.
|
|
func TestWriteSpaceResolveError(t *testing.T) {
|
|
rec := httptest.NewRecorder()
|
|
if !writeSpaceResolveError(rec, service.ErrSpaceNotFound) {
|
|
t.Fatal("expected writeSpaceResolveError to handle ErrSpaceNotFound")
|
|
}
|
|
if rec.Code != 400 {
|
|
t.Fatalf("expected 400, got %d", rec.Code)
|
|
}
|
|
|
|
rec = httptest.NewRecorder()
|
|
if writeSpaceResolveError(rec, errors.New("boom")) {
|
|
t.Fatal("expected writeSpaceResolveError to ignore a non-space-resolution error")
|
|
}
|
|
if rec.Code != 200 {
|
|
t.Fatalf("expected nothing written (default 200), got %d", rec.Code)
|
|
}
|
|
}
|