mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 19:06:06 +02:00
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary navigation and working surface, on the "associations bind at creation time only" model. Model - Issue <-> space is the only enforced ownership (per-space numbering). Parent/child and project<->space associations only seed defaults at creation; cross-space/child and project-association validations are removed. - Moving an issue renumbers it and records the old identifier in issue_identifier_alias; API/CLI lookups and GitHub branch/PR auto-linking fall back to the alias, so old identifiers resolve forever. - Membership drives only the sidebar and personal defaults — never access. Anyone can configure any space's member set wholesale (PUT /api/spaces/{id}/members); saving an empty set archives the space behind a confirm. - Per-user space order (workspace_space_member.sort_order, fractional): drag-sorted sidebar, "my first space" is the personal issue-creation default; the workspace default space backs headless creation (agents/CLI/Slack) and system placement. Surfaces - Sidebar: joined-spaces section (drag reorder, row -> space page, per-group persisted collapse), Workspace group with a More menu, Settings demoted to a footer icon. - /space/:key/{issues,projects,autopilots,settings} — space surfaces reuse shared page components; a routed /space/new create page (replacing the earlier create-space modal), reserved key "NEW" so it can never collide with a real space's /space/:key detail page. - Issue detail moves to /issue/:id (identifier-first, Linear-style; old /issues/:id redirects); create dialogs lead with a required space pill. - Agent runtime brief now carries Space context (id/key/name) through the daemon claim -> TaskContextForEnv -> prompt pipeline, with a "## Space Context" section and --space on issue create/update in both brief renderers, matching Project's existing treatment. - zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx. Fixes along the way - Cache membership judgment gains the space dimension + space_changed WS flag. - Silent skip on default-space lookup during invite acceptance is now a hard failure (no space-less members). - Backfilled space_id into ~28 raw-SQL Go test fixtures across internal/handler and cmd/server that predated migration 132's NOT NULL cutover. - Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/ unmount cycle on resolution failure) and gave it its own loading skeleton instead of a blank screen while resolving. - reserved-slugs generator's stale hardcoded doc-comment example synced back to /create-space. Verification - go build ./..., go vet ./..., go test ./... all clean. - pnpm typecheck (core/views/web/desktop) clean. - packages/views: 162 files / 1656 tests passing. - pnpm generate:reserved-slugs produces no diff. Follow-ups tracked in docs/follow-ups/space-rollout.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
142 lines
4.6 KiB
Go
142 lines
4.6 KiB
Go
// Package issueidentifier is the single authority for turning an issue into its
|
|
// human-readable "PREFIX-NUMBER" identifier and for resolving the bare prefix
|
|
// (Space key) of an issue or workspace.
|
|
//
|
|
// It replaces four drifted copies of the same fallback chain that previously
|
|
// lived in the handler, task service, autopilot service, and channel router.
|
|
// The chain is, in order:
|
|
//
|
|
// 1. the issue's own Space key (when the issue has a Space);
|
|
// 2. the workspace's default Space key;
|
|
// 3. the legacy workspace issue_prefix (compatibility window);
|
|
// 4. a prefix generated from the workspace name.
|
|
//
|
|
// Step 4 is the defensive fallback-of-last-resort: callers never emit "-42" or
|
|
// "#42" for an issue whose Space/workspace lookups all failed.
|
|
package issueidentifier
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
)
|
|
|
|
// Queries is the read surface the resolver needs. Both *db.Queries and the
|
|
// channel engine's SessionReader satisfy it.
|
|
type Queries interface {
|
|
GetWorkspaceSpace(ctx context.Context, arg db.GetWorkspaceSpaceParams) (db.WorkspaceSpace, error)
|
|
GetDefaultWorkspaceSpace(ctx context.Context, workspaceID pgtype.UUID) (db.WorkspaceSpace, error)
|
|
GetWorkspace(ctx context.Context, id pgtype.UUID) (db.Workspace, error)
|
|
}
|
|
|
|
var nonAlpha = regexp.MustCompile(`[^a-zA-Z]`)
|
|
|
|
// GeneratePrefix produces a 2-3 char uppercase prefix from a workspace name.
|
|
// Examples: "Jiayuan's Workspace" -> "JIA", "My Space" -> "MYT", "AB" -> "AB".
|
|
func GeneratePrefix(name string) string {
|
|
letters := nonAlpha.ReplaceAllString(name, "")
|
|
if len(letters) == 0 {
|
|
return "WS"
|
|
}
|
|
letters = strings.ToUpper(letters)
|
|
if len(letters) > 3 {
|
|
letters = letters[:3]
|
|
}
|
|
return letters
|
|
}
|
|
|
|
// PrefixForIssue returns the identifier prefix (Space key) for a single issue,
|
|
// following the full fallback chain.
|
|
func PrefixForIssue(ctx context.Context, q Queries, issue db.Issue) string {
|
|
if issue.SpaceID.Valid {
|
|
space, err := q.GetWorkspaceSpace(ctx, db.GetWorkspaceSpaceParams{
|
|
ID: issue.SpaceID,
|
|
WorkspaceID: issue.WorkspaceID,
|
|
})
|
|
if err == nil && space.Key != "" {
|
|
return space.Key
|
|
}
|
|
}
|
|
return PrefixForWorkspace(ctx, q, issue.WorkspaceID)
|
|
}
|
|
|
|
// PrefixForWorkspace returns the workspace-level identifier prefix: the default
|
|
// Space key, then the legacy issue_prefix, then a generated prefix.
|
|
func PrefixForWorkspace(ctx context.Context, q Queries, workspaceID pgtype.UUID) string {
|
|
space, err := q.GetDefaultWorkspaceSpace(ctx, workspaceID)
|
|
if err == nil && space.Key != "" {
|
|
return space.Key
|
|
}
|
|
ws, err := q.GetWorkspace(ctx, workspaceID)
|
|
if err != nil {
|
|
return ""
|
|
}
|
|
if ws.IssuePrefix != "" {
|
|
return ws.IssuePrefix
|
|
}
|
|
return GeneratePrefix(ws.Name)
|
|
}
|
|
|
|
// ForIssue returns the full "PREFIX-NUMBER" identifier for an issue.
|
|
func ForIssue(ctx context.Context, q Queries, issue db.Issue) string {
|
|
return fmt.Sprintf("%s-%d", PrefixForIssue(ctx, q, issue), issue.Number)
|
|
}
|
|
|
|
// Resolver memoizes Space-key lookups so list/batch paths that resolve
|
|
// identifiers for many issues avoid a per-row GetWorkspaceSpace query. It is not
|
|
// safe for concurrent use; construct one per request/loop.
|
|
type Resolver struct {
|
|
q Queries
|
|
spaceKeys map[pgtype.UUID]string // resolved Space ID -> Space key ("" = lookup failed/empty)
|
|
wsPrefix map[pgtype.UUID]string // workspace ID -> fallback prefix
|
|
}
|
|
|
|
// NewResolver returns a memoizing Resolver over the given queries.
|
|
func NewResolver(q Queries) *Resolver {
|
|
return &Resolver{
|
|
q: q,
|
|
spaceKeys: make(map[pgtype.UUID]string),
|
|
wsPrefix: make(map[pgtype.UUID]string),
|
|
}
|
|
}
|
|
|
|
// PrefixForIssue mirrors the package-level function but caches Space and
|
|
// workspace lookups across calls on the same Resolver.
|
|
func (r *Resolver) PrefixForIssue(ctx context.Context, issue db.Issue) string {
|
|
if issue.SpaceID.Valid {
|
|
if key := r.spaceKey(ctx, issue.SpaceID, issue.WorkspaceID); key != "" {
|
|
return key
|
|
}
|
|
}
|
|
return r.prefixForWorkspace(ctx, issue.WorkspaceID)
|
|
}
|
|
|
|
func (r *Resolver) spaceKey(ctx context.Context, spaceID, workspaceID pgtype.UUID) string {
|
|
if key, ok := r.spaceKeys[spaceID]; ok {
|
|
return key
|
|
}
|
|
key := ""
|
|
space, err := r.q.GetWorkspaceSpace(ctx, db.GetWorkspaceSpaceParams{
|
|
ID: spaceID,
|
|
WorkspaceID: workspaceID,
|
|
})
|
|
if err == nil {
|
|
key = space.Key
|
|
}
|
|
r.spaceKeys[spaceID] = key
|
|
return key
|
|
}
|
|
|
|
func (r *Resolver) prefixForWorkspace(ctx context.Context, workspaceID pgtype.UUID) string {
|
|
if prefix, ok := r.wsPrefix[workspaceID]; ok {
|
|
return prefix
|
|
}
|
|
prefix := PrefixForWorkspace(ctx, r.q, workspaceID)
|
|
r.wsPrefix[workspaceID] = prefix
|
|
return prefix
|
|
}
|