Files
multica/packages/views/modals/feedback.tsx
Naiyuan Qing 3b08456264 feat(views): block draft-fixing actions while attachments upload (#5465)
Submitting a composer mid-upload silently lost the file: the editor holds a
`blob:` placeholder that gets stripped during serialization, and the
attachment id does not exist yet, so the send succeeded without the file.
Chat and Quick Create gated this; manual issue create, Feedback's button,
comments, replies and comment edit did not.

Gate every action that FIXES a draft — Send/Create/Save, Cmd/Ctrl+Enter,
Enter on the title, and the manual/agent mode switches — behind one source
of truth: the editor document, which IS the upload queue. ContentEditor
publishes queue transitions via `onUploadingChange` (a transaction listener,
not `onUpdate` — that path is debounced and skips no-change emissions, and a
failed upload leaves byte-identical markdown, so the un-gate would never
fire). `useUploadGate` pairs that render state with an `isBlocked()` re-read
at submit time, since the shortcut paths never consult the button.

The publisher emits its current answer on subscribe rather than only on
flips: hosts outlive editor instances (comment edit remounts on cancel,
chat swaps by key on agent switch), and an editor torn down mid-upload would
otherwise leave submit wedged shut with no pending node left to reopen it.

Also fixes the failure toast that never fired: `uploadWithToast` only
reported errors if a caller passed `onError`, and none did, so failed uploads
removed their placeholder and vanished unexplained. `useEditorUpload` now
supplies it once for every composer.

Per MUL-4808: drops Quick Create's upload-time lock on the attach button
(files can queue), and leaves description autosave ungated by design.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
2026-07-16 09:56:24 +08:00

199 lines
6.9 KiB
TypeScript

"use client";
import { useRef, useState } from "react";
import { toast } from "sonner";
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
} from "@multica/ui/components/ui/dialog";
import { Button } from "@multica/ui/components/ui/button";
import { FileUploadButton } from "@multica/ui/components/common/file-upload-button";
import {
ContentEditor,
type ContentEditorRef,
useFileDropZone,
FileDropOverlay,
useUploadGate,
useEditorUpload,
} from "../editor";
import {
useCreateFeedback,
useFeedbackDraftStore,
FEEDBACK_KINDS,
type FeedbackKind,
} from "@multica/core/feedback";
import { useCurrentWorkspace } from "@multica/core/paths";
import { useT } from "../i18n";
import { useShortcut } from "@multica/core/shortcuts";
import { ShortcutKeycaps } from "../common/shortcut-keycaps";
const MAX_MESSAGE_LEN = 10000;
const FEEDBACK_KIND_SET = new Set<FeedbackKind>(FEEDBACK_KINDS);
function composeFeedbackInitialMessage(draftMessage: string, incomingInitialMessage: string) {
const draft = draftMessage.trim();
const incoming = incomingInitialMessage.trim();
if (!incoming) return draftMessage;
if (!draft) return incomingInitialMessage;
if (draft.includes(incoming)) return draftMessage;
return `${draftMessage}
---
${incomingInitialMessage}`;
}
export function FeedbackModal({
onClose,
data,
initialMessage,
}: {
onClose: () => void;
data?: Record<string, unknown> | null;
initialMessage?: string;
}) {
const sendShortcut = useShortcut("send");
const { t } = useT("modals");
const { t: tEditor } = useT("editor");
const workspace = useCurrentWorkspace();
const draft = useFeedbackDraftStore((s) => s.draft);
const setDraft = useFeedbackDraftStore((s) => s.setDraft);
const clearDraft = useFeedbackDraftStore((s) => s.clearDraft);
const editorRef = useRef<ContentEditorRef>(null);
const incomingInitialMessage =
initialMessage ?? (typeof data?.initialMessage === "string" ? data.initialMessage : "");
const kind = typeof data?.kind === "string" && FEEDBACK_KIND_SET.has(data.kind as FeedbackKind)
? (data.kind as FeedbackKind)
: undefined;
const seededMessage = composeFeedbackInitialMessage(draft.message, incomingInitialMessage);
const [message, setMessage] = useState(seededMessage);
const { isDragOver, dropZoneProps } = useFileDropZone({
onDrop: (files) => files.forEach((f) => editorRef.current?.uploadFile(f)),
});
const { uploadWithToast } = useEditorUpload();
// The handler already refused to submit mid-upload, but the button stayed
// clickable — so the only feedback was a toast fired after the click.
const uploadGate = useUploadGate(editorRef);
const mutation = useCreateFeedback();
const canSubmit =
message.trim().length > 0 &&
message.length <= MAX_MESSAGE_LEN &&
!mutation.isPending &&
!uploadGate.uploading;
const handleSubmit = async () => {
// The button can use debounced `message` state, but the keyboard shortcut
// must not: Command+Enter can arrive before ContentEditor's 150ms onUpdate
// fires. The editor ref below is the submit-time source of truth.
if (mutation.isPending) return;
// Keep the toast on this path: the shortcut can fire while the button is
// disabled and off-screen, so a silent no-op would read as a dead ⌘+Enter.
if (uploadGate.isBlocked()) {
toast.info(t(($) => $.feedback.toast_uploading));
return;
}
// Read from the editor ref at submit time — `message` state lags 150ms
// behind keystrokes due to `debounceMs`, so ⌘+Enter fired immediately
// after typing would otherwise submit stale content.
const latest = editorRef.current?.getMarkdown()?.trim() ?? "";
if (!latest) return;
if (latest.length > MAX_MESSAGE_LEN) {
toast.error(t(($) => $.feedback.toast_too_long));
return;
}
try {
await mutation.mutateAsync({
message: latest,
url: typeof window !== "undefined" ? window.location.href : undefined,
workspace_id: workspace?.id,
kind,
});
clearDraft();
toast.success(t(($) => $.feedback.toast_sent));
onClose();
} catch (err) {
const msg =
err instanceof Error && err.message
? err.message
: t(($) => $.feedback.toast_failed);
toast.error(msg);
}
};
return (
<Dialog open onOpenChange={(v) => !v && onClose()}>
<DialogContent className="sm:max-w-2xl !h-[28rem] p-0 gap-0 flex flex-col overflow-hidden">
<DialogHeader className="px-5 pt-4 pb-2 shrink-0">
<DialogTitle>{t(($) => $.feedback.title)}</DialogTitle>
<p className="mt-1 text-xs text-muted-foreground">
{t(($) => $.feedback.github_hint_prefix)}
<a
href="https://github.com/multica-ai/multica/issues"
target="_blank"
rel="noopener noreferrer"
className="text-brand underline decoration-brand/40 underline-offset-2 hover:decoration-brand"
>
{t(($) => $.feedback.github_hint_link)}
</a>
</p>
</DialogHeader>
<div className="flex-1 min-h-0 px-5 pb-3">
<div
{...dropZoneProps}
className="relative h-full overflow-y-auto rounded-lg border-1 border-border transition-colors focus-within:border-brand"
>
<ContentEditor
ref={editorRef}
defaultValue={seededMessage}
placeholder={t(($) => $.feedback.placeholder)}
onUpdate={(md) => { setMessage(md); setDraft({ message: md }); }}
onUploadFile={uploadWithToast}
onUploadingChange={uploadGate.onUploadingChange}
onSubmit={handleSubmit}
debounceMs={150}
showBubbleMenu={false}
className="px-3 py-2"
/>
{isDragOver && <FileDropOverlay />}
</div>
</div>
<div className="flex items-center justify-between px-4 py-3 border-t shrink-0">
<FileUploadButton
size="sm"
multiple
onSelect={(file) => editorRef.current?.uploadFile(file)}
/>
<Button
size="sm"
onClick={handleSubmit}
disabled={!canSubmit}
aria-disabled={uploadGate.uploading || undefined}
aria-busy={uploadGate.uploading || undefined}
>
{mutation.isPending
? t(($) => $.feedback.sending)
: uploadGate.uploading
? tEditor(($) => $.upload.in_progress)
: t(($) => $.feedback.send)}
{sendShortcut ? (
<ShortcutKeycaps
shortcut={sendShortcut}
decorative
className="ml-1"
keyClassName="border-background/30 bg-background/15 text-primary-foreground shadow-none"
/>
) : null}
</Button>
</div>
</DialogContent>
</Dialog>
);
}