mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-27 21:33:41 +02:00
Adds an "Archived" sub-view to the Inbox, reachable from an entry at the
bottom of the main list, with per-row unarchive. Mirrors chat's archived
sub-view so the two surfaces share one mental model.
Backend:
- GET /api/inbox/archived and POST /api/inbox/{id}/unarchive. Kept off the
existing GET /api/inbox so installed clients keep their contract and the
unbounded archive never rides along with the main list.
- The archived query excludes any issue that still has an active row. Archiving
is issue-level, so a new notification on an archived issue leaves old archived
rows beside a fresh active one — without the guard the issue renders in BOTH
lists. The exclusion lives in SQL so neither list depends on the other's cache.
- Unarchive is issue-level (mirroring archive) and leaves `read` untouched, so a
restored unread item raises the unread badge again.
- v1 ships no pagination: LIMIT 200, newest-first, so truncation drops the
oldest rows and never hides a group's newest one.
- inbox:unarchived event, fanned out to the recipient like the other personal
inbox events.
- Two CONCURRENTLY-built indexes; inbox_item previously had none covering
workspace/archived/created_at.
Frontend:
- Separate TanStack cache per list; every inbox event invalidates the workspace
prefix, since any of them can move an item across the boundary.
- View persisted as ?view=archived, so refresh, back/forward, and the mobile
detail-back all return to the list the user was in.
- Batch actions stay main-view only — they archive from the MAIN inbox, so
offering them over the archived list would do the opposite of what it reads.
- Mobile subscribes to inbox:unarchived (its list gains the restored row); its
own archived view remains follow-up.
Known debt: no pagination, so an archive past ~200 rows is truncated silently
in the UI; the entry's count is the deduplicated count of the rows returned.
Verified: pnpm typecheck/test/lint (0 errors), go build/vet, Go inbox suite
against a real Postgres, migrations up+down, and EXPLAIN confirming both new
indexes serve the query.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
436 lines
13 KiB
Go
436 lines
13 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/multica-ai/multica/server/internal/logger"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
"github.com/multica-ai/multica/server/pkg/protocol"
|
|
)
|
|
|
|
type InboxItemResponse struct {
|
|
ID string `json:"id"`
|
|
WorkspaceID string `json:"workspace_id"`
|
|
RecipientType string `json:"recipient_type"`
|
|
RecipientID string `json:"recipient_id"`
|
|
Type string `json:"type"`
|
|
Severity string `json:"severity"`
|
|
IssueID *string `json:"issue_id"`
|
|
Title string `json:"title"`
|
|
Body *string `json:"body"`
|
|
Read bool `json:"read"`
|
|
Archived bool `json:"archived"`
|
|
CreatedAt string `json:"created_at"`
|
|
IssueStatus *string `json:"issue_status"`
|
|
ActorType *string `json:"actor_type"`
|
|
ActorID *string `json:"actor_id"`
|
|
Details json.RawMessage `json:"details"`
|
|
}
|
|
|
|
func inboxToResponse(i db.InboxItem) InboxItemResponse {
|
|
return InboxItemResponse{
|
|
ID: uuidToString(i.ID),
|
|
WorkspaceID: uuidToString(i.WorkspaceID),
|
|
RecipientType: i.RecipientType,
|
|
RecipientID: uuidToString(i.RecipientID),
|
|
Type: i.Type,
|
|
Severity: i.Severity,
|
|
IssueID: uuidToPtr(i.IssueID),
|
|
Title: i.Title,
|
|
Body: textToPtr(i.Body),
|
|
Read: i.Read,
|
|
Archived: i.Archived,
|
|
CreatedAt: timestampToString(i.CreatedAt),
|
|
ActorType: textToPtr(i.ActorType),
|
|
ActorID: uuidToPtr(i.ActorID),
|
|
Details: json.RawMessage(i.Details),
|
|
}
|
|
}
|
|
|
|
func inboxRowToResponse(r db.ListInboxItemsRow) InboxItemResponse {
|
|
return InboxItemResponse{
|
|
ID: uuidToString(r.ID),
|
|
WorkspaceID: uuidToString(r.WorkspaceID),
|
|
RecipientType: r.RecipientType,
|
|
RecipientID: uuidToString(r.RecipientID),
|
|
Type: r.Type,
|
|
Severity: r.Severity,
|
|
IssueID: uuidToPtr(r.IssueID),
|
|
Title: r.Title,
|
|
Body: textToPtr(r.Body),
|
|
Read: r.Read,
|
|
Archived: r.Archived,
|
|
CreatedAt: timestampToString(r.CreatedAt),
|
|
IssueStatus: textToPtr(r.IssueStatus),
|
|
ActorType: textToPtr(r.ActorType),
|
|
ActorID: uuidToPtr(r.ActorID),
|
|
Details: json.RawMessage(r.Details),
|
|
}
|
|
}
|
|
|
|
// ListArchivedInboxItemsRow carries the same columns as ListInboxItemsRow (both
|
|
// queries select `inbox_item.*` plus the joined issue status), so the archived
|
|
// row converts to the active one and reuses its mapper. If either query's
|
|
// column list drifts, this conversion stops compiling — which is the point.
|
|
func archivedInboxRowToResponse(r db.ListArchivedInboxItemsRow) InboxItemResponse {
|
|
return inboxRowToResponse(db.ListInboxItemsRow(r))
|
|
}
|
|
|
|
func (h *Handler) enrichInboxResponse(ctx context.Context, resp InboxItemResponse, issueID pgtype.UUID) InboxItemResponse {
|
|
if !issueID.Valid {
|
|
return resp
|
|
}
|
|
issue, err := h.Queries.GetIssue(ctx, issueID)
|
|
if err == nil {
|
|
s := issue.Status
|
|
resp.IssueStatus = &s
|
|
}
|
|
return resp
|
|
}
|
|
|
|
func (h *Handler) ListInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
items, err := h.Queries.ListInboxItems(r.Context(), db.ListInboxItemsParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientType: "member",
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to list inbox")
|
|
return
|
|
}
|
|
|
|
resp := make([]InboxItemResponse, len(items))
|
|
for i, item := range items {
|
|
resp[i] = inboxRowToResponse(item)
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
// ListArchivedInbox returns the recipient's archived notifications, backing the
|
|
// inbox's "Archived" sub-view. Kept as its own endpoint rather than a flag on
|
|
// ListInbox so installed clients keep their current contract, and so the
|
|
// unbounded archive never rides along with the main list.
|
|
//
|
|
// The query drops any issue that also has an active row, keeping this list and
|
|
// the main inbox mutually exclusive per issue group, and caps the response at
|
|
// 200 rows — see the query comment for both.
|
|
func (h *Handler) ListArchivedInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
items, err := h.Queries.ListArchivedInboxItems(r.Context(), db.ListArchivedInboxItemsParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientType: "member",
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to list archived inbox")
|
|
return
|
|
}
|
|
|
|
resp := make([]InboxItemResponse, len(items))
|
|
for i, item := range items {
|
|
resp[i] = archivedInboxRowToResponse(item)
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
func (h *Handler) MarkInboxRead(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
prev, ok := h.loadInboxItemForUser(w, r, id)
|
|
if !ok {
|
|
return
|
|
}
|
|
item, err := h.Queries.MarkInboxRead(r.Context(), prev.ID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to mark read")
|
|
return
|
|
}
|
|
|
|
userID := requestUserID(r)
|
|
workspaceID := uuidToString(item.WorkspaceID)
|
|
h.publish(protocol.EventInboxRead, workspaceID, "member", userID, map[string]any{
|
|
"item_id": uuidToString(item.ID),
|
|
"recipient_id": uuidToString(item.RecipientID),
|
|
})
|
|
|
|
resp := h.enrichInboxResponse(r.Context(), inboxToResponse(item), item.IssueID)
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
func (h *Handler) ArchiveInboxItem(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
prev, ok := h.loadInboxItemForUser(w, r, id)
|
|
if !ok {
|
|
return
|
|
}
|
|
item, err := h.Queries.ArchiveInboxItem(r.Context(), prev.ID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to archive")
|
|
return
|
|
}
|
|
|
|
// Archive all sibling inbox items for the same issue (issue-level archive)
|
|
if item.IssueID.Valid {
|
|
h.Queries.ArchiveInboxByIssue(r.Context(), db.ArchiveInboxByIssueParams{
|
|
WorkspaceID: item.WorkspaceID,
|
|
RecipientType: item.RecipientType,
|
|
RecipientID: item.RecipientID,
|
|
IssueID: item.IssueID,
|
|
})
|
|
}
|
|
|
|
userID := requestUserID(r)
|
|
workspaceID := uuidToString(item.WorkspaceID)
|
|
h.publish(protocol.EventInboxArchived, workspaceID, "member", userID, map[string]any{
|
|
"item_id": uuidToString(item.ID),
|
|
"issue_id": uuidToPtr(item.IssueID),
|
|
"recipient_id": uuidToString(item.RecipientID),
|
|
})
|
|
|
|
resp := h.enrichInboxResponse(r.Context(), inboxToResponse(item), item.IssueID)
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
// UnarchiveInboxItem restores an archived notification to the main inbox. It is
|
|
// the inverse of ArchiveInboxItem and mirrors its issue-level scope: archiving
|
|
// one item archives every sibling for the same issue, so restoring brings the
|
|
// whole group back.
|
|
//
|
|
// `read` is untouched on purpose. An item archived while unread comes back
|
|
// unread, which raises the unread badge again — the badge only ever counted
|
|
// non-archived items, so restoring one is a real addition, not a bug.
|
|
func (h *Handler) UnarchiveInboxItem(w http.ResponseWriter, r *http.Request) {
|
|
id := chi.URLParam(r, "id")
|
|
prev, ok := h.loadInboxItemForUser(w, r, id)
|
|
if !ok {
|
|
return
|
|
}
|
|
item, err := h.Queries.UnarchiveInboxItem(r.Context(), prev.ID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to unarchive")
|
|
return
|
|
}
|
|
|
|
// Restore all sibling inbox items for the same issue (issue-level restore).
|
|
if item.IssueID.Valid {
|
|
h.Queries.UnarchiveInboxByIssue(r.Context(), db.UnarchiveInboxByIssueParams{
|
|
WorkspaceID: item.WorkspaceID,
|
|
RecipientType: item.RecipientType,
|
|
RecipientID: item.RecipientID,
|
|
IssueID: item.IssueID,
|
|
})
|
|
}
|
|
|
|
userID := requestUserID(r)
|
|
workspaceID := uuidToString(item.WorkspaceID)
|
|
h.publish(protocol.EventInboxUnarchived, workspaceID, "member", userID, map[string]any{
|
|
"item_id": uuidToString(item.ID),
|
|
"issue_id": uuidToPtr(item.IssueID),
|
|
"recipient_id": uuidToString(item.RecipientID),
|
|
})
|
|
|
|
resp := h.enrichInboxResponse(r.Context(), inboxToResponse(item), item.IssueID)
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
func (h *Handler) CountUnreadInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
count, err := h.Queries.CountUnreadInbox(r.Context(), db.CountUnreadInboxParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientType: "member",
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to count unread inbox")
|
|
return
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, map[string]int64{"count": count})
|
|
}
|
|
|
|
// InboxWorkspaceUnreadResponse is one workspace's unread inbox count in the
|
|
// cross-workspace summary.
|
|
type InboxWorkspaceUnreadResponse struct {
|
|
WorkspaceID string `json:"workspace_id"`
|
|
Count int64 `json:"count"`
|
|
}
|
|
|
|
// UnreadInboxSummary returns per-workspace unread inbox counts across every
|
|
// workspace the user belongs to. The sidebar uses it to light a dot on the
|
|
// workspace switcher when a workspace OTHER than the active one has unread
|
|
// items, without fetching each workspace's full inbox list. It is
|
|
// account-level by nature: it ignores the active workspace and keys only on
|
|
// the authenticated user.
|
|
func (h *Handler) UnreadInboxSummary(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
rows, err := h.Queries.CountUnreadInboxByWorkspace(r.Context(), parseUUID(userID))
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to summarize unread inbox")
|
|
return
|
|
}
|
|
|
|
resp := make([]InboxWorkspaceUnreadResponse, len(rows))
|
|
for i, row := range rows {
|
|
resp[i] = InboxWorkspaceUnreadResponse{
|
|
WorkspaceID: uuidToString(row.WorkspaceID),
|
|
Count: row.Count,
|
|
}
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
func (h *Handler) MarkAllInboxRead(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
count, err := h.Queries.MarkAllInboxRead(r.Context(), db.MarkAllInboxReadParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to mark all inbox read")
|
|
return
|
|
}
|
|
|
|
slog.Info("inbox: mark all read", append(logger.RequestAttrs(r), "user_id", userID, "count", count)...)
|
|
h.publish(protocol.EventInboxBatchRead, workspaceID, "member", userID, map[string]any{
|
|
"recipient_id": userID,
|
|
"count": count,
|
|
})
|
|
|
|
writeJSON(w, http.StatusOK, map[string]any{"count": count})
|
|
}
|
|
|
|
func (h *Handler) ArchiveAllInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
count, err := h.Queries.ArchiveAllInbox(r.Context(), db.ArchiveAllInboxParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to archive all inbox")
|
|
return
|
|
}
|
|
|
|
slog.Info("inbox: archive all", append(logger.RequestAttrs(r), "user_id", userID, "count", count)...)
|
|
h.publish(protocol.EventInboxBatchArchived, workspaceID, "member", userID, map[string]any{
|
|
"recipient_id": userID,
|
|
"count": count,
|
|
})
|
|
|
|
writeJSON(w, http.StatusOK, map[string]any{"count": count})
|
|
}
|
|
|
|
func (h *Handler) ArchiveAllReadInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
count, err := h.Queries.ArchiveAllReadInbox(r.Context(), db.ArchiveAllReadInboxParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to archive all read inbox")
|
|
return
|
|
}
|
|
|
|
slog.Info("inbox: archive all read", append(logger.RequestAttrs(r), "user_id", userID, "count", count)...)
|
|
h.publish(protocol.EventInboxBatchArchived, workspaceID, "member", userID, map[string]any{
|
|
"recipient_id": userID,
|
|
"count": count,
|
|
})
|
|
|
|
writeJSON(w, http.StatusOK, map[string]any{"count": count})
|
|
}
|
|
|
|
func (h *Handler) ArchiveCompletedInbox(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := ctxWorkspaceID(r.Context())
|
|
wsUUID, ok := parseUUIDOrBadRequest(w, workspaceID, "workspace id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
count, err := h.Queries.ArchiveCompletedInbox(r.Context(), db.ArchiveCompletedInboxParams{
|
|
WorkspaceID: wsUUID,
|
|
RecipientID: parseUUID(userID),
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to archive completed inbox")
|
|
return
|
|
}
|
|
|
|
slog.Info("inbox: archive completed", append(logger.RequestAttrs(r), "user_id", userID, "count", count)...)
|
|
h.publish(protocol.EventInboxBatchArchived, workspaceID, "member", userID, map[string]any{
|
|
"recipient_id": userID,
|
|
"count": count,
|
|
})
|
|
|
|
writeJSON(w, http.StatusOK, map[string]any{"count": count})
|
|
}
|