mirror of
https://github.com/multica-ai/multica.git
synced 2026-06-17 03:38:32 +02:00
* feat(auth): make auth token TTL configurable via AUTH_TOKEN_TTL env var Add AUTH_TOKEN_TTL environment variable (in seconds) to override the hardcoded 30-day auth token lifetime. Self-hosted deployments on trusted networks can set a longer value to avoid frequent magic-link re-authentication. The value is read once at startup and cached. Invalid or missing values fall back to the 30-day default with a warning log. Closes #2685 * refactor(auth): extract parseAuthTokenTTL for testability Address review feedback: extract pure parse function from sync.Once wrapper so the parsing logic can be unit-tested independently. Add TestParseAuthTokenTTL with table-driven cases. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com> * refactor(auth): accept Go duration strings + hoist shared TTL in SetAuthCookies Address nice-to-have review feedback from Bohan-J: - parseAuthTokenTTL now tries time.ParseDuration first (e.g. '8760h'), falling back to ParseInt for integer seconds - Warn on unreasonable values (>10 years) but still accept them - Hoist AuthTokenTTL() and time.Now() in SetAuthCookies so both cookies share the exact same expiry - Add security trade-off note in .env.example - Add 5 new test cases for duration strings Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com> Signed-off-by: kagura-agent <kagura.agent.ai@gmail.com> * fix: use AuthTokenTTL() in CloudFront middleware, guard ParseInt overflow Address review feedback from Bohan-J (round 2): 1. CloudFront refresh middleware (cloudfront.go:21) was hardcoding 30*24*time.Hour instead of using auth.AuthTokenTTL(). Now calls AuthTokenTTL() so the middleware respects AUTH_TOKEN_TTL env var. 2. parseAuthTokenTTL integer-seconds branch: very large values like 9999999999 would silently overflow int64 when multiplied by time.Second. Added overflow guard comparing against math.MaxInt64/int64(time.Second) before the multiplication. 3. Updated AuthTokenTTL() doc comment to reflect that it accepts Go duration strings or integer seconds (not just seconds). 4. Added middleware test (cloudfront_test.go) verifying short AUTH_TOKEN_TTL produces short cookie expiry, not 30-day hardcode. Also covers nil signer and existing-cookie-skip cases. 5. Added integer overflow test case to cookie_test.go. * style: run gofmt on cookie.go and cookie_test.go --------- Signed-off-by: kagura-agent <kagura.agent.ai@gmail.com> Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com>
256 lines
6.8 KiB
Go
256 lines
6.8 KiB
Go
package auth
|
|
|
|
import (
|
|
"crypto/hmac"
|
|
"crypto/rand"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"log/slog"
|
|
"math"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
const (
|
|
AuthCookieName = "multica_auth"
|
|
CSRFCookieName = "multica_csrf"
|
|
defaultAuthTokenTTL = 30 * 24 * time.Hour // 30 days
|
|
)
|
|
|
|
var (
|
|
ipCookieDomainWarnOnce sync.Once
|
|
authTokenTTLOnce sync.Once
|
|
authTokenTTLCached time.Duration
|
|
)
|
|
|
|
// parseAuthTokenTTL parses a raw AUTH_TOKEN_TTL value into a duration.
|
|
// It first tries time.ParseDuration (e.g. "8760h", "720h30m"), then falls
|
|
// back to parsing as integer seconds. Returns the parsed duration and true
|
|
// on success; zero and false when the input is empty or invalid.
|
|
func parseAuthTokenTTL(raw string) (time.Duration, bool) {
|
|
raw = strings.TrimSpace(raw)
|
|
if raw == "" {
|
|
return 0, false
|
|
}
|
|
|
|
// Try Go duration string first (e.g. "8760h", "720h30m").
|
|
if d, err := time.ParseDuration(raw); err == nil {
|
|
if d <= 0 {
|
|
return 0, false
|
|
}
|
|
if d > 10*365*24*time.Hour {
|
|
slog.Warn("AUTH_TOKEN_TTL exceeds 10 years; accepting but verify this is intentional",
|
|
"value", raw, "hours", d.Hours())
|
|
}
|
|
return d, true
|
|
}
|
|
|
|
// Fall back to plain integer seconds.
|
|
secs, err := strconv.ParseInt(raw, 10, 64)
|
|
if err != nil || secs <= 0 {
|
|
return 0, false
|
|
}
|
|
if secs > int64(math.MaxInt64/int64(time.Second)) {
|
|
return 0, false
|
|
}
|
|
d := time.Duration(secs) * time.Second
|
|
if d > 10*365*24*time.Hour {
|
|
slog.Warn("AUTH_TOKEN_TTL exceeds 10 years; accepting but verify this is intentional",
|
|
"value", raw, "hours", d.Hours())
|
|
}
|
|
return d, true
|
|
}
|
|
|
|
// AuthTokenTTL returns the configured auth token lifetime. It reads the
|
|
// AUTH_TOKEN_TTL environment variable (Go duration string or integer seconds) on first call and caches
|
|
// the result. When the variable is unset or invalid the default of 30 days
|
|
// is used.
|
|
func AuthTokenTTL() time.Duration {
|
|
authTokenTTLOnce.Do(func() {
|
|
raw := os.Getenv("AUTH_TOKEN_TTL")
|
|
if ttl, ok := parseAuthTokenTTL(raw); ok {
|
|
authTokenTTLCached = ttl
|
|
slog.Info("auth token TTL configured", "seconds", int(ttl.Seconds()))
|
|
return
|
|
}
|
|
authTokenTTLCached = defaultAuthTokenTTL
|
|
if strings.TrimSpace(raw) != "" {
|
|
slog.Warn("AUTH_TOKEN_TTL is not a valid duration or positive integer; using default",
|
|
"value", raw, "default_seconds", int(defaultAuthTokenTTL.Seconds()))
|
|
}
|
|
})
|
|
return authTokenTTLCached
|
|
}
|
|
|
|
// cookieDomain returns the trimmed COOKIE_DOMAIN env value, or "" if it looks
|
|
// like an IP address. RFC 6265 §4.1.2.3 forbids IP literals in the cookie
|
|
// Domain attribute, so browsers silently drop Set-Cookie headers that carry
|
|
// one. An IP value here is almost always a misconfiguration.
|
|
func cookieDomain() string {
|
|
raw := strings.TrimSpace(os.Getenv("COOKIE_DOMAIN"))
|
|
if raw == "" {
|
|
return ""
|
|
}
|
|
// A leading dot ("." for subdomain matching) is legal syntax but doesn't
|
|
// change whether the remainder is an IP literal.
|
|
if ip := net.ParseIP(strings.TrimPrefix(raw, ".")); ip != nil {
|
|
ipCookieDomainWarnOnce.Do(func() {
|
|
slog.Warn(
|
|
"COOKIE_DOMAIN looks like an IP address; ignoring. RFC 6265 forbids IP literals in the cookie Domain attribute, so browsers would drop the Set-Cookie. Leave COOKIE_DOMAIN empty for single-host deployments, or use a real domain.",
|
|
"value", raw,
|
|
)
|
|
})
|
|
return ""
|
|
}
|
|
return raw
|
|
}
|
|
|
|
// isSecureCookie reports whether session cookies should carry the Secure flag.
|
|
// Derived from the scheme of FRONTEND_ORIGIN — browsers silently drop Secure
|
|
// cookies received on a plain-HTTP page, so the flag has to track the actual
|
|
// user-facing scheme rather than a coarser environment name.
|
|
func isSecureCookie() bool {
|
|
raw := strings.TrimSpace(os.Getenv("FRONTEND_ORIGIN"))
|
|
if raw == "" {
|
|
return false
|
|
}
|
|
u, err := url.Parse(raw)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return strings.EqualFold(u.Scheme, "https")
|
|
}
|
|
|
|
// generateCSRFToken creates a CSRF token bound to the auth token via HMAC.
|
|
// Format: hex(nonce) + "." + hex(HMAC-SHA256(nonce, authToken)).
|
|
// This ensures an attacker who can write cookies on a subdomain cannot forge
|
|
// a valid CSRF token without knowing the auth token.
|
|
func generateCSRFToken(authToken string) (string, error) {
|
|
nonce := make([]byte, 16)
|
|
if _, err := rand.Read(nonce); err != nil {
|
|
return "", err
|
|
}
|
|
nonceHex := hex.EncodeToString(nonce)
|
|
|
|
mac := hmac.New(sha256.New, []byte(authToken))
|
|
mac.Write(nonce)
|
|
sig := hex.EncodeToString(mac.Sum(nil))
|
|
|
|
return nonceHex + "." + sig, nil
|
|
}
|
|
|
|
// SetAuthCookies sets the HttpOnly auth cookie and the readable CSRF cookie on the response.
|
|
func SetAuthCookies(w http.ResponseWriter, token string) error {
|
|
secure := isSecureCookie()
|
|
domain := cookieDomain()
|
|
ttl := AuthTokenTTL()
|
|
now := time.Now()
|
|
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: AuthCookieName,
|
|
Value: token,
|
|
Path: "/",
|
|
Domain: domain,
|
|
MaxAge: int(ttl.Seconds()),
|
|
Expires: now.Add(ttl),
|
|
HttpOnly: true,
|
|
Secure: secure,
|
|
SameSite: http.SameSiteStrictMode,
|
|
})
|
|
|
|
csrfToken, err := generateCSRFToken(token)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: CSRFCookieName,
|
|
Value: csrfToken,
|
|
Path: "/",
|
|
Domain: domain,
|
|
MaxAge: int(ttl.Seconds()),
|
|
Expires: now.Add(ttl),
|
|
HttpOnly: false,
|
|
Secure: secure,
|
|
SameSite: http.SameSiteStrictMode,
|
|
})
|
|
|
|
return nil
|
|
}
|
|
|
|
// ClearAuthCookies removes the auth and CSRF cookies.
|
|
func ClearAuthCookies(w http.ResponseWriter) {
|
|
domain := cookieDomain()
|
|
secure := isSecureCookie()
|
|
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: AuthCookieName,
|
|
Value: "",
|
|
Path: "/",
|
|
Domain: domain,
|
|
MaxAge: -1,
|
|
Expires: time.Unix(0, 0),
|
|
HttpOnly: true,
|
|
Secure: secure,
|
|
SameSite: http.SameSiteStrictMode,
|
|
})
|
|
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: CSRFCookieName,
|
|
Value: "",
|
|
Path: "/",
|
|
Domain: domain,
|
|
MaxAge: -1,
|
|
Expires: time.Unix(0, 0),
|
|
HttpOnly: false,
|
|
Secure: secure,
|
|
SameSite: http.SameSiteStrictMode,
|
|
})
|
|
}
|
|
|
|
// ValidateCSRF checks the X-CSRF-Token header against the auth cookie.
|
|
// The CSRF token is HMAC-signed with the auth token, so the server verifies
|
|
// the signature rather than simply comparing cookie == header.
|
|
// Returns true if validation passes (including for safe methods that don't need CSRF).
|
|
func ValidateCSRF(r *http.Request) bool {
|
|
switch r.Method {
|
|
case http.MethodGet, http.MethodHead, http.MethodOptions:
|
|
return true
|
|
}
|
|
|
|
csrfHeader := r.Header.Get("X-CSRF-Token")
|
|
if csrfHeader == "" {
|
|
return false
|
|
}
|
|
|
|
authCookie, err := r.Cookie(AuthCookieName)
|
|
if err != nil || authCookie.Value == "" {
|
|
return false
|
|
}
|
|
|
|
parts := strings.SplitN(csrfHeader, ".", 2)
|
|
if len(parts) != 2 {
|
|
return false
|
|
}
|
|
|
|
nonce, err := hex.DecodeString(parts[0])
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
expectedSig, err := hex.DecodeString(parts[1])
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
mac := hmac.New(sha256.New, []byte(authCookie.Value))
|
|
mac.Write(nonce)
|
|
return hmac.Equal(mac.Sum(nil), expectedSig)
|
|
}
|