Files
multica/packages/views/issues/surface/use-issue-surface-controller.ts
Naiyuan Qing afc7ac4bd0 feat: space rollout — space-first navigation, per-user membership, move-to-space (MUL-4142)
Squashed history of PR #4892 (pr-4784-fix). Makes spaces the primary
navigation and working surface, on the "associations bind at creation
time only" model.

Model
- Issue <-> space is the only enforced ownership (per-space numbering).
  Parent/child and project<->space associations only seed defaults at
  creation; cross-space/child and project-association validations are
  removed.
- Moving an issue renumbers it and records the old identifier in
  issue_identifier_alias; API/CLI lookups and GitHub branch/PR
  auto-linking fall back to the alias, so old identifiers resolve forever.
- Membership drives only the sidebar and personal defaults — never
  access. Anyone can configure any space's member set wholesale
  (PUT /api/spaces/{id}/members); saving an empty set archives the
  space behind a confirm.
- Per-user space order (workspace_space_member.sort_order, fractional):
  drag-sorted sidebar, "my first space" is the personal issue-creation
  default; the workspace default space backs headless creation
  (agents/CLI/Slack) and system placement.

Surfaces
- Sidebar: joined-spaces section (drag reorder, row -> space page,
  per-group persisted collapse), Workspace group with a More menu,
  Settings demoted to a footer icon.
- /space/:key/{issues,projects,autopilots,settings} — space surfaces
  reuse shared page components; a routed /space/new create page
  (replacing the earlier create-space modal), reserved key "NEW" so it
  can never collide with a real space's /space/:key detail page.
- Issue detail moves to /issue/:id (identifier-first, Linear-style; old
  /issues/:id redirects); create dialogs lead with a required space pill.
- Agent runtime brief now carries Space context (id/key/name) through
  the daemon claim -> TaskContextForEnv -> prompt pipeline, with a
  "## Space Context" section and --space on issue create/update in both
  brief renderers, matching Project's existing treatment.
- zh-Hans: Space translated to 空间 across locales and conventions.zh.mdx.

Fixes along the way
- Cache membership judgment gains the space dimension + space_changed
  WS flag.
- Silent skip on default-space lookup during invite acceptance is now a
  hard failure (no space-less members).
- Backfilled space_id into ~28 raw-SQL Go test fixtures across
  internal/handler and cmd/server that predated migration 132's NOT
  NULL cutover.
- Fixed a resolve-loop bug in the IssueDetail identifier wrapper (mount/
  unmount cycle on resolution failure) and gave it its own loading
  skeleton instead of a blank screen while resolving.
- reserved-slugs generator's stale hardcoded doc-comment example synced
  back to /create-space.

Verification
- go build ./..., go vet ./..., go test ./... all clean.
- pnpm typecheck (core/views/web/desktop) clean.
- packages/views: 162 files / 1656 tests passing.
- pnpm generate:reserved-slugs produces no diff.

Follow-ups tracked in docs/follow-ups/space-rollout.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-08 20:57:38 +08:00

229 lines
7.6 KiB
TypeScript

"use client";
import { useEffect, useMemo } from "react";
import type { QueryKey } from "@tanstack/react-query";
import type { Issue, IssueAssigneeGroup, Project } from "@multica/core/types";
import { useWorkspaceId } from "@multica/core/hooks";
import { BOARD_STATUSES } from "@multica/core/issues/config";
import { dateOnlyToLocalDate } from "@multica/core/issues/date";
import type {
AssigneeGroupedIssuesFilter,
IssueSortParam,
MyIssuesFilter,
} from "@multica/core/issues/queries";
import {
buildIssueSurfaceQueryPlan,
type IssueSurfaceQueryPlan,
} from "@multica/core/issues/surface/query-plan";
import type { IssueScope } from "@multica/core/issues/surface/scope";
import type { IssueDateFilter } from "@multica/core/issues/stores/view-store";
import { useViewStore } from "@multica/core/issues/stores/view-store-context";
import type { IssueFilters } from "../utils/filter";
import type { ChildProgress } from "../components/list-row";
import type { IssueSurfaceMode } from "./types";
import type { IssueSurfaceActivity } from "./activity";
import type { IssueSurfaceActions } from "./actions-context";
import {
type IssueSurfaceSelection,
useCreateIssueSurfaceSelection,
} from "./selection-context";
import type { IssueCreateDefaults } from "./types";
import {
useIssueSurfaceActions,
type MoveIssueUpdates,
} from "./use-issue-surface-actions";
import { useIssueSurfaceData } from "./use-issue-surface-data";
interface UseIssueSurfaceControllerInput {
scope: IssueScope;
modes: IssueSurfaceMode[];
createDefaults?: IssueCreateDefaults;
}
export interface IssueSurfaceController {
scopeKey: string;
projectId?: string;
createDefaults: IssueCreateDefaults;
viewMode: IssueSurfaceMode;
allowGantt: boolean;
surfaceIssues: Issue[];
projectIssues: Issue[];
issues: Issue[];
swimlaneIssues: Issue[];
filteredGanttIssues: Issue[];
assigneeGroups?: IssueAssigneeGroup[];
assigneeGroupQueryKey?: QueryKey;
assigneeGroupFilter?: AssigneeGroupedIssuesFilter;
filter: MyIssuesFilter;
loadMoreScope?: string;
loadMoreFilter?: MyIssuesFilter;
sort: IssueSortParam;
ganttIssues: Issue[];
visibleStatuses: typeof BOARD_STATUSES;
hiddenStatuses: typeof BOARD_STATUSES;
activeFilters: Omit<IssueFilters, "statusFilters" | "runningIssueIds">;
activity: IssueSurfaceActivity;
actions: IssueSurfaceActions;
selection: IssueSurfaceSelection;
childProgressMap: Map<string, ChildProgress>;
projectMap: Map<string, Project>;
isLoading: boolean;
/** See IssueSurfaceData.isRefreshing — placeholder-backed revalidation. */
isRefreshing: boolean;
isEmpty: boolean;
openCreateIssue: (defaults?: IssueCreateDefaults) => void;
moveIssue: (
issueId: string,
updates: MoveIssueUpdates,
onSettled?: () => void,
) => void;
}
function issueDateFilterToApiParams(filter: IssueDateFilter | null) {
if (!filter) return {};
const from = dateOnlyToLocalDate(filter.from);
const to = dateOnlyToLocalDate(filter.to);
if (!from || !to) return {};
const start = from <= to ? from : to;
const endSource = from <= to ? to : from;
const end = new Date(endSource);
end.setDate(end.getDate() + 1);
return {
date_field: filter.field,
date_start: start.toISOString(),
date_end: end.toISOString(),
};
}
export function useIssueSurfaceController({
scope,
modes,
createDefaults,
}: UseIssueSurfaceControllerInput): IssueSurfaceController {
const wsId = useWorkspaceId();
const queryPlan = useMemo<IssueSurfaceQueryPlan>(
() => buildIssueSurfaceQueryPlan(scope),
[scope],
);
const scopeKey = queryPlan.scopeKey;
const projectId = scope.type === "project" ? scope.projectId : undefined;
const viewMode = useViewStore((s) => s.viewMode);
const setViewMode = useViewStore((s) => s.setViewMode);
const grouping = useViewStore((s) => s.grouping);
const sortBy = useViewStore((s) => s.sortBy);
const sortDirection = useViewStore((s) => s.sortDirection);
const dateFilter = useViewStore((s) => s.dateFilter);
const statusFilters = useViewStore((s) => s.statusFilters);
const priorityFilters = useViewStore((s) => s.priorityFilters);
const assigneeFilters = useViewStore((s) => s.assigneeFilters);
const includeNoAssignee = useViewStore((s) => s.includeNoAssignee);
const creatorFilters = useViewStore((s) => s.creatorFilters);
const spaceFilter = useViewStore((s) => s.spaceFilter);
const projectFilters = useViewStore((s) => s.projectFilters);
const includeNoProject = useViewStore((s) => s.includeNoProject);
const labelFilters = useViewStore((s) => s.labelFilters);
const agentRunningFilter = useViewStore((s) => s.agentRunningFilter);
const showSubIssues = useViewStore((s) => s.showSubIssues);
const cardProperties = useViewStore((s) => s.cardProperties);
const swimlaneGrouping = useViewStore((s) => s.swimlaneGrouping);
const allowedModes = useMemo(() => new Set<IssueSurfaceMode>(modes), [modes]);
const fallbackMode = modes[0] ?? "list";
const effectiveViewMode = allowedModes.has(viewMode as IssueSurfaceMode)
? (viewMode as IssueSurfaceMode)
: fallbackMode;
useEffect(() => {
if (!allowedModes.has(viewMode as IssueSurfaceMode)) {
setViewMode(fallbackMode);
}
}, [allowedModes, fallbackMode, setViewMode, viewMode]);
const resolvedCreateDefaults = useMemo(
() => ({ ...queryPlan.createDefaults, ...createDefaults }),
[createDefaults, queryPlan.createDefaults],
);
const dateParams = useMemo(
() => issueDateFilterToApiParams(dateFilter),
[dateFilter],
);
const sort = useMemo<IssueSortParam>(
() => ({
sort_by: sortBy,
sort_direction: sortBy !== "position" ? sortDirection : undefined,
...dateParams,
// space_id is a cross-scope server filter, not a sort. It rides the
// sort param bag (like the date filter) so it threads through every
// repository path — workspace list, scoped list, and assignee-grouped —
// and forks the query-key cache per space without the query plan (built
// from scope alone) needing to know about the view store.
...(spaceFilter ? { space_id: spaceFilter } : {}),
}),
[dateParams, sortBy, sortDirection, spaceFilter],
);
const selection = useCreateIssueSurfaceSelection(
scopeKey,
`${scopeKey}:${effectiveViewMode}`,
);
const usesAssigneeBoard =
effectiveViewMode === "board" && grouping === "assignee";
const usesGantt = effectiveViewMode === "gantt" && !!projectId;
const projectFilterState = useMemo(
() => ({
projectFilters: scope.type === "project" ? [] : projectFilters,
includeNoProject: scope.type === "project" ? false : includeNoProject,
}),
[includeNoProject, projectFilters, scope.type],
);
const { projectFilters: viewProjectFilters, includeNoProject: viewIncludeNoProject } =
projectFilterState;
const data = useIssueSurfaceData({
wsId,
queryPlan,
projectId,
usesAssigneeBoard,
usesGantt,
sort,
statusFilters,
priorityFilters,
assigneeFilters,
includeNoAssignee,
creatorFilters,
projectFilters: viewProjectFilters,
includeNoProject: viewIncludeNoProject,
labelFilters,
agentRunningFilter,
showSubIssues,
loadProjects:
cardProperties.project ||
(effectiveViewMode === "swimlane" && swimlaneGrouping === "project"),
});
const { actions, openCreateIssue, moveIssue } = useIssueSurfaceActions({
createDefaults: resolvedCreateDefaults,
});
return {
scopeKey,
projectId,
createDefaults: resolvedCreateDefaults,
viewMode: effectiveViewMode,
allowGantt: allowedModes.has("gantt") && !!projectId,
...data,
sort,
actions,
selection,
openCreateIssue,
moveIssue,
};
}