mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-05 09:30:05 +02:00
* perf(agents): make runtime model discovery fast on runtime switch (MUL-5444) Switching runtime in the agent creation form left the model picker spinning for ~8-20s. Two costs stacked up: - the list-models request sat in the store until the daemon's next scheduled heartbeat (0-15s, avg 7.5s of pure dead wait), and - the daemon then enumerated the catalog locally (static for claude, but a CLI/ACP round trip up to ~15s for everyone else). Both are addressed with the two standard techniques for a slow, low-frequency, read-only operation: push instead of poll, and stale-while-revalidate. Push (removes the heartbeat wait): - new additive `daemon:pending_work` hint, runtime-scoped, delivered through the existing daemon WS hub and the Redis relay so the API node holding the socket does the delivery. - the daemon answers a hint with ONE immediate heartbeat and dispatches what it claimed. The hint deliberately carries no work, so nothing has to be un-claimed when delivery fails and a duplicate hint cannot duplicate work - PopPending stays the atomic claim. - per-runtime coalescing plus a 1s floor keeps a caller-triggered hint from becoming a heartbeat amplifier. Cache (removes the discovery wait on repeat opens): - server-side per-runtime catalog cache (in-memory single-node, Redis multi-node) written on every successful report. - a snapshot younger than 15min answers the POST immediately as an already-completed request; older than 60s it also enqueues a background refresh that only warms the cache. - only supported, non-empty catalogs are cached; a completed-but-empty report invalidates instead, while a failed report keeps serving the last known good list. Frontend: staleTime 60s -> 5min and gcTime 30min, so a runtime revisited in the same session renders from cache and revalidates in the background instead of showing the spinner again. Compatibility: every wire change is additive. Old daemons ignore the unknown hint type and keep using the scheduled heartbeat; new daemons against an old server simply never receive one. The cached response is shaped exactly like a completed live discovery apart from the optional `cached` / `cached_at` markers. Co-authored-by: multica-agent <github@multica.ai> * fix(agents): address review on model discovery SWR (MUL-5444) Sol-Boy's review on #6098 found the client cache could outlive the server's own staleness promise, and that the two changed endpoints were still cast rather than validated. Must-fix 1 — client freshness now derives from the served answer. `staleTime` was a flat 5min, so a 14-minute-old snapshot (which the server returns while queueing its own refresh) was held as fresh for another 5min: observable staleness became server window + client window, and the refreshed catalog never reached the tab that triggered the refresh. `staleTime` is now a function of the query data: a `cached` answer is stale on arrival (bound stays the server's window alone, and the next mount/focus picks up the refreshed snapshot), while a live discovery — which just measured the truth — is trusted for the full 5min so a cold runtime is never re-enumerated inside one form session. `gcTime` stays 30min, so a revisited runtime still renders from cache and revalidates in the background; the pickers gate their spinner on `isLoading`, which stays false throughout. Must-fix 2 — both model-discovery responses go through a zod schema. `POST /api/runtimes/{id}/models` and its poll companion were casting network JSON to `RuntimeModelListRequest`, which the root CLAUDE.md API-compatibility rules forbid. Added a lenient schema (`status` stays `z.string()`, `supported` defaults to true, `.loose()` keeps unknown fields) plus a fallback record whose `status` is `failed`: a malformed body now surfaces "discovery failed" with manual entry still usable instead of a fabricated empty catalog or an endless spinner. `resolveRuntimeModels` was tightened to match — only an explicit `completed` is a catalog, so an unrecognised status is an error rather than a silent empty list, and `supported` can no longer be `undefined`. Nit — the in-memory catalog cache now deep-copies each entry's `Thinking` (and its level slice) and `ServiceTiers`, so it delivers the independent value its comment promises and matches the Redis backend's JSON round-trip semantics. Tests: staleTime policy for cached/live/no-data; a QueryObserver test proving the refreshed catalog reaches the same client with no blank loading state; unknown-status and omitted-`supported` handling; schema tests for live, cached, old-backend and nine malformed shapes; client tests that both endpoints degrade to an explicit failure; nested-field mutation isolation for the cache. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Eve <eve@multica-ai.local> Co-authored-by: multica-agent <github@multica.ai>
532 lines
20 KiB
Go
532 lines
20 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/multica-ai/multica/server/pkg/protocol"
|
|
)
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Model list request store
|
|
// ---------------------------------------------------------------------------
|
|
//
|
|
// The server cannot call the daemon directly (the daemon is behind the user's
|
|
// NAT and only polls the server). So "list models for this runtime" uses a
|
|
// pending-request pattern: a frontend POST creates a pending request, the
|
|
// daemon pops it on the next heartbeat, executes locally, and reports the
|
|
// result back.
|
|
//
|
|
// The store is the cross-cutting state for that flow. It MUST stay coherent
|
|
// across API replicas — POST, heartbeat and poll can each land on a different
|
|
// node, and they all need to see the same request lifecycle. The single-node
|
|
// in-memory implementation is fine for self-hosted dev; multi-node deploys
|
|
// (Multica Cloud) MUST use the Redis-backed implementation, otherwise the
|
|
// pending request is invisible to whichever replica receives the next call
|
|
// and the picker shows "No models available" (regression: see issue
|
|
// review on multica-ai/multica#2009).
|
|
|
|
// ModelListStatus represents the lifecycle of a model list request.
|
|
type ModelListStatus string
|
|
|
|
const (
|
|
ModelListPending ModelListStatus = "pending"
|
|
ModelListRunning ModelListStatus = "running"
|
|
ModelListCompleted ModelListStatus = "completed"
|
|
ModelListFailed ModelListStatus = "failed"
|
|
ModelListTimeout ModelListStatus = "timeout"
|
|
)
|
|
|
|
// ModelListRequest represents a pending or completed model list request.
|
|
// Supported is false when the provider ignores per-agent model
|
|
// selection entirely (currently: hermes). The UI uses this to
|
|
// disable its dropdown rather than silently accepting a value the
|
|
// backend will drop.
|
|
//
|
|
// RunStartedAt is set when PopPending claims the request. It is
|
|
// `json:"-"` because it's a server-side bookkeeping field — the UI only
|
|
// needs Status / UpdatedAt to drive the polling loop.
|
|
type ModelListRequest struct {
|
|
ID string `json:"id"`
|
|
RuntimeID string `json:"runtime_id"`
|
|
Status ModelListStatus `json:"status"`
|
|
Models []ModelEntry `json:"models,omitempty"`
|
|
Supported bool `json:"supported"`
|
|
Error string `json:"error,omitempty"`
|
|
CreatedAt time.Time `json:"created_at"`
|
|
UpdatedAt time.Time `json:"updated_at"`
|
|
RunStartedAt *time.Time `json:"-"`
|
|
// Cached marks a response answered from the server-side catalog cache
|
|
// instead of a live daemon round trip (MUL-5444). Purely informational —
|
|
// Status is already "completed" and Models is already populated, so a client
|
|
// that ignores this field behaves exactly as before. CachedAt carries the
|
|
// snapshot's capture time for clients that want to surface freshness.
|
|
// Neither field is ever persisted in the request store; they only exist on
|
|
// the synthetic cache-hit response.
|
|
Cached bool `json:"cached,omitempty"`
|
|
CachedAt *time.Time `json:"cached_at,omitempty"`
|
|
}
|
|
|
|
// ModelEntry mirrors agent.Model for the wire. `Default` tags the
|
|
// model the runtime advertises as its preferred pick (e.g. Claude
|
|
// Code's shipped default, or hermes' currentModelId) so the UI can
|
|
// badge it — don't drop it when marshalling.
|
|
//
|
|
// `Thinking` carries the per-model reasoning-effort catalog discovered
|
|
// by the daemon for runtimes that support it (claude, codex — see
|
|
// MUL-2339). nil means "no picker for this model"; the UI hides the
|
|
// thinking_level selector. Older daemons (pre-2026-05) won't send this
|
|
// field, which is fine: the UI hides the selector and the agent runs
|
|
// with the runtime default.
|
|
type ModelEntry struct {
|
|
ID string `json:"id"`
|
|
Label string `json:"label"`
|
|
Provider string `json:"provider,omitempty"`
|
|
Default bool `json:"default,omitempty"`
|
|
Thinking *ModelThinking `json:"thinking,omitempty"`
|
|
ServiceTiers []ModelServiceTier `json:"service_tiers,omitempty"`
|
|
}
|
|
|
|
type ModelServiceTier struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
Description string `json:"description,omitempty"`
|
|
}
|
|
|
|
// ModelThinking is the wire shape for the per-model thinking catalog.
|
|
// Mirrors agent.ModelThinking so the daemon's report passes through
|
|
// without remapping.
|
|
type ModelThinking struct {
|
|
SupportedLevels []ThinkingLevel `json:"supported_levels"`
|
|
DefaultLevel string `json:"default_level,omitempty"`
|
|
}
|
|
|
|
// ThinkingLevel is the wire shape for a single entry in a model's
|
|
// reasoning-effort catalog. `Value` is the literal token the daemon
|
|
// passes to the CLI; `Label` is the human-readable display string;
|
|
// `Description` is optional helper copy (Codex's debug-models output
|
|
// includes one per level).
|
|
type ThinkingLevel struct {
|
|
Value string `json:"value"`
|
|
Label string `json:"label"`
|
|
Description string `json:"description,omitempty"`
|
|
}
|
|
|
|
const (
|
|
// modelListPendingTimeout bounds how long a pending request can sit in
|
|
// the store before the UI is told "daemon didn't pick this up".
|
|
modelListPendingTimeout = 30 * time.Second
|
|
// modelListRunningTimeout bounds how long a claimed (running) request
|
|
// can stay claimed before the UI is told "daemon picked this up but
|
|
// never reported a result". This matters when the heartbeat response
|
|
// carrying `pending_model_list` is lost in transit (e.g. HTTP client
|
|
// timeout after PopPending already mutated store state): without this
|
|
// transition the UI would keep polling a record that is stuck in
|
|
// `running` until retention sweeps it.
|
|
modelListRunningTimeout = 60 * time.Second
|
|
// modelListStoreRetention bounds how long any stored request lives in
|
|
// the backing store. The Redis backend uses it as a TTL; the in-memory
|
|
// backend GCs on Create. The window is deliberately wider than the
|
|
// running/pending timeouts so terminal records are still readable when
|
|
// the UI's last poll arrives.
|
|
modelListStoreRetention = 2 * time.Minute
|
|
)
|
|
|
|
// ModelListStore is the contract every backend (in-memory single-node,
|
|
// Redis multi-node) must satisfy. Methods take a context so the Redis
|
|
// implementation can honour the heartbeat-side timeout that gates a
|
|
// slow shared store from stalling the rest of the heartbeat.
|
|
type ModelListStore interface {
|
|
Create(ctx context.Context, runtimeID string) (*ModelListRequest, error)
|
|
Get(ctx context.Context, id string) (*ModelListRequest, error)
|
|
// HasPending is a cheap read-only probe used by the heartbeat hot path
|
|
// to gate the side-effecting PopPending. A spurious "true" is fine —
|
|
// PopPending handles "queue empty after probe" by returning nil.
|
|
HasPending(ctx context.Context, runtimeID string) (bool, error)
|
|
PopPending(ctx context.Context, runtimeID string) (*ModelListRequest, error)
|
|
Complete(ctx context.Context, id string, models []ModelEntry, supported bool) error
|
|
Fail(ctx context.Context, id string, errMsg string) error
|
|
}
|
|
|
|
// applyModelListTimeout transitions a request to ModelListTimeout when it has
|
|
// been stuck in a non-terminal state past its threshold. Returns true when
|
|
// the record was modified so callers can persist the change. The pending
|
|
// threshold catches "daemon never picked this up"; the running threshold
|
|
// catches "daemon picked it up but the result report was lost" — without
|
|
// the running escape, only retention sweep ends the polling loop.
|
|
func applyModelListTimeout(req *ModelListRequest, now time.Time) bool {
|
|
switch req.Status {
|
|
case ModelListPending:
|
|
if now.Sub(req.CreatedAt) > modelListPendingTimeout {
|
|
req.Status = ModelListTimeout
|
|
req.Error = "daemon did not respond within 30 seconds"
|
|
req.UpdatedAt = now
|
|
return true
|
|
}
|
|
case ModelListRunning:
|
|
if req.RunStartedAt != nil && now.Sub(*req.RunStartedAt) > modelListRunningTimeout {
|
|
req.Status = ModelListTimeout
|
|
req.Error = "daemon did not finish within 60 seconds"
|
|
req.UpdatedAt = now
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// InMemoryModelListStore is the single-node implementation. Adequate for
|
|
// self-hosted dev and the test suite, but unsafe in multi-node deploys
|
|
// (each replica gets its own map and the pending request is invisible to
|
|
// every replica that didn't receive the POST).
|
|
type InMemoryModelListStore struct {
|
|
mu sync.Mutex
|
|
requests map[string]*ModelListRequest
|
|
}
|
|
|
|
func NewInMemoryModelListStore() *InMemoryModelListStore {
|
|
return &InMemoryModelListStore{requests: make(map[string]*ModelListRequest)}
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) Create(_ context.Context, runtimeID string) (*ModelListRequest, error) {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
// Garbage-collect stale entries so the map can't grow unbounded.
|
|
for id, req := range s.requests {
|
|
if time.Since(req.CreatedAt) > modelListStoreRetention {
|
|
delete(s.requests, id)
|
|
}
|
|
}
|
|
|
|
now := time.Now()
|
|
req := &ModelListRequest{
|
|
ID: randomID(),
|
|
RuntimeID: runtimeID,
|
|
Status: ModelListPending,
|
|
// Default to true; the daemon overrides this in the report
|
|
// for providers that don't support per-agent model selection.
|
|
Supported: true,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}
|
|
s.requests[req.ID] = req
|
|
return req, nil
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) Get(_ context.Context, id string) (*ModelListRequest, error) {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
req, ok := s.requests[id]
|
|
if !ok {
|
|
return nil, nil
|
|
}
|
|
applyModelListTimeout(req, time.Now())
|
|
return req, nil
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) HasPending(_ context.Context, runtimeID string) (bool, error) {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
now := time.Now()
|
|
for _, req := range s.requests {
|
|
applyModelListTimeout(req, now)
|
|
if req.RuntimeID == runtimeID && req.Status == ModelListPending {
|
|
return true, nil
|
|
}
|
|
}
|
|
return false, nil
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) PopPending(_ context.Context, runtimeID string) (*ModelListRequest, error) {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
var oldest *ModelListRequest
|
|
now := time.Now()
|
|
for _, req := range s.requests {
|
|
applyModelListTimeout(req, now)
|
|
if req.RuntimeID == runtimeID && req.Status == ModelListPending {
|
|
if oldest == nil || req.CreatedAt.Before(oldest.CreatedAt) {
|
|
oldest = req
|
|
}
|
|
}
|
|
}
|
|
if oldest != nil {
|
|
oldest.Status = ModelListRunning
|
|
startedAt := now
|
|
oldest.RunStartedAt = &startedAt
|
|
oldest.UpdatedAt = now
|
|
}
|
|
return oldest, nil
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) Complete(_ context.Context, id string, models []ModelEntry, supported bool) error {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
if req, ok := s.requests[id]; ok {
|
|
req.Status = ModelListCompleted
|
|
req.Models = models
|
|
req.Supported = supported
|
|
req.UpdatedAt = time.Now()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *InMemoryModelListStore) Fail(_ context.Context, id string, errMsg string) error {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
if req, ok := s.requests[id]; ok {
|
|
req.Status = ModelListFailed
|
|
req.Error = errMsg
|
|
req.UpdatedAt = time.Now()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func modelListRequestTerminal(status ModelListStatus) bool {
|
|
return status == ModelListCompleted || status == ModelListFailed || status == ModelListTimeout
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Handlers
|
|
// ---------------------------------------------------------------------------
|
|
|
|
// InitiateListModels answers a "list this runtime's models" request.
|
|
//
|
|
// Fast path: a cached catalog younger than modelCatalogServeWindow is returned
|
|
// as an already-completed request, so the picker renders immediately instead of
|
|
// waiting for the daemon (stale-while-revalidate). Serving a snapshot older than
|
|
// modelCatalogRevalidateAfter also enqueues a background refresh, which nobody
|
|
// polls — its only job is to warm the cache for the next open.
|
|
//
|
|
// Slow path: enqueue a pending request the daemon claims on its next heartbeat,
|
|
// and push a wakeup hint so "next heartbeat" is now rather than up to one
|
|
// HeartbeatInterval away.
|
|
func (h *Handler) InitiateListModels(w http.ResponseWriter, r *http.Request) {
|
|
runtimeID := chi.URLParam(r, "runtimeId")
|
|
runtimeUUID, ok := parseUUIDOrBadRequest(w, runtimeID, "runtime_id")
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
rt, err := h.Queries.GetAgentRuntime(r.Context(), runtimeUUID)
|
|
if err != nil {
|
|
writeError(w, http.StatusNotFound, "runtime not found")
|
|
return
|
|
}
|
|
if _, ok := h.requireWorkspaceMember(w, r, uuidToString(rt.WorkspaceID), "runtime not found"); !ok {
|
|
return
|
|
}
|
|
if rt.Status != "online" {
|
|
writeError(w, http.StatusServiceUnavailable, "runtime is offline")
|
|
return
|
|
}
|
|
resolvedRuntimeID := uuidToString(rt.ID)
|
|
|
|
if cached := h.cachedModelCatalog(r.Context(), resolvedRuntimeID); cached != nil {
|
|
age := cached.Age(time.Now())
|
|
if age >= modelCatalogRevalidateAfter {
|
|
h.revalidateModelCatalog(r.Context(), resolvedRuntimeID)
|
|
}
|
|
storedAt := cached.StoredAt
|
|
writeJSON(w, http.StatusOK, &ModelListRequest{
|
|
// Synthetic ID: no store record backs a cache hit. Clients only poll
|
|
// GET /models/{id} while status is pending/running, which this
|
|
// response never is.
|
|
ID: randomID(),
|
|
RuntimeID: resolvedRuntimeID,
|
|
Status: ModelListCompleted,
|
|
Models: cached.Models,
|
|
Supported: cached.Supported,
|
|
CreatedAt: storedAt,
|
|
UpdatedAt: storedAt,
|
|
Cached: true,
|
|
CachedAt: &storedAt,
|
|
})
|
|
return
|
|
}
|
|
|
|
req, err := h.ModelListStore.Create(r.Context(), resolvedRuntimeID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to enqueue model list request: "+err.Error())
|
|
return
|
|
}
|
|
h.requestDaemonPendingWork(resolvedRuntimeID, protocol.PendingWorkKindModelList)
|
|
writeJSON(w, http.StatusOK, req)
|
|
}
|
|
|
|
// cachedModelCatalog returns a usable cached catalog, or nil when the cache is
|
|
// absent, cold, or unreadable. Cache problems must never fail the request — the
|
|
// caller just falls back to the daemon round trip.
|
|
func (h *Handler) cachedModelCatalog(ctx context.Context, runtimeID string) *ModelCatalogSnapshot {
|
|
if h.ModelCatalogCache == nil {
|
|
return nil
|
|
}
|
|
snapshot, err := h.ModelCatalogCache.Get(ctx, runtimeID)
|
|
if err != nil {
|
|
slog.Warn("model catalog cache read failed", "error", err, "runtime_id", runtimeID)
|
|
return nil
|
|
}
|
|
if snapshot == nil || !cacheableModelCatalog(snapshot.Models, snapshot.Supported) {
|
|
return nil
|
|
}
|
|
return snapshot
|
|
}
|
|
|
|
// revalidateModelCatalog enqueues a background discovery request whose result
|
|
// only updates the cache. No client polls it; the store's own timeout sweeps the
|
|
// record if the daemon never answers.
|
|
//
|
|
// Stampede control: skip when a request for this runtime is already queued. A
|
|
// running request that has already been claimed is not visible to HasPending, so
|
|
// two opens in the same second can enqueue two refreshes — bounded, cheap
|
|
// (the daemon memoizes discovery for 60s), and strictly better than the
|
|
// alternative of never refreshing.
|
|
func (h *Handler) revalidateModelCatalog(ctx context.Context, runtimeID string) {
|
|
if h.ModelListStore == nil {
|
|
return
|
|
}
|
|
pending, err := h.ModelListStore.HasPending(ctx, runtimeID)
|
|
if err != nil {
|
|
slog.Debug("model catalog revalidate probe failed", "error", err, "runtime_id", runtimeID)
|
|
return
|
|
}
|
|
if pending {
|
|
return
|
|
}
|
|
if _, err := h.ModelListStore.Create(ctx, runtimeID); err != nil {
|
|
slog.Debug("model catalog revalidate enqueue failed", "error", err, "runtime_id", runtimeID)
|
|
return
|
|
}
|
|
h.requestDaemonPendingWork(runtimeID, protocol.PendingWorkKindModelList)
|
|
}
|
|
|
|
// requestDaemonPendingWork nudges the daemon to heartbeat now. Best-effort by
|
|
// design: the daemon's scheduled heartbeat remains the correctness path, so a
|
|
// missing notifier or an offline daemon only costs latency. Prefers the relay
|
|
// notifier (reaches the API node holding the daemon's socket) and falls back to
|
|
// the local hub, which is the whole cluster in single-node deployments.
|
|
func (h *Handler) requestDaemonPendingWork(runtimeID, kind string) {
|
|
if runtimeID == "" {
|
|
return
|
|
}
|
|
if h.DaemonPendingWork != nil {
|
|
h.DaemonPendingWork.NotifyPendingWork(runtimeID, kind)
|
|
return
|
|
}
|
|
if h.DaemonHub != nil {
|
|
h.DaemonHub.NotifyPendingWork(runtimeID, kind)
|
|
}
|
|
}
|
|
|
|
// GetModelListRequest returns the status of a model list request.
|
|
func (h *Handler) GetModelListRequest(w http.ResponseWriter, r *http.Request) {
|
|
requestID := chi.URLParam(r, "requestId")
|
|
|
|
req, err := h.ModelListStore.Get(r.Context(), requestID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to load request: "+err.Error())
|
|
return
|
|
}
|
|
if req == nil {
|
|
writeError(w, http.StatusNotFound, "request not found")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, req)
|
|
}
|
|
|
|
// ReportModelListResult receives the list result from the daemon.
|
|
func (h *Handler) ReportModelListResult(w http.ResponseWriter, r *http.Request) {
|
|
runtimeID := chi.URLParam(r, "runtimeId")
|
|
|
|
if _, ok := h.requireDaemonRuntimeAccess(w, r, runtimeID); !ok {
|
|
return
|
|
}
|
|
|
|
requestID := chi.URLParam(r, "requestId")
|
|
|
|
// Fetch first so we can ignore stale reports for already-terminal
|
|
// requests (e.g. the heartbeat response that triggered the daemon
|
|
// run was a retry, and the original report already landed).
|
|
existing, err := h.ModelListStore.Get(r.Context(), requestID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to load request: "+err.Error())
|
|
return
|
|
}
|
|
if existing == nil || existing.RuntimeID != runtimeID {
|
|
writeError(w, http.StatusNotFound, "request not found")
|
|
return
|
|
}
|
|
if modelListRequestTerminal(existing.Status) {
|
|
slog.Debug("ignoring stale model list report", "runtime_id", runtimeID, "request_id", requestID, "status", existing.Status)
|
|
writeJSON(w, http.StatusOK, map[string]string{"status": "ok"})
|
|
return
|
|
}
|
|
|
|
var body struct {
|
|
Status string `json:"status"` // "completed" or "failed"
|
|
Models []ModelEntry `json:"models"`
|
|
Supported *bool `json:"supported"`
|
|
Error string `json:"error"`
|
|
}
|
|
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body")
|
|
return
|
|
}
|
|
|
|
if body.Status == "completed" {
|
|
// Older daemons may omit `supported`; default to true to keep
|
|
// the UI usable while they haven't been redeployed yet.
|
|
supported := true
|
|
if body.Supported != nil {
|
|
supported = *body.Supported
|
|
}
|
|
if err := h.ModelListStore.Complete(r.Context(), requestID, body.Models, supported); err != nil {
|
|
// Surface the store failure as 5xx so the daemon can retry instead
|
|
// of swallowing the report (leaves the request stuck in running
|
|
// until the server-side timeout, which is exactly the "looks OK
|
|
// but nothing happens" class of bug we're trying to avoid).
|
|
slog.Error("ModelListStore Complete failed", "error", err, "request_id", requestID)
|
|
writeError(w, http.StatusInternalServerError, "failed to persist completion")
|
|
return
|
|
}
|
|
// Warm the catalog cache so the next picker open renders instantly
|
|
// (MUL-5444). A cache write failure is not the daemon's problem — the
|
|
// report itself succeeded — so it is logged, not surfaced.
|
|
//
|
|
// A completed-but-uncacheable result (empty catalog, or a runtime that
|
|
// does not honour per-agent model selection) is the freshest truth we
|
|
// have: drop any older snapshot instead of letting the fast path keep
|
|
// serving a catalog the runtime no longer advertises. Failed reports
|
|
// deliberately leave the cache alone — serving the last known good list
|
|
// through a transient discovery failure is the point of the cache.
|
|
if h.ModelCatalogCache != nil {
|
|
if cacheableModelCatalog(body.Models, supported) {
|
|
if err := h.ModelCatalogCache.Put(r.Context(), runtimeID, body.Models, supported); err != nil {
|
|
slog.Warn("model catalog cache write failed", "error", err, "runtime_id", runtimeID)
|
|
}
|
|
} else if err := h.ModelCatalogCache.Invalidate(r.Context(), runtimeID); err != nil {
|
|
slog.Warn("model catalog cache invalidate failed", "error", err, "runtime_id", runtimeID)
|
|
}
|
|
}
|
|
} else {
|
|
if err := h.ModelListStore.Fail(r.Context(), requestID, body.Error); err != nil {
|
|
slog.Error("ModelListStore Fail failed", "error", err, "request_id", requestID)
|
|
writeError(w, http.StatusInternalServerError, "failed to persist failure")
|
|
return
|
|
}
|
|
}
|
|
|
|
slog.Debug("model list report", "runtime_id", runtimeID, "request_id", requestID, "status", body.Status, "count", len(body.Models))
|
|
writeJSON(w, http.StatusOK, map[string]string{"status": "ok"})
|
|
}
|