mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-04 17:18:35 +02:00
44a82fda4d
InitiateUpdate answered every UpdateStore.Create failure with a 409 carrying err.Error(). The in-memory store only ever returns errUpdateInProgress, so this looked safe — but the Redis store also wraps infrastructure failures as "reserve active update: <dial error>" and "persist update request: <error>". Surfacing 409 bodies in the CLI turns that into a user-visible leak of internal addresses, and labels an outage as a conflict the caller could fix by retrying. Classify instead: errUpdateInProgress keeps its 409 and its actionable message, everything else is logged and answered with a 500 and fixed copy. Also pins the prose-over-machine-code preference for validation bodies, which the shared extractor applies to 400/422 as well as 409. Only the issue-table endpoints are shaped that way and none is reachable from the CLI today, but the change is intentional and should fail loudly if reverted. MUL-5619 Co-authored-by: multica-agent <github@multica.ai>
84 lines
3.0 KiB
Go
84 lines
3.0 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// failingUpdateStore returns a chosen error from Create. The embedded interface
|
|
// supplies the rest of the method set; InitiateUpdate only reaches Create, so
|
|
// anything else calling through would panic loudly rather than pass silently.
|
|
type failingUpdateStore struct {
|
|
UpdateStore
|
|
createErr error
|
|
}
|
|
|
|
func (s *failingUpdateStore) Create(context.Context, string, string, string) (*UpdateRequest, error) {
|
|
return nil, s.createErr
|
|
}
|
|
|
|
// TestInitiateUpdate_InfrastructureErrorIsNotAConflict pins the classification
|
|
// split this PR adds alongside GH #6264. InitiateUpdate used to answer every
|
|
// UpdateStore.Create failure with a 409 carrying err.Error(). That was survivable
|
|
// while the CLI hid conflict bodies; now that they print by default, a Redis
|
|
// outage would show its dial address to the user and read as a conflict they
|
|
// could fix by retrying.
|
|
func TestInitiateUpdate_InfrastructureErrorIsNotAConflict(t *testing.T) {
|
|
if testHandler == nil || testPool == nil {
|
|
t.Skip("database not available")
|
|
}
|
|
|
|
// Shape mirrors RedisUpdateStore.Create wrapping a dial failure.
|
|
infraErr := errors.New("reserve active update: dial tcp 10.1.2.3:6379: connect: connection refused")
|
|
|
|
original := testHandler.UpdateStore
|
|
testHandler.UpdateStore = &failingUpdateStore{createErr: infraErr}
|
|
t.Cleanup(func() { testHandler.UpdateStore = original })
|
|
|
|
w := httptest.NewRecorder()
|
|
r := newRequest("POST", "/api/runtimes/"+testRuntimeID+"/update", map[string]any{"target_version": "v1.2.3"})
|
|
r = withURLParams(r, "runtimeId", testRuntimeID)
|
|
|
|
testHandler.InitiateUpdate(w, r)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("infrastructure failure: expected 500, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
body := w.Body.String()
|
|
for _, leak := range []string{"10.1.2.3:6379", "connection refused", "reserve active update"} {
|
|
if strings.Contains(body, leak) {
|
|
t.Fatalf("response leaked internal detail %q: %s", leak, body)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestInitiateUpdate_InProgressStillConflicts is the positive half: the one
|
|
// Create failure a caller can actually act on keeps its 409 and its actionable
|
|
// wording, which is exactly what the CLI now surfaces by default.
|
|
func TestInitiateUpdate_InProgressStillConflicts(t *testing.T) {
|
|
if testHandler == nil || testPool == nil {
|
|
t.Skip("database not available")
|
|
}
|
|
|
|
original := testHandler.UpdateStore
|
|
testHandler.UpdateStore = &failingUpdateStore{createErr: errUpdateInProgress}
|
|
t.Cleanup(func() { testHandler.UpdateStore = original })
|
|
|
|
w := httptest.NewRecorder()
|
|
r := newRequest("POST", "/api/runtimes/"+testRuntimeID+"/update", map[string]any{"target_version": "v1.2.3"})
|
|
r = withURLParams(r, "runtimeId", testRuntimeID)
|
|
|
|
testHandler.InitiateUpdate(w, r)
|
|
|
|
if w.Code != http.StatusConflict {
|
|
t.Fatalf("update-in-progress: expected 409, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
if !strings.Contains(w.Body.String(), "already in progress") {
|
|
t.Fatalf("409 should keep its actionable message, got %s", w.Body.String())
|
|
}
|
|
}
|