multica

mirror of https://github.com/multica-ai/multica.git synced 2026-08-03 11:10:23 +02:00

Files

Eve 9ffc5af030 fix(comments): merge only into the queued task, never a deferred fallback (MUL-4195)

Fourth-round review follow-up on PR #5068.

MergeCommentIntoPendingTask targeted status IN ('queued','deferred') ordered
by created_at DESC. When a (issue, agent) pair had both an older queued task
(the run about to be claimed) and a newer deferred assignee-fallback task, a
new comment merged into the deferred row instead of the queued one — so the
comment missed the imminent run and the deferred fallback could later promote
into a duplicate/conflicting run.

This merge is only ever reached when HasPendingTaskForIssueAndAgent matched a
queued/dispatched task (it never inspects deferred), so the coalescing target
must be the queued row. Restricted the merge target to status = 'queued'
(the unique index guarantees at most one). Deferred fallbacks keep their own
fire_at/promotion escalation lifecycle and are never a merge target.

Test: TestMergeCommentIntoPendingTask_TargetsQueuedNotDeferred seeds an older
queued task + a newer deferred fallback for the same (issue, agent), merges a
new comment, and asserts it lands on the queued task (trigger repointed, old
trigger coalesced) while the deferred fallback is left untouched.

Co-authored-by: multica-agent <github@multica.ai>

2026-07-08 14:54:36 +08:00

cmd

fix(comments): merge only into the queued task, never a deferred fallback (MUL-4195)

2026-07-08 14:54:36 +08:00

internal

fix(comments): merge only into the queued task, never a deferred fallback (MUL-4195)

2026-07-08 14:54:36 +08:00

migrations

fix(comments): guarantee at-least-once processing of user comments (MUL-4195)

2026-07-08 13:15:09 +08:00

pkg

fix(comments): merge only into the queued task, never a deferred fallback (MUL-4195)