mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-05 13:29:44 +02:00
d0ac67dea2
* fix(skills): drop SKILL.md content from list endpoints (#2174) `GET /api/skills` and `GET /api/agents/{id}/skills` were SELECT *'ing the skill row and shipping the full SKILL.md `content` blob to every caller. SKILL.md bodies routinely run 50–200KB each, so a workspace with 30–40 skills returned multi-megabyte JSON arrays — past the CLI's 15s timeout on high-latency links and locking out non-US users entirely. Add `ListSkillSummariesByWorkspace` / `ListAgentSkillSummaries` sqlc queries that omit `content`, plus a dedicated `SkillSummaryResponse` wire shape so the contract is explicit (versus stuffing `Content: ""` back into the existing struct). Detail endpoints (`GET /api/skills/{id}`, agent CRUD return values) keep returning the full body. `AgentResponse.skills` and the matching TS `Agent.skills` now use `SkillSummary[]` — frontend list/columns code already only read id/name/description/config.origin, so the type narrowing matches actual usage and prevents new code from accidentally depending on a content field that won't be there. Co-authored-by: multica-agent <github@multica.ai> * fix(agents): narrow embedded skills to AgentSkillSummary; gofmt agent.go GPT-Boy review of #2180: the previous commit typed AgentResponse.Skills as []SkillSummaryResponse, but the agent list batch query (ListAgentSkillsByWorkspace) only joins agent_id/id/name/description, so the wider type left workspace_id/config/created_at/updated_at as zero values. Define a dedicated AgentSkillSummary {id,name,description} that matches what the batch query actually returns and what the frontend actually reads (`agent.skills.map(s => s.name|s.id)`); the standalone GET /api/agents/{id}/skills endpoint keeps SkillSummaryResponse for callers that need the source/origin info. Switch GetAgent's per-agent skills load from ListAgentSkills (full Skill rows including content) back to ListAgentSkillSummaries to avoid reading SKILL.md bodies just to discard them. Re-run gofmt on agent.go to fix the field-tag alignment that drifted when Skills changed type. Co-authored-by: multica-agent <github@multica.ai> * docs(types): correct SkillSummary JSDoc — Agent.skills is AgentSkillSummary[] GPT-Boy spotted on review: comment said SkillSummary was "embedded in Agent.skills", but that field is now AgentSkillSummary[]. Re-point the reader at the right type to avoid future confusion. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: multica-agent <github@multica.ai>
104 lines
2.8 KiB
SQL
104 lines
2.8 KiB
SQL
-- Skill CRUD
|
|
|
|
-- name: ListSkillsByWorkspace :many
|
|
SELECT * FROM skill
|
|
WHERE workspace_id = $1
|
|
ORDER BY name ASC;
|
|
|
|
-- name: ListSkillSummariesByWorkspace :many
|
|
-- Same as ListSkillsByWorkspace but omits the SKILL.md `content` column. Used
|
|
-- by list endpoints (CLI table, web list page) where the body is never read;
|
|
-- shipping it everywhere blew up payload size on workspaces with many skills
|
|
-- and caused 15s CLI timeouts from high-latency regions (GH multica-ai/multica#2174).
|
|
SELECT id, workspace_id, name, description, config, created_by, created_at, updated_at
|
|
FROM skill
|
|
WHERE workspace_id = $1
|
|
ORDER BY name ASC;
|
|
|
|
-- name: GetSkill :one
|
|
SELECT * FROM skill
|
|
WHERE id = $1;
|
|
|
|
-- name: GetSkillInWorkspace :one
|
|
SELECT * FROM skill
|
|
WHERE id = $1 AND workspace_id = $2;
|
|
|
|
-- name: CreateSkill :one
|
|
INSERT INTO skill (workspace_id, name, description, content, config, created_by)
|
|
VALUES ($1, $2, $3, $4, $5, $6)
|
|
RETURNING *;
|
|
|
|
-- name: UpdateSkill :one
|
|
UPDATE skill SET
|
|
name = COALESCE(sqlc.narg('name'), name),
|
|
description = COALESCE(sqlc.narg('description'), description),
|
|
content = COALESCE(sqlc.narg('content'), content),
|
|
config = COALESCE(sqlc.narg('config'), config),
|
|
updated_at = now()
|
|
WHERE id = $1
|
|
RETURNING *;
|
|
|
|
-- name: DeleteSkill :exec
|
|
DELETE FROM skill WHERE id = $1;
|
|
|
|
-- Skill File CRUD
|
|
|
|
-- name: ListSkillFiles :many
|
|
SELECT * FROM skill_file
|
|
WHERE skill_id = $1
|
|
ORDER BY path ASC;
|
|
|
|
-- name: GetSkillFile :one
|
|
SELECT * FROM skill_file
|
|
WHERE id = $1;
|
|
|
|
-- name: UpsertSkillFile :one
|
|
INSERT INTO skill_file (skill_id, path, content)
|
|
VALUES ($1, $2, $3)
|
|
ON CONFLICT (skill_id, path) DO UPDATE SET
|
|
content = EXCLUDED.content,
|
|
updated_at = now()
|
|
RETURNING *;
|
|
|
|
-- name: DeleteSkillFile :exec
|
|
DELETE FROM skill_file WHERE id = $1;
|
|
|
|
-- name: DeleteSkillFilesBySkill :exec
|
|
DELETE FROM skill_file WHERE skill_id = $1;
|
|
|
|
-- Agent-Skill junction
|
|
|
|
-- name: ListAgentSkills :many
|
|
SELECT s.* FROM skill s
|
|
JOIN agent_skill ask ON ask.skill_id = s.id
|
|
WHERE ask.agent_id = $1
|
|
ORDER BY s.name ASC;
|
|
|
|
-- name: ListAgentSkillSummaries :many
|
|
-- Summary variant for the agent skills list endpoint — omits `content` for
|
|
-- the same reason as ListSkillSummariesByWorkspace.
|
|
SELECT s.id, s.workspace_id, s.name, s.description, s.config, s.created_by, s.created_at, s.updated_at
|
|
FROM skill s
|
|
JOIN agent_skill ask ON ask.skill_id = s.id
|
|
WHERE ask.agent_id = $1
|
|
ORDER BY s.name ASC;
|
|
|
|
-- name: AddAgentSkill :exec
|
|
INSERT INTO agent_skill (agent_id, skill_id)
|
|
VALUES ($1, $2)
|
|
ON CONFLICT DO NOTHING;
|
|
|
|
-- name: RemoveAgentSkill :exec
|
|
DELETE FROM agent_skill
|
|
WHERE agent_id = $1 AND skill_id = $2;
|
|
|
|
-- name: RemoveAllAgentSkills :exec
|
|
DELETE FROM agent_skill WHERE agent_id = $1;
|
|
|
|
-- name: ListAgentSkillsByWorkspace :many
|
|
SELECT ask.agent_id, s.id, s.name, s.description
|
|
FROM agent_skill ask
|
|
JOIN skill s ON s.id = ask.skill_id
|
|
WHERE s.workspace_id = $1
|
|
ORDER BY s.name ASC;
|