mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-06 14:00:09 +02:00
* feat(issues): unify run-enqueue decision behind WillEnqueueRun + preview endpoint Collapse the issue update/batch enqueue copies into one service predicate service.IssueService.WillEnqueueRun, shared verbatim with a new dry-run endpoint POST /api/issues/preview-trigger so the four entry points stop drifting (squad/self-loop/batch omissions, MUL-3375). The private-agent gate stays at the HTTP boundary: write paths inject allow-all, preview injects the real gate so it never leaks a private agent's readiness. Add suppress_run to issue update/batch: the change applies but no run starts. Remove the now-dead handler mirrors shouldEnqueueSquadLeaderOnAssign / isSquadLeaderReady. service.Create and the comment trigger chain are untouched. Tests: preview behavior, preview<->write-path match, batch aggregation, member no-trigger, suppress_run skip, malformed-body 400. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * feat(issues): inject handoff note into assigned runs via first-class task field Add an optional handoff_note carried by issue assign/promote into the run's opening prompt and issue_context.md, via a dedicated agent_task_queue column (migration 122) and a daemon assignment-handoff render branch — never a fabricated comment, never trigger_comment_id (MUL-3375 §6.1). Thread the note through enqueueIssueTask/enqueueMentionTask + WithHandoff public variants and dispatchIssueRun; suppress_run or a parked write drops it (no run = nothing to inject). Soft version gate: MinHandoffCLIVersion + HandoffSupported, surfaced per-trigger as handoff_supported in the preview so the UI can gray the note box on old daemons; the assignment never hard-fails. Tests: daemon prompt + issue_context render via the assignment branch (not quick-create/comment), version helper matrix, note persists on the task, suppressed assign enqueues nothing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * feat(issues): leave a display-only handoff record on the timeline When an assign/promote with a handoff note starts a run, write one type='handoff' timeline record via TaskService.RecordHandoff — a direct Queries.CreateComment + timeline event that bypasses Handler.CreateComment, so it never reaches triggerTasksForComment and cannot start a second run (MUL-3375 §6.2, the must-not-retrigger invariant). Author is the actor who handed off; body is the note. Migration 123 admits the 'handoff' comment type. Recorded only on a real run start: suppress_run or a parked write writes nothing. enqueueSquadLeaderTask now reports whether it enqueued so the trace is gated on an actual dispatch. Test: exactly one handoff record on assign-with-note, exactly one task (no re-trigger), and no record when suppressed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * feat(issues): frontend plumbing for issue-trigger preview + handoff (core) Add api.previewIssueTrigger + IssueTriggerPreviewSchema (zod parseWithFallback), the use-issue-trigger-preview hook, issueKeys.issueTriggerPreview(+All) with WS queue-state invalidation, suppress_run/handoff_note on UpdateIssueRequest, the 'handoff' CommentType, and stripping of the control fields from optimistic update/batch cache patches (MUL-3375 §9). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(issues): exclude handoff records from new-comment counting type='handoff' is a display-only timeline record, not conversation. Exclude it from CountNewCommentsSince so a handoff note never inflates the count of "new comments to catch up on" fed to a claiming agent (MUL-3375 §12). Analytics already excludes it (RecordHandoff is a direct write that emits no analytics event), and the comment-trigger path is already bypassed. Test: a handoff record does not bump the new-comment count; a real comment does. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * feat(issues): pre-trigger preview UI, handoff note, timeline card (web/desktop) Wire the §9 frontend onto the preview endpoint + handoff fields: - Delete the backlog blocking dialog (backlog-agent-hint*) and its modal type; the over-eager nag is gone. Backlog awareness is now a passive label. - RunConfirmModal: single assign + batch assign/status route here. Shows the backend predicate's verdict ("将启动 @X" / "将启动 N 个" / parked), an optional handoff note (assign only, soft-gated by handoff_supported), and 暂不启动 — then applies via update/batch. No frontend guessing. - create modal: passive CreateRunHint ("将启动 @X" / backlog parked). - single status change stays a direct apply (unchanged). - timeline: render type='handoff' as a distinct, non-interactive handoff card. - i18n run_confirm + handoff_card across en/ja/ko/zh-Hans; drop backlog action keys; locale parity green. Tests: use-issue-actions (assign → run-confirm modal, member → direct), create-issue + comment-card suites updated/green; views typecheck + lint clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * test(issues): use a valid anchor in the handoff count-exclusion test CountNewCommentsSince filters id <> @anchor_id; SQL id <> NULL is NULL and excludes every row, so an empty anchor made the control assertion read 0. The production caller always passes a real anchor — mirror that with a non-matching sentinel uuid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * test(issues): RunConfirmModal apply logic (start/suppress/note-gate/batch) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * test(core): preview schema malformed/missing/null fallback coverage Cover IssueTriggerPreviewSchema via parseWithFallback (MUL-3375): well-formed parse, top-level + item default fills (empty/older backend), and fallback to { triggers: [], total_count: 0 } for malformed shapes, a dropped required issue_id, a wrong-typed total_count, and null/non-object bodies — so the four entry points degrade to "nothing will start" instead of throwing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * refactor(issues): remove display-only handoff timeline record (留痕) The handoff "留痕" timeline record (type='handoff' comment written on run start) was judged superfluous and dropped per product call. This removes only the display-only trace; the handoff NOTE injection into the run's opening prompt + issue_context.md is untouched. - backend: drop RecordHandoff + its call in dispatchIssueRun - db: drop the `type <> 'handoff'` exclusion in CountNewCommentsSince and migration 123 (comment_type_check reverts to the 4-type set from 001); no production data exists for this unreleased feature - frontend: drop the "handoff" CommentType, HandoffCard, and handoff_card i18n (all locales) - tests: drop handoff_count_test.go and the record-write assertions in issue_trigger_preview_test.go (note-injection tests retained) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * feat(issues): dismissable run-confirm modal + team-handoff copy Two fixes to the pre-trigger confirm modal (MUL-3375). 1. Dismissable: switch RunConfirmModal from AlertDialog to the standard shadcn Dialog so it has the close (X) button + Esc + click-outside. Previously the only choices were "start" / "don't start now" with no way to abort the action entirely; dismissing now cancels with no write. 2. Copy: rework the action-surface wording away from the backend term "run" toward team-handoff voice — 指派 / 开始 / 交接 (run stays only on record surfaces). Unifies the note's three names to "交接说明", and parallels the rewrite across en/ja/ko. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * chore(agent): bump handoff note min CLI version to 0.3.28 The daemon release that renders handoff notes ships in 0.3.28 (0.3.27 was the prior tag), so move the soft-gate threshold up. Below this the note is silently dropped and the frontend grays the note box — assignment is never blocked. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(issues): skip run-confirm when batch-moving issues to backlog A move into backlog never starts a run (service/issue_trigger.go), so the pre-trigger confirm modal degenerated to an empty "won't start" box with a single Apply button — pure friction. Apply directly instead, matching the single-issue status path. Other target statuses still route through the modal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(issues): refine pre-trigger preview hint and copy - Move the create-issue run hint to a reveal band (grid 0fr→1fr) above the property toolbar. It was sharing the footer button row and, lacking a width constraint, reflowed the submit buttons whenever it appeared. Restyle to a borderless, comment-style avatar+caption that is purely a caption (non-interactive avatar). - Distinguish squad from agent in the pre-trigger copy: a squad's leader evaluates and delegates rather than "starting work" itself. Add will_start_named_squad / will_start_squad / create_will_start_squad across en/zh/ja/ko (reusing the squad_leader_* evaluate→arrange vocabulary) and branch run-confirm + the create hint on squad assignees. - Bold the assignee name in the run-confirm headline via a language-safe sentinel split (no per-language prefix/suffix keys). - Align zh "开始处理" → "开始工作" on the single-assign copy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(issues): stub ActorAvatar in create-issue suite CreateRunHint now renders an ActorAvatar for agent/squad assignees, which pulls in getActorInitials/getActorAvatarUrl + the workspace/presence/navigation hook tree. This form-focused suite only stubbed getActorName, so the squad-forwarding test crashed with "getActorInitials is not a function". Stub the avatar inert — its own behavior is covered elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Walt <walt@multica.ai> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
226 lines
8.4 KiB
Go
226 lines
8.4 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/multica-ai/multica/server/internal/service"
|
|
"github.com/multica-ai/multica/server/internal/util"
|
|
agentver "github.com/multica-ai/multica/server/pkg/agent"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
)
|
|
|
|
// maxPreviewTriggerIssues caps a single preview request so a pathological
|
|
// selection cannot fan out into thousands of readiness probes.
|
|
const maxPreviewTriggerIssues = 500
|
|
|
|
// issueTriggerWriteProbe builds the probe the write paths feed to
|
|
// WillEnqueueRun. The private-agent gate is already enforced at the HTTP
|
|
// boundary (validateAssigneePair on assign) and inside enqueueSquadLeaderTask
|
|
// (canEnqueueSquadLeader), so a write must NOT re-run or sink it — it passes
|
|
// allow-all. The self-loop check needs the request's X-Task-ID header.
|
|
func (h *Handler) issueTriggerWriteProbe(r *http.Request, actorType string, issue db.Issue) service.IssueTriggerProbe {
|
|
return service.IssueTriggerProbe{
|
|
CanAccessAgent: nil, // allow-all; gate lives at the write boundary
|
|
IsSelfLoop: func() bool {
|
|
return h.isAgentRunningOnIssue(r, actorType, issue)
|
|
},
|
|
}
|
|
}
|
|
|
|
// issueTriggerPreviewProbe mirrors the real write-time gates for the read-only
|
|
// preview: the private-agent gate (so preview never leaks a private agent's
|
|
// readiness to a member who cannot see it — matching validateAssigneePair /
|
|
// canEnqueueSquadLeader) and the same self-loop guard.
|
|
func (h *Handler) issueTriggerPreviewProbe(r *http.Request, actorType, actorID, workspaceID string, issue db.Issue) service.IssueTriggerProbe {
|
|
return service.IssueTriggerProbe{
|
|
CanAccessAgent: func(agent db.Agent) bool {
|
|
at := actorType
|
|
if at == "system" {
|
|
at = "agent"
|
|
}
|
|
return h.canAccessPrivateAgent(r.Context(), agent, at, actorID, workspaceID)
|
|
},
|
|
IsSelfLoop: func() bool {
|
|
return h.isAgentRunningOnIssue(r, actorType, issue)
|
|
},
|
|
}
|
|
}
|
|
|
|
// dispatchIssueRun executes the enqueue side effect for a decision produced by
|
|
// WillEnqueueRun, carrying an optional handoff note into the run's opening
|
|
// context. The squad path still flows through enqueueSquadLeaderTask so the
|
|
// leader access gate and pending dedup stay in one place.
|
|
func (h *Handler) dispatchIssueRun(ctx context.Context, issue db.Issue, trigger service.IssueRunTrigger, actorType, actorID, handoffNote string) {
|
|
switch trigger.AssigneeType {
|
|
case "agent":
|
|
_, _ = h.TaskService.EnqueueTaskForIssueWithHandoff(ctx, issue, handoffNote)
|
|
case "squad":
|
|
h.enqueueSquadLeaderTask(ctx, issue, pgtype.UUID{}, actorType, actorID, handoffNote)
|
|
}
|
|
}
|
|
|
|
// IssueTriggerPreviewRequest asks "if I apply this assignee and/or status to
|
|
// these issues (or create one), which runs will start". All fields are
|
|
// optional; a nil prospective field means "leave unchanged".
|
|
type IssueTriggerPreviewRequest struct {
|
|
// IssueIDs are existing issues to evaluate (single assign, single status,
|
|
// or a batch). Empty with IsCreate=true evaluates a candidate new issue.
|
|
IssueIDs []string `json:"issue_ids"`
|
|
// IsCreate previews a not-yet-persisted issue from AssigneeType/ID/Status.
|
|
IsCreate bool `json:"is_create"`
|
|
AssigneeType *string `json:"assignee_type"`
|
|
AssigneeID *string `json:"assignee_id"`
|
|
Status *string `json:"status"`
|
|
}
|
|
|
|
// IssueTriggerPreviewItem is one issue that WILL start a run under the
|
|
// prospective write. AgentID is the runnable agent (squad leader for squads).
|
|
// HandoffSupported is the soft-gate signal: false when the target runtime's
|
|
// daemon is too old to render a handoff note, so the UI can gray out the note
|
|
// box rather than silently drop the text. The assignment itself still works.
|
|
type IssueTriggerPreviewItem struct {
|
|
IssueID string `json:"issue_id"`
|
|
AgentID string `json:"agent_id"`
|
|
Source string `json:"source"`
|
|
HandoffSupported bool `json:"handoff_supported"`
|
|
}
|
|
|
|
// IssueTriggerPreviewResponse lists every issue that will enqueue plus a total
|
|
// the UI can show directly ("将启动 N 个"). Issues that will NOT start a run are
|
|
// simply absent, so total_count == len(triggers).
|
|
type IssueTriggerPreviewResponse struct {
|
|
Triggers []IssueTriggerPreviewItem `json:"triggers"`
|
|
TotalCount int `json:"total_count"`
|
|
}
|
|
|
|
// PreviewIssueTrigger dry-runs WillEnqueueRun for a prospective issue write and
|
|
// returns the runs that would start, without any side effect. It is the single
|
|
// authority the four entry points (create / single assign / single status /
|
|
// batch) consult so the frontend never re-implements the enqueue rule
|
|
// (MUL-3375). Mirrors PreviewCommentTriggers.
|
|
func (h *Handler) PreviewIssueTrigger(w http.ResponseWriter, r *http.Request) {
|
|
userID, ok := requireUserID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
workspaceID := h.resolveWorkspaceID(r)
|
|
if workspaceID == "" {
|
|
writeError(w, http.StatusBadRequest, "workspace is required")
|
|
return
|
|
}
|
|
|
|
var req IssueTriggerPreviewRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body")
|
|
return
|
|
}
|
|
if len(req.IssueIDs) > maxPreviewTriggerIssues {
|
|
writeError(w, http.StatusBadRequest, "too many issue_ids")
|
|
return
|
|
}
|
|
|
|
// Resolve the prospective assignee once — a malformed id is a deterministic
|
|
// 400, never a silent miscount.
|
|
var (
|
|
newAssigneeType pgtype.Text
|
|
newAssigneeID pgtype.UUID
|
|
hasNewAssignee bool
|
|
)
|
|
if req.AssigneeType != nil && *req.AssigneeType != "" && req.AssigneeID != nil && *req.AssigneeID != "" {
|
|
id, parseOK := parseUUIDOrBadRequest(w, *req.AssigneeID, "assignee_id")
|
|
if !parseOK {
|
|
return
|
|
}
|
|
newAssigneeType = pgtype.Text{String: *req.AssigneeType, Valid: true}
|
|
newAssigneeID = id
|
|
hasNewAssignee = true
|
|
}
|
|
|
|
actorType, actorID := h.resolveActor(r, userID, workspaceID)
|
|
resp := IssueTriggerPreviewResponse{Triggers: make([]IssueTriggerPreviewItem, 0)}
|
|
|
|
appendTrigger := func(issue db.Issue, in service.IssueTriggerInput) {
|
|
probe := h.issueTriggerPreviewProbe(r, actorType, actorID, workspaceID, issue)
|
|
if trigger, ok := h.IssueService.WillEnqueueRun(r.Context(), in, probe); ok {
|
|
resp.Triggers = append(resp.Triggers, IssueTriggerPreviewItem{
|
|
IssueID: uuidToString(trigger.IssueID),
|
|
AgentID: uuidToString(trigger.AgentID),
|
|
Source: string(trigger.Source),
|
|
HandoffSupported: h.runtimeSupportsHandoff(r.Context(), trigger.AgentID),
|
|
})
|
|
}
|
|
}
|
|
|
|
if req.IsCreate {
|
|
wsUUID, err := util.ParseUUID(workspaceID)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid workspace")
|
|
return
|
|
}
|
|
status := "todo"
|
|
if req.Status != nil && *req.Status != "" {
|
|
status = *req.Status
|
|
}
|
|
candidate := db.Issue{
|
|
WorkspaceID: wsUUID,
|
|
Status: status,
|
|
AssigneeType: newAssigneeType,
|
|
AssigneeID: newAssigneeID,
|
|
}
|
|
appendTrigger(candidate, service.IssueTriggerInput{Issue: candidate, IsCreate: true})
|
|
resp.TotalCount = len(resp.Triggers)
|
|
writeJSON(w, http.StatusOK, resp)
|
|
return
|
|
}
|
|
|
|
for _, rawID := range req.IssueIDs {
|
|
issueUUID, err := util.ParseUUID(rawID)
|
|
if err != nil {
|
|
continue // malformed id contributes no trigger; deterministic
|
|
}
|
|
loaded, err := h.Queries.GetIssueInWorkspace(r.Context(), db.GetIssueInWorkspaceParams{
|
|
ID: issueUUID,
|
|
WorkspaceID: parseUUID(workspaceID),
|
|
})
|
|
if err != nil {
|
|
continue // cross-workspace / unknown id contributes no trigger
|
|
}
|
|
|
|
post := loaded
|
|
in := service.IssueTriggerInput{PrevStatus: loaded.Status}
|
|
if hasNewAssignee {
|
|
post.AssigneeType = newAssigneeType
|
|
post.AssigneeID = newAssigneeID
|
|
in.AssigneeChanged = loaded.AssigneeType.String != newAssigneeType.String ||
|
|
uuidToString(loaded.AssigneeID) != uuidToString(newAssigneeID)
|
|
}
|
|
if req.Status != nil && *req.Status != "" {
|
|
post.Status = *req.Status
|
|
in.StatusChanged = loaded.Status != *req.Status
|
|
}
|
|
in.Issue = post
|
|
appendTrigger(post, in)
|
|
}
|
|
|
|
resp.TotalCount = len(resp.Triggers)
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
// runtimeSupportsHandoff reports whether the agent's bound runtime reports a
|
|
// CLI version new enough to render handoff notes. Drives the preview's
|
|
// handoff_supported soft-gate signal. Any resolution failure → false (degrade).
|
|
func (h *Handler) runtimeSupportsHandoff(ctx context.Context, agentID pgtype.UUID) bool {
|
|
agent, err := h.Queries.GetAgent(ctx, agentID)
|
|
if err != nil || !agent.RuntimeID.Valid {
|
|
return false
|
|
}
|
|
rt, err := h.Queries.GetAgentRuntime(ctx, agent.RuntimeID)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return agentver.HandoffSupported(readRuntimeCLIVersion(rt.Metadata))
|
|
}
|